#4690 PickupShelfOut Details Display FETCHED_PARTIAL Action Correctly

#4684 Routing to Pickup Shelf Out Update

apps/domain/pickup-shelf/src/lib/pickup-shelf-out.service.ts

@@ -35,7 +35,7 @@ export class PickupShelfOutService extends PickupShelfIOService {
       );
     }
 
-    const { orderdate } = args.filter?.getQueryToken()?.filter ?? {};
+    const { orderdate, supplier_id } = args.filter?.getQueryToken()?.filter ?? {};
 
     return this._abholfachService.AbholfachWarenausgabe({
       input: {
@@ -45,6 +45,7 @@ export class PickupShelfOutService extends PickupShelfIOService {
         archive: String(true),
         all_branches: String(true),
         orderdate,
+        supplier_id,
       },
     });
   }

apps/page/checkout/src/lib/checkout-summary/checkout-summary.component.ts

@@ -296,18 +296,8 @@ export class CheckoutSummaryComponent implements OnInit, OnDestroy {
     if (takeNowOrders.length != 1) return;
 
     try {
-      for (const takeNowOrder of takeNowOrders) {
-        for (const orderItem of takeNowOrder.items.filter((item) => item.features?.orderType === 'Rücklage')) {
-          await this.omsService
-            .changeOrderStatus(takeNowOrder.id, orderItem.id, orderItem.subsetItems[0]?.id, {
-              processingStatus: 128,
-            })
-            .toPromise();
-        }
-      }
-
       await this.router.navigate(this._shelfOutNavigationService.listRoute({ processId: Date.now() }).path, {
-        queryParams: { main_qs: takeNowOrders[0].orderNumber },
+        queryParams: { main_qs: takeNowOrders[0].orderNumber, filter_supplier_id: '16' },
       });
     } catch (e) {
       console.error(e);

apps/page/pickup-shelf/src/lib/pickup-shelf-base.component.ts

@@ -5,14 +5,13 @@ import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import { Breadcrumb, BreadcrumbService } from '@core/breadcrumb';
 import { take } from 'rxjs/operators';
 import { NavigationRoute } from '@shared/services';
-import { DBHOrderItemListItemDTO, KeyValueDTOOfStringAndString } from '@swagger/oms';
+import { DBHOrderItemListItemDTO, KeyValueDTOOfStringAndString, ListResponseArgsOfDBHOrderItemListItemDTO } from '@swagger/oms';
 import { isEmpty } from 'lodash';
 import { Observable } from 'rxjs';
 import { RunCheckTrigger } from './trigger';
 import { OrderItemsContext } from '@domain/oms';
 import { ActionHandlerService } from './services/action-handler.service';
 import { Config } from '@core/config';
-import { debounce } from '@utils/common';
 
 export type GetNameForBreadcrumbData = {
   processId: number;
@@ -131,7 +130,7 @@ export abstract class PickupShelfBaseComponent implements OnInit {
       //   return;
       // }
 
-      if (response.hits === 1) {
+      if (response.hits === 1 || this._hasSameOrderNumber(response)) {
         const detailsPath = await this.getPathForDetail(response.result[0]).pipe(take(1)).toPromise();
         await this.router.navigate(detailsPath.path, { queryParams: { ...queryParams, ...filterQueryParams, ...detailsPath.queryParams } });
       } else if (response.hits > 1) {
@@ -143,6 +142,13 @@ export abstract class PickupShelfBaseComponent implements OnInit {
     });
   }
 
+  // Fix Ticket #4684 Navigate on Details if items contain same OrderNumber
+  private _hasSameOrderNumber(response: ListResponseArgsOfDBHOrderItemListItemDTO) {
+    if (response.hits === 0) return false;
+    const orderNumbers = new Set(response.result.map((item) => item.orderNumber));
+    return orderNumbers.size === 1;
+  }
+
   /**
    * Sucht die Breadcrumb anhand des Tags.
    * @param tag Der gesuchte Tag

apps/page/pickup-shelf/src/lib/pickup-shelf-out/pickup-shelf-out-details/pickup-shelf-out-details.component.ts

@@ -84,7 +84,7 @@ export class PickupShelfOutDetailsComponent extends PickupShelfDetailsBaseCompon
 
   addToPreviousCompartmentAction$ = this.store.addToPreviousCompartmentAction$;
 
-  mainActions$ = this.store.mainActions$;
+  mainActions$ = this.store.mainShelfOutActions$;
 
   trackByFnGroupDBHOrderItemListItemDTO = (index: number, group: { type: string; items: DBHOrderItemListItemDTO[] }) => group.type;
 

apps/page/pickup-shelf/src/lib/store/pickup-shelf-details.selectors.ts

@@ -1,5 +1,5 @@
 import { PickupShelfDetailsState } from './pickup-shelf-details.state';
-import { DBHOrderItemListItemDTO } from '@swagger/oms';
+import { DBHOrderItemListItemDTO, KeyValueDTOOfStringAndString } from '@swagger/oms';
 
 export const selectOrder = (s: PickupShelfDetailsState) => s.order;
 
@@ -245,6 +245,26 @@ export const selectMainActions = (s: PickupShelfDetailsState) => {
     ?.filter((action) => (fetchPartial ? !action.command.includes('FETCHED_PARTIAL') : true));
 };
 
+export const selectShelfOutMainActions = (s: PickupShelfDetailsState) => {
+  const items = selectOrderItems(s);
+  const fetchPartial = selectFetchPartial(s);
+
+  // Ticket #4690 Consider every Item for selecting the main actions in Details View - Only for PickUpShelfOut
+  const actions: KeyValueDTOOfStringAndString[] = [];
+  for (const item of items) {
+    const actionsFromItem = item?.actions
+      ?.filter((action) => typeof action?.enabled !== 'boolean')
+      ?.filter((action) => (fetchPartial ? !action.command.includes('FETCHED_PARTIAL') : true));
+    for (const action of actionsFromItem) {
+      if (!actions.find((a) => a.command === action.command)) {
+        actions.push(action);
+      }
+    }
+  }
+
+  return actions;
+};
+
 export const selectCustomerNumber = (s: PickupShelfDetailsState) => {
   const order = selectOrder(s);
   return order?.buyer?.buyerNumber;

apps/page/pickup-shelf/src/lib/store/pickup-shelf-details.store.ts

@@ -212,6 +212,12 @@ export class PickupShelfDetailsStore extends ComponentStore<PickupShelfDetailsSt
     return this.get(Selectors.selectMainActions);
   }
 
+  mainShelfOutActions$ = this.select(Selectors.selectShelfOutMainActions);
+
+  get mainShelfOutActions() {
+    return this.get(Selectors.selectShelfOutMainActions);
+  }
+
   customerNumber$ = this.select(Selectors.selectCustomerNumber);
 
   get customerNumber() {