Add ShippingDocumentNumber Formatter for deleted shipping documents

apps/sales/src/app/modules/remission/components/remissions-overview-card-content/remissions-overview-card-content.component.html

@@ -26,7 +26,9 @@
   <div class="content-row" *ngIf="isCompleted && shippingDocumentNumber">
     <div class="content-field">
       <span class="descriptor">Wannennummer</span>
-      <span class="value">{{ shippingDocumentNumber }}</span>
+      <span class="value">{{
+        shippingDocumentNumber | shippingDocumentNumberFormatter
+      }}</span>
     </div>
   </div>
 </div>

apps/sales/src/app/modules/remission/pages/remission-details/remission-details.component.html

@@ -38,7 +38,9 @@
           [numberOfItems]="
             (remissionProcess?.shippingDocuments)[0].products?.length
           "
-          [shippingDocumentNumber]="(remissionProcess?.shippingDocuments)[0].id"
+          [shippingDocumentNumber]="
+            (remissionProcess?.shippingDocuments)[0].shippingDocumentNumber
+          "
           [date]="remissionProcess?.startDate"
         ></app-remissions-overview-card-content>
       </div>

apps/sales/src/app/pipes/shipping-document-number-formatter.pipe.spec.ts

@@ -0,0 +1,30 @@
+import { ShippingDocumentNumberFormatterPipe } from './shipping-document-number-formatter.pipe';
+
+describe('ShippingDocumentNumberFormatterPipe', () => {
+  let pipe: ShippingDocumentNumberFormatterPipe;
+
+  beforeEach(() => {
+    pipe = new ShippingDocumentNumberFormatterPipe();
+  });
+
+  it('should create an instance', () => {
+    const pipeInstance = new ShippingDocumentNumberFormatterPipe();
+    expect(pipeInstance).toBeTruthy();
+  });
+
+  it('should return 026706900194072971', () => {
+    const shippingDocumentNumber = '026706900194072971';
+
+    const result = pipe.transform(shippingDocumentNumber);
+
+    expect(result).toBe('026706900194072971');
+  });
+
+  it('should return 026706900194072972', () => {
+    const shippingDocumentNumber = '026706900194072972_DEL@2020030516515137470';
+
+    const result = pipe.transform(shippingDocumentNumber);
+
+    expect(result).toBe('026706900194072972');
+  });
+});

apps/sales/src/app/pipes/shipping-document-number-formatter.pipe.ts

@@ -0,0 +1,14 @@
+import { Pipe, PipeTransform } from '@angular/core';
+
+@Pipe({
+  name: 'shippingDocumentNumberFormatter'
+})
+export class ShippingDocumentNumberFormatterPipe implements PipeTransform {
+  transform(shippingDocumentNumber: string): string {
+    if (shippingDocumentNumber.length <= 18) {
+      return shippingDocumentNumber;
+    }
+
+    return shippingDocumentNumber.slice(0, 18);
+  }
+}

apps/sales/src/app/shared/shared.module.ts

@@ -12,6 +12,7 @@ import { CommonModule } from '@angular/common';
 import { SafeHtmlPipe } from '../pipes/safe-html.pipe';
 import { PackageNumberParserPipe } from '../pipes/package-number-parser.pipe';
 import { AddClassDirective } from './directives/add-class.directive';
+import { ShippingDocumentNumberFormatterPipe } from '../pipes/shipping-document-number-formatter.pipe';
 
 const components = [BackArrowComponent];
 const directives = [VarDirective, TooltipDirective, AddClassDirective];
@@ -22,7 +23,8 @@ const pipes = [
   PhonePipe,
   BookThumbnailPipe,
   TrimPipe,
-  PackageNumberParserPipe
+  PackageNumberParserPipe,
+  ShippingDocumentNumberFormatterPipe
 ];
 @NgModule({
   imports: [CommonModule, IconModule],

package-lock.json

@@ -1039,33 +1039,33 @@
       }
     },
     "@cmf/catalog-api": {
-      "version": "0.1.24",
-      "resolved": "https://pkgs.dev.azure.com/hugendubel/_packaging/hugendubel/npm/registry/@cmf/catalog-api/-/catalog-api-0.1.24.tgz",
-      "integrity": "sha1-UJutPTN2kIt0BWZJm6ViXbre7PU=",
+      "version": "0.1.25",
+      "resolved": "https://pkgs.dev.azure.com/hugendubel/_packaging/hugendubel/npm/registry/@cmf/catalog-api/-/catalog-api-0.1.25.tgz",
+      "integrity": "sha1-ei0AyWpHjSrGUsxaiVqKWGeXK7s=",
       "requires": {
         "tslib": "^1.9.0"
       }
     },
     "@cmf/core": {
-      "version": "0.1.24",
-      "resolved": "https://pkgs.dev.azure.com/hugendubel/_packaging/hugendubel/npm/registry/@cmf/core/-/core-0.1.24.tgz",
-      "integrity": "sha1-VikCC0+gVcW2MSt1BODzjlDE5Bw=",
+      "version": "0.1.25",
+      "resolved": "https://pkgs.dev.azure.com/hugendubel/_packaging/hugendubel/npm/registry/@cmf/core/-/core-0.1.25.tgz",
+      "integrity": "sha1-h2Z1h5MBHRNA3LnDk7R6gaFhvEI=",
       "requires": {
         "tslib": "^1.9.0"
       }
     },
     "@cmf/inventory-api": {
-      "version": "0.1.24",
-      "resolved": "https://pkgs.dev.azure.com/hugendubel/_packaging/hugendubel/npm/registry/@cmf/inventory-api/-/inventory-api-0.1.24.tgz",
-      "integrity": "sha1-HtWtNfsOLGchks2IOL+ZQ2Hv8wQ=",
+      "version": "0.1.25",
+      "resolved": "https://pkgs.dev.azure.com/hugendubel/_packaging/hugendubel/npm/registry/@cmf/inventory-api/-/inventory-api-0.1.25.tgz",
+      "integrity": "sha1-XNQWWPxmmHDff77KWKzVXxwSWYo=",
       "requires": {
         "tslib": "^1.9.0"
       }
     },
     "@cmf/trade-api": {
-      "version": "0.1.24",
-      "resolved": "https://pkgs.dev.azure.com/hugendubel/_packaging/hugendubel/npm/registry/@cmf/trade-api/-/trade-api-0.1.24.tgz",
-      "integrity": "sha1-NVdd17cwWqJMjzPGjZp8BmbSBuM=",
+      "version": "0.1.25",
+      "resolved": "https://pkgs.dev.azure.com/hugendubel/_packaging/hugendubel/npm/registry/@cmf/trade-api/-/trade-api-0.1.25.tgz",
+      "integrity": "sha1-FebJbZC4psk7gu2/6h+u3rxL680=",
       "requires": {
         "tslib": "^1.9.0"
       }
@@ -1095,9 +1095,9 @@
       }
     },
     "@isa/remission": {
-      "version": "0.3.3",
-      "resolved": "https://pkgs.dev.azure.com/hugendubel/_packaging/hugendubel/npm/registry/@isa/remission/-/remission-0.3.3.tgz",
-      "integrity": "sha1-saOIlZmjMXUCrOXV9MAQoYMWTuA=",
+      "version": "0.3.4",
+      "resolved": "https://pkgs.dev.azure.com/hugendubel/_packaging/hugendubel/npm/registry/@isa/remission/-/remission-0.3.4.tgz",
+      "integrity": "sha1-yL8OPs10DF8rdKq9C9nl1X6I/a4=",
       "requires": {
         "tslib": "^1.9.0"
       }

package.json

@@ -30,14 +30,14 @@
     "@angular/pwa": "^0.13.4",
     "@angular/router": "~7.2.12",
     "@angular/service-worker": "~7.2.12",
-    "@cmf/catalog-api": "^0.1.24",
-    "@cmf/core": "^0.1.24",
-    "@cmf/inventory-api": "^0.1.24",
-    "@cmf/trade-api": "^0.1.24",
+    "@cmf/catalog-api": "^0.1.25",
+    "@cmf/core": "^0.1.25",
+    "@cmf/inventory-api": "^0.1.25",
+    "@cmf/trade-api": "^0.1.25",
     "@isa/catsearch-api": "^0.0.53",
     "@isa/print-api": "0.0.53",
     "@isa/remi-api": "^0.0.53",
-    "@isa/remission": "^0.3.3",
+    "@isa/remission": "^0.3.4",
     "@ng-idle/core": "^8.0.0-beta.4",
     "@ng-idle/keepalive": "^8.0.0-beta.4",
     "@ngxs/store": "^3.4.1",