fix: resolve build warnings and improve code quality

- Remove unused Angular component and pipe imports to eliminate TS-998113 warnings
- Fix Sass mixed declarations warnings by reordering CSS properties
- Remove empty ngOnInit method from preview component
- Clean up unused imports across customer search and OMS components
- Move animation/transition properties above nested rules in SCSS files

Reduces build warnings significantly and improves code maintainability.
This commit is contained in:
Lorenz Hilpert
2025-06-27 16:19:18 +02:00
parent 7a44101e90
commit 9af4a72a76
13 changed files with 19 additions and 50 deletions

View File

@@ -1,7 +1,6 @@
import { Platform, PlatformModule } from '@angular/cdk/platform';
import { CommonModule } from '@angular/common';
import { Component, OnInit } from '@angular/core';
import { BranchSelectorComponent } from '@shared/components/branch-selector';
import { Component } from '@angular/core';
import { BranchDTO } from '@generated/swagger/checkout-api';
import { BehaviorSubject } from 'rxjs';
@@ -9,9 +8,9 @@ import { BehaviorSubject } from 'rxjs';
selector: 'app-preview',
templateUrl: 'preview.component.html',
styleUrls: ['preview.component.css'],
imports: [CommonModule, BranchSelectorComponent, PlatformModule],
imports: [CommonModule, PlatformModule],
})
export class PreviewComponent implements OnInit {
export class PreviewComponent {
selectedBranch$ = new BehaviorSubject<BranchDTO>({});
get appVersion() {
@@ -24,7 +23,7 @@ export class PreviewComponent implements OnInit {
get navigator() {
const nav = {};
for (let i in window.navigator) nav[i] = navigator[i];
for (const i in window.navigator) nav[i] = navigator[i];
return nav;
}
@@ -51,8 +50,6 @@ export class PreviewComponent implements OnInit {
constructor(private readonly _platform: Platform) {}
ngOnInit() {}
setNewBranch(branch: BranchDTO) {
this.selectedBranch$.next(branch);
}

View File

@@ -7,7 +7,6 @@ import { UiSelectModule } from '@ui/select';
import { UiIconModule } from '@ui/icon';
import { FormGroup, ReactiveFormsModule } from '@angular/forms';
import { RouterLink } from '@angular/router';
import { UiDateInputDirective } from '@ui/input';
import { validateCompanyOrPersonalInfoRequired } from '../../validators/gender-b2b-validator';
@Component({
@@ -23,7 +22,6 @@ import { validateCompanyOrPersonalInfoRequired } from '../../validators/gender-b
UiIconModule,
ReactiveFormsModule,
RouterLink,
UiDateInputDirective,
],
})
export class CustomerDataEditB2BComponent extends CustomerDataEditComponent {

View File

@@ -1,12 +1,11 @@
import { Component, ChangeDetectionStrategy, OnInit, OnDestroy, inject } from '@angular/core';
import { CustomerSearchStore } from '../store';
import { ActivatedRoute, RouterLink } from '@angular/router';
import { ActivatedRoute } from '@angular/router';
import { Subject, combineLatest, of } from 'rxjs';
import { catchError, map, share, switchMap } from 'rxjs/operators';
import { CrmCustomerService } from '@domain/crm';
import { KundenkarteComponent } from '../../components/kundenkarte';
import { AsyncPipe } from '@angular/common';
import { IconComponent } from '@shared/components/icon';
import { CustomerSearchNavigation } from '@shared/services/navigation';
import { BonusCardInfoDTO } from '@generated/swagger/crm-api';
import { CustomerMenuComponent } from '../../components/customer-menu';
@@ -17,7 +16,7 @@ import { CustomerMenuComponent } from '../../components/customer-menu';
styleUrls: ['kundenkarte-main-view.component.css'],
changeDetection: ChangeDetectionStrategy.OnPush,
host: { class: 'page-customer-kundenkarte-main-view' },
imports: [CustomerMenuComponent, KundenkarteComponent, AsyncPipe, IconComponent, RouterLink],
imports: [CustomerMenuComponent, KundenkarteComponent, AsyncPipe],
})
export class KundenkarteMainViewComponent implements OnInit, OnDestroy {
private _store = inject(CustomerSearchStore);

View File

@@ -19,7 +19,7 @@ import { AddressPipe } from '@shared/pipes/customer';
import { IconComponent } from '@shared/components/icon';
import { CustomerSearchNavigation } from '@shared/services/navigation';
import { CustomerOrderItemListItemComponent } from './order-item-list-item/order-item-list-item.component';
import { GroupByPipe, groupBy } from '@ui/common';
import { groupBy } from '@ui/common';
import { EnvironmentService } from '@core/environment';
@Component({
@@ -40,7 +40,6 @@ import { EnvironmentService } from '@core/environment';
RouterLink,
CustomerOrderItemListItemComponent,
NgFor,
GroupByPipe,
NgSwitch,
NgSwitchCase,
NgSwitchDefault,

View File

@@ -2,9 +2,7 @@ import { AsyncPipe, CurrencyPipe, DatePipe } from '@angular/common';
import { Component, ChangeDetectionStrategy, Input, OnDestroy, OnInit, inject } from '@angular/core';
import { ActivatedRoute, RouterLink } from '@angular/router';
import { ProductImagePipe } from '@cdn/product-image';
import { IconComponent } from '@shared/components/icon';
import { BranchNamePipe, ResolveBranchPipe } from '@shared/pipes/branch';
import { OrderItemProcessingStatusPipe, OrderProcessingStatusPipe } from '@shared/pipes/order';
import { OrderItemProcessingStatusPipe } from '@shared/pipes/order';
import { OrderItemDTO } from '@generated/swagger/oms-api';
import { BehaviorSubject, Subject, combineLatest } from 'rxjs';
import { map, takeUntil } from 'rxjs/operators';
@@ -21,16 +19,12 @@ import { PaymentTypePipe } from '@shared/pipes/customer';
imports: [
AsyncPipe,
DatePipe,
OrderProcessingStatusPipe,
ProductImagePipe,
ResolveBranchPipe,
BranchNamePipe,
CurrencyPipe,
IconComponent,
RouterLink,
PaymentTypePipe,
OrderItemProcessingStatusPipe
],
],
})
export class CustomerOrderItemListItemComponent implements OnInit, OnDestroy {
private _activatedRoute = inject(ActivatedRoute);

View File

@@ -4,8 +4,6 @@ import { map } from 'rxjs/operators';
import { CustomerNamePipe } from '@shared/pipes/customer';
import { AsyncPipe } from '@angular/common';
import { ProductImagePipe } from '@cdn/product-image';
import { CustomerSearchNavigation } from '@shared/services/navigation';
import { RouterLink, RouterLinkActive } from '@angular/router';
import { OrderItemProcessingStatusPipe } from '@shared/pipes/order';
@Component({
@@ -18,8 +16,6 @@ import { OrderItemProcessingStatusPipe } from '@shared/pipes/order';
CustomerNamePipe,
AsyncPipe,
ProductImagePipe,
RouterLink,
RouterLinkActive,
OrderItemProcessingStatusPipe
],
})

View File

@@ -1,6 +1,6 @@
import { AsyncPipe, CurrencyPipe, DatePipe } from '@angular/common';
import { Component, ChangeDetectionStrategy, Input, inject } from '@angular/core';
import { OrderDestinationPipe, OrderProcessingStatusPipe } from '@shared/pipes/order';
import { OrderProcessingStatusPipe } from '@shared/pipes/order';
import { AddressPipe } from '@shared/pipes/customer';
import { OrderListItemDTO } from '@generated/swagger/oms-api';
@@ -19,7 +19,6 @@ import { RouterLink } from '@angular/router';
imports: [
DatePipe,
OrderProcessingStatusPipe,
OrderDestinationPipe,
CurrencyPipe,
AddressPipe,
AsyncPipe,

View File

@@ -4,8 +4,6 @@ import { Subject, combineLatest } from 'rxjs';
import { distinctUntilChanged, map, takeUntil } from 'rxjs/operators';
import { AsyncPipe } from '@angular/common';
import { CustomerSearchNavigation } from '@shared/services/navigation';
import { RouterLink } from '@angular/router';
import { IconComponent } from '@shared/components/icon';
import { LoaderComponent } from '@shared/components/loader';
import { CustomerOrderListItemComponent } from './order-list-item/order-list-item.component';
import { CustomerMenuComponent } from '../../components/customer-menu';
@@ -19,8 +17,6 @@ import { CustomerMenuComponent } from '../../components/customer-menu';
imports: [
CustomerMenuComponent,
AsyncPipe,
RouterLink,
IconComponent,
LoaderComponent,
CustomerOrderListItemComponent
],

View File

@@ -1,4 +1,4 @@
import { CurrencyPipe, DatePipe } from '@angular/common';
import { DatePipe } from '@angular/common';
import { ChangeDetectionStrategy, Component, ElementRef, Input, inject } from '@angular/core';
import { RouterLink, RouterLinkActive } from '@angular/router';
import { NavigateOnClickDirective, ProductImageModule } from '@cdn/product-image';
@@ -25,7 +25,6 @@ import { MatomoModule } from 'ngx-matomo-client';
RouterLinkActive,
IconModule,
DatePipe,
CurrencyPipe,
ProductImageModule,
UiCommonModule,
PickupShelfProcessingStatusPipe,

View File

@@ -4,6 +4,9 @@
@tailwind utilities;
@import "./scss/components";
@import "./scss/root";
@import "./scss/customer";
@import "./scss/branch";
/* Scanner Fullscreen Styles */
.full-screen-scanner {
@@ -30,10 +33,6 @@
}
}
@import "./scss/root";
@import "./scss/customer";
@import "./scss/branch";
@layer base {
body {
@apply bg-background;

View File

@@ -34,6 +34,7 @@
bottom: 30px !important;
right: 12px;
box-shadow: 0px 0px 20px 0px rgba(89, 100, 112, 0.5);
transition: all 100ms linear;
@screen desktop {
margin-left: 600px;
@@ -44,7 +45,6 @@
box-shadow: none;
}
transition: all 100ms linear;
&.up {
transform: rotate(-90deg);
}

View File

@@ -16,8 +16,6 @@ import {
ReturnProcessStore,
} from '@isa/oms/data-access';
import {
ChipOptionComponent,
ChipsComponent,
CheckboxComponent,
ChecklistComponent,
CheckboxLabelDirective,
@@ -25,7 +23,6 @@ import {
TextareaComponent,
} from '@isa/ui/input-controls';
import { isEqual } from 'lodash';
import { z } from 'zod';
@Component({
selector: 'oms-feature-return-process-checklist-question',
@@ -35,8 +32,6 @@ import { z } from 'zod';
standalone: true,
imports: [
FormsModule,
ChipsComponent,
ChipOptionComponent,
CheckboxComponent,
ChecklistComponent,
ChecklistValueDirective,

View File

@@ -3,6 +3,10 @@
}
.ui-skeleton-loader-bar {
@apply block absolute top-0 left-0 right-0 bottom-0;
@apply bg-gradient-to-r from-isa-neutral-300 via-isa-neutral-400 to-isa-neutral-300;
animation: loader 1s ease-in-out infinite;
@keyframes loader {
0% {
transform: translateX(-100%);
@@ -16,10 +20,4 @@
opacity: 0.3;
}
}
@apply block absolute top-0 left-0 right-0 bottom-0;
@apply bg-gradient-to-r from-isa-neutral-300 via-isa-neutral-400 to-isa-neutral-300;
animation: loader 1s ease-in-out infinite;
}