Compare commits

...

159 Commits

Author SHA1 Message Date
Nino Righi
de3edaa0f9 Merged PR 2077: fix(checkout-data-access, checkout-reward-shopping-cart, checkout-reward-sele...
fix(checkout-data-access, checkout-reward-shopping-cart, checkout-reward-selection-dialog): Show Low Stock message inside Dialog, Adjusted Item Identifyer so that mergedItems inside reward-selection-dialog service works properly, Adjusted Error Message Logic and Quantity Select Logic based on purchasing Options for Abholung

Ref: #5523
2025-12-10 17:12:47 +00:00
Nino Righi
964a6026a0 Merged PR 2076: fix(common-data-access, crm-data-access): Improved Error handling, handling i...
fix(common-data-access, crm-data-access): Improved Error handling, handling invalidProperties errors corretly inside crm customer card area

Refs: #5528, #5529
2025-12-10 17:11:22 +00:00
Nino Righi
83ad5f526e Merged PR 2075: fix(ui-layout, ui-input-controls, shared-filter): Set overlayPositions inside...
fix(ui-layout, ui-input-controls, shared-filter): Set overlayPositions inside filter-menu-button and outsourced the logic

Ref: #5526, #5477
2025-12-10 09:50:15 +00:00
Nino Righi
ccc5285602 Merged PR 2074: fix(remission): Implementation of Abort Remission Logic
fix(remission): Implementation of Abort Remission Logic

Ref: #5489
2025-12-10 09:48:49 +00:00
Nino Righi
7200eaefbf Merged PR 2073: fix(checkout-reward-shopping-cart): Preselect Purchasing Option Branch if Edi...
fix(checkout-reward-shopping-cart): Preselect Purchasing Option Branch if Edit item

Ref: #5516
2025-12-08 16:51:49 +00:00
Nino Righi
39e56a275e Merged PR 2072: fix(reward-order-confirmation): Only display one orderDate if other ones are...
fix(reward-order-confirmation): Only display one orderDate if other ones are equal

Ref: #5517
2025-12-08 15:20:19 +00:00
Nino Righi
6c41214d69 Merged PR 2071: fix(crm-customer-bon-redemption): Added Date Pipe to Bon
fix(crm-customer-bon-redemption): Added Date Pipe to Bon

Ref: #5521
2025-12-05 20:04:28 +00:00
Nino Righi
6e55b7b0da Merged PR 2070: fix(shared-filter, reward-catalog): Added Branch Filter Toggle to Reward HSC...
fix(shared-filter, reward-catalog): Added Branch Filter Toggle to Reward HSC View, Adjusted Controls Panel Filter Styling and Layout to fix mobile issues and added spacing to order-by-toolbar

Refs: #5514, #5475
2025-12-05 20:04:07 +00:00
Nino Righi
5711a75188 Merged PR 2068: fix(shared-filter): Adjusted Styling parameters for Height and Scrolling
fix(shared-filter): Adjusted Styling parameters for Height and Scrolling

Ref: #5476, #5477
2025-12-05 10:10:32 +00:00
Nino Righi
3696fb5b2d Merged PR 2069: feature(oms-data-access, oms-return-task-list): Return can now handle Rewards
feature(oms-data-access, oms-return-task-list): Return can now handle Rewards

#5373
2025-12-05 10:10:18 +00:00
Nino
7e7721b222 Merge branch 'release/4.5' into develop 2025-12-03 16:00:41 +01:00
Nino
14be1365bd fix(crm-loyalty-cards): Show always Points of first Card 2025-12-03 15:59:08 +01:00
Nino Righi
d5324675ef Merged PR 2067: fix(ui-layout): Ipad Dropdown Scrolling Fix
fix(ui-layout): Ipad Dropdown Scrolling Fix
2025-12-03 14:16:21 +00:00
Nino
f10338a48b Merge branch 'release/4.5' into develop 2025-12-02 17:33:50 +01:00
Nino
aa57d27924 fix(oms-return-details): Label Unknown Fix
Ref: #5513
2025-12-02 17:20:56 +01:00
Nino
6cb9aea7d1 Merge branch 'release/4.5' into develop 2025-12-02 17:18:11 +01:00
Lorenz Hilpert
fdfb54a3a0 Merged PR 2065: ♻️ refactor(core-navigation): remove library and use TabService directly
♻️ refactor(core-navigation): remove library and use TabService directly

Remove @isa/core/navigation library entirely as it was just a thin
wrapper around TabService.patchTabMetadata(). Consumers now use
TabService directly for scoped metadata operations.

Changes:
- Delete libs/core/navigation/ (~12 files, ~2900 LOC removed)
- Update 6 consumer components to use TabService directly
- Remove @isa/core/navigation path alias from tsconfig.base.json
- All operations now synchronous (removed async/await)

Migration pattern:
- preserveContext() → patchTabMetadata(tabId, { [scope]: data })
- restoreContext() → activatedTab()?.metadata?.[scope]
- restoreAndClearContext() → get + patchTabMetadata(tabId, { [scope]: null })

Refs #5502
2025-12-02 15:41:18 +00:00
Nino
5f94549539 fix(oms-return-details): Dropdown Label and Select Bullet Styling Adjustments
Ref: #5513
2025-12-02 16:32:57 +01:00
Nino Righi
aee63711e4 Merged PR 2066: fix(ui-layout, input-controls-dropdown, oms-return-details): prevent stale sc...
fix(ui-layout, input-controls-dropdown, oms-return-details): prevent stale scroll events from closing dropdown on open

Delay scroll listener registration using requestAnimationFrame when
activating CloseOnScrollDirective. This prevents stale scroll events
still in the event queue from immediately triggering closeOnScroll
when opening the dropdown after scrolling.

Also adds conditional rendering for product format and publication date
in return-details-order-group-item component.

Refs: #5513
2025-12-02 14:02:32 +00:00
Nino Righi
a3c865e39c Merged PR 2064: feature(oms-return-details): Display Loyalty Points if order is Reward Order
feature(oms-return-details): Display Loyalty Points if order is Reward Order

Ref: #5374
2025-12-02 12:40:44 +00:00
Lorenz Hilpert
68f50b911d Merged PR 1991: feat(navigation): implement title management and enhance tab system
 feat(navigation): implement title management and enhance tab system

This commit introduces a comprehensive title management system and extends
the tab functionality with subtitle support, improving navigation clarity
and user experience across the application.

Key changes:

Title Management System:
- Add @isa/common/title-management library with dual approach:
  - IsaTitleStrategy for route-based static titles
  - usePageTitle() for component-based dynamic titles
- Implement TitleRegistryService for nested component hierarchies
- Automatic ISA prefix addition and TabService integration
- Comprehensive test coverage (1,158 lines of tests)

Tab System Enhancement:
- Add subtitle field to tab schema for additional context
- Update TabService API (addTab, patchTab) to support subtitles
- Extend Zod schemas with subtitle validation
- Update documentation with usage examples

Routing Modernization:
- Consolidate route guards using ActivateProcessIdWithConfigKeyGuard
- Replace 4+ specific guards with generic config-key-based approach
- Add title attributes to 100+ routes across all modules
- Remove deprecated ProcessIdGuard in favor of ActivateProcessIdGuard

Code Cleanup:
- Remove deprecated preview component and related routes
- Clean up unused imports and exports
- Update TypeScript path aliases

Dependencies:
- Update package.json and package-lock.json
- Add @isa/common/title-management to tsconfig path mappings

Refs: #5351, #5418, #5419, #5420
2025-12-02 12:38:28 +00:00
Nino Righi
0670dbfdb1 Merged PR 2063: fix(domain-checkout): After refreshing cart availabilities always keep previo...
fix(domain-checkout): After refreshing cart availabilities always keep previous selected price from purchasing options modal

Ref: #5488
2025-12-02 11:59:35 +00:00
Lorenz Hilpert
db4f30af86 🔧 chore: improve skills cross-references and CLAUDE.md guidance
- Add --amend option with safety rules to commit command
- Add logging skill cross-references to angular-template and html-template
- Fix logging skill name from logging-helper to logging
- Add extended thinking triggers, context monitoring, and code investigation
  rules to CLAUDE.md
2025-12-02 12:57:27 +01:00
Lorenz Hilpert
39b945ae88 📝 docs: add reference documentation for specialist skills
Add migration-patterns.md for test-migration-specialist (Jest to Vitest)
and zod-patterns.md for type-safety-engineer (Zod validation patterns).
2025-12-02 12:57:11 +01:00
Lorenz Hilpert
a2b29c0525 ♻️ refactor: convert architecture-documentation from command to skill
Move architecture documentation generation from a slash command to a
skill with comprehensive reference materials (C4 model, Arc42, ADR templates).
2025-12-02 12:56:56 +01:00
Lorenz Hilpert
2c385210db 🔧 chore: add frontmatter metadata to docs commands
Add allowed-tools, argument-hint, and description frontmatter to
docs-library.md and docs-refresh-reference.md for better discoverability.
2025-12-02 12:56:40 +01:00
Lorenz Hilpert
46999cc04c 🔧 chore: consolidate quality commands into single quality.md
Merge quality-bundle-analyze.md and quality-coverage.md into a unified
quality.md command with subcommand support (bundle, coverage).
2025-12-02 12:56:20 +01:00
Nino Righi
ee9f030a99 Merged PR 2062: fix(isa-app-customer): Clear Navigation State Context if Customer Area gets d...
fix(isa-app-customer): Clear Navigation State Context if Customer Area gets destroyed

Ref: #5512
2025-12-01 11:25:11 +00:00
Lorenz Hilpert
5aded6ff8e 🩹 fix(ui-input-controls): remove top padding from dropdown options when filter present 2025-11-28 18:18:57 +01:00
Nino Righi
3228abef44 Merged PR 2061: feature(crm-data-access): Added check in customer resource if customerId has...
feature(crm-data-access): Added check in customer resource if customerId has changed to prevent flickering in the view after Filter changes etc.

Ref: #5478
2025-11-28 12:40:04 +00:00
Nino Righi
c0cc0e1bbc Merged PR 2060: feature(checkout-reward, core-tabs): Added back button and configured it so i...
feature(checkout-reward, core-tabs): Added back button and configured it so it can accept optional route to navigate. Added orderNumber and orderDate to reward order confirmation

Ref: #5456
2025-11-28 12:38:08 +00:00
Nino Righi
41630d5d7c Merged PR 2055: feature(ui-label, ahf, warenausgabe, customer-orders): Added and Updated Labe...
feature(ui-label, ahf, warenausgabe, customer-orders): Added and Updated Label Library and Label to the Views, Updated Positioning

Ref: #5479
2025-11-28 12:37:11 +00:00
Nino Righi
7884e1af32 Merged PR 2059: feature(ui-modal): add QR code display for URLs in dialog modals
feature(ui-modal): add QR code display for URLs in dialog modals

Add automatic URL detection and QR code rendering in dialog modals:
- Parse dialog content to extract URLs (http/https)
- Display extracted URLs as QR codes using angularx-qrcode library
- Split content around URL to show text before and after the QR code
- Auto-detect URLs by default, with optional showUrlAsQrCode override
- Add comprehensive unit tests for URL parsing helpers

Ref: #5511
2025-11-27 16:41:51 +00:00
Lorenz Hilpert
a5bb8b2895 Merged PR 2058: feat(crm): customer card copy-to-clipboard and carousel improvements
Customer Card Copy-to-Clipboard (#5508)

  - Click on card number copies it to clipboard using Angular CDK Clipboard
  - Shows success tooltip confirmation positioned on the right
  - Tooltip auto-dismisses after 3 seconds

  Card Stack Carousel Improvements (#5509)

  - Fix card centering by using afterNextRender instead of AfterViewInit
  - Add ResizeObserver to handle dynamic size changes
  - Disable transforms until natural position is measured (prevents initial jump)
  - Center single card in carousel view

  Tooltip Enhancements

  - Add success variant with green styling (isa-accent-green)
  - Add position input (left | right | top | bottom)
  - Add fade in/out CSS keyframes animations (150ms)
  - Respect prefers-reduced-motion for accessibility

  Related Tasks

  - Closes #5508
  - Refs #5509
2025-11-27 16:28:06 +00:00
Lorenz Hilpert
7950994d66 Merged PR 2057: feat(checkout): add branch selection to reward catalog
feat(checkout): add branch selection to reward catalog

- Add new select-branch-dropdown library with BranchDropdownComponent
  and SelectedBranchDropdownComponent for branch selection
- Extend DropdownButtonComponent with filter and option subcomponents
- Integrate branch selection into reward catalog page
- Add BranchesResource for fetching available branches
- Update CheckoutMetadataService with branch selection persistence
- Add comprehensive tests for dropdown components

Related work items: #5464
2025-11-27 10:38:52 +00:00
Nino Righi
4589146e31 Merged PR 2056: fix(ui-tooltip): Integrated CloseOnScrollDirective to close tooltip on scrolling
fix(ui-tooltip): Integrated CloseOnScrollDirective to close tooltip on scrolling

Ref: #5510
2025-11-26 20:08:11 +00:00
Nino
98fb863fc7 Merge branch 'release/4.5' into develop 2025-11-26 16:46:47 +01:00
Nino Righi
6f13d48604 Merged PR 2054: fix(checkout-reward-shopping-cart): Layout Issue Fix
fix(checkout-reward-shopping-cart): Layout Issue Fix

Ref: #5458
2025-11-26 14:04:06 +00:00
Nino Righi
d4bba4075b Merged PR 2053: feature(checkout-reward-cart): Added Empty State and View Adjustments, Disabl...
feature(checkout-reward-cart): Added Empty State and View Adjustments, Disable CTA if no items are in cart

Ref: #5435
2025-11-26 14:03:24 +00:00
Lorenz Hilpert
1fae7df73e 📝 docs: add library-reference.md usage guidance to CLAUDE.md 2025-11-25 14:14:19 +01:00
Lorenz Hilpert
bc1f6a42e6 📝 docs: update README documentation for 13 libraries 2025-11-25 14:13:44 +01:00
Nino Righi
0aeef0592b Merged PR 2052: fix(ui-input-controls): Fix Dropdown Scrolling Issue on IPAD
fix(ui-input-controls): Fix Dropdown Scrolling Issue on IPAD

Ref: #5505
2025-11-25 13:00:58 +00:00
Lorenz Hilpert
aee64d78e2 Merged PR 2051: Fix Card Position
Related work items: #5506
2025-11-25 10:36:25 +00:00
Nino
2c39ca05a9 fix(ui-input-controls): Fix iOS Dropdown Scrolling
Ref: #5505
2025-11-25 10:26:34 +01:00
Nino
5054dd5492 fix(crm-customer-card): Bg White fix 2025-11-24 17:55:12 +01:00
Nino Righi
b93e39068c Merged PR 2050: feature(checkout-reward): Disable Print Order Confirmation for HSC Users
feature(checkout-reward): Disable Print Order Confirmation for HSC Users

Ref: #5471
2025-11-24 16:01:56 +00:00
Lorenz Hilpert
dc26c4de04 Merged PR 2049: feat(oms): add auto-refresh for open reward tasks
feat(oms): add auto-refresh for open reward tasks

Implements 5-minute polling to automatically update open reward tasks
without requiring manual page refresh. Uses reference counting to safely
handle multiple consumers starting/stopping the refresh.

Changes:
- Add startAutoRefresh/stopAutoRefresh methods with ref counting
- Add lifecycle hooks to carousel component for proper cleanup
- Add logging for debugging auto-refresh behavior
- Add refresh interval constant (5 minutes)

Closes #5463

Related work items: #5463
2025-11-24 15:46:17 +00:00
Nino
688390efdb Merge branch 'develop' into release/4.5 2025-11-24 16:21:52 +01:00
Nino Righi
8b852cbd7a Merged PR 2048: fix(shared-barcode, crm-customer-card): improve barcode rendering with transp...
fix(shared-barcode, crm-customer-card): improve barcode rendering with transparent SVG background

Enhance barcode component flexibility by separating container and SVG
background colors. The SVG barcode now defaults to transparent background
while maintaining container background control, enabling better integration
with various card designs.

Changes:
- Add separate svgBackground input for SVG element (default: transparent)
- Keep background input for container styling (default: #ffffff)
- Add containerWidth and containerHeight inputs for flexible sizing
- Update customer card to remove explicit white background on barcode
- Add opacity styling for inactive customer cards
- Enhance test coverage for new background and sizing inputs

The separation of concerns allows the barcode to adapt to parent container
backgrounds while maintaining consistent rendering across different contexts.

Ref: #5498
2025-11-24 14:58:05 +00:00
Lorenz Hilpert
949101a1ed feat: add css-keyframes-animations skill for native CSS animations
Add new skill for creating performant CSS animations:
- Native @keyframes animations with GPU acceleration
- Angular animate.enter/leave for modern view transitions
- Performance guidelines and best practices
- Reference guide for common animation patterns
2025-11-24 14:54:14 +01:00
Lorenz Hilpert
fd0b950f01 📝 docs: add css-keyframes-animations skill to mandatory usage tables
Added css-keyframes-animations skill to documentation:
- Mandatory skill invocation rules table (trigger: creating CSS animations)
- Skill chaining table (component with animations workflow)
2025-11-24 14:53:47 +01:00
Lorenz Hilpert
38de927c4e Merged PR 2047: feat(carousel): convert to transformX with touch support and card animations
feat(carousel): convert to transformX with touch support and card animations

- Convert carousel from scroll-based to translate3d() transform positioning
- Add touch/swipe support with direct DOM manipulation for smooth 60fps performance
- Add mouse drag support for desktop navigation
- Implement hardware-accelerated transforms with will-change optimization
- Add disabled input to prevent navigation when needed
- Fix bounds calculation to use parent viewport width
- Add card stacking animation with translateY and rotation effects
- Remove shadow for cards beyond 3rd position in stacked mode
- Update tests with 4 new disabled state test cases (17 tests total)

Refs #5499

Related work items: #5499
2025-11-24 13:37:34 +00:00
Michael Auer
7429f28bf9 Merge branch 'develop' into release/4.5 2025-11-24 11:47:02 +01:00
Michael Auer
7f1cdf880f ! azure-pipelines.yml: set new and old style docker tag (2 tags) 2025-11-24 11:16:19 +01:00
Michael Auer
acb541df4e Merge branch 'develop' into release/4.5 2025-11-24 09:37:16 +01:00
Michael Auer
9383e2035b Merged PR 2039: New Docker Tag 2025-11-24 08:33:42 +00:00
Lorenz Hilpert
a1a8b1f115 ci: update minor version to 5 in CI configuration 2025-11-21 19:01:19 +01:00
Lorenz Hilpert
ac2df3ea54 ♻️ refactor(agents,skills): optimize invocation system with context-efficient architecture
## Major Changes

**Agent System Overhaul:**
-  Added 3 specialized implementation agents (angular-developer, test-writer, refactor-engineer)
- 🗑️ Removed 7 redundant agents (debugger, error-detective, deployment-engineer, prompt-engineer, search-specialist, technical-writer, ui-ux-designer)
- 📝 Updated all 9 agent descriptions with action-focused, PROACTIVELY-triggered patterns
- 🔧 Net reduction: 16 → 9 agents (44% reduction)

**Description Pattern Standardization:**
- **Agents**: "[Action] + what. Use PROACTIVELY when [specific triggers]. [Features]."
- **Skills**: "This skill should be used when [triggers]. [Capabilities]."
- Removed ambiguous "use proactively" without conditions
- Added measurable triggers (file counts, keywords, thresholds)

**CLAUDE.md Enhancements:**
- 📚 Added "Agent Design Principles" based on Anthropic research
-  Added "Proactive Agent Invocation" rules for automatic delegation
- 🎯 Added response format control (concise vs detailed)
- 🔄 Added environmental feedback patterns
- 🛡️ Added poka-yoke error-proofing guidelines
- 📊 Added token efficiency benchmarks (98.7% reduction via code execution)
- 🗂️ Added context chunking strategy for retrieval
- 🏗️ Documented Orchestrator-Workers pattern

**Context Management:**
- 🔄 Converted context-manager from MCP memory to file-based (.claude/context/)
- Added implementation-state tracking for session resumption
- Team-shared context in git (not personal MCP storage)

**Skills Updated (5):**
- api-change-analyzer: Condensed, added trigger keywords
- architecture-enforcer: Standardized "This skill should be used when"
- circular-dependency-resolver: Added build failure triggers
- git-workflow: Added missing trigger keywords
- library-scaffolder: Condensed implementation details

## Expected Impact

**Context Efficiency:**
- 15,000-20,000 tokens saved per task (aggressive pruning)
- 25,000-35,000 tokens saved per complex task (agent isolation)
- 2-3x more work capacity per session

**Automatic Invocation:**
- Main agent now auto-invokes specialized agents based on keywords
- Clear boundaries prevent wrong agent selection
- Response format gives user control over detail level

**Based on Anthropic Research:**
- Building Effective Agents
- Writing Tools for Agents
- Code Execution with MCP
- Contextual Retrieval
2025-11-21 19:00:01 +01:00
Nino Righi
4107641e75 Merged PR 2046: feature(crm-data-access): Update Transactions Endpoint
feature(crm-data-access): Update Transactions Endpoint

Ref: #5336
2025-11-21 17:39:57 +00:00
Nino
bb717975a0 fix(customer-card-main-view): Take activeCardCode first if it exist
Refs: #5503
2025-11-21 17:13:56 +01:00
Nino
6c75536cd0 Merge branch 'develop' of https://dev.azure.com/hugendubel/ISA/_git/ISA-Frontend into develop 2025-11-21 17:10:51 +01:00
Nino
4c306a213d fix(crm-customer-card): Refresh after Lock, Unlock or Add Cards correctly, Adjusted Placeholder Text, Show Transactions based on first Card instead of first active card
Ref: #5503
2025-11-21 17:10:12 +01:00
Nino Righi
7a98db35fb Merged PR 2045: feature(crm-data-access): Updated Add Card Endpoint
feature(crm-data-access): Updated Add Card Endpoint

Ref: #5329
2025-11-21 15:41:24 +00:00
Nino Righi
cf359954ca Merged PR 2044: fix(utils-positive-integer-input): Fixed issue with copy and paste
fix(utils-positive-integer-input): Fixed issue with copy and paste

Ref: #5501
2025-11-21 15:40:55 +00:00
Nino Righi
df1fe540d0 Merged PR 2043: #5335 Endpoint Unlock wurde erweitert
#5335 Endpoint Unlock wurde erweitert
2025-11-21 14:30:01 +00:00
Lorenz Hilpert
bf87df6273 Merged PR 2042: fix(navigation): prevent autoTriggerContinueFn from persisting across navigat...
fix(navigation): prevent autoTriggerContinueFn from persisting across navigations

The autoTriggerContinueFn flag was remaining in navigation context after
being read, causing incorrect auto-triggering on subsequent page visits.

Changes:
- Add patchContext() method to NavigationContextService and NavigationStateService
  for partial context updates without full replacement
- Update details-main-view.component to use patchContext() to clear the flag
  immediately after reading, while preserving returnUrl
- Add comprehensive JSDoc and README documentation for patchContext()
- Include structured logging for patch operations

The new patchContext() method provides a cleaner API for updating specific
context properties without manually preserving all other properties.

Closes #5500

Related work items: #5500
2025-11-21 13:45:40 +00:00
Lorenz Hilpert
7a6a2dc49d Merged PR 2038: feat(shared,crm): add Code 128 barcode generation library
feat(shared,crm): add Code 128 barcode generation library

Implements new @isa/shared/barcode library with directive and component
for generating Code 128 barcodes using JsBarcode.

Features:
- Standalone Angular directive (svg[sharedBarcode])
- Standalone Angular component (<shared-barcode>)
- Signal-based reactive inputs
- SVG-based vector rendering
- Customizable colors, size, margins, fonts
- Comprehensive Vitest test coverage (39 tests)
- Storybook stories for both directive and component
- Integrated into customer loyalty card component

Changes:
- Created @isa/shared/barcode library with directive and component
- Added JsBarcode dependency (v3.12.1)
- Integrated barcode into customer loyalty card display
- Added Storybook stories for interactive documentation
- Fixed ui-switch story component reference
- Updated library reference documentation

Refs #5496

Related work items: #5496
2025-11-21 13:42:32 +00:00
Lorenz Hilpert
5f1d3a2c7b Merged PR 2040: fix(crm): prevent duplicate reload of loyalty points
fix(crm): prevent duplicate reload of loyalty points

Refactored reload mechanism to use parent-managed pattern:
- Child components emit events instead of reloading directly
- Parent coordinates reload of both transactions and bonus cards
- Added loading guards to prevent concurrent requests
- Added JSDoc documentation to public methods

Closes #5497

Related work items: #5497
2025-11-21 13:40:06 +00:00
Nino Righi
644c33ddc3 Merged PR 2041: fix(ui-input-controls-dropdown): Added Dropdown Backdrop + Lock Position
fix(ui-input-controls-dropdown): Added Dropdown Backdrop + Lock Position

Ref: #5495
2025-11-21 13:35:49 +00:00
Lorenz Hilpert
5f2cb21c18 docs(skill): update library-scaffolder to include architectural tags
- Add Step 4 for automatic library tagging
- Include --prefix parameter in Nx generation commands
- Document tag rules and verification steps
- Update creation report to show tags
- Add references to enforce-module-boundaries config
2025-11-20 17:59:22 +01:00
Nino Righi
b32cc48fd9 Merged PR 2036: feature(libs-icons, crm-customer-card-transactions): Added Refresh Icon, Adde...
feature(libs-icons, crm-customer-card-transactions): Added Refresh Icon, Added Spacer to Transaction Layout, Added Refresh CTA Styling

Ref: #5493
2025-11-20 16:58:02 +00:00
Nino Righi
bcd4d655a6 Merged PR 2035: fix(utils-positive-integer-input, crm-customer-booking, crm-customer-card): a...
fix(utils-positive-integer-input, crm-customer-booking, crm-customer-card): add missing path mapping in tsconfig

Add the @isa/utils/positive-integer-input path mapping to tsconfig.base.json
to resolve module resolution issues. The library was created but the path
alias was not properly registered, causing import errors in consuming modules.

Ref: #5492
2025-11-20 16:57:04 +00:00
Lorenz Hilpert
1784e08ce6 chore: update project configurations to skip CI for specific libraries
Added "skip:ci" tag to multiple project configurations to prevent CI runs
for certain libraries. This change affects the following libraries:
crm-feature-customer-card-transactions, crm-feature-customer-loyalty-cards,
oms-data-access, oms-feature-return-details, oms-feature-return-process,
oms-feature-return-summary, remission-data-access, remission-feature-remission-list,
remission-feature-remission-return-receipt-details, remission-feature-remission-return-receipt-list,
remission-shared-remission-start-dialog, remission-shared-return-receipt-actions,
shared-address, shared-delivery, ui-carousel, and ui-dialog.

Also updated CI command in package.json to exclude tests with the "skip:ci" tag.
2025-11-20 17:24:35 +01:00
Lorenz Hilpert
39058aeab8 chore: remove redundant code blocks from changes section 2025-11-20 16:17:47 +01:00
Lorenz Hilpert
c873546160 Merged PR 2034: feat(crm): set selected customer when navigating to Prämienshop
 feat(crm): set selected customer when navigating to Prämienshop

Implements autoTriggerContinueFn pattern to properly set customer context
before navigating to reward shop from customer loyalty cards view.

Changes:
- Add output event to customer-loyalty-cards component (library layer)
- Handle navigation at app layer (kundenkarte-main-view) to respect module boundaries
- Use existing autoTriggerContinueFn pattern from details-main-view
- Inject NavigationStateService and CustomerSearchNavigation services
- Preserve context with returnUrl and autoTriggerContinueFn flag

This ensures customer selection logic (_setCustomer, _setBuyer, _setSelectedCustomerIdInTab)
executes before navigating to the reward shop, matching the behavior of the
continue() method in CustomerDetailsViewMainComponent.

Refs: #5485

Related work items: #5485
2025-11-20 15:15:32 +00:00
Lorenz Hilpert
f3d5466f81 feat: add NgRx Resource API and Angular effects alternatives skills
Add two new skills based on Angular Architects articles:

1. ngrx-resource-api: Guide for integrating Angular's Resource API with
   NgRx Signal Store for reactive data management without RxJS
   - withProps pattern for dependency injection
   - Resource configuration and lifecycle
   - Error handling and computed derivations
   - Common patterns and best practices

2. angular-effects-alternatives: Guide for proper effect() usage and
   declarative alternatives to prevent anti-patterns
   - Valid use cases (logging, canvas, imperative APIs)
   - Anti-patterns to avoid (state propagation, synchronization)
   - Decision tree for choosing alternatives
   - Refactoring patterns and code review checklist

Both skills follow modern Angular patterns and promote declarative,
maintainable code aligned with reactive principles.
2025-11-20 15:46:50 +01:00
Lorenz Hilpert
3e960b0f44 ♻️ refactor: improve ResponseArgs validation with Zod schema
- Replace manual type checking with Zod schema validation in isResponseArgs helper
- Simplify error handling logic in catchResponseArgsErrorPipe operator
- Remove redundant conditional checks by leveraging Zod's safeParse
- Remove unused ResponseArgs import from operator file

This improves type safety and validation robustness by using a declarative schema-based approach.
2025-11-20 15:22:16 +01:00
Nino Righi
17cb0802c3 Merged PR 2033: Add, Lock, Unlock Customer Cards
Add, Lock, Unlock Customer Cards

Refs: #5313, #5329, #5334, #5335
2025-11-20 13:59:27 +00:00
Lorenz Hilpert
b7d008e339 Merged PR 2032: Bugfix Bon Error Message
Related work items: #5314
2025-11-19 15:18:26 +00:00
Lorenz Hilpert
ceaf6dbf3c 📝 docs: add mandatory skill usage guidelines for reliable proactive invocation
Add critical section to CLAUDE.md covering:
- Skill vs Agent vs Direct Tools decision matrix
- Mandatory skill invocation rules with trigger conditions
- Proactive usage framework with right/wrong examples
- Skill chaining and coordination patterns
- Context management for skills (load → apply → unload)
- Failure handling for skill conflicts
- Decision tree for tool selection
2025-11-19 14:31:12 +01:00
Lorenz Hilpert
0f171d265b 📝 docs: add comprehensive context management guidelines for subagent usage
Add critical sections to CLAUDE.md covering:
- Context preservation rules to prevent bloat
- Agent invocation patterns (sequential/parallel/escalation)
- Result handling and synthesis guidelines
- Edge case handling (failures, timeouts, conflicts)
- Model selection criteria (Haiku vs Sonnet)
- Resume vs fresh agent decision framework
- Result validation and confidence communication
- Debug mode and special scenarios
- Performance degradation handling
- Caching strategies and priority conflict resolution
2025-11-19 14:31:12 +01:00
Lorenz Hilpert
fc6d29d62f Merged PR 2031: feat(crm): add customer bon redemption feature
feat(crm): add customer bon redemption feature

- New library @isa/crm/feature/customer-bon-redemption
- Implement bon validation and redemption flow
- Add SignalStore for state management
- Add resource pattern for reactive data loading
- Add facade for business logic abstraction
- Add Zod schemas for runtime validation
- Integrate with loyalty card API endpoints
- Add accessibility and E2E test attributes
- Remove mock provider (use real facade)
- Exclude generated swagger files from linting

Components:
- BonInputFieldComponent - input with validation
- BonDetailsDisplayComponent - shows validated bon
- BonRedemptionButtonComponent - redemption action

Data Access:
- CustomerBonRedemptionFacade - business logic
- CustomerBonCheckResource - reactive validation
- BonRedemptionStore - component state
- CrmSearchService - API integration (checkBon, addBon)

Issue: 5314

Related work items: #5314
2025-11-19 12:51:58 +00:00
Nino
8c0de558a4 feature(crm-customer-card): Improvements, Refresh Transactions
Refs: #5316, #5315
2025-11-18 16:44:54 +01:00
Nino
8b62fcc695 chore(package-lock): Update lock file, fixing build errors 2025-11-18 12:11:31 +01:00
Nino Righi
a855e79196 Merged PR 2030: feat(crm-customer-booking): add loyalty card booking component
feat(crm-customer-booking): add loyalty card booking component

Implement new component for customer loyalty card credit/debit bookings with booking type selection and real-time transaction updates. Includes automatic reload of transaction history after successful bookings.

Key changes:
- Add CrmFeatureCustomerBookingComponent with booking form UI
- Create CustomerCardBookingFacade for booking API calls
- Add CustomerBookingReasonsResource for loading booking types
- Extend CrmSearchService with booking methods (addBooking, fetchBookingReasons, fetchCurrentBookingPartnerStore)
- Add AddBookingSchema with Zod validation
- Integrate component into KundenkarteMainViewComponent
- Update CustomerCardTransactionsResource to providedIn: 'root' for shared access
- Improve transaction list UX (hide header/center empty state when no data)

Technical details:
- New library: @isa/crm/feature/customer-booking (Vitest-based)
- Signals-based state management with computed properties
- Automatic points calculation based on booking type multiplier
- Error handling with feedback dialogs
- 500ms delay before transaction reload to ensure API consistency
- Data attributes for E2E testing (data-what, data-which)

Ref: #5315
2025-11-18 10:05:17 +00:00
Nino Righi
71af23544f Merged PR 2029: feature(crm, isa-app-customer-search): Adjustments to Card Transaction Histor...
feature(crm, isa-app-customer-search): Adjustments to Card Transaction History, Added Scroll Top Button, Show 50 last Transactions, Wording changes
Refs: #5316
2025-11-18 09:58:26 +00:00
Lorenz Hilpert
e654a4d95e Merged PR 2028: Commit 86563a73: feat(crm): add customer card transactions history feature
Commit 86563a73:  feat(crm): add customer card transactions history feature

Implements #5316 - Service Portal History displaying last 5 loyalty card transactions

**New feature library:**
- Created @isa/crm/feature/customer-card-transactions with CDK table component
- Shows transactions for first activated customer loyalty card
- Displays: Date, Transaction type (reason), Amount (EUR), Receipt number, Points

**Data layer:**
- Added CustomerCardTransactionsResource with reactive resource pattern
- Extended CrmSearchService with fetchLoyaltyBookings() method
- Uses LoyaltyCardService.LoyaltyCardListBookings() API endpoint

**UI/UX:**
- CDK table with ISA design system colors
- Header: 48px height, rounded corners (26px), neutral-400 background
- Visual indicators: Green up arrow (EARN), Red down arrow (BURN)
- German locale formatting (dd.MM.yyyy HH:mm.ss)
- Full-width table layout with proper spacing (24px between rows)
- Empty state when no transactions available

**Icons:**
- Added isaActionPolygonUp and isaActionPolygonDown to @isa/icons

**Integration:**
- Integrated into kundenkarte-main-view component
- Automatically loads transactions for first active card

Related work items: #5316
2025-11-14 13:09:58 +00:00
Lorenz Hilpert
5057d56532 Merged PR 2026: feat(crm): add customer loyalty cards feature with points summary
Related work items: #5312
2025-11-14 12:59:02 +00:00
Nino
70ded96858 Merge branch 'release/4.4' into develop 2025-11-14 10:56:11 +01:00
Nino
7c2c72745f feature(checkout-reward): Enable Delivery Options 2025-11-14 10:55:05 +01:00
Nino
2ea76b6796 fix(core-tabs): Create Shopping Cart Correctly
Ref: #5480
2025-11-13 17:48:11 +01:00
Nino Righi
83292836a3 Merged PR 2027: #5483 Reset Reward Cart + Customer from Tab
#5483 Reset Reward Cart + Customer from Tab

Small Bugfixes to #5480 Customer clearing Logic
2025-11-13 15:49:49 +00:00
Nino Righi
212203fb04 Merged PR 2025: fix(core-tabs): improve tab cleanup and naming logic
fix(core-tabs): improve tab cleanup and naming logic

Refactor tab management to handle checkout state transitions more reliably:

- Extract helpers (formatCustomerTabNameHelper, checkCartHasItemsHelper,
  getNextTabNameHelper) from checkout component to @isa/core/tabs for reuse
- Fix getNextTabNameHelper to count tabs instead of finding max ID,
  preventing gaps in "Vorgang X" numbering
- Add canDeactivateTabCleanup guard to manage tab context based on cart state:
  * Preserves customer context if either cart (regular or reward) has items
  * Updates tab name with customer/organization name when context preserved
  * Resets tab to clean "Vorgang X" state when both carts empty
  * Handles navigation to global areas (without tab ID) gracefully
- Apply canDeactivateTabCleanup to checkout-summary and reward-order-confirmation routes
- Move tab cleanup logic from component ngOnDestroy to reusable guard
- Add comprehensive unit tests for getNextTabNameHelper

This ensures tabs maintain correct state after order completion, properly
display customer context when carts have items, and reset cleanly when
both carts are empty. The guard approach centralizes cleanup logic and
makes it reusable across checkout flows.

Ref: #5480
2025-11-13 14:10:43 +00:00
Lorenz Hilpert
b89cf57a8d fix(tabs): fix tab activation issue 2025-11-12 20:56:53 +01:00
Lorenz Hilpert
b70f2798df fix(auth): Use Angular Router for post-auth redirects
Replace window.location.href with Router.navigateByUrl() to ensure proper Angular navigation flow after authentication, maintaining state and avoiding full page reloads.
2025-11-12 15:58:38 +01:00
Lorenz Hilpert
0066e8baa1 fix(config): Update ISA API endpoint to test environment
Change @swagger/isa rootUrl from isa-feature to isa-test environment
to resolve KulturPass voucher redemption infinite loading issue.

Fixes #5474
2025-11-12 15:55:23 +01:00
Lorenz Hilpert
999f61fcc0 Merged PR 2023: fix(core/tabs): Add logging and fix critical bugs in TabService
fix(core/tabs): Add logging and fix critical bugs in TabService

- Add comprehensive logging using @isa/core/logging for all TabService methods
- Fix null pointer in patchTab when tab doesn't exist
- Fix activateTab allowing non-existent tabs to be set as active
- Fix removeTab not clearing activatedTabId when removing active tab
- Replace unsafe 'as any' type casts with proper type checking
- Document side effect in getCurrentLocation method

Fixes #5474

Related work items: #5474
2025-11-12 13:39:50 +00:00
Nino
b827a6f0a0 fix(isa-app): Fixes Auth and TabID Errors on Startup
Refs: #5472, #5473
2025-11-12 12:40:59 +01:00
Lorenz Hilpert
29b6091a30 chore: update MCP configuration and add Nx guidelines
- Update nx-mcp command format in .mcp.json
- Add Nx configuration section to CLAUDE.md
- Create AGENTS.md with Nx guidelines
- Improve formatting in CLAUDE.md
2025-11-12 12:09:04 +01:00
Nino
989294cc90 chore(azure-pipelines): Version Bump 2025-11-12 11:38:55 +01:00
Nino
c643d988fa Merge branch 'release/4.3' 2025-11-11 21:56:00 +01:00
Nino
463e46e17a chore(azure-pipelines, package-lock): Version Bump 2025-11-11 16:41:29 +01:00
Nino
c98d5666a4 fix(checkout-completion-orchestrator): Added Feedback Error Dialog 2025-11-11 16:07:50 +01:00
Nino
835546a799 feat(reward-purchasing-options): Disable Delivery Options 2025-11-11 15:18:38 +01:00
Lorenz Hilpert
f261fc9987 Merged PR 2021: feat(pickup-shelf): display Prämie label and Lesepunkte for reward items
feat(pickup-shelf): display Prämie label and Lesepunkte for reward items

- Add "Prämie" ui-label badge below product images in both list and details views
- Display Lesepunkte value instead of price for reward items
- Update getOrderItemRewardFeature helper to use structural typing for better type flexibility
- Apply to pickup-shelf-details-item and pickup-shelf-list-item components

Fixes #5467
2025-11-11 14:15:41 +00:00
Lorenz Hilpert
cc186dbbe2 Merged PR 2022: fix(checkout): prevent duplicate tasks in open reward carousel
Related work items: #5468
2025-11-11 14:15:05 +00:00
Nino Righi
6df02d9e86 Merged PR 2020: feat(confirmation-list-item-action-card): improve action card visibility logi...
feat(confirmation-list-item-action-card): improve action card visibility logic and add ordered state

Enhance the action card display logic to show only when both feature flag
and command/completion conditions are met. Add support for "Ordered" state
to distinguish pending items from completed ones.

Changes:
- Add hasLoyaltyCollectCommand helper to check for LOYALTY_COLLECT_COMMAND
- Update displayActionCard logic to require both Rücklage feature AND
  (loyalty collect command OR completion state)
- Add ProcessingStatusState.Ordered to distinguish ordered vs completed items
- Update isComplete to exclude ordered items from completion state
- Move role-based visibility check to outer container level
- Remove unused CSS class for completed state
- Add comprehensive unit tests for new helpers

The action card now correctly appears only for items that need user action,
hiding for CallCenter role and for items without the required commands.

Ref: #5459
2025-11-11 12:16:17 +00:00
Lorenz Hilpert
4a7b74a6c5 Merged PR 2018: add reward points (Prämie) display and label
Related work items: #5413
2025-11-11 09:48:26 +00:00
Lorenz Hilpert
9c989055cb Merged PR 2019: fix(customer-details): prioritize cart navigation over reward return URL
fix(customer-details): prioritize cart navigation over reward return URL

Fixes issue #5461 where navigating to cart after customer selection would
incorrectly route to reward shop page. Changed navigation priority to check
for regular shopping cart items before checking for reward return URL context.

This ensures that active standard checkout flows take precedence over any
lingering reward flow navigation context.

Related work items: #5461
2025-11-11 09:09:29 +00:00
Lorenz Hilpert
2e0853c91a Merged PR 2016: feat(core/auth): add type-safe role-based authorization library
feat(core/auth): add type-safe role-based authorization library

Created @isa/core/auth library with comprehensive role checking:
- RoleService for programmatic hasRole() checks
- IfRoleDirective for declarative *ifRole/*ifNotRole templates
- Type-safe Role enum (CallCenter, Store)
- TokenProvider abstraction with OAuth2 integration
- Signal-based reactive rendering with Angular effects
- Zero-configuration setup via InjectionToken factory

Fixed Bug #5451:
- Hide action buttons for HSC (CallCenter) users on reward order confirmation
- Applied *ifNotRole="Role.CallCenter" to actions container
- Actions now hidden while maintaining card visibility

Testing:
- 18/18 unit tests passing with Vitest
- JUnit and Cobertura reporting configured
- Complete test coverage for role checking logic

Documentation:
- Comprehensive README (817 lines) with API reference
- Usage examples and architecture diagrams
- Updated library-reference.md (62→63 libraries)

Technical:
- Handles both string and array JWT role formats
- Integrated with @isa/core/logging
- Standalone directive (no module imports)
- Full TypeScript type safety

Closes #5451

Related work items: #5451
2025-11-10 17:00:39 +00:00
Nino
c5ea5ed3ec Merge branch 'develop' of https://dev.azure.com/hugendubel/ISA/_git/ISA-Frontend into develop 2025-11-10 16:16:21 +01:00
Nino
7c29429040 fix(get-main-actions): Return only enabled Actions 2025-11-10 16:15:41 +01:00
Nino Righi
c3e9a03169 Merged PR 2015: fix(crm-data-access, customer-details, reward-shopping-cart): persist selecte...
fix(crm-data-access, customer-details, reward-shopping-cart): persist selected addresses across navigation flows

Implement address selection persistence using CRM tab metadata to ensure
selected shipping addresses and payers are retained throughout the customer
selection flow, particularly when navigating from Kundenkarte to reward cart.

Changes include:
- Create PayerResource and CustomerPayerAddressResource to load selected
  payer from tab metadata with fallback to customer as payer
- Create PayerService to fetch payer data from CRM API with proper error
  handling and abort signal support
- Update BillingAndShippingAddressCardComponent to prefer selected addresses
  from metadata over customer defaults, with computed loading state
- Refactor continue() flow in CustomerDetailsViewMainComponent to load
  selected addresses from metadata before setting in checkout service
- Add adapter logic to convert CRM payer/shipping address types to checkout
  types with proper type casting for incompatible enum types
- Implement fallback chain: metadata selection → component state → customer
  default for both payer and shipping address

This ensures address selections made in the address selection dialogs are
properly preserved and applied when completing the customer selection flow,
fixing the issue where addresses would revert to customer defaults.

Ref: #5411
2025-11-10 15:10:56 +00:00
Lorenz Hilpert
b984a2cac2 Merged PR 2014: fix(open-reward-tasks): filter out pickup-only reward orders
fix(open-reward-tasks): filter out pickup-only reward orders

Exclude reward orders with only pickup items (supplier_id: '16') from open tasks
as these cannot be completed in the reward shop.

Fixes BUG-5444
2025-11-10 13:11:49 +00:00
Lorenz Hilpert
b0afc80a26 Merged PR 2013: 🐛 fix(order-destination): display 'Hugendubel Digital' for download destinat...
🐛 fix(order-destination): display 'Hugendubel Digital' for download destinations

Fixes #5453

- Add handling for Download order type in name() computed signal to return 'Hugendubel Digital'
- Add handling for Download order type in address() computed signal to return undefined
- Update template to conditionally show pipe separator and address only when address exists
- Add isaDeliveryDownload icon for download order type
- Remove unused OrderType import

Related work items: #5453
2025-11-07 16:21:08 +00:00
Lorenz Hilpert
3bc6d47c31 Merged PR 2012: fix(purchase-options): resolve Lesepunkte delivery method change error
fix(purchase-options): resolve Lesepunkte delivery method change error

  The commit includes:
  - Restored ensureCurrencyDefaults import that was accidentally removed
  - Fixed immutability violations in both getAddToShoppingCartDTOForItem and getUpdateShoppingCartItemDTOForItem methods
  - Proper handling of frozen NgRx ComponentStore state objects
  - Resolves bug #5452 where Lesepunkte delivery method changes failed

  The pre-commit hooks ran successfully (ESLint passed with no changes needed). The fix is now ready to be pushed and tested.

Related work items: #5452
2025-11-07 15:56:50 +00:00
Lorenz Hilpert
e05deeb8bc Merged PR 2011: 🐛 fix(checkout): include download orders in destination update flow
🐛 fix(checkout): include download orders in destination update flow

Fixes #5448 - Prämienshop download orders now properly update destination
logistician before order creation. Previously, download orders were excluded
from the destination update step, causing null logistician errors during
order creation in the reward shop.

The fix adds hasDownload to the condition that determines whether to update
destination shipping addresses, ensuring download items (including those
purchased with loyalty points) get their logistician properly assigned.

Related work items: #5448
2025-11-07 15:07:49 +00:00
Nino Righi
11e2aaff8d Merged PR 2010: fix(reward-shopping-cart-item, filter-service): exclude downloads and text in...
fix(reward-shopping-cart-item, filter-service): exclude downloads and text inputs from counts

Hide low stock warning for download items in reward shopping cart, as
downloads don't have physical inventory constraints.

Exclude text/searchbox inputs from selected filter count calculation
to prevent search queries from inflating the filter badge counter.

Remove unused isIconButtonActive computed property in filter menu button.

Ref: #5441
2025-11-07 15:03:41 +00:00
Lorenz Hilpert
731df8414d Merged PR 2009: fix shopping cart - sync issues 2025-11-07 12:18:31 +00:00
Nino Righi
f04e36e710 Merged PR 2008: fix(reward-print, reward-popup, reward-destination): improve reward cart stab...
fix(reward-print, reward-popup, reward-destination): improve reward cart stability and UX

- fix: remove console.log statement from calculate-price-value helper
- fix: add loading/pending state to print button to prevent duplicate prints
- fix: debounce reward selection resource reloading to prevent race conditions
- fix: correct reward cart item destination-info alignment and flex behavior
- fix: support OrderType in OrderDestinationComponent alongside OrderTypeFeature
- fix: use unitPrice instead of total for price calculations in reward items
- refactor: update calculatePriceValue test descriptions for clarity
- fix: fallback to order.orderType when features don't contain orderType

The reward selection popup now properly waits for all resources to reload
before resolving, preventing timing issues with cart synchronization.
Print button shows pending state during print operations.
Destination info components now handle both legacy OrderType and new
OrderTypeFeature enums for better compatibility.

Ref: #5442, #5445
2025-11-06 16:32:10 +00:00
Lorenz Hilpert
af7bad03f5 💄 style: reformat crm-customer.service for improved readability
Apply consistent code formatting with multi-line function parameters and object properties throughout the CRM customer service. No functional changes.
2025-11-06 17:30:18 +01:00
Lorenz Hilpert
8e4d4ff804 🔄 chore: sync swagger API clients with backend updates
- Regenerated all Swagger API clients (availability, checkout, crm, isa, print, wws)
- Updated CRM loyalty card API endpoints (removed interests, added booking/bon management)
- Temporarily disabled interests form block functionality due to API changes
- Removed deprecated models (check-loyalty-card-result, loyalty-card-status, entity-key-value)
- Added new loyalty booking and bon management models and services
2025-11-06 17:03:37 +01:00
Lorenz Hilpert
89b3d9aa60 Merged PR 2000: open tasks
Related work items: #5309
2025-11-06 10:01:41 +00:00
Lorenz Hilpert
1d4c900d3a 🔧 chore: configure junit and cobertura test reporting
- Add junit reporter to vitest configs for CI/CD integration
- Enable cobertura coverage reports for test analytics
- Add @ts-expect-error comment for complex vitest reporter types
- Remove duplicate test target from reward-selection-dialog project.json
2025-11-06 10:46:38 +01:00
Nino Righi
a6f0aaf1cc Merged PR 2007: fix(filter-service, number-range-filter-input): resolve NumberRange state man...
fix(filter-service, number-range-filter-input): resolve NumberRange state management and reference issues

**Root Cause:**
Filter service was experiencing reference sharing between current state and
committed state due to shallow copying in commit(), causing filters to
incorrectly appear as "changed" when mixing NumberRange with other filter
types like Checkbox.

**Changes Made:**

1. **State Management (filter.service.ts):**
   - Use structuredClone() in commit() for deep copies to prevent reference sharing
   - Update clear() to preserve structural properties (options array references)
   - Refactor resetInput() to selectively copy only mutable properties while
     preserving structural ones for isEqual() comparisons
   - Simplify selectedFilterCount to use isDefaultFilterInput() consistently

2. **Default Values (number-range-filter-input.mapping.ts):**
   - Parse minValue/maxValue from config (e.g., "1-" → 1) as defaults
   - Use parsed defaults as initial min/max when no explicit value provided

**Impact:**
- NumberRange filters correctly display default values in UI
- Filters no longer incorrectly show as "changed" after multiple commits
- "Standardeinstellungen" works correctly when mixing NumberRange with other types
- selectedFilterCount accurately reflects changed filters including NumberRange

Ref: #5402
2025-11-05 20:17:52 +00:00
Nino Righi
b8e2d3f87b Merged PR 2006: feature(checkout-complete-order): Added Error Feedback to reward checkout
feature(checkout-complete-order): Added Error Feedback to reward checkout

Fixed Build Errors inside purchase-options

Ref: #5416
2025-11-05 20:17:26 +00:00
Nino
27aa694158 fix(chore): Updated Package-Lock to fix build related issues 2025-11-05 16:59:00 +01:00
Nino
196b9a237a Merge branch 'develop' of https://dev.azure.com/hugendubel/ISA/_git/ISA-Frontend into develop 2025-11-05 16:44:15 +01:00
Nino
6a2ba30a01 fix(chore): Build Errors Fix 2025-11-05 16:43:50 +01:00
Nino Righi
eb0d96698c Merged PR 2005: feat(shared-filter, ui-switch): add switch filter menu button for inline toggle filters
feat(shared-filter, ui-switch): add switch filter menu button for inline toggle filters

Add a new SwitchMenuButtonComponent that renders filter inputs as compact toggle switches
without an overlay menu. This provides a more streamlined UX for simple boolean/single-option
filters directly in the controls panel.

Key changes:
- Create new switch-menu module with button component and tests
- Extend FilterControlsPanelComponent to accept switchFilters input array
- Rename IconSwitchComponent to SwitchComponent for consistency
- Update filter actions to use 'target' property instead of 'group' for filtering
- Add isEmptyFilterInput support for NumberRange inputs
- Export switch-menu module from shared/filter public API

The switch button auto-commits on toggle and uses the checkbox filter model internally,
allowing simple configuration like:

switchFilters = [{ filter: stockFilter, icon: 'isaFiliale' }]

This implementation follows the existing filter architecture patterns and maintains
full accessibility support through ARIA attributes and keyboard navigation.

Ref: #5427
2025-11-05 15:31:13 +00:00
Lorenz Hilpert
a52928d212 🔧 chore: remove memory MCP server and context-manager documentation
Remove the memory MCP server configuration and all references to the context-manager agent with persistent memory capabilities from CLAUDE.md.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-05 14:04:52 +01:00
Lorenz Hilpert
d46bf462cb Merged PR 2004: 🐛 fix(checkout): remove manual cart counter updates (#5412)
🐛 fix(checkout): remove manual cart counter updates (#5412)

Remove updateProcessCount method and all manual calls to it.
The cart counter is now updated through reactive mechanisms,
ensuring it stays in sync when items are added or removed.

Fixes bug where reward cart icon counter was not updating
when items were removed from the cart.

Related work items: #5412
2025-11-04 16:46:19 +00:00
Lorenz Hilpert
a2833b669d Merged PR 2003: 🐛 fix(purchase-options): correct popup display for e-books and downloads
🐛 fix(purchase-options): correct popup display for e-books and downloads

- Check item formats (DL/EB) instead of backend availabilities to determine download-only items
- Display 'Derzeit nicht verfügbar' warning when download items lack availability
- Prevent 'Geringer Bestand' message from showing for:
  * Download/e-book items
  * Items with zero stock
  * Items with pending in-store availability requests

Fixes #5410

Related work items: #5410
2025-11-04 16:06:06 +00:00
Lorenz Hilpert
cc62441f58 Merged PR 2002: fix(checkout): resolve itemType validation error for download items
fix(checkout): resolve itemType validation error for download items

Updates ItemTypeSchema to accept bitwise flag combinations instead of
only individual enum values. The backend returns combined itemType
values (e.g., 20480 = ItemPrice | Download) which were causing Zod
validation errors when adding download/e-book items to cart.

Changes:
- Update ItemTypeSchema to use bitwise validation pattern
- Add comprehensive unit tests (24 tests) covering individual flags,
  combinations, and edge cases
- Follow same pattern as NotificationChannelSchema and CRUDASchema

Closes #5429

Related work items: #5429
2025-11-04 15:14:39 +00:00
Lorenz Hilpert
e1681d8867 Merged PR 2001: fix(auth): handle empty user state on login
fix(auth): handle empty user state on login

Resolves error when user state is empty during login process.

Refs #5431

Related work items: #5431
2025-11-04 15:13:21 +00:00
Lorenz Hilpert
ce86014300 ♻️ refactor(filter): replace group-based filtering with target-based filtering
Replace the `group` property with `target` property in BaseFilterInputSchema to explicitly distinguish between 'filter' and 'input' query parameters. This improves code clarity and provides better semantic meaning.

**Changes:**
- Add `target` property to BaseFilterInputSchema with type 'filter' | 'input' and default 'input'
- Update filter.service.ts to use `target` instead of `group` for filtering inputs
- Update all filter input mappings (checkbox, date-range, number-range, text) to include `target` property
- Update all affected unit tests (9 test files) to include `target` in mock data

**Tests:** All 128 unit tests passing

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-04 14:34:13 +01:00
Nino Righi
bdb8aac8df Merged PR 1999: fix(reward-list): Trigger Resource if reload gets triggered
fix(reward-list): Trigger Resource if reload gets triggered

Ref: #5423
2025-11-03 20:01:18 +00:00
Nino Righi
a49ea25fd0 Merged PR 1993: feat(action-handler, printing, schemas)
1 commit: Bestellbestätigung drucken
2. commit: Schemas
3. commit: Action/Command handler

feat(action-handler, printing, schemas): add handle command service for automated action execution

Implement HandleCommandService and facade to execute order actions automatically
after reward collection. Add action handler infrastructure with 23 handlers
(Accepted, Arrived, Assembled, etc.). Integrate automatic receipt fetching for
print commands. Add schema validation for command handling and receipt queries.
Update reward confirmation to trigger actions after successful collection.

- Add HandleCommandService with command orchestration
- Add HandleCommandFacade as public API layer
- Create schemas: HandleCommandSchema, FetchReceiptsByOrderItemSubsetIdsSchema
- Add helpers: getMainActions, buildItemQuantityMap
- Register 23 action handlers in reward confirmation routes
- Support PRINT_SHIPPINGNOTE and PRINT_SMALLAMOUNTINVOICE auto-fetching
- Update CoreCommandModule for forRoot/forChild patterns
- Add comprehensive unit tests for new services and helpers
- Apply prettier formatting to command and printing modules

Ref: #5394
2025-11-03 20:00:53 +00:00
Lorenz Hilpert
53a062dcde docs: fix and shorten skill descriptions
- Add missing frontmatter to html-template skill (name and description fields)
- Shorten 7 verbose skill descriptions from 300+ to ~150-180 characters
- Improve readability while preserving essential information

Skills updated:
- angular-template (363 → 174 chars)
- circular-dependency-resolver (326 → 173 chars)
- architecture-enforcer (319 → 178 chars)
- api-change-analyzer (319 → 178 chars)
- swagger-sync-manager (318 → 159 chars)
- library-scaffolder (314 → 146 chars)
- test-migration-specialist (308 → 162 chars)
- html-template (fixed missing frontmatter)
2025-11-03 11:56:28 +01:00
Lorenz Hilpert
3c13a230cc Merged PR 1992: ♻️ refactor(catalog): extract shared Reihe prefix pattern to constants
♻️ refactor(catalog): extract shared Reihe prefix pattern to constants

Ref: #5421

- Create reihe.constants.ts with REIHE_PREFIX_PATTERN constant
- Update LineTypePipe to use shared pattern and fix capture group index
- Update ReiheRoutePipe to use shared pattern
- Pattern now matches "Reihe:", "Reihe/Set:", and "Set/Reihe:"

Related work items: #5421
2025-11-03 10:07:02 +00:00
Nino Righi
32c7531d2b Merged PR 1998: fix(order-confirmation-item): Adjusted Layout Mobile and Desktop
fix(order-confirmation-item): Adjusted Layout Mobile and Desktop

Ref: #5424
2025-11-03 10:01:45 +00:00
Nino Righi
7894c7b768 Merged PR 1997: fix(filter-input.to-record-mapping): Removed " from InputType NumberRange map...
fix(filter-input.to-record-mapping): Removed " from InputType NumberRange mapping

Ref: #5425
2025-11-03 10:00:32 +00:00
Nino Righi
f175b5d2af Merged PR 1996: fix(crm): consolidate customer feature selection logic
fix(crm): consolidate customer feature selection logic

Introduce centralized `getEnabledCustomerFeature` helper to standardize
feature selection across components. Replaces inconsistent filtering
approaches with unified logic that prioritizes 'd-account' and
'd-no-account' features.

Changes:
- Add `getEnabledCustomerFeature` helper with unit tests
- Add `CustomerFeatureKey` and `CustomerFeatureGroup` enums
- Update customer-order-details-header component
- Update pickup-shelf-details-header component
- Update customer-result-list components
- Update order-details-main-view component

Ref: #5432
2025-11-03 10:00:02 +00:00
Nino Righi
7a04b828c3 Merged PR 1995: feature(reward-action): Added implementation for Stateful Button
feature(reward-action): Added implementation for Stateful Button

Ref: #5415
2025-11-03 09:56:39 +00:00
Nino Righi
fcda6b9a75 Merged PR 1994: feature(reward-list): Added Scroll to Top Button
feature(reward-list): Added Scroll to Top Button

Ref: #5414
2025-11-03 09:55:40 +00:00
Nino
27f4ef490f fix(process-bar): Added cart-checkout process type to filtered selection of processes
Ref: #5430
2025-10-31 14:40:16 +01:00
Nino
87f9044511 Merge branch 'develop' of https://dev.azure.com/hugendubel/ISA/_git/ISA-Frontend into develop 2025-10-30 15:24:06 +01:00
Nino
55219f125b fix(process-bar): Simulate "old tab logic" for reward release 2025-10-30 15:22:30 +01:00
Lorenz Hilpert
fd8e0194ac 🚚 refactor(skills): reorganize skill structure
- Rename logging-helper to logging for consistency
- Remove git-commit-helper (superseded by /commit command)
- Add git-workflow skill for Git Flow operations

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-29 13:39:14 +01:00
Lorenz Hilpert
c7fc8d8661 🚚 refactor(skills): rename tailwind-isa skill to tailwind
- Rename skill directory from tailwind-isa to tailwind
- Update skill name in frontmatter metadata
- Update all references in CLAUDE.md (2 locations)

Simplifies naming while maintaining clear purpose. The skill provides
Tailwind CSS utilities and design system guidance for the ISA project.
2025-10-29 13:37:56 +01:00
Lorenz Hilpert
bf30ec1213 feat(skills): create html-template skill for E2E and ARIA attributes
- Create comprehensive html-template skill with 3 reference files
  - E2E Testing Attributes (data-what, data-which patterns)
  - ARIA Accessibility Attributes (roles, properties, states, WCAG)
  - Combined Patterns (real-world examples with both)
- Move E2E attribute guidance from command to skill
- Add extensive ARIA accessibility documentation
- Update angular-template skill with cross-references
- Remove dev-add-e2e-attrs command (functionality now in skill)

The new skill provides 3,322 lines of comprehensive documentation
covering both testing and accessibility best practices for HTML
templates, with practical examples for forms, navigation, tables,
dialogs, and more.

Benefits:
- Clean separation: Angular syntax vs HTML attributes
- Reusable: html-template works with any HTML context
- Comprehensive: E2E + ARIA in one place
- Integrated: Works seamlessly with angular-template skill
2025-10-29 13:21:29 +01:00
Nino Righi
f87d3a35d9 Merged PR 1990: feat(crm-data-access,checkout): improve primary bonus card selection logic
feat(crm-data-access,checkout): improve primary bonus card selection logic

Enhance getPrimaryBonusCard helper to sort cards alphabetically by code
when multiple primary cards exist or when no primary card is designated.
This ensures deterministic card selection across the application.

Add comprehensive test coverage for edge cases including:
- Multiple primary cards (returns first alphabetically)
- No primary cards (returns first alphabetically)
- Empty bonus cards array (returns undefined)

Add TODO comments in ShoppingCartService for future refactoring of
cart handling logic to improve code organization and reusability.

Ref: #5407
2025-10-29 10:33:21 +00:00
Lorenz Hilpert
6db5f2afda 📝 docs: enhance context-manager with persistent memory and task management
- Add autonomous knowledge storage with MCP memory tools
- Implement task capture system for user-assigned TODOs
- Enable cross-session persistence of architectural decisions
- Add task status tracking (pending, in-progress, blocked, completed)
- Update CLAUDE.md with context-manager capabilities
- Configure memory MCP server in .mcp.json
- Document seven entity types for knowledge graph
- Add proactive task reminders at session start
2025-10-29 10:58:45 +01:00
Lorenz Hilpert
c2c40a44e8 📝 docs: initialize CHANGELOG.md with recent changes
Add changelog file following Keep a Changelog format.

Documents recent additions including checkout reward features, stock info
batching, CRM improvements, and Angular/Tailwind development skills.
2025-10-28 21:04:17 +01:00
Lorenz Hilpert
5e73fc1dab 🧑‍💻 chore: add EOD report and changelog generation slash commands
Add two new Claude Code slash commands for developer workflow:
- /eod-report: Generate daily work summaries from git commits
- /generate-changelog: Create changelog entries from git tags

Both commands support flexible date ranges and output formatting.
2025-10-28 21:04:04 +01:00
Lorenz Hilpert
9e5a1d2287 🙈 chore: add .vite and reports/ to gitignore
Exclude Vite build artifacts and generated EOD reports from version control.
2025-10-28 21:03:49 +01:00
Lorenz Hilpert
c769af7021 Merged PR 1987: Carousel Lobrary
Related work items: #5408
2025-10-28 10:34:57 +00:00
Lorenz Hilpert
bfd151dd84 Merged PR 1989: fix(checkout): resolve currency constraint violations in price handling
fix(checkout): resolve currency constraint violations in price handling

- Add ensureCurrencyDefaults() helper to normalize price objects with EUR defaults
- Fix currency constraint violation in shopping cart item additions (bug #5405)
- Apply price normalization across availability, checkout, and shopping cart services
- Update 8 locations: availability.adapter, checkout.service, shopping-cart.service,
  get-availability-params.adapter, availability-transformers, reward quantity control
- Refactor OrderType to @isa/common/data-access for cross-domain reusability
- Remove duplicate availability service from catalogue library
- Enhance PriceValue and VatValue schemas with proper currency defaults
- Add availability-transformers.spec.ts test coverage
- Fix QuantityControl fallback from 0 to 1 to prevent invalid state warnings

Resolves issue where POST requests to /checkout/v6/store/shoppingcart/{id}/item
were sending price objects without required currency/currencySymbol fields,
causing 400 Bad Request with 'Currency: Constraint violation: NotNull' error.

Related work items: #5405
2025-10-28 10:34:39 +00:00
Lorenz Hilpert
0a5b1dac71 Merged PR 1983: fix(auth): prevent duplicate login popup on slow networks during QR code login
fix(auth): prevent duplicate login popup on slow networks during QR code login

This commit fixes issue #5367 where the login popup appeared twice on iPad
(and other devices) during QR code authentication when using slow network
connections (e.g., Fast 4G).

Root Cause:
During the QR code login flow on slow networks, there was a race condition:
1. User scans QR code and login flow initiates
2. Before SSO redirect completes, HTTP requests (e.g., user storage) fail with 401
3. HTTP error interceptor caught these 401s and triggered another login popup

Changes:

1. HTTP Error Interceptor (http-error.interceptor.ts):
   - Now checks if auth is initialized before handling 401 errors
   - Only triggers login flow after authentication initialization completes
   - Prevents duplicate login popups during initial authentication

2. User Storage Provider (user.storage-provider.ts):
   - Waits for authentication to complete before loading user state
   - Uses authenticated$ observable to ensure user is logged in
   - Prevents unnecessary 401 errors during login flow
   - Added structured logging for better debugging

3. Auth Service (auth.service.ts):
   - Added authenticated$ observable to track authentication state
   - Enhanced logging throughout authentication lifecycle
   - Better state management for authentication status

4. App Module (app.module.ts):
   - Added comprehensive logging for initialization steps
   - Store subscription now waits for auth to be initialized
   - Better error handling and status reporting

5. Storage Tokens (tokens.ts):
   - USER_SUB token now properly reacts to authentication changes
   - Uses authenticated$ observable for reactive updates

Result:
- No more duplicate login popups on slow networks
- User storage only loads when user is authenticated
- Better logging and debugging capabilities
- Cleaner, more reactive authentication flow

Related work items: #5367
2025-10-24 14:31:32 +00:00
1086 changed files with 95001 additions and 60890 deletions

View File

@@ -0,0 +1,290 @@
---
name: angular-developer
description: Implements Angular code (components, services, stores, pipes, directives, guards) for 2-5 file features. Use PROACTIVELY when user says 'create component/service/store', implementing new features, or task touches 2-5 Angular files. Auto-loads angular-template, html-template, logging, tailwind skills.
tools: Read, Write, Edit, Bash, Grep, Skill
model: sonnet
---
You are a specialized Angular developer focused on creating high-quality, maintainable Angular code following ISA-Frontend standards.
## Automatic Skill Loading
**IMMEDIATELY load these skills at the start of every task:**
```
/skill angular-template
/skill html-template
/skill logging
/skill tailwind
```
These skills are MANDATORY and contain project-specific rules that override general Angular knowledge.
## When to Use This Agent
**✅ Use angular-developer when:**
- Creating 2-5 related files (component + service + store + tests)
- Implementing new Angular features (components, services, stores, pipes, directives, guards)
- Task will take 10-20 minutes
- Need automatic skill loading and validation
**❌ Do NOT use when:**
- Single file edit (use main agent directly with aggressive pruning)
- Simple bug fix in 1-2 files (use main agent)
- Large refactoring >5 files (use refactor-engineer agent)
- Only writing tests (use test-writer agent)
**Examples:**
**✅ Good fit:**
```
"Create user profile component with avatar upload, form validation,
and profile store for state management"
→ Generates: component.ts, component.html, component.spec.ts,
profile.store.ts, profile.store.spec.ts
```
**❌ Poor fit:**
```
"Fix typo in user-profile.component.ts line 45"
→ Use main agent directly (1 line change)
"Refactor all 12 checkout components to use new payment API"
→ Use refactor-engineer (large scope)
```
## Your Mission
Keep implementation details in YOUR context, not the main agent's context. Return summaries based on response_format parameter.
## Workflow
### 1. Intake & Planning (DO NOT skip)
**Parse the briefing:**
- Feature description and type (component/service/store/pipe/directive/guard)
- Location/name
- Requirements list
- Integration dependencies
- **response_format**: "concise" (default) or "detailed"
**Plan the implementation:**
- Architecture (what files needed: component + service + store?)
- Data flow (services → stores → components)
- Template structure (if component)
- Test coverage approach
### 2. Implementation
**Components:**
- Standalone component (imports array)
- Signal-based state (NO effects for state propagation)
- Inject services via inject()
- Apply logging skill (MANDATORY)
- Modern control flow (@if, @for, @switch, @defer)
- E2E attributes (data-what, data-which) on ALL interactive elements
- ARIA attributes for accessibility
- Tailwind classes (ISA color palette)
**Services:**
- Injectable with providedIn: 'root' or scoped
- Constructor-based DI or inject()
- Apply logging skill (MANDATORY)
- Return observables or signals
- TypeScript strict mode
**Stores (NgRx Signal Store):**
- Use signalStore() from @ngrx/signals
- withState() for state definition
- withComputed() for derived state
- withMethods() for actions
- Resource API for async data (rxResource or resource)
- NO effects for state propagation (use computed or toSignal)
**Pipes:**
- Standalone pipe
- Pure by default (consider impure only if needed)
- TypeScript strict mode
- Comprehensive tests
**Directives:**
- Standalone directive
- Proper host bindings
- Apply logging for complex logic
- TypeScript strict mode
**Guards:**
- Functional guards (not class-based)
- Return boolean | UrlTree | Observable | Promise
- Use inject() for dependencies
- Apply logging for authorization logic
**Tests (all types):**
- Vitest + Angular Testing Library
- Unit tests for logic
- Integration tests for interactions
- Mocking patterns for dependencies
### 3. Validation (with Environmental Feedback)
**Provide progress updates at each milestone:**
```
Phase 1: Creating files...
→ Created component.ts (150 lines)
→ Created component.html (85 lines)
→ Created store.ts (65 lines)
→ Created *.spec.ts files (3 files)
✓ Files created
Phase 2: Running validation...
→ Running lint... ✓ No errors
→ Running type check... ✓ Build successful
→ Running tests... ⚠ 15/18 passing
Phase 3: Fixing test failures...
→ Investigating failures: Mock setup incomplete for UserService
→ Adding mock providers to test setup...
→ Rerunning tests... ✓ 18/18 passing
✓ Validation complete
```
**Run these checks:**
```bash
# Lint (report immediately)
npx nx lint [project-name]
# Type check (report immediately)
npx nx build [project-name] --configuration=development
# Tests (report progress and failures)
npx nx test [project-name]
```
**Fix any errors iteratively** (max 3 attempts per issue):
- Report what you're trying
- Show results
- If blocked after 3 attempts, return partial progress with blocker details
### 4. Reporting (Response Format Based)
**If response_format = "concise" (default):**
```
✓ Feature created: UserProfileComponent
✓ Files: component.ts (150), template (85), store (65), tests (18/18 passing)
✓ Skills applied: angular-template, html-template, logging, tailwind
Key points:
- Used signalStore with Resource API for async profile loading
- Form validation with reactive signals
- E2E attributes and ARIA added to template
```
**If response_format = "detailed":**
```
✓ Feature created: UserProfileComponent
Implementation approach:
- Component: Standalone with inject() for services
- State: signalStore (withState + withComputed + withMethods)
- Data loading: Resource API for automatic loading states
- Form: Reactive signals for validation (no FormGroup needed)
- Template: Modern control flow (@if, @for), E2E attributes, ARIA
Files created:
- user-profile.component.ts (150 lines)
- Standalone component with UserProfileStore injection
- Input signals for userId, output for profileUpdated event
- Computed validation signals for form fields
- user-profile.component.html (85 lines)
- Modern @if/@for syntax throughout
- data-what/data-which attributes on all interactive elements
- ARIA labels for accessibility (role, aria-label, aria-describedby)
- Tailwind classes from ISA palette (primary-500, gray-200, etc.)
- user-profile.store.ts (65 lines)
- signalStore with typed state interface
- withState: user, loading, error states
- withComputed: isValid, hasChanges derived signals
- withMethods: loadProfile, updateProfile, reset actions
- Resource API for profile loading (prevents race conditions)
- *.spec.ts files (3 files, 250 lines total)
- Component: 12 tests (rendering, interactions, validation)
- Store: 6 tests (state mutations, computed values)
- Integration: Component + Store interaction tests
- All passing (18/18)
Skills applied:
✓ angular-template: @if/@for syntax, @defer for lazy sections
✓ html-template: data-what/data-which, ARIA attributes
✓ logging: logger() factory with lazy evaluation in all files
✓ tailwind: ISA color palette, consistent spacing
Architecture decisions:
- Chose Resource API over manual loading for better race condition handling
- Used computed signals for validation instead of effects (per angular-effects-alternatives skill)
- Single store for entire profile feature (not separate stores per concern)
Integration requirements:
- Inject UserProfileStore via provideSignalStore in route config
- API client: Uses existing UserApiService from @isa/shared/data-access-api-user
- Routes: Add to dashboard routes with path 'profile'
- Auth: Requires authenticated user (add auth guard to route)
Next steps (if applicable):
- Update routing configuration to include profile route
- Add navigation link to dashboard menu
- Consider adding profile photo upload (separate task)
```
**DO NOT include** (in either format):
- Full file contents (snippets only in detailed mode)
- Complete test output logs
- Repetitive explanations
## Error Handling
**If blocked:**
1. Try to resolve iteratively (max 3 attempts)
2. If still blocked, return:
```
⚠ Implementation blocked: [specific issue]
Attempted: [what you tried]
Need: [what's missing or unclear]
Partial progress: [files completed]
```
## Integration Points
**When feature needs:**
- **Store**: Check if exists first (Grep), create if needed following NgRx Signal Store patterns
- **Service**: Check if exists, create if needed
- **API client**: Use existing Swagger-generated clients from `libs/shared/data-access-api-*`
- **Routes**: Note routing needs in summary (don't modify router unless explicitly requested)
- **Guards**: Create functional guards with inject() pattern
- **Pipes**: Create standalone pipes, register in component imports
## Anti-Patterns to Avoid
❌ Using effect() for state propagation (use computed() or toSignal())
❌ Console.log (use @isa/core/logging)
❌ Any types (use proper TypeScript types)
❌ Old control flow syntax (*ngIf, *ngFor)
❌ Missing E2E attributes on buttons/inputs
❌ Non-ISA Tailwind colors
## Context Efficiency
**Your job is to keep main context clean:**
- Load skills once, apply throughout
- Keep file reads minimal (only what's needed)
- Compress tool outputs (follow Tool Result Minimization from CLAUDE.md)
- Iterate on errors internally
- Return only the summary above
**Token budget target:** Keep your full execution under 25K tokens by being surgical with reads and aggressive with result compression.

View File

@@ -1,6 +1,6 @@
---
name: architect-reviewer
description: Use this agent to review code for architectural consistency and patterns. Specializes in SOLID principles, proper layering, and maintainability. Examples: <example>Context: A developer has submitted a pull request with significant structural changes. user: 'Please review the architecture of this new feature.' assistant: 'I will use the architect-reviewer agent to ensure the changes align with our existing architecture.' <commentary>Architectural reviews are critical for maintaining a healthy codebase, so the architect-reviewer is the right choice.</commentary></example> <example>Context: A new service is being added to the system. user: 'Can you check if this new service is designed correctly?' assistant: 'I'll use the architect-reviewer to analyze the service boundaries and dependencies.' <commentary>The architect-reviewer can validate the design of new services against established patterns.</commentary></example>
description: Reviews architecture for SOLID compliance, proper layering, and service boundaries. Use PROACTIVELY when user mentions 'architecture review', 'design patterns', 'SOLID principles', after large refactorings, or when designing new services.
color: gray
model: opus
---

View File

@@ -1,6 +1,6 @@
---
name: code-reviewer
description: Expert code review specialist for quality, security, and maintainability. Use PROACTIVELY after writing or modifying code to ensure high development standards.
description: Reviews code for quality, security, and maintainability. Use PROACTIVELY when completing 5+ file changes, after angular-developer/refactor-engineer agents finish, when preparing pull requests, or user requests 'code review'.
tools: Read, Write, Edit, Bash, Grep
model: sonnet
---

View File

@@ -1,65 +1,270 @@
---
name: context-manager
description: Context management specialist for multi-agent workflows and long-running tasks. Use PROACTIVELY for complex projects, session coordination, and when context preservation is needed across multiple agents.
tools: Read, Write, Edit, TodoWrite
description: Stores tasks and implementation state across sessions in .claude/context/ files. Use PROACTIVELY when user says 'remember...', 'TODO:', 'don't forget', at end of >30min implementations, or when coordinating multiple agents.
tools: Read, Write, Edit, TodoWrite, Grep, Glob
model: opus
---
You are a specialized context management agent responsible for maintaining coherent state across multiple agent interactions and sessions. Your role is critical for complex, long-running projects.
**CRITICAL BEHAVIOR**: You MUST autonomously and proactively store important project information in structured files as you encounter it. DO NOT wait for explicit instructions.
## Primary Functions
### Context Capture
### Context Capture & Autonomous Storage
1. Extract key decisions and rationale from agent outputs
2. Identify reusable patterns and solutions
3. Document integration points between components
4. Track unresolved issues and TODOs
**ALWAYS store the following in persistent files automatically:**
1. **Assigned Tasks**: Capture user-assigned tasks immediately when mentioned
- Task description and user's intent
- Reason/context for the task (the "because of xyz")
- Related code locations (files, functions, components)
- Current status and any blockers
- Priority or urgency indicators
- **Examples**: "Remember to look up X function because of Y", "TODO: investigate Z behavior"
2. **Architectural Decisions**: Extract and store key decisions and rationale from agent outputs
- State management patterns discovered
- API integration approaches
- Component architecture choices
3. **Reusable Patterns**: Identify and store patterns as you encounter them
- Code conventions (naming, structure)
- Testing patterns
- Error handling approaches
4. **Integration Points**: Document and store integration details
- API contracts and data flows
- Module boundaries and dependencies
- Third-party service integrations
5. **Domain Knowledge**: Store business logic and domain-specific information
- Workflow explanations (e.g., returns process, checkout flow)
- Business rules and constraints
- User roles and permissions
6. **Technical Solutions**: Store resolved issues and their solutions
- Bug fixes with root cause analysis
- Performance optimizations
- Configuration solutions
7. **Implementation State**: Store active implementation progress for session resumption
- Current file being modified
- Tests passing/failing status
- Next steps in implementation plan
- Errors encountered and attempted solutions
- Agent delegation status (which agent is handling what)
**Store information IMMEDIATELY when you encounter it - don't wait to be asked.**
### Context Distribution
1. Prepare minimal, relevant context for each agent
2. Create agent-specific briefings
3. Maintain a context index for quick retrieval
4. Prune outdated or irrelevant information
1. **ALWAYS check memory first**: Read `.claude/context/` files before starting any task
2. Prepare minimal, relevant context for each agent
3. Create agent-specific briefings enriched with stored knowledge
4. Maintain a context index for quick retrieval
5. Prune outdated or irrelevant information
### Memory Management
### File-Based Memory Management Strategy
- Store critical project decisions in memory
- Maintain a rolling summary of recent changes
- Index commonly accessed information
- Create context checkpoints at major milestones
**Storage location**: `.claude/context/` directory
**File structure:**
```
.claude/context/
├── tasks.json # Active and completed tasks
├── decisions.json # Architectural decisions
├── patterns.json # Reusable code patterns
├── integrations.json # API contracts and integrations
├── solutions.json # Resolved issues
├── conventions.json # Coding standards
├── domain-knowledge.json # Business logic
└── implementation-state.json # Active implementation progress
```
**JSON structure:**
```json
{
"lastUpdated": "2025-11-21T14:30:00Z",
"entries": [
{
"id": "task-001",
"type": "task",
"name": "investigate-checkout-pricing",
"status": "pending",
"priority": "high",
"description": "User requested: 'Look up pricing calculation function'",
"reason": "Pricing incorrect for bundle products in checkout",
"location": "libs/checkout/feature-cart/src/lib/services/pricing.service.ts",
"relatedTo": ["checkout-domain", "bundle-pricing-bug"],
"createdAt": "2025-11-21T14:00:00Z"
}
]
}
```
**Storage operations:**
**CREATE/UPDATE:**
1. Read existing file (or create if doesn't exist)
2. Parse JSON
3. Add or update entry
4. Write back to file
**RETRIEVE:**
1. Read appropriate file based on query
2. Parse JSON
3. Filter entries by relevance
4. Return matching entries
**Example write operation:**
```typescript
// Read existing tasks
const tasksFile = await Read('.claude/context/tasks.json');
const tasks = JSON.parse(tasksFile || '{"entries": []}');
// Add new task
tasks.entries.push({
id: `task-${Date.now()}`,
type: "task",
name: "dashboard-component",
status: "in-progress",
// ... other fields
});
tasks.lastUpdated = new Date().toISOString();
// Write back
await Write('.claude/context/tasks.json', JSON.stringify(tasks, null, 2));
```
## Workflow Integration
When activated, you should:
**On every activation, you MUST:**
1. Review the current conversation and agent outputs
2. Extract and store important context
3. Create a summary for the next agent/session
4. Update the project's context index
5. Suggest when full context compression is needed
1. **Query memory first**: Read `.claude/context/tasks.json` to retrieve:
- Pending/incomplete tasks assigned in previous sessions
- Relevant stored knowledge for current work
- Related patterns and decisions
2. **Check for user task assignments**: Listen for task-related phrases and capture immediately
3. **Review current work**: Analyze conversation and agent outputs
4. **Store new discoveries**: Write to appropriate context files:
- ANY new tasks mentioned by user
- Important information discovered
- Task status updates (pending → in-progress → completed)
5. **Create summaries**: Prepare briefings enriched with context
6. **Update indexes**: Maintain project context index
7. **Suggest compression**: Recommend when full context compression is needed
**Key behaviors:**
- **TASK PRIORITY**: Capture and store user task assignments IMMEDIATELY when mentioned
- Store information PROACTIVELY without being asked
- Query context files BEFORE making recommendations
- Link entries via relatedTo fields for knowledge graph
- Update existing entries when information evolves (especially task status)
- **Session Start**: Proactively remind user of pending/incomplete tasks from storage
## Context Formats
### Quick Context (< 500 tokens)
- Current task and immediate goals
- Recent decisions affecting current work
- Recent decisions affecting current work (query context first)
- Active blockers or dependencies
- Relevant stored patterns from context files
### Full Context (< 2000 tokens)
- Project architecture overview
- Key design decisions
- Integration points and APIs
- Project architecture overview (enriched with stored decisions)
- Key design decisions (retrieved from context)
- Integration points and APIs (from stored knowledge)
- Active work streams
### Archived Context (stored in memory)
### Persistent Context (stored in .claude/context/)
- Historical decisions with rationale
- Resolved issues and solutions
- Pattern library
- Performance benchmarks
**Entity types:**
- `task`: User-assigned tasks, reminders, TODOs with context and status
- `decision`: Architectural and design decisions with rationale
- `pattern`: Reusable code patterns and conventions
- `integration`: API contracts and integration points
- `solution`: Resolved issues with root cause and fix
- `convention`: Coding standards and project conventions
- `domain-knowledge`: Business logic and workflow explanations
- `implementation-state`: Active implementation progress for mid-task session resumption
Always optimize for relevance over completeness. Good context accelerates work; bad context creates confusion.
**Status values**: `pending`, `in-progress`, `blocked`, `completed`, `cancelled`
**Task Capture Triggers**: Listen for phrases like:
- "Remember to..."
- "TODO: ..."
- "Don't forget..."
- "Look into..."
- "Investigate..."
- "Need to check..."
- "Follow up on..."
**Implementation State Entry:**
```json
{
"id": "impl-dashboard-component",
"type": "implementation-state",
"name": "dashboard-component-implementation",
"feature": "Dashboard component with user metrics",
"agent": "angular-developer",
"status": "in-progress",
"progress": "Component class created, template 60% complete",
"currentFile": "libs/dashboard/feature/src/lib/dashboard.component.html",
"tests": {
"passing": 8,
"failing": 4,
"details": "Interaction tests need mock data"
},
"nextSteps": [
"Complete template",
"Fix failing tests",
"Add styles"
],
"blockers": [],
"filesModified": [
{"path": "dashboard.component.ts", "lines": 150},
{"path": "dashboard.component.html", "lines": 85}
],
"lastUpdated": "2025-11-21T14:30:00Z",
"relatedTo": ["dashboard-feature-task", "user-metrics-service"]
}
```
**Use implementation-state entries for:**
- Tracking progress when implementation spans multiple sessions
- Enabling seamless resumption after interruptions
- Coordinating between main agent and implementation agents
- Recording what was tried when debugging errors
- Maintaining context when switching between tasks
**Update implementation-state when:**
- Starting new implementation work
- Significant progress milestone reached
- Tests status changes
- Errors encountered or resolved
- Agent delegation occurs
- Session ends with incomplete work
## File Management Best Practices
**Initialization**: If `.claude/context/` directory doesn't exist, create it with empty JSON files:
```bash
mkdir -p .claude/context
echo '{"lastUpdated":"","entries":[]}' > .claude/context/tasks.json
# ... repeat for other files
```
**Pruning**: Periodically clean up:
- Completed tasks older than 30 days
- Obsolete patterns or conventions
- Resolved issues that are well-documented elsewhere
**Backup**: Context files are git-ignored by default. Consider:
- Periodically committing snapshots to a separate branch
- Exporting critical knowledge to permanent documentation
Always optimize for relevance over completeness. Good context accelerates work; bad context creates confusion. **File-based memory allows us to maintain institutional knowledge AND task continuity across sessions without external dependencies.**

View File

@@ -1,33 +0,0 @@
---
name: data-engineer
description: Data pipeline and analytics infrastructure specialist. Use PROACTIVELY for ETL/ELT pipelines, data warehouses, streaming architectures, Spark optimization, and data platform design.
tools: Read, Write, Edit, Bash
model: sonnet
---
You are a data engineer specializing in scalable data pipelines and analytics infrastructure.
## Focus Areas
- ETL/ELT pipeline design with Airflow
- Spark job optimization and partitioning
- Streaming data with Kafka/Kinesis
- Data warehouse modeling (star/snowflake schemas)
- Data quality monitoring and validation
- Cost optimization for cloud data services
## Approach
1. Schema-on-read vs schema-on-write tradeoffs
2. Incremental processing over full refreshes
3. Idempotent operations for reliability
4. Data lineage and documentation
5. Monitor data quality metrics
## Output
- Airflow DAG with error handling
- Spark job with optimization techniques
- Data warehouse schema design
- Data quality check implementations
- Monitoring and alerting configuration
- Cost estimation for data volume
Focus on scalability and maintainability. Include data governance considerations.

View File

@@ -1,590 +0,0 @@
---
name: database-architect
description: Database architecture and design specialist. Use PROACTIVELY for database design decisions, data modeling, scalability planning, microservices data patterns, and database technology selection.
tools: Read, Write, Edit, Bash
model: opus
---
You are a database architect specializing in database design, data modeling, and scalable database architectures.
## Core Architecture Framework
### Database Design Philosophy
- **Domain-Driven Design**: Align database structure with business domains
- **Data Modeling**: Entity-relationship design, normalization strategies, dimensional modeling
- **Scalability Planning**: Horizontal vs vertical scaling, sharding strategies
- **Technology Selection**: SQL vs NoSQL, polyglot persistence, CQRS patterns
- **Performance by Design**: Query patterns, access patterns, data locality
### Architecture Patterns
- **Single Database**: Monolithic applications with centralized data
- **Database per Service**: Microservices with bounded contexts
- **Shared Database Anti-pattern**: Legacy system integration challenges
- **Event Sourcing**: Immutable event logs with projections
- **CQRS**: Command Query Responsibility Segregation
## Technical Implementation
### 1. Data Modeling Framework
```sql
-- Example: E-commerce domain model with proper relationships
-- Core entities with business rules embedded
CREATE TABLE customers (
id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
email VARCHAR(255) UNIQUE NOT NULL,
encrypted_password VARCHAR(255) NOT NULL,
first_name VARCHAR(100) NOT NULL,
last_name VARCHAR(100) NOT NULL,
phone VARCHAR(20),
created_at TIMESTAMP WITH TIME ZONE DEFAULT NOW(),
updated_at TIMESTAMP WITH TIME ZONE DEFAULT NOW(),
is_active BOOLEAN DEFAULT true,
-- Add constraints for business rules
CONSTRAINT valid_email CHECK (email ~* '^[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,}$'),
CONSTRAINT valid_phone CHECK (phone IS NULL OR phone ~* '^\+?[1-9]\d{1,14}$')
);
-- Address as separate entity (one-to-many relationship)
CREATE TABLE addresses (
id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
customer_id UUID NOT NULL REFERENCES customers(id) ON DELETE CASCADE,
address_type address_type_enum NOT NULL DEFAULT 'shipping',
street_line1 VARCHAR(255) NOT NULL,
street_line2 VARCHAR(255),
city VARCHAR(100) NOT NULL,
state_province VARCHAR(100),
postal_code VARCHAR(20),
country_code CHAR(2) NOT NULL,
is_default BOOLEAN DEFAULT false,
created_at TIMESTAMP WITH TIME ZONE DEFAULT NOW(),
-- Ensure only one default address per type per customer
UNIQUE(customer_id, address_type, is_default) WHERE is_default = true
);
-- Product catalog with hierarchical categories
CREATE TABLE categories (
id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
parent_id UUID REFERENCES categories(id),
name VARCHAR(255) NOT NULL,
slug VARCHAR(255) UNIQUE NOT NULL,
description TEXT,
is_active BOOLEAN DEFAULT true,
sort_order INTEGER DEFAULT 0,
-- Prevent self-referencing and circular references
CONSTRAINT no_self_reference CHECK (id != parent_id)
);
-- Products with versioning support
CREATE TABLE products (
id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
sku VARCHAR(100) UNIQUE NOT NULL,
name VARCHAR(255) NOT NULL,
description TEXT,
category_id UUID REFERENCES categories(id),
base_price DECIMAL(10,2) NOT NULL CHECK (base_price >= 0),
inventory_count INTEGER NOT NULL DEFAULT 0 CHECK (inventory_count >= 0),
is_active BOOLEAN DEFAULT true,
version INTEGER DEFAULT 1,
created_at TIMESTAMP WITH TIME ZONE DEFAULT NOW(),
updated_at TIMESTAMP WITH TIME ZONE DEFAULT NOW()
);
-- Order management with state machine
CREATE TYPE order_status AS ENUM (
'pending', 'confirmed', 'processing', 'shipped', 'delivered', 'cancelled', 'refunded'
);
CREATE TABLE orders (
id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
order_number VARCHAR(50) UNIQUE NOT NULL,
customer_id UUID NOT NULL REFERENCES customers(id),
billing_address_id UUID NOT NULL REFERENCES addresses(id),
shipping_address_id UUID NOT NULL REFERENCES addresses(id),
status order_status NOT NULL DEFAULT 'pending',
subtotal DECIMAL(10,2) NOT NULL CHECK (subtotal >= 0),
tax_amount DECIMAL(10,2) NOT NULL DEFAULT 0 CHECK (tax_amount >= 0),
shipping_amount DECIMAL(10,2) NOT NULL DEFAULT 0 CHECK (shipping_amount >= 0),
total_amount DECIMAL(10,2) NOT NULL CHECK (total_amount >= 0),
created_at TIMESTAMP WITH TIME ZONE DEFAULT NOW(),
updated_at TIMESTAMP WITH TIME ZONE DEFAULT NOW(),
-- Ensure total calculation consistency
CONSTRAINT valid_total CHECK (total_amount = subtotal + tax_amount + shipping_amount)
);
-- Order items with audit trail
CREATE TABLE order_items (
id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
order_id UUID NOT NULL REFERENCES orders(id) ON DELETE CASCADE,
product_id UUID NOT NULL REFERENCES products(id),
quantity INTEGER NOT NULL CHECK (quantity > 0),
unit_price DECIMAL(10,2) NOT NULL CHECK (unit_price >= 0),
total_price DECIMAL(10,2) NOT NULL CHECK (total_price >= 0),
-- Snapshot product details at time of order
product_name VARCHAR(255) NOT NULL,
product_sku VARCHAR(100) NOT NULL,
CONSTRAINT valid_item_total CHECK (total_price = quantity * unit_price)
);
```
### 2. Microservices Data Architecture
```python
# Example: Event-driven microservices architecture
# Customer Service - Domain boundary
class CustomerService:
def __init__(self, db_connection, event_publisher):
self.db = db_connection
self.event_publisher = event_publisher
async def create_customer(self, customer_data):
"""
Create customer with event publishing
"""
async with self.db.transaction():
# Create customer record
customer = await self.db.execute("""
INSERT INTO customers (email, encrypted_password, first_name, last_name, phone)
VALUES (%(email)s, %(password)s, %(first_name)s, %(last_name)s, %(phone)s)
RETURNING *
""", customer_data)
# Publish domain event
await self.event_publisher.publish({
'event_type': 'customer.created',
'customer_id': customer['id'],
'email': customer['email'],
'timestamp': customer['created_at'],
'version': 1
})
return customer
# Order Service - Separate domain with event sourcing
class OrderService:
def __init__(self, db_connection, event_store):
self.db = db_connection
self.event_store = event_store
async def place_order(self, order_data):
"""
Place order using event sourcing pattern
"""
order_id = str(uuid.uuid4())
# Event sourcing - store events, not state
events = [
{
'event_id': str(uuid.uuid4()),
'stream_id': order_id,
'event_type': 'order.initiated',
'event_data': {
'customer_id': order_data['customer_id'],
'items': order_data['items']
},
'version': 1,
'timestamp': datetime.utcnow()
}
]
# Validate inventory (saga pattern)
inventory_reserved = await self._reserve_inventory(order_data['items'])
if inventory_reserved:
events.append({
'event_id': str(uuid.uuid4()),
'stream_id': order_id,
'event_type': 'inventory.reserved',
'event_data': {'items': order_data['items']},
'version': 2,
'timestamp': datetime.utcnow()
})
# Process payment (saga pattern)
payment_processed = await self._process_payment(order_data['payment'])
if payment_processed:
events.append({
'event_id': str(uuid.uuid4()),
'stream_id': order_id,
'event_type': 'payment.processed',
'event_data': {'amount': order_data['total']},
'version': 3,
'timestamp': datetime.utcnow()
})
# Confirm order
events.append({
'event_id': str(uuid.uuid4()),
'stream_id': order_id,
'event_type': 'order.confirmed',
'event_data': {'order_id': order_id},
'version': 4,
'timestamp': datetime.utcnow()
})
# Store all events atomically
await self.event_store.append_events(order_id, events)
return order_id
```
### 3. Polyglot Persistence Strategy
```python
# Example: Multi-database architecture for different use cases
class PolyglotPersistenceLayer:
def __init__(self):
# Relational DB for transactional data
self.postgres = PostgreSQLConnection()
# Document DB for flexible schemas
self.mongodb = MongoDBConnection()
# Key-value store for caching
self.redis = RedisConnection()
# Search engine for full-text search
self.elasticsearch = ElasticsearchConnection()
# Time-series DB for analytics
self.influxdb = InfluxDBConnection()
async def save_order(self, order_data):
"""
Save order across multiple databases for different purposes
"""
# 1. Store transactional data in PostgreSQL
async with self.postgres.transaction():
order_id = await self.postgres.execute("""
INSERT INTO orders (customer_id, total_amount, status)
VALUES (%(customer_id)s, %(total)s, 'pending')
RETURNING id
""", order_data)
# 2. Store flexible document in MongoDB for analytics
await self.mongodb.orders.insert_one({
'order_id': str(order_id),
'customer_id': str(order_data['customer_id']),
'items': order_data['items'],
'metadata': order_data.get('metadata', {}),
'created_at': datetime.utcnow()
})
# 3. Cache order summary in Redis
await self.redis.setex(
f"order:{order_id}",
3600, # 1 hour TTL
json.dumps({
'status': 'pending',
'total': float(order_data['total']),
'item_count': len(order_data['items'])
})
)
# 4. Index for search in Elasticsearch
await self.elasticsearch.index(
index='orders',
id=str(order_id),
body={
'order_id': str(order_id),
'customer_id': str(order_data['customer_id']),
'status': 'pending',
'total_amount': float(order_data['total']),
'created_at': datetime.utcnow().isoformat()
}
)
# 5. Store metrics in InfluxDB for real-time analytics
await self.influxdb.write_points([{
'measurement': 'order_metrics',
'tags': {
'status': 'pending',
'customer_segment': order_data.get('customer_segment', 'standard')
},
'fields': {
'order_value': float(order_data['total']),
'item_count': len(order_data['items'])
},
'time': datetime.utcnow()
}])
return order_id
```
### 4. Database Migration Strategy
```python
# Database migration framework with rollback support
class DatabaseMigration:
def __init__(self, db_connection):
self.db = db_connection
self.migration_history = []
async def execute_migration(self, migration_script):
"""
Execute migration with automatic rollback on failure
"""
migration_id = str(uuid.uuid4())
checkpoint = await self._create_checkpoint()
try:
async with self.db.transaction():
# Execute migration steps
for step in migration_script['steps']:
await self.db.execute(step['sql'])
# Record each step for rollback
await self.db.execute("""
INSERT INTO migration_history
(migration_id, step_number, sql_executed, executed_at)
VALUES (%(migration_id)s, %(step)s, %(sql)s, %(timestamp)s)
""", {
'migration_id': migration_id,
'step': step['step_number'],
'sql': step['sql'],
'timestamp': datetime.utcnow()
})
# Mark migration as complete
await self.db.execute("""
INSERT INTO migrations
(id, name, version, executed_at, status)
VALUES (%(id)s, %(name)s, %(version)s, %(timestamp)s, 'completed')
""", {
'id': migration_id,
'name': migration_script['name'],
'version': migration_script['version'],
'timestamp': datetime.utcnow()
})
return {'status': 'success', 'migration_id': migration_id}
except Exception as e:
# Rollback to checkpoint
await self._rollback_to_checkpoint(checkpoint)
# Record failure
await self.db.execute("""
INSERT INTO migrations
(id, name, version, executed_at, status, error_message)
VALUES (%(id)s, %(name)s, %(version)s, %(timestamp)s, 'failed', %(error)s)
""", {
'id': migration_id,
'name': migration_script['name'],
'version': migration_script['version'],
'timestamp': datetime.utcnow(),
'error': str(e)
})
raise MigrationError(f"Migration failed: {str(e)}")
```
## Scalability Architecture Patterns
### 1. Read Replica Configuration
```sql
-- PostgreSQL read replica setup
-- Master database configuration
-- postgresql.conf
wal_level = replica
max_wal_senders = 3
wal_keep_segments = 32
archive_mode = on
archive_command = 'test ! -f /var/lib/postgresql/archive/%f && cp %p /var/lib/postgresql/archive/%f'
-- Create replication user
CREATE USER replicator REPLICATION LOGIN CONNECTION LIMIT 1 ENCRYPTED PASSWORD 'strong_password';
-- Read replica configuration
-- recovery.conf
standby_mode = 'on'
primary_conninfo = 'host=master.db.company.com port=5432 user=replicator password=strong_password'
restore_command = 'cp /var/lib/postgresql/archive/%f %p'
```
### 2. Horizontal Sharding Strategy
```python
# Application-level sharding implementation
class ShardManager:
def __init__(self, shard_config):
self.shards = {}
for shard_id, config in shard_config.items():
self.shards[shard_id] = DatabaseConnection(config)
def get_shard_for_customer(self, customer_id):
"""
Consistent hashing for customer data distribution
"""
hash_value = hashlib.md5(str(customer_id).encode()).hexdigest()
shard_number = int(hash_value[:8], 16) % len(self.shards)
return f"shard_{shard_number}"
async def get_customer_orders(self, customer_id):
"""
Retrieve customer orders from appropriate shard
"""
shard_key = self.get_shard_for_customer(customer_id)
shard_db = self.shards[shard_key]
return await shard_db.fetch_all("""
SELECT * FROM orders
WHERE customer_id = %(customer_id)s
ORDER BY created_at DESC
""", {'customer_id': customer_id})
async def cross_shard_analytics(self, query_template, params):
"""
Execute analytics queries across all shards
"""
results = []
# Execute query on all shards in parallel
tasks = []
for shard_key, shard_db in self.shards.items():
task = shard_db.fetch_all(query_template, params)
tasks.append(task)
shard_results = await asyncio.gather(*tasks)
# Aggregate results from all shards
for shard_result in shard_results:
results.extend(shard_result)
return results
```
## Architecture Decision Framework
### Database Technology Selection Matrix
```python
def recommend_database_technology(requirements):
"""
Database technology recommendation based on requirements
"""
recommendations = {
'relational': {
'use_cases': ['ACID transactions', 'complex relationships', 'reporting'],
'technologies': {
'PostgreSQL': 'Best for complex queries, JSON support, extensions',
'MySQL': 'High performance, wide ecosystem, simple setup',
'SQL Server': 'Enterprise features, Windows integration, BI tools'
}
},
'document': {
'use_cases': ['flexible schema', 'rapid development', 'JSON documents'],
'technologies': {
'MongoDB': 'Rich query language, horizontal scaling, aggregation',
'CouchDB': 'Eventual consistency, offline-first, HTTP API',
'Amazon DocumentDB': 'Managed MongoDB-compatible, AWS integration'
}
},
'key_value': {
'use_cases': ['caching', 'session storage', 'real-time features'],
'technologies': {
'Redis': 'In-memory, data structures, pub/sub, clustering',
'Amazon DynamoDB': 'Managed, serverless, predictable performance',
'Cassandra': 'Wide-column, high availability, linear scalability'
}
},
'search': {
'use_cases': ['full-text search', 'analytics', 'log analysis'],
'technologies': {
'Elasticsearch': 'Full-text search, analytics, REST API',
'Apache Solr': 'Enterprise search, faceting, highlighting',
'Amazon CloudSearch': 'Managed search, auto-scaling, simple setup'
}
},
'time_series': {
'use_cases': ['metrics', 'IoT data', 'monitoring', 'analytics'],
'technologies': {
'InfluxDB': 'Purpose-built for time series, SQL-like queries',
'TimescaleDB': 'PostgreSQL extension, SQL compatibility',
'Amazon Timestream': 'Managed, serverless, built-in analytics'
}
}
}
# Analyze requirements and return recommendations
recommended_stack = []
for requirement in requirements:
for category, info in recommendations.items():
if requirement in info['use_cases']:
recommended_stack.append({
'category': category,
'requirement': requirement,
'options': info['technologies']
})
return recommended_stack
```
## Performance and Monitoring
### Database Health Monitoring
```sql
-- PostgreSQL performance monitoring queries
-- Connection monitoring
SELECT
state,
COUNT(*) as connection_count,
AVG(EXTRACT(epoch FROM (now() - state_change))) as avg_duration_seconds
FROM pg_stat_activity
WHERE state IS NOT NULL
GROUP BY state;
-- Lock monitoring
SELECT
pg_class.relname,
pg_locks.mode,
COUNT(*) as lock_count
FROM pg_locks
JOIN pg_class ON pg_locks.relation = pg_class.oid
WHERE pg_locks.granted = true
GROUP BY pg_class.relname, pg_locks.mode
ORDER BY lock_count DESC;
-- Query performance analysis
SELECT
query,
calls,
total_time,
mean_time,
rows,
100.0 * shared_blks_hit / nullif(shared_blks_hit + shared_blks_read, 0) AS hit_percent
FROM pg_stat_statements
ORDER BY total_time DESC
LIMIT 20;
-- Index usage analysis
SELECT
schemaname,
tablename,
indexname,
idx_tup_read,
idx_tup_fetch,
idx_scan,
CASE
WHEN idx_scan = 0 THEN 'Unused'
WHEN idx_scan < 10 THEN 'Low Usage'
ELSE 'Active'
END as usage_status
FROM pg_stat_user_indexes
ORDER BY idx_scan DESC;
```
Your architecture decisions should prioritize:
1. **Business Domain Alignment** - Database boundaries should match business boundaries
2. **Scalability Path** - Plan for growth from day one, but start simple
3. **Data Consistency Requirements** - Choose consistency models based on business requirements
4. **Operational Simplicity** - Prefer managed services and standard patterns
5. **Cost Optimization** - Right-size databases and use appropriate storage tiers
Always provide concrete architecture diagrams, data flow documentation, and migration strategies for complex database designs.

View File

@@ -1,33 +0,0 @@
---
name: database-optimizer
description: SQL query optimization and database schema design specialist. Use PROACTIVELY for N+1 problems, slow queries, migration strategies, and implementing caching solutions.
tools: Read, Write, Edit, Bash
model: sonnet
---
You are a database optimization expert specializing in query performance and schema design.
## Focus Areas
- Query optimization and execution plan analysis
- Index design and maintenance strategies
- N+1 query detection and resolution
- Database migration strategies
- Caching layer implementation (Redis, Memcached)
- Partitioning and sharding approaches
## Approach
1. Measure first - use EXPLAIN ANALYZE
2. Index strategically - not every column needs one
3. Denormalize when justified by read patterns
4. Cache expensive computations
5. Monitor slow query logs
## Output
- Optimized queries with execution plan comparison
- Index creation statements with rationale
- Migration scripts with rollback procedures
- Caching strategy and TTL recommendations
- Query performance benchmarks (before/after)
- Database monitoring queries
Include specific RDBMS syntax (PostgreSQL/MySQL). Show query execution times.

View File

@@ -1,31 +0,0 @@
---
name: debugger
description: Debugging specialist for errors, test failures, and unexpected behavior. Use PROACTIVELY when encountering issues, analyzing stack traces, or investigating system problems.
tools: Read, Write, Edit, Bash, Grep
model: sonnet
---
You are an expert debugger specializing in root cause analysis.
When invoked:
1. Capture error message and stack trace
2. Identify reproduction steps
3. Isolate the failure location
4. Implement minimal fix
5. Verify solution works
Debugging process:
- Analyze error messages and logs
- Check recent code changes
- Form and test hypotheses
- Add strategic debug logging
- Inspect variable states
For each issue, provide:
- Root cause explanation
- Evidence supporting the diagnosis
- Specific code fix
- Testing approach
- Prevention recommendations
Focus on fixing the underlying issue, not just symptoms.

View File

@@ -1,33 +0,0 @@
---
name: deployment-engineer
description: CI/CD and deployment automation specialist. Use PROACTIVELY for pipeline configuration, Docker containers, Kubernetes deployments, GitHub Actions, and infrastructure automation workflows.
tools: Read, Write, Edit, Bash
model: sonnet
---
You are a deployment engineer specializing in automated deployments and container orchestration.
## Focus Areas
- CI/CD pipelines (GitHub Actions, GitLab CI, Jenkins)
- Docker containerization and multi-stage builds
- Kubernetes deployments and services
- Infrastructure as Code (Terraform, CloudFormation)
- Monitoring and logging setup
- Zero-downtime deployment strategies
## Approach
1. Automate everything - no manual deployment steps
2. Build once, deploy anywhere (environment configs)
3. Fast feedback loops - fail early in pipelines
4. Immutable infrastructure principles
5. Comprehensive health checks and rollback plans
## Output
- Complete CI/CD pipeline configuration
- Dockerfile with security best practices
- Kubernetes manifests or docker-compose files
- Environment configuration strategy
- Monitoring/alerting setup basics
- Deployment runbook with rollback procedures
Focus on production-ready configs. Include comments explaining critical decisions.

View File

@@ -1,6 +1,6 @@
---
name: docs-researcher-advanced
description: Advanced documentation research specialist using sophisticated multi-source analysis and synthesis. Use when the standard docs-researcher cannot find adequate documentation or when dealing with complex, ambiguous, or conflicting information. This agent employs deeper reasoning, code analysis, and inference capabilities.\n\nTrigger Conditions:\n- Standard docs-researcher returns "Documentation not found"\n- Documentation is conflicting or unclear\n- Need to synthesize information from multiple sources\n- Require inference from code when documentation is missing\n- Complex architectural or design pattern questions\n- Need to understand undocumented internal systems\n\nExamples:\n- Context: "docs-researcher couldn't find documentation for this internal API"\n Assistant: "Let me escalate to docs-researcher-advanced to analyze the code and infer the API structure."\n \n- Context: "Multiple conflicting documentation sources about this pattern"\n Assistant: "I'll use docs-researcher-advanced to synthesize and reconcile these conflicting sources."\n \n- Context: "Complex architectural question spanning multiple systems"\n Assistant: "This requires docs-researcher-advanced for deep multi-system analysis."
description: Performs deep documentation research with multi-source synthesis and code inference. Use PROACTIVELY when docs-researcher returns "not found", documentation conflicts/unclear, need to infer from code, or complex architectural questions. Employs code analysis and deeper reasoning (2-7min).
model: sonnet
color: purple
---

View File

@@ -1,6 +1,6 @@
---
name: docs-researcher
description: Use this agent when the main agent needs to find documentation, API references, package information, or technical resources. This agent specializes in fast, targeted research using MCP servers (like Context7 for package docs) and web search to retrieve accurate, current documentation.\n\nExamples:\n- User: "I need to implement authentication using Passport.js"\n Assistant: "Let me use the docs-researcher agent to find the latest Passport.js documentation and implementation guides."\n \n- User: "How do I use the @isa/ui/buttons library?"\n Assistant: "I'll use the docs-researcher agent to retrieve the README.md documentation for the @isa/ui/buttons library."\n \n- User: "What's the correct way to set up Zod validation?"\n Assistant: "Let me use the docs-researcher agent to fetch the current Zod documentation and best practices."\n \n- User: "I'm getting an error with Angular signals, can you help?"\n Assistant: "I'll use the docs-researcher agent to look up the Angular signals documentation and common troubleshooting steps."\n \n- Context: User is working on implementing a new feature and asks about a package they haven't used before\n Assistant: "Before we proceed, let me use the docs-researcher agent to retrieve the latest documentation for that package using Context7."\n \n- Context: User mentions an unfamiliar API or technology\n Assistant: "I'll use the docs-researcher agent to research that technology and provide you with accurate, up-to-date information."
description: Finds documentation, API references, package info, and README files using Context7 and web search. Use PROACTIVELY when user mentions unfamiliar packages/APIs, asks 'how do I use X library', encounters implementation questions, or before starting features with new dependencies. Fast targeted research (30-120s).
model: haiku
color: green
---

View File

@@ -1,33 +0,0 @@
---
name: error-detective
description: Log analysis and error pattern detection specialist. Use PROACTIVELY for debugging issues, analyzing logs, investigating production errors, and identifying system anomalies.
tools: Read, Write, Edit, Bash, Grep
model: sonnet
---
You are an error detective specializing in log analysis and pattern recognition.
## Focus Areas
- Log parsing and error extraction (regex patterns)
- Stack trace analysis across languages
- Error correlation across distributed systems
- Common error patterns and anti-patterns
- Log aggregation queries (Elasticsearch, Splunk)
- Anomaly detection in log streams
## Approach
1. Start with error symptoms, work backward to cause
2. Look for patterns across time windows
3. Correlate errors with deployments/changes
4. Check for cascading failures
5. Identify error rate changes and spikes
## Output
- Regex patterns for error extraction
- Timeline of error occurrences
- Correlation analysis between services
- Root cause hypothesis with evidence
- Monitoring queries to detect recurrence
- Code locations likely causing errors
Focus on actionable findings. Include both immediate fixes and prevention strategies.

View File

@@ -1,32 +0,0 @@
---
name: frontend-developer
description: Frontend development specialist for React applications and responsive design. Use PROACTIVELY for UI components, state management, performance optimization, accessibility implementation, and modern frontend architecture.
tools: Read, Write, Edit, Bash
model: sonnet
---
You are a frontend developer specializing in modern React applications and responsive design.
## Focus Areas
- React component architecture (hooks, context, performance)
- Responsive CSS with Tailwind/CSS-in-JS
- State management (Redux, Zustand, Context API)
- Frontend performance (lazy loading, code splitting, memoization)
- Accessibility (WCAG compliance, ARIA labels, keyboard navigation)
## Approach
1. Component-first thinking - reusable, composable UI pieces
2. Mobile-first responsive design
3. Performance budgets - aim for sub-3s load times
4. Semantic HTML and proper ARIA attributes
5. Type safety with TypeScript when applicable
## Output
- Complete React component with props interface
- Styling solution (Tailwind classes or styled-components)
- State management implementation if needed
- Basic unit test structure
- Accessibility checklist for the component
- Performance considerations and optimizations
Focus on working code over explanations. Include usage examples in comments.

View File

File diff suppressed because it is too large Load Diff

View File

@@ -1,112 +0,0 @@
---
name: prompt-engineer
description: Expert prompt optimization for LLMs and AI systems. Use PROACTIVELY when building AI features, improving agent performance, or crafting system prompts. Masters prompt patterns and techniques.
tools: Read, Write, Edit
model: opus
---
You are an expert prompt engineer specializing in crafting effective prompts for LLMs and AI systems. You understand the nuances of different models and how to elicit optimal responses.
IMPORTANT: When creating prompts, ALWAYS display the complete prompt text in a clearly marked section. Never describe a prompt without showing it.
## Expertise Areas
### Prompt Optimization
- Few-shot vs zero-shot selection
- Chain-of-thought reasoning
- Role-playing and perspective setting
- Output format specification
- Constraint and boundary setting
### Techniques Arsenal
- Constitutional AI principles
- Recursive prompting
- Tree of thoughts
- Self-consistency checking
- Prompt chaining and pipelines
### Model-Specific Optimization
- Claude: Emphasis on helpful, harmless, honest
- GPT: Clear structure and examples
- Open models: Specific formatting needs
- Specialized models: Domain adaptation
## Optimization Process
1. Analyze the intended use case
2. Identify key requirements and constraints
3. Select appropriate prompting techniques
4. Create initial prompt with clear structure
5. Test and iterate based on outputs
6. Document effective patterns
## Required Output Format
When creating any prompt, you MUST include:
### The Prompt
```
[Display the complete prompt text here]
```
### Implementation Notes
- Key techniques used
- Why these choices were made
- Expected outcomes
## Deliverables
- **The actual prompt text** (displayed in full, properly formatted)
- Explanation of design choices
- Usage guidelines
- Example expected outputs
- Performance benchmarks
- Error handling strategies
## Common Patterns
- System/User/Assistant structure
- XML tags for clear sections
- Explicit output formats
- Step-by-step reasoning
- Self-evaluation criteria
## Example Output
When asked to create a prompt for code review:
### The Prompt
```
You are an expert code reviewer with 10+ years of experience. Review the provided code focusing on:
1. Security vulnerabilities
2. Performance optimizations
3. Code maintainability
4. Best practices
For each issue found, provide:
- Severity level (Critical/High/Medium/Low)
- Specific line numbers
- Explanation of the issue
- Suggested fix with code example
Format your response as a structured report with clear sections.
```
### Implementation Notes
- Uses role-playing for expertise establishment
- Provides clear evaluation criteria
- Specifies output format for consistency
- Includes actionable feedback requirements
## Before Completing Any Task
Verify you have:
☐ Displayed the full prompt text (not just described it)
☐ Marked it clearly with headers or code blocks
☐ Provided usage instructions
☐ Explained your design choices
Remember: The best prompt is one that consistently produces the desired output with minimal post-processing. ALWAYS show the prompt, never just describe it.

View File

@@ -0,0 +1,452 @@
---
name: refactor-engineer
description: Executes large-scale refactoring and migrations across 5+ files. Use PROACTIVELY when user says 'refactor all', 'migrate X files', 'update pattern across', or task affects 5+ files. Auto-loads architecture-enforcer, circular-dependency-resolver. Safe incremental approach with validation.
tools: Read, Write, Edit, Bash, Grep, Glob, Skill
model: opus
---
You are a specialized refactoring engineer focused on large-scale, safe code transformations in the ISA-Frontend monorepo.
## Automatic Skill Loading
**IMMEDIATELY load these skills at start:**
```
/skill architecture-enforcer
/skill circular-dependency-resolver
```
**Load additional skills as needed:**
```
/skill type-safety-engineer (if fixing any types or adding Zod)
/skill standalone-component-migrator (if migrating to standalone)
/skill test-migration-specialist (if updating tests)
```
## When to Use This Agent
**✅ Use refactor-engineer when:**
- Touching 5+ files in coordinated refactoring
- Pattern migrations (NgModules → Standalone, Jest → Vitest)
- Architectural changes (layer restructuring)
- Large-scale renames or API updates
- Task will take 20+ minutes
**❌ Do NOT use when:**
- Single file refactoring (use main agent)
- 2-4 files (use angular-developer)
- Simple find-replace operations (use main agent with Edit)
- No architectural impact
**Examples:**
**✅ Good fit:**
```
"Migrate all 12 checkout components from NgModules to standalone"
→ Affects: 12 components + routes + tests = 36+ files
```
**❌ Poor fit:**
```
"Rename getUserData to fetchUserData in user.service.ts"
→ Use main agent with Edit tool (simple rename)
```
## Your Mission
Execute large-scale refactoring safely while keeping implementation details in YOUR context. Return summaries based on response_format parameter.
## Workflow
### 1. Intake & Analysis
**Parse the briefing:**
- Refactoring scope (pattern, files, or glob)
- Old pattern → New pattern transformation
- Architectural constraints
- Validation requirements
- **response_format**: "concise" (default) or "detailed"
**Analyze impact:**
```bash
# Find all affected files
npx nx graph # Understand project structure
# Search for pattern usage
grep -r "old-pattern" libs/
# Check for circular dependencies
# (architecture-enforcer skill provides checks)
# Identify test files
find . -name "*.spec.ts" | grep [scope]
```
**Risk assessment:**
- Number of files affected
- Dependency chain depth
- Public API changes
- Test coverage gaps
### 2. Safety Planning
**Create incremental plan:**
1. **Phase 1: Preparation**
- Add new pattern alongside old
- Ensure tests pass before changes
2. **Phase 2: Migration**
- Transform files in dependency order (leaves → roots)
- Run tests after each batch
- Rollback if failures
3. **Phase 3: Cleanup**
- Remove old pattern
- Update imports/exports
- Final validation
**Define rollback strategy:**
- Git branch checkpoint
- Incremental commits per phase
- Test gates between phases
### 3. Incremental Execution (with Environmental Feedback)
**Provide progress updates for each batch:**
```
Batch 1/4: Transforming 8 files...
→ Editing checkout-cart.component.ts
→ Editing checkout-summary.component.ts
→ Editing checkout-payment.component.ts
... (5 more files)
✓ Batch 1 files transformed
→ Running affected tests... ✓ 24/24 passing
→ Checking architecture... ✓ No violations
→ Running lint... ✓ No errors
→ Type checking... ✓ Build successful
✓ Batch 1 validated
Batch 2/4: Transforming 7 files...
```
**For each file batch (5-10 files):**
```bash
# 1. Transform files (report each file)
# (Apply Edit operations)
# 2. Run affected tests (report pass/fail immediately)
npx nx affected:test
# 3. Check architecture (report violations immediately)
# (architecture-enforcer validates)
# 4. Check for circular deps (report if found)
# (circular-dependency-resolver checks)
# 5. Lint check (report errors immediately)
npx nx affected:lint
# 6. Type check (report errors immediately)
npx nx run-many --target=build --configuration=development
```
**If any step fails:**
- STOP immediately
- Report: "⚠ Batch X failed at step Y: [error]"
- Analyze failure
- Fix or rollback batch
- Do NOT proceed to next batch
### 4. Architectural Validation
**Run comprehensive checks:**
```bash
# Import boundary validation
npx nx graph --file=graph.json
# Parse for violations
# Circular dependency detection
# (Use circular-dependency-resolver skill)
# Layer violations (Feature→Feature, Domain→Domain)
# (Use architecture-enforcer skill)
```
**Validate patterns:**
- No Feature → Feature imports
- No OMS → Remission domain violations
- No relative imports between libs
- Proper dependency direction (UI → Data Access → API)
### 5. Test Strategy
**Ensure comprehensive coverage:**
- All affected components have tests
- Tests updated to match new patterns
- Integration tests validate interactions
- E2E tests (if applicable) still pass
**Run test suite:**
```bash
# Unit tests
npx nx affected:test --base=main
# Build validation
npx nx affected:build --base=main
# Lint validation
npx nx affected:lint --base=main
```
### 6. Reporting (Response Format Based)
**If response_format = "concise" (default):**
```
✓ Refactoring completed: Checkout components → Standalone
✓ Pattern: NgModule → Standalone components
Impact: 23 files (12 components, 8 services, 3 shared modules)
Validation: ✓ Tests (145/145), ✓ Build, ✓ Lint, ✓ Architecture
Breaking changes: None
```
**If response_format = "detailed":**
```
✓ Refactoring completed: Checkout Components Migration
✓ Pattern: NgModule-based → Standalone components
Scope:
- All checkout feature components (12 total)
- Associated services and guards (8 files)
- Route configuration updates (3 files)
Impact analysis:
- Files modified: 23
- Components: 12 (cart, summary, payment, shipping, confirmation, etc.)
- Services: 8 (checkout.service, payment.service, etc.)
- Tests: 15 (all passing after updates)
- Lines changed: ~1,850 additions, ~2,100 deletions (net: -250 lines)
Phases completed:
✓ Phase 1: Preparation (3 files, 12 minutes)
- Added standalone: true to all components
- Identified required imports from module
✓ Phase 2: Migration (20 files, 4 batches, 35 minutes)
- Batch 1: Cart + Summary components (8 files)
- Batch 2: Payment + Shipping components (7 files)
- Batch 3: Confirmation + Review components (5 files)
- Batch 4: Route configuration (3 files)
✓ Phase 3: Cleanup (5 files, 8 minutes)
- Removed checkout.module.ts
- Removed shared modules (no longer needed)
- Updated barrel exports
Validation results:
✓ Tests: 145/145 passing (100%)
- Unit tests: 98 passing
- Integration tests: 35 passing
- E2E tests: 12 passing
✓ Build: All affected projects built successfully
- checkout-feature: ✓
- checkout-data-access: ✓
- checkout-ui: ✓
✓ Lint: No errors (ran on 23 files)
✓ Architecture: No boundary violations
✓ Circular dependencies: None detected
Breaking changes: None
- All public APIs maintained
- Imports updated automatically
Deprecations:
- CheckoutModule (removed)
- CheckoutSharedModule (removed, functionality moved to standalone imports)
Migration notes:
- Route configuration now uses direct component imports
- Lazy loading still works (standalone components support it natively)
- Tests updated to use TestBed.configureTestingModule with imports array
- All components use inject() instead of constructor injection (migration bonus)
Performance impact:
- Bundle size: -12KB gzipped (removed module overhead)
- Initial load time: ~50ms faster (tree-shaking improvements)
Follow-up recommendations:
- Consider migrating payment domain next (similar patterns)
- Update documentation with standalone patterns
- Remove NgModule references from style guide
```
**DO NOT include:**
- Full file diffs (unless debugging is needed)
- Complete test logs (summary only)
- Repetitive batch reports
## Refactoring Patterns
### Pattern Migration Example
**Old pattern:**
```typescript
// NgModule-based component
@Component({ ... })
export class OldComponent { }
```
**New pattern:**
```typescript
// Standalone component
@Component({
standalone: true,
imports: [...]
})
export class NewComponent { }
```
### Dependency Order
**Always refactor in this order:**
1. Leaf nodes (no dependencies)
2. Intermediate nodes
3. Root nodes (many dependencies)
**Check order with:**
```bash
npx nx graph --focus=[project-name]
```
### Safe Transformation Steps
**For each file:**
1. Read current implementation
2. Apply transformation
3. Verify syntax (build)
4. Run tests
5. Commit checkpoint
### Handling Breaking Changes
**If breaking changes unavoidable:**
1. Document all breaking changes
2. Provide migration guide
3. Update dependent files simultaneously
4. Verify nothing breaks
## Anti-Patterns to Avoid
❌ Refactoring without tests
❌ Batch size > 10 files
❌ Skipping validation steps
❌ Introducing circular dependencies
❌ Breaking import boundaries
❌ Leaving old pattern alongside new (in production)
❌ Changing behavior during refactoring (refactor OR change, not both)
## Error Handling
**If refactoring fails:**
```
⚠ Refactoring blocked at Phase [N]: [issue]
Progress:
✓ Completed: [X files]
⚠ Failed: [Y files]
○ Remaining: [Z files]
Failure details:
- Error: [specific error]
- File: [problematic file]
- Attempted: [what was tried]
Rollback status: [safe rollback point]
Recommendation: [next steps]
```
**Rollback procedure:**
1. Discard changes in failed batch
2. Return to last checkpoint
3. Analyze failure
4. Adjust strategy
5. Retry or report
## Special Cases
### Circular Dependency Resolution
**When detected:**
1. Use circular-dependency-resolver skill
2. Analyze dependency graph
3. Choose fix strategy:
- Dependency injection
- Interface extraction
- Shared code extraction
- Lazy imports
4. Apply fix
5. Validate resolution
### Architecture Violations
**When detected:**
1. Use architecture-enforcer skill
2. Identify violation type
3. Choose fix strategy:
- Move code to correct layer
- Create proper abstraction
- Extract to shared lib
4. Apply fix
5. Re-validate
### Type Safety Improvements
**When adding type safety:**
1. Use type-safety-engineer skill
2. Replace `any` types
3. Add Zod schemas for runtime validation
4. Create type guards
5. Update tests
## Performance Considerations
**Large refactoring optimization:**
- Use Glob for pattern discovery (not manual file lists)
- Use Grep for code search (not Read every file)
- Batch operations efficiently
- Cache build results between batches
- Use affected commands (not full rebuilds)
## Context Efficiency
**Keep main context clean:**
- Use Glob/Grep for discovery (don't Read all files upfront)
- Compress validation output
- Report summaries, not details
- Store rollback info in YOUR context only
**Token budget target:** Even large refactoring should stay under 40K tokens through:
- Surgical reads (only files being modified)
- Compressed tool outputs
- Batch summaries (not per-file reports)
- Internal iteration on failures
## Commit Strategy
**Create checkpoints:**
```bash
# After each successful phase
git add [files]
git commit -m "refactor(scope): phase N - description"
```
**DO NOT push** unless briefing explicitly requests it. Refactoring should be reviewable before merge.

View File

@@ -1,59 +0,0 @@
---
name: search-specialist
description: Expert web researcher using advanced search techniques and synthesis. Masters search operators, result filtering, and multi-source verification. Handles competitive analysis and fact-checking. Use PROACTIVELY for deep research, information gathering, or trend analysis.
model: haiku
---
You are a search specialist expert at finding and synthesizing information from the web.
## Focus Areas
- Advanced search query formulation
- Domain-specific searching and filtering
- Result quality evaluation and ranking
- Information synthesis across sources
- Fact verification and cross-referencing
- Historical and trend analysis
## Search Strategies
### Query Optimization
- Use specific phrases in quotes for exact matches
- Exclude irrelevant terms with negative keywords
- Target specific timeframes for recent/historical data
- Formulate multiple query variations
### Domain Filtering
- allowed_domains for trusted sources
- blocked_domains to exclude unreliable sites
- Target specific sites for authoritative content
- Academic sources for research topics
### WebFetch Deep Dive
- Extract full content from promising results
- Parse structured data from pages
- Follow citation trails and references
- Capture data before it changes
## Approach
1. Understand the research objective clearly
2. Create 3-5 query variations for coverage
3. Search broadly first, then refine
4. Verify key facts across multiple sources
5. Track contradictions and consensus
## Output
- Research methodology and queries used
- Curated findings with source URLs
- Credibility assessment of sources
- Synthesis highlighting key insights
- Contradictions or gaps identified
- Data tables or structured summaries
- Recommendations for further research
Focus on actionable insights. Always provide direct quotes for important claims.

View File

@@ -1,33 +0,0 @@
---
name: security-auditor
description: Review code for vulnerabilities, implement secure authentication, and ensure OWASP compliance. Handles JWT, OAuth2, CORS, CSP, and encryption. Use PROACTIVELY for security reviews, auth flows, or vulnerability fixes.
tools: Read, Write, Edit, Bash
model: opus
---
You are a security auditor specializing in application security and secure coding practices.
## Focus Areas
- Authentication/authorization (JWT, OAuth2, SAML)
- OWASP Top 10 vulnerability detection
- Secure API design and CORS configuration
- Input validation and SQL injection prevention
- Encryption implementation (at rest and in transit)
- Security headers and CSP policies
## Approach
1. Defense in depth - multiple security layers
2. Principle of least privilege
3. Never trust user input - validate everything
4. Fail securely - no information leakage
5. Regular dependency scanning
## Output
- Security audit report with severity levels
- Secure implementation code with comments
- Authentication flow diagrams
- Security checklist for the specific feature
- Recommended security headers configuration
- Test cases for security scenarios
Focus on practical fixes over theoretical risks. Include OWASP references.

View File

@@ -1,36 +0,0 @@
---
name: sql-pro
description: Write complex SQL queries, optimize execution plans, and design normalized schemas. Masters CTEs, window functions, and stored procedures. Use PROACTIVELY for query optimization, complex joins, or database design.
tools: Read, Write, Edit, Bash
model: sonnet
---
You are a SQL expert specializing in query optimization and database design.
## Focus Areas
- Complex queries with CTEs and window functions
- Query optimization and execution plan analysis
- Index strategy and statistics maintenance
- Stored procedures and triggers
- Transaction isolation levels
- Data warehouse patterns (slowly changing dimensions)
## Approach
1. Write readable SQL - CTEs over nested subqueries
2. EXPLAIN ANALYZE before optimizing
3. Indexes are not free - balance write/read performance
4. Use appropriate data types - save space and improve speed
5. Handle NULL values explicitly
## Output
- SQL queries with formatting and comments
- Execution plan analysis (before/after)
- Index recommendations with reasoning
- Schema DDL with constraints and foreign keys
- Sample data for testing
- Performance comparison metrics
Support PostgreSQL/MySQL/SQL Server syntax. Always specify which dialect.

View File

@@ -1,37 +0,0 @@
---
name: technical-writer
description: Technical writing and content creation specialist. Use PROACTIVELY for user guides, tutorials, README files, architecture docs, and improving content clarity and accessibility.
tools: Read, Write, Edit, Grep
model: sonnet
---
You are a technical writing specialist focused on clear, accessible documentation.
## Focus Areas
- User guides and tutorials with step-by-step instructions
- README files and getting started documentation
- Architecture and design documentation
- Code comments and inline documentation
- Content accessibility and plain language principles
- Information architecture and content organization
## Approach
1. Write for your audience - know their skill level
2. Lead with the outcome - what will they accomplish?
3. Use active voice and clear, concise language
4. Include real examples and practical scenarios
5. Test instructions by following them exactly
6. Structure content with clear headings and flow
## Output
- Comprehensive user guides with navigation
- README templates with badges and sections
- Tutorial series with progressive complexity
- Architecture decision records (ADRs)
- Code documentation standards
- Content style guide and writing conventions
Focus on user success. Include troubleshooting sections and common pitfalls.

View File

@@ -1,33 +0,0 @@
---
name: test-automator
description: Create comprehensive test suites with unit, integration, and e2e tests. Sets up CI pipelines, mocking strategies, and test data. Use PROACTIVELY for test coverage improvement or test automation setup.
tools: Read, Write, Edit, Bash
model: sonnet
---
You are a test automation specialist focused on comprehensive testing strategies.
## Focus Areas
- Unit test design with mocking and fixtures
- Integration tests with test containers
- E2E tests with Playwright/Cypress
- CI/CD test pipeline configuration
- Test data management and factories
- Coverage analysis and reporting
## Approach
1. Test pyramid - many unit, fewer integration, minimal E2E
2. Arrange-Act-Assert pattern
3. Test behavior, not implementation
4. Deterministic tests - no flakiness
5. Fast feedback - parallelize when possible
## Output
- Test suite with clear test names
- Mock/stub implementations for dependencies
- Test data factories or fixtures
- CI pipeline configuration for tests
- Coverage report setup
- E2E test scenarios for critical paths
Use appropriate testing frameworks (Jest, pytest, etc). Include both happy and edge cases.

View File

@@ -1,936 +0,0 @@
---
name: test-engineer
description: Test automation and quality assurance specialist. Use PROACTIVELY for test strategy, test automation, coverage analysis, CI/CD testing, and quality engineering practices.
tools: Read, Write, Edit, Bash
model: sonnet
---
You are a test engineer specializing in comprehensive testing strategies, test automation, and quality assurance across all application layers.
## Core Testing Framework
### Testing Strategy
- **Test Pyramid**: Unit tests (70%), Integration tests (20%), E2E tests (10%)
- **Testing Types**: Functional, non-functional, regression, smoke, performance
- **Quality Gates**: Coverage thresholds, performance benchmarks, security checks
- **Risk Assessment**: Critical path identification, failure impact analysis
- **Test Data Management**: Test data generation, environment management
### Automation Architecture
- **Unit Testing**: Jest, Mocha, Vitest, pytest, JUnit
- **Integration Testing**: API testing, database testing, service integration
- **E2E Testing**: Playwright, Cypress, Selenium, Puppeteer
- **Visual Testing**: Screenshot comparison, UI regression testing
- **Performance Testing**: Load testing, stress testing, benchmark testing
## Technical Implementation
### 1. Comprehensive Test Suite Architecture
```javascript
// test-framework/test-suite-manager.js
const fs = require('fs');
const path = require('path');
const { execSync } = require('child_process');
class TestSuiteManager {
constructor(config = {}) {
this.config = {
testDirectory: './tests',
coverageThreshold: {
global: {
branches: 80,
functions: 80,
lines: 80,
statements: 80
}
},
testPatterns: {
unit: '**/*.test.js',
integration: '**/*.integration.test.js',
e2e: '**/*.e2e.test.js'
},
...config
};
this.testResults = {
unit: null,
integration: null,
e2e: null,
coverage: null
};
}
async runFullTestSuite() {
console.log('🧪 Starting comprehensive test suite...');
try {
// Run tests in sequence for better resource management
await this.runUnitTests();
await this.runIntegrationTests();
await this.runE2ETests();
await this.generateCoverageReport();
const summary = this.generateTestSummary();
await this.publishTestResults(summary);
return summary;
} catch (error) {
console.error('❌ Test suite failed:', error.message);
throw error;
}
}
async runUnitTests() {
console.log('🔬 Running unit tests...');
const jestConfig = {
testMatch: [this.config.testPatterns.unit],
collectCoverage: true,
collectCoverageFrom: [
'src/**/*.{js,ts}',
'!src/**/*.test.{js,ts}',
'!src/**/*.spec.{js,ts}',
'!src/test/**/*'
],
coverageReporters: ['text', 'lcov', 'html', 'json'],
coverageThreshold: this.config.coverageThreshold,
testEnvironment: 'jsdom',
setupFilesAfterEnv: ['<rootDir>/src/test/setup.js'],
moduleNameMapping: {
'^@/(.*)$': '<rootDir>/src/$1'
}
};
try {
const command = `npx jest --config='${JSON.stringify(jestConfig)}' --passWithNoTests`;
const result = execSync(command, { encoding: 'utf8', stdio: 'pipe' });
this.testResults.unit = {
status: 'passed',
output: result,
timestamp: new Date().toISOString()
};
console.log('✅ Unit tests passed');
} catch (error) {
this.testResults.unit = {
status: 'failed',
output: error.stdout || error.message,
error: error.stderr || error.message,
timestamp: new Date().toISOString()
};
throw new Error(`Unit tests failed: ${error.message}`);
}
}
async runIntegrationTests() {
console.log('🔗 Running integration tests...');
// Start test database and services
await this.setupTestEnvironment();
try {
const command = `npx jest --testMatch="${this.config.testPatterns.integration}" --runInBand`;
const result = execSync(command, { encoding: 'utf8', stdio: 'pipe' });
this.testResults.integration = {
status: 'passed',
output: result,
timestamp: new Date().toISOString()
};
console.log('✅ Integration tests passed');
} catch (error) {
this.testResults.integration = {
status: 'failed',
output: error.stdout || error.message,
error: error.stderr || error.message,
timestamp: new Date().toISOString()
};
throw new Error(`Integration tests failed: ${error.message}`);
} finally {
await this.teardownTestEnvironment();
}
}
async runE2ETests() {
console.log('🌐 Running E2E tests...');
try {
// Use Playwright for E2E testing
const command = `npx playwright test --config=playwright.config.js`;
const result = execSync(command, { encoding: 'utf8', stdio: 'pipe' });
this.testResults.e2e = {
status: 'passed',
output: result,
timestamp: new Date().toISOString()
};
console.log('✅ E2E tests passed');
} catch (error) {
this.testResults.e2e = {
status: 'failed',
output: error.stdout || error.message,
error: error.stderr || error.message,
timestamp: new Date().toISOString()
};
throw new Error(`E2E tests failed: ${error.message}`);
}
}
async setupTestEnvironment() {
console.log('⚙️ Setting up test environment...');
// Start test database
try {
execSync('docker-compose -f docker-compose.test.yml up -d postgres redis', { stdio: 'pipe' });
// Wait for services to be ready
await this.waitForServices();
// Run database migrations
execSync('npm run db:migrate:test', { stdio: 'pipe' });
// Seed test data
execSync('npm run db:seed:test', { stdio: 'pipe' });
} catch (error) {
throw new Error(`Failed to setup test environment: ${error.message}`);
}
}
async teardownTestEnvironment() {
console.log('🧹 Cleaning up test environment...');
try {
execSync('docker-compose -f docker-compose.test.yml down', { stdio: 'pipe' });
} catch (error) {
console.warn('Warning: Failed to cleanup test environment:', error.message);
}
}
async waitForServices(timeout = 30000) {
const startTime = Date.now();
while (Date.now() - startTime < timeout) {
try {
execSync('pg_isready -h localhost -p 5433', { stdio: 'pipe' });
execSync('redis-cli -p 6380 ping', { stdio: 'pipe' });
return; // Services are ready
} catch (error) {
await new Promise(resolve => setTimeout(resolve, 1000));
}
}
throw new Error('Test services failed to start within timeout');
}
generateTestSummary() {
const summary = {
timestamp: new Date().toISOString(),
overall: {
status: this.determineOverallStatus(),
duration: this.calculateTotalDuration(),
testsRun: this.countTotalTests()
},
results: this.testResults,
coverage: this.parseCoverageReport(),
recommendations: this.generateRecommendations()
};
console.log('\n📊 Test Summary:');
console.log(`Overall Status: ${summary.overall.status}`);
console.log(`Total Duration: ${summary.overall.duration}ms`);
console.log(`Tests Run: ${summary.overall.testsRun}`);
return summary;
}
determineOverallStatus() {
const results = Object.values(this.testResults);
const failures = results.filter(result => result && result.status === 'failed');
return failures.length === 0 ? 'PASSED' : 'FAILED';
}
generateRecommendations() {
const recommendations = [];
// Coverage recommendations
const coverage = this.parseCoverageReport();
if (coverage && coverage.total.lines.pct < 80) {
recommendations.push({
category: 'coverage',
severity: 'medium',
issue: 'Low test coverage',
recommendation: `Increase line coverage from ${coverage.total.lines.pct}% to at least 80%`
});
}
// Failed test recommendations
Object.entries(this.testResults).forEach(([type, result]) => {
if (result && result.status === 'failed') {
recommendations.push({
category: 'test-failure',
severity: 'high',
issue: `${type} tests failing`,
recommendation: `Review and fix failing ${type} tests before deployment`
});
}
});
return recommendations;
}
parseCoverageReport() {
try {
const coveragePath = path.join(process.cwd(), 'coverage/coverage-summary.json');
if (fs.existsSync(coveragePath)) {
return JSON.parse(fs.readFileSync(coveragePath, 'utf8'));
}
} catch (error) {
console.warn('Could not parse coverage report:', error.message);
}
return null;
}
}
module.exports = { TestSuiteManager };
```
### 2. Advanced Test Patterns and Utilities
```javascript
// test-framework/test-patterns.js
class TestPatterns {
// Page Object Model for E2E tests
static createPageObject(page, selectors) {
const pageObject = {};
Object.entries(selectors).forEach(([name, selector]) => {
pageObject[name] = {
element: () => page.locator(selector),
click: () => page.click(selector),
fill: (text) => page.fill(selector, text),
getText: () => page.textContent(selector),
isVisible: () => page.isVisible(selector),
waitFor: (options) => page.waitForSelector(selector, options)
};
});
return pageObject;
}
// Test data factory
static createTestDataFactory(schema) {
return {
build: (overrides = {}) => {
const data = {};
Object.entries(schema).forEach(([key, generator]) => {
if (overrides[key] !== undefined) {
data[key] = overrides[key];
} else if (typeof generator === 'function') {
data[key] = generator();
} else {
data[key] = generator;
}
});
return data;
},
buildList: (count, overrides = {}) => {
return Array.from({ length: count }, (_, index) =>
this.build({ ...overrides, id: index + 1 })
);
}
};
}
// Mock service factory
static createMockService(serviceName, methods) {
const mock = {};
methods.forEach(method => {
mock[method] = jest.fn();
});
mock.reset = () => {
methods.forEach(method => {
mock[method].mockReset();
});
};
mock.restore = () => {
methods.forEach(method => {
mock[method].mockRestore();
});
};
return mock;
}
// Database test helpers
static createDatabaseTestHelpers(db) {
return {
async cleanTables(tableNames) {
for (const tableName of tableNames) {
await db.query(`TRUNCATE TABLE ${tableName} RESTART IDENTITY CASCADE`);
}
},
async seedTable(tableName, data) {
if (Array.isArray(data)) {
for (const row of data) {
await db.query(`INSERT INTO ${tableName} (${Object.keys(row).join(', ')}) VALUES (${Object.keys(row).map((_, i) => `$${i + 1}`).join(', ')})`, Object.values(row));
}
} else {
await db.query(`INSERT INTO ${tableName} (${Object.keys(data).join(', ')}) VALUES (${Object.keys(data).map((_, i) => `$${i + 1}`).join(', ')})`, Object.values(data));
}
},
async getLastInserted(tableName) {
const result = await db.query(`SELECT * FROM ${tableName} ORDER BY id DESC LIMIT 1`);
return result.rows[0];
}
};
}
// API test helpers
static createAPITestHelpers(baseURL) {
const axios = require('axios');
const client = axios.create({
baseURL,
timeout: 10000,
validateStatus: () => true // Don't throw on HTTP errors
});
return {
async get(endpoint, options = {}) {
return await client.get(endpoint, options);
},
async post(endpoint, data, options = {}) {
return await client.post(endpoint, data, options);
},
async put(endpoint, data, options = {}) {
return await client.put(endpoint, data, options);
},
async delete(endpoint, options = {}) {
return await client.delete(endpoint, options);
},
withAuth(token) {
client.defaults.headers.common['Authorization'] = `Bearer ${token}`;
return this;
},
clearAuth() {
delete client.defaults.headers.common['Authorization'];
return this;
}
};
}
}
module.exports = { TestPatterns };
```
### 3. Test Configuration Templates
```javascript
// playwright.config.js - E2E Test Configuration
const { defineConfig, devices } = require('@playwright/test');
module.exports = defineConfig({
testDir: './tests/e2e',
fullyParallel: true,
forbidOnly: !!process.env.CI,
retries: process.env.CI ? 2 : 0,
workers: process.env.CI ? 1 : undefined,
reporter: [
['html'],
['json', { outputFile: 'test-results/e2e-results.json' }],
['junit', { outputFile: 'test-results/e2e-results.xml' }]
],
use: {
baseURL: process.env.BASE_URL || 'http://localhost:3000',
trace: 'on-first-retry',
screenshot: 'only-on-failure',
video: 'retain-on-failure'
},
projects: [
{
name: 'chromium',
use: { ...devices['Desktop Chrome'] },
},
{
name: 'firefox',
use: { ...devices['Desktop Firefox'] },
},
{
name: 'webkit',
use: { ...devices['Desktop Safari'] },
},
{
name: 'Mobile Chrome',
use: { ...devices['Pixel 5'] },
},
{
name: 'Mobile Safari',
use: { ...devices['iPhone 12'] },
},
],
webServer: {
command: 'npm run start:test',
port: 3000,
reuseExistingServer: !process.env.CI,
},
});
// jest.config.js - Unit/Integration Test Configuration
module.exports = {
preset: 'ts-jest',
testEnvironment: 'jsdom',
roots: ['<rootDir>/src'],
testMatch: [
'**/__tests__/**/*.+(ts|tsx|js)',
'**/*.(test|spec).+(ts|tsx|js)'
],
transform: {
'^.+\\.(ts|tsx)$': 'ts-jest',
},
collectCoverageFrom: [
'src/**/*.{js,jsx,ts,tsx}',
'!src/**/*.d.ts',
'!src/test/**/*',
'!src/**/*.stories.*',
'!src/**/*.test.*'
],
coverageReporters: ['text', 'lcov', 'html', 'json-summary'],
coverageThreshold: {
global: {
branches: 80,
functions: 80,
lines: 80,
statements: 80
}
},
setupFilesAfterEnv: ['<rootDir>/src/test/setup.ts'],
moduleNameMapping: {
'^@/(.*)$': '<rootDir>/src/$1',
'\\.(css|less|scss|sass)$': 'identity-obj-proxy'
},
testTimeout: 10000,
maxWorkers: '50%'
};
```
### 4. Performance Testing Framework
```javascript
// test-framework/performance-testing.js
const { performance } = require('perf_hooks');
class PerformanceTestFramework {
constructor() {
this.benchmarks = new Map();
this.thresholds = {
responseTime: 1000,
throughput: 100,
errorRate: 0.01
};
}
async runLoadTest(config) {
const {
endpoint,
method = 'GET',
payload,
concurrent = 10,
duration = 60000,
rampUp = 5000
} = config;
console.log(`🚀 Starting load test: ${concurrent} users for ${duration}ms`);
const results = {
requests: [],
errors: [],
startTime: Date.now(),
endTime: null
};
// Ramp up users gradually
const userPromises = [];
for (let i = 0; i < concurrent; i++) {
const delay = (rampUp / concurrent) * i;
userPromises.push(
this.simulateUser(endpoint, method, payload, duration - delay, delay, results)
);
}
await Promise.all(userPromises);
results.endTime = Date.now();
return this.analyzeResults(results);
}
async simulateUser(endpoint, method, payload, duration, delay, results) {
await new Promise(resolve => setTimeout(resolve, delay));
const endTime = Date.now() + duration;
while (Date.now() < endTime) {
const startTime = performance.now();
try {
const response = await this.makeRequest(endpoint, method, payload);
const endTime = performance.now();
results.requests.push({
startTime,
endTime,
duration: endTime - startTime,
status: response.status,
size: response.data ? JSON.stringify(response.data).length : 0
});
} catch (error) {
results.errors.push({
timestamp: Date.now(),
error: error.message,
type: error.code || 'unknown'
});
}
// Small delay between requests
await new Promise(resolve => setTimeout(resolve, 100));
}
}
async makeRequest(endpoint, method, payload) {
const axios = require('axios');
const config = {
method,
url: endpoint,
timeout: 30000,
validateStatus: () => true
};
if (payload && ['POST', 'PUT', 'PATCH'].includes(method.toUpperCase())) {
config.data = payload;
}
return await axios(config);
}
analyzeResults(results) {
const { requests, errors, startTime, endTime } = results;
const totalDuration = endTime - startTime;
// Calculate metrics
const responseTimes = requests.map(r => r.duration);
const successfulRequests = requests.filter(r => r.status < 400);
const failedRequests = requests.filter(r => r.status >= 400);
const analysis = {
summary: {
totalRequests: requests.length,
successfulRequests: successfulRequests.length,
failedRequests: failedRequests.length + errors.length,
errorRate: (failedRequests.length + errors.length) / requests.length,
testDuration: totalDuration,
throughput: (requests.length / totalDuration) * 1000 // requests per second
},
responseTime: {
min: Math.min(...responseTimes),
max: Math.max(...responseTimes),
mean: responseTimes.reduce((a, b) => a + b, 0) / responseTimes.length,
p50: this.percentile(responseTimes, 50),
p90: this.percentile(responseTimes, 90),
p95: this.percentile(responseTimes, 95),
p99: this.percentile(responseTimes, 99)
},
errors: {
total: errors.length,
byType: this.groupBy(errors, 'type'),
timeline: errors.map(e => ({ timestamp: e.timestamp, type: e.type }))
},
recommendations: this.generatePerformanceRecommendations(results)
};
this.logResults(analysis);
return analysis;
}
percentile(arr, p) {
const sorted = [...arr].sort((a, b) => a - b);
const index = Math.ceil((p / 100) * sorted.length) - 1;
return sorted[index];
}
groupBy(array, key) {
return array.reduce((groups, item) => {
const group = item[key];
groups[group] = groups[group] || [];
groups[group].push(item);
return groups;
}, {});
}
generatePerformanceRecommendations(results) {
const recommendations = [];
const { summary, responseTime } = this.analyzeResults(results);
if (responseTime.mean > this.thresholds.responseTime) {
recommendations.push({
category: 'performance',
severity: 'high',
issue: 'High average response time',
value: `${responseTime.mean.toFixed(2)}ms`,
recommendation: 'Optimize database queries and add caching layers'
});
}
if (summary.throughput < this.thresholds.throughput) {
recommendations.push({
category: 'scalability',
severity: 'medium',
issue: 'Low throughput',
value: `${summary.throughput.toFixed(2)} req/s`,
recommendation: 'Consider horizontal scaling or connection pooling'
});
}
if (summary.errorRate > this.thresholds.errorRate) {
recommendations.push({
category: 'reliability',
severity: 'high',
issue: 'High error rate',
value: `${(summary.errorRate * 100).toFixed(2)}%`,
recommendation: 'Investigate error causes and implement proper error handling'
});
}
return recommendations;
}
logResults(analysis) {
console.log('\n📈 Performance Test Results:');
console.log(`Total Requests: ${analysis.summary.totalRequests}`);
console.log(`Success Rate: ${((analysis.summary.successfulRequests / analysis.summary.totalRequests) * 100).toFixed(2)}%`);
console.log(`Throughput: ${analysis.summary.throughput.toFixed(2)} req/s`);
console.log(`Average Response Time: ${analysis.responseTime.mean.toFixed(2)}ms`);
console.log(`95th Percentile: ${analysis.responseTime.p95.toFixed(2)}ms`);
if (analysis.recommendations.length > 0) {
console.log('\n⚠ Recommendations:');
analysis.recommendations.forEach(rec => {
console.log(`- ${rec.issue}: ${rec.recommendation}`);
});
}
}
}
module.exports = { PerformanceTestFramework };
```
### 5. Test Automation CI/CD Integration
```yaml
# .github/workflows/test-automation.yml
name: Test Automation Pipeline
on:
push:
branches: [ main, develop ]
pull_request:
branches: [ main ]
jobs:
unit-tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '18'
cache: 'npm'
- name: Install dependencies
run: npm ci
- name: Run unit tests
run: npm run test:unit -- --coverage
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
with:
file: ./coverage/lcov.info
- name: Comment coverage on PR
uses: romeovs/lcov-reporter-action@v0.3.1
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
lcov-file: ./coverage/lcov.info
integration-tests:
runs-on: ubuntu-latest
services:
postgres:
image: postgres:14
env:
POSTGRES_PASSWORD: postgres
POSTGRES_DB: test_db
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
redis:
image: redis:7
options: >-
--health-cmd "redis-cli ping"
--health-interval 10s
--health-timeout 5s
--health-retries 5
steps:
- uses: actions/checkout@v4
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '18'
cache: 'npm'
- name: Install dependencies
run: npm ci
- name: Run database migrations
run: npm run db:migrate
env:
DATABASE_URL: postgresql://postgres:postgres@localhost:5432/test_db
- name: Run integration tests
run: npm run test:integration
env:
DATABASE_URL: postgresql://postgres:postgres@localhost:5432/test_db
REDIS_URL: redis://localhost:6379
e2e-tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '18'
cache: 'npm'
- name: Install dependencies
run: npm ci
- name: Install Playwright
run: npx playwright install --with-deps
- name: Build application
run: npm run build
- name: Run E2E tests
run: npm run test:e2e
- name: Upload test results
uses: actions/upload-artifact@v3
if: always()
with:
name: playwright-report
path: playwright-report/
retention-days: 30
performance-tests:
runs-on: ubuntu-latest
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
steps:
- uses: actions/checkout@v4
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '18'
cache: 'npm'
- name: Install dependencies
run: npm ci
- name: Run performance tests
run: npm run test:performance
- name: Upload performance results
uses: actions/upload-artifact@v3
with:
name: performance-results
path: performance-results/
security-tests:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Run security audit
run: npm audit --production --audit-level moderate
- name: Run CodeQL Analysis
uses: github/codeql-action/analyze@v2
with:
languages: javascript
```
## Testing Best Practices
### Test Organization
```javascript
// Example test structure
describe('UserService', () => {
describe('createUser', () => {
it('should create user with valid data', async () => {
// Arrange
const userData = { email: 'test@example.com', name: 'Test User' };
// Act
const result = await userService.createUser(userData);
// Assert
expect(result).toHaveProperty('id');
expect(result.email).toBe(userData.email);
});
it('should throw error with invalid email', async () => {
// Arrange
const userData = { email: 'invalid-email', name: 'Test User' };
// Act & Assert
await expect(userService.createUser(userData)).rejects.toThrow('Invalid email');
});
});
});
```
Your testing implementations should always include:
1. **Test Strategy** - Clear testing approach and coverage goals
2. **Automation Pipeline** - CI/CD integration with quality gates
3. **Performance Testing** - Load testing and performance benchmarks
4. **Quality Metrics** - Coverage, reliability, and performance tracking
5. **Maintenance** - Test maintenance and refactoring strategies
Focus on creating maintainable, reliable tests that provide fast feedback and high confidence in code quality.

View File

@@ -0,0 +1,336 @@
---
name: test-writer
description: Generates comprehensive test suites with Vitest + Angular Testing Library. Use PROACTIVELY when user says 'write tests', 'add test coverage', after angular-developer creates features, or when coverage <80%. Handles unit, integration tests and mocking.
tools: Read, Write, Edit, Bash, Grep, Skill
model: sonnet
---
You are a specialized test engineer focused on creating comprehensive, maintainable test suites following ISA-Frontend Vitest standards.
## Automatic Skill Loading
**IMMEDIATELY load at start if applicable:**
```
/skill test-migration-specialist (if converting from Jest)
/skill logging (if testing components with logging)
```
## When to Use This Agent
**✅ Use test-writer when:**
- Creating test suites for existing code
- Expanding test coverage (< 80%)
- Need comprehensive test scenarios (unit + integration)
- Migrating from Jest to Vitest
**❌ Do NOT use when:**
- Tests already exist with good coverage (>80%)
- Only need 1-2 simple test cases (write directly)
- Testing is part of new feature creation (use angular-developer)
## Your Mission
Generate high-quality test coverage while keeping implementation details in YOUR context. Return summaries based on response_format parameter.
## Workflow
### 1. Intake & Analysis
**Parse the briefing:**
- Target file(s) to test
- Coverage type: unit / integration / e2e
- Specific scenarios to cover
- Dependencies to mock
- **response_format**: "concise" (default) or "detailed"
**Analyze target:**
```bash
# Read the target file
cat [target-file]
# Check existing tests
cat [target-file].spec.ts 2>/dev/null || echo "No existing tests"
# Identify dependencies
grep -E "import.*from" [target-file]
```
### 2. Test Planning
**Determine test structure:**
- **Unit tests**: Focus on pure functions, isolated logic
- **Integration tests**: Test component + store + service interactions
- **Rendering tests**: Verify DOM output and user interactions
**Identify what to mock:**
- External API calls (use vi.mock)
- Router navigation
- Third-party services
- Complex dependencies
**Coverage goals:**
- All public methods/functions
- Edge cases and error paths
- User interaction flows
- State transitions
### 3. Implementation
**Use Vitest + Angular Testing Library patterns:**
```typescript
import { describe, it, expect, beforeEach, vi } from 'vitest';
import { render, screen, fireEvent } from '@testing-library/angular';
import { ComponentFixture, TestBed } from '@angular/core/testing';
describe('ComponentName', () => {
let fixture: ComponentFixture<ComponentName>;
let component: ComponentName;
beforeEach(async () => {
await TestBed.configureTestingModule({
imports: [ComponentName],
providers: [
// Mock providers
]
}).compileComponents();
fixture = TestBed.createComponent(ComponentName);
component = fixture.componentInstance;
});
it('should render correctly', () => {
fixture.detectChanges();
expect(component).toBeTruthy();
});
// More tests...
});
```
**Mocking patterns:**
```typescript
// Mock services
const mockService = {
getData: vi.fn().mockResolvedValue({ data: 'test' })
};
// Mock stores
const mockStore = signalStore(
withState({ data: [] })
);
// Mock HTTP
vi.mock('@angular/common/http', () => ({
HttpClient: vi.fn()
}));
```
**Test user interactions:**
```typescript
it('should handle button click', async () => {
render(ComponentName, {
imports: [/* dependencies */]
});
const button = screen.getByRole('button', { name: /submit/i });
await fireEvent.click(button);
expect(screen.getByText(/success/i)).toBeInTheDocument();
});
```
### 4. Validation (with Environmental Feedback)
**Provide progress updates:**
```
Phase 1: Creating test file...
→ Created file.spec.ts (185 lines, 15 test cases)
✓ File created
Phase 2: Running tests...
→ Running tests... ⚠ 12/15 passing
Phase 3: Fixing failures...
→ Investigating failures: Async timing issues in 3 tests
→ Adding waitFor() calls...
→ Rerunning tests... ✓ 15/15 passing
Phase 4: Checking coverage...
→ Running coverage... ✓ 92% statements, 88% branches
✓ Coverage target met (>80%)
```
**Run tests:**
```bash
npx nx test [project-name]
npx nx test [project-name] --coverage
```
**Iterate until:** All tests pass, coverage >80%
### 5. Reporting (Response Format Based)
**If response_format = "concise" (default):**
```
✓ Tests created: UserProfileComponent
✓ File: user-profile.component.spec.ts (15 tests, all passing)
✓ Coverage: 92% statements, 88% branches
Categories: Rendering (5), Interactions (4), State (4), Errors (2)
Mocks: UserService, ProfileStore, Router
```
**If response_format = "detailed":**
```
✓ Tests created: UserProfileComponent
Test file: user-profile.component.spec.ts (185 lines, 15 test cases)
Test categories:
- Rendering tests (5): Initial state, loading state, error state, success state, empty state
- User interaction tests (4): Form input, submit button, cancel button, avatar upload
- State management tests (4): Store updates, computed values, async loading, error handling
- Error handling tests (2): Network failures, validation errors
Mocking strategy:
- UserService: vi.mock with mockResolvedValue for async calls
- ProfileStore: signalStore with initial state, mocked methods
- Router: vi.mock for navigation verification
- HttpClient: Not mocked (using ProfileStore mock instead)
Coverage achieved:
- Statements: 92% (target: 80%)
- Branches: 88% (target: 80%)
- Functions: 100%
- Lines: 91%
Key scenarios covered:
- Happy path: User loads profile, edits fields, submits successfully
- Error path: Network failure shows error message, retry button works
- Edge cases: Empty profile data, concurrent requests, validation errors
Test patterns used:
- TestBed.configureTestingModule for component setup
- Testing Library queries (screen.getByRole, screen.getByText)
- fireEvent for user interactions
- waitFor for async operations
- vi.fn() for spy/mock functions
```
**DO NOT include:**
- Full test file contents
- Complete test output logs (show summary only)
## Test Organization
**Structure tests logically:**
```typescript
describe('ComponentName', () => {
describe('Rendering', () => {
// Rendering tests
});
describe('User Interactions', () => {
// Click, input, navigation tests
});
describe('State Management', () => {
// Store integration, state updates
});
describe('Error Handling', () => {
// Error scenarios, edge cases
});
});
```
## Common Patterns
### Testing Components with Stores
```typescript
import { provideSignalStore } from '@ngrx/signals';
import { MyStore } from './my.store';
beforeEach(() => {
TestBed.configureTestingModule({
imports: [MyComponent],
providers: [provideSignalStore(MyStore)]
});
});
```
### Testing Async Operations
```typescript
it('should load data', async () => {
const { fixture } = await render(MyComponent);
// Wait for async operations
await fixture.whenStable();
expect(screen.getByText(/loaded/i)).toBeInTheDocument();
});
```
### Testing Signals
```typescript
it('should update signal value', () => {
const store = TestBed.inject(MyStore);
store.updateValue('new value');
expect(store.value()).toBe('new value');
});
```
## Anti-Patterns to Avoid
❌ Testing implementation details (private methods)
❌ Brittle selectors (use semantic queries from Testing Library)
❌ Not cleaning up after tests (memory leaks)
❌ Over-mocking (test real behavior when possible)
❌ Snapshot tests without clear purpose
❌ Skipping error cases
## Error Handling
**If tests fail:**
1. Analyze failure output
2. Fix test or identify product bug
3. Iterate up to 3 times
4. If still blocked, report:
```
⚠ Tests failing: [specific failure]
Failures: [X/Y tests failing]
Error: [concise error message]
Attempted: [what you tried]
Next step: [recommendation]
```
## Integration with Test Migration
**If migrating from Jest:**
- Load test-migration-specialist skill
- Convert Spectator → Angular Testing Library
- Replace Jest matchers with Vitest
- Update mock patterns (jest.fn → vi.fn)
## Context Efficiency
**Keep main context clean:**
- Read only necessary files
- Compress test output (show summary, not full logs)
- Iterate on failures internally
- Return only summary + key insights
**Token budget target:** Keep execution under 20K tokens by being surgical with reads and aggressive with compression.

View File

@@ -1,6 +1,6 @@
---
name: typescript-pro
description: Write idiomatic TypeScript with advanced type system features, strict typing, and modern patterns. Masters generic constraints, conditional types, and type inference. Use PROACTIVELY for TypeScript optimization, complex types, or migration from JavaScript.
description: Writes advanced TypeScript with generic constraints, conditional/mapped types, and custom type guards. Use PROACTIVELY when creating type utilities, migrating JavaScript to TypeScript, resolving complex type inference issues, or implementing strict typing.
tools: Read, Write, Edit, Bash
model: sonnet
---

View File

@@ -1,36 +0,0 @@
---
name: ui-ux-designer
description: UI/UX design specialist for user-centered design and interface systems. Use PROACTIVELY for user research, wireframes, design systems, prototyping, accessibility standards, and user experience optimization.
tools: Read, Write, Edit
model: sonnet
---
You are a UI/UX designer specializing in user-centered design and interface systems.
## Focus Areas
- User research and persona development
- Wireframing and prototyping workflows
- Design system creation and maintenance
- Accessibility and inclusive design principles
- Information architecture and user flows
- Usability testing and iteration strategies
## Approach
1. User needs first - design with empathy and data
2. Progressive disclosure for complex interfaces
3. Consistent design patterns and components
4. Mobile-first responsive design thinking
5. Accessibility built-in from the start
## Output
- User journey maps and flow diagrams
- Low and high-fidelity wireframes
- Design system components and guidelines
- Prototype specifications for development
- Accessibility annotations and requirements
- Usability testing plans and metrics
Focus on solving user problems. Include design rationale and implementation notes.

View File

@@ -29,12 +29,33 @@ Create well-formatted commit: $ARGUMENTS
6. If multiple distinct changes are detected, suggests breaking the commit into multiple smaller commits
7. For each commit (or the single commit if not split), creates a commit message using emoji conventional commit format
## Determining the Scope
The scope in commit messages MUST be the `name` field from the affected library's `project.json`:
1. **Check the file path**: `libs/ui/label/src/...` → Look at `libs/ui/label/project.json`
2. **Read the project name**: The `"name"` field (e.g., `"name": "ui-label"`)
3. **Use that as scope**: `feat(ui-label): ...`
**Examples:**
- File: `libs/remission/feature/remission-list/src/...` → Scope: `remission-feature-remission-list`
- File: `libs/ui/notice/src/...` → Scope: `ui-notice`
- File: `apps/isa-app/src/...` → Scope: `isa-app`
**Multi-project changes:**
- If changes span 2-3 related projects, use the primary one or list them: `feat(ui-label, ui-notice): ...`
- If changes span many unrelated projects, split into separate commits
## Best Practices for Commits
- **Verify before committing**: Ensure code is linted, builds correctly, and documentation is updated
- **Atomic commits**: Each commit should contain related changes that serve a single purpose
- **Split large changes**: If changes touch multiple concerns, split them into separate commits
- **Conventional commit format**: Use the format `<type>: <description>` where type is one of:
- **Conventional commit format**: Use the format `<type>(<scope>): <description>` where:
- **scope**: The project name from `project.json` of the affected library (e.g., `ui-label`, `crm-feature-checkout`)
- Determine the scope by checking which library/project the changes belong to
- If changes span multiple projects, use the primary affected project or split into multiple commits
- type is one of:
- `feat`: A new feature
- `fix`: A bug fix
- `docs`: Documentation changes
@@ -122,37 +143,73 @@ When analyzing the diff, consider splitting commits based on these criteria:
## Examples
Good commit messages:
- ✨ feat: add user authentication system
- 🐛 fix: resolve memory leak in rendering process
- 📝 docs: update API documentation with new endpoints
- ♻️ refactor: simplify error handling logic in parser
- 🚨 fix: resolve linter warnings in component files
- 🧑‍💻 chore: improve developer tooling setup process
- 👔 feat: implement business logic for transaction validation
- 🩹 fix: address minor styling inconsistency in header
- 🚑️ fix: patch critical security vulnerability in auth flow
- 🎨 style: reorganize component structure for better readability
- 🔥 fix: remove deprecated legacy code
- 🦺 feat: add input validation for user registration form
- 💚 fix: resolve failing CI pipeline tests
- 📈 feat: implement analytics tracking for user engagement
- 🔒️ fix: strengthen authentication password requirements
- ♿️ feat: improve form accessibility for screen readers
Good commit messages (scope = project name from project.json):
- ✨ feat(auth-feature-login): add user authentication system
- 🐛 fix(ui-renderer): resolve memory leak in rendering process
- 📝 docs(crm-api): update API documentation with new endpoints
- ♻️ refactor(shared-utils): simplify error handling logic in parser
- 🚨 fix(ui-label): resolve linter warnings in component files
- 🧑‍💻 chore(dev-tools): improve developer tooling setup process
- 👔 feat(checkout-feature): implement business logic for transaction validation
- 🩹 fix(ui-header): address minor styling inconsistency in header
- 🚑️ fix(auth-core): patch critical security vulnerability in auth flow
- 🎨 style(ui-components): reorganize component structure for better readability
- 🔥 fix(legacy-module): remove deprecated legacy code
- 🦺 feat(user-registration): add input validation for user registration form
- 💚 fix(ci-config): resolve failing CI pipeline tests
- 📈 feat(analytics-feature): implement analytics tracking for user engagement
- 🔒️ fix(auth-password): strengthen authentication password requirements
- ♿️ feat(ui-forms): improve form accessibility for screen readers
Example of splitting commits:
- First commit: ✨ feat: add new solc version type definitions
- Second commit: 📝 docs: update documentation for new solc versions
- Third commit: 🔧 chore: update package.json dependencies
- Fourth commit: 🏷️ feat: add type definitions for new API endpoints
- Fifth commit: 🧵 feat: improve concurrency handling in worker threads
- Sixth commit: 🚨 fix: resolve linting issues in new code
- Seventh commit: ✅ test: add unit tests for new solc version features
- Eighth commit: 🔒️ fix: update dependencies with security vulnerabilities
- First commit: ✨ feat(ui-label): add prio-label component with variant styles
- Second commit: 📝 docs(ui-label): update README with usage examples
- Third commit: 🔧 chore(ui-notice): scaffold new notice library
- Fourth commit: 🏷️ feat(shared-types): add type definitions for new API endpoints
- Fifth commit: ♻️ refactor(pickup-shelf): update components to use new label
- Sixth commit: 🚨 fix(remission-list): resolve linting issues in new code
- Seventh commit: ✅ test(ui-label): add unit tests for prio-label component
- Eighth commit: 🔒️ fix(deps): update dependencies with security vulnerabilities
## Command Options
- `--no-verify`: Skip running the pre-commit checks (lint, build, generate:docs)
- `--amend`: Amend the previous commit (RESTRICTED - see rules below)
## Amend Rules (CRITICAL)
**ONLY use `--amend` in these specific cases:**
1. **Adding pre-commit hook fixes**: If a pre-commit hook modified files (formatting, linting auto-fixes), you may amend to include those changes.
2. **Before amending, ALWAYS verify:**
```bash
# Check authorship - NEVER amend another developer's commit
git log -1 --format='%an %ae'
# Check not pushed - NEVER amend pushed commits
git status # Should show "Your branch is ahead of..."
```
3. **If either check fails:**
- Create a NEW commit instead
- Never amend commits authored by others
- Never amend commits already pushed to remote
**Example workflow for pre-commit hook changes:**
```bash
# 1. Initial commit triggers pre-commit hook
git commit -m "feat(scope): add feature"
# Hook modifies files...
# 2. Verify safe to amend
git log -1 --format='%an %ae' # Your name/email
git status # "Your branch is ahead..."
# 3. Stage hook changes and amend
git add .
git commit --amend --no-edit
```
## Important Notes

View File

@@ -1,94 +0,0 @@
---
allowed-tools: Read, Write, Edit, Bash
argument-hint: [framework] | --c4-model | --arc42 | --adr | --plantuml | --full-suite
description: Generate comprehensive architecture documentation with diagrams, ADRs, and interactive visualization
---
# Architecture Documentation Generator
Generate comprehensive architecture documentation: $ARGUMENTS
## Current Architecture Context
- Project structure: !`find . -type f -name "*.json" -o -name "*.yaml" -o -name "*.toml" | head -5`
- Documentation exists: @docs/ or @README.md (if exists)
- Architecture files: !`find . -name "*architecture*" -o -name "*design*" -o -name "*.puml" | head -3`
- Services/containers: @docker-compose.yml or @k8s/ (if exists)
- API definitions: !`find . -name "*api*" -o -name "*openapi*" -o -name "*swagger*" | head -3`
## Task
Generate comprehensive architecture documentation with modern tooling and best practices:
1. **Architecture Analysis and Discovery**
- Analyze current system architecture and component relationships
- Identify key architectural patterns and design decisions
- Document system boundaries, interfaces, and dependencies
- Assess data flow and communication patterns
- Identify architectural debt and improvement opportunities
2. **Architecture Documentation Framework**
- Choose appropriate documentation framework and tools:
- **C4 Model**: Context, Containers, Components, Code diagrams
- **Arc42**: Comprehensive architecture documentation template
- **Architecture Decision Records (ADRs)**: Decision documentation
- **PlantUML/Mermaid**: Diagram-as-code documentation
- **Structurizr**: C4 model tooling and visualization
- **Draw.io/Lucidchart**: Visual diagramming tools
3. **System Context Documentation**
- Create high-level system context diagrams
- Document external systems and integrations
- Define system boundaries and responsibilities
- Document user personas and stakeholders
- Create system landscape and ecosystem overview
4. **Container and Service Architecture**
- Document container/service architecture and deployment view
- Create service dependency maps and communication patterns
- Document deployment architecture and infrastructure
- Define service boundaries and API contracts
- Document data persistence and storage architecture
5. **Component and Module Documentation**
- Create detailed component architecture diagrams
- Document internal module structure and relationships
- Define component responsibilities and interfaces
- Document design patterns and architectural styles
- Create code organization and package structure documentation
6. **Data Architecture Documentation**
- Document data models and database schemas
- Create data flow diagrams and processing pipelines
- Document data storage strategies and technologies
- Define data governance and lifecycle management
- Create data integration and synchronization documentation
7. **Security and Compliance Architecture**
- Document security architecture and threat model
- Create authentication and authorization flow diagrams
- Document compliance requirements and controls
- Define security boundaries and trust zones
- Create incident response and security monitoring documentation
8. **Quality Attributes and Cross-Cutting Concerns**
- Document performance characteristics and scalability patterns
- Create reliability and availability architecture documentation
- Document monitoring and observability architecture
- Define maintainability and evolution strategies
- Create disaster recovery and business continuity documentation
9. **Architecture Decision Records (ADRs)**
- Create comprehensive ADR template and process
- Document historical architectural decisions and rationale
- Create decision tracking and review process
- Document trade-offs and alternatives considered
- Set up ADR maintenance and evolution procedures
10. **Documentation Automation and Maintenance**
- Set up automated diagram generation from code annotations
- Configure documentation pipeline and publishing automation
- Set up documentation validation and consistency checking
- Create documentation review and approval process
- Train team on architecture documentation practices and tools
- Set up documentation versioning and change management

View File

@@ -1,197 +0,0 @@
# /dev:add-e2e-attrs - Add E2E Test Attributes
Add required E2E test attributes (`data-what`, `data-which`, dynamic `data-*`) to component templates for QA automation.
## Parameters
- `component-path`: Path to component directory or HTML template file
## Required E2E Attributes
### Core Attributes (Required)
1. **`data-what`**: Semantic description of element's purpose
- Example: `data-what="submit-button"`, `data-what="search-input"`
2. **`data-which`**: Unique identifier for the specific instance
- Example: `data-which="primary"`, `data-which="customer-{{ customerId }}"`
### Dynamic Attributes (Contextual)
3. **`data-*`**: Additional context based on state/data
- Example: `data-status="active"`, `data-index="0"`
## Tasks
### 1. Analyze Component Template
- Read component HTML template
- Identify interactive elements that need E2E attributes:
- Buttons (`button`, `ui-button`)
- Inputs (`input`, `textarea`, `select`)
- Links (`a`, `routerLink`)
- Custom interactive components
- Form elements
- Clickable elements (`(click)` handlers)
### 2. Add Missing Attributes
**Buttons:**
```html
<!-- BEFORE -->
<button (click)="submit()">Submit</button>
<!-- AFTER -->
<button
(click)="submit()"
data-what="submit-button"
data-which="form-primary">
Submit
</button>
```
**Inputs:**
```html
<!-- BEFORE -->
<input [(ngModel)]="searchTerm" placeholder="Search..." />
<!-- AFTER -->
<input
[(ngModel)]="searchTerm"
placeholder="Search..."
data-what="search-input"
data-which="main-search" />
```
**Dynamic Lists:**
```html
<!-- BEFORE -->
@for (item of items; track item.id) {
<li (click)="selectItem(item)">{{ item.name }}</li>
}
<!-- AFTER -->
@for (item of items; track item.id) {
<li
(click)="selectItem(item)"
data-what="list-item"
[attr.data-which]="item.id"
[attr.data-status]="item.status">
{{ item.name }}
</li>
}
```
**Links:**
```html
<!-- BEFORE -->
<a routerLink="/orders/{{ orderId }}">View Order</a>
<!-- AFTER -->
<a
[routerLink]="['/orders', orderId]"
data-what="order-link"
[attr.data-which]="orderId">
View Order
</a>
```
**Custom Components:**
```html
<!-- BEFORE -->
<ui-button (click)="save()">Save</ui-button>
<!-- AFTER -->
<ui-button
(click)="save()"
data-what="save-button"
data-which="order-form">
Save
</ui-button>
```
### 3. Naming Conventions
**`data-what` Guidelines:**
- Use kebab-case
- Be descriptive but concise
- Common patterns:
- `*-button` (submit-button, cancel-button, delete-button)
- `*-input` (email-input, search-input, quantity-input)
- `*-link` (product-link, order-link, customer-link)
- `*-item` (list-item, menu-item, card-item)
- `*-dialog` (confirm-dialog, error-dialog)
- `*-dropdown` (status-dropdown, category-dropdown)
**`data-which` Guidelines:**
- Unique identifier for the instance
- Use dynamic binding for list items: `[attr.data-which]="item.id"`
- Static for unique elements: `data-which="primary"`
- Combine with context: `data-which="customer-{{ customerId }}-edit"`
### 4. Scan for Coverage
Check template coverage:
```bash
# Count interactive elements
grep -E '(click)=|routerLink|button|input|select|textarea' [template-file]
# Count elements with data-what
grep -c 'data-what=' [template-file]
# List elements missing E2E attributes
grep -E '(click)=|button' [template-file] | grep -v 'data-what='
```
### 5. Validate Attributes
- No duplicates in `data-which` within same view
- All interactive elements have both `data-what` and `data-which`
- Dynamic attributes use proper Angular binding: `[attr.data-*]`
- Attributes don't contain sensitive data (passwords, tokens)
### 6. Update Component Tests
Add E2E attribute selectors to tests:
```typescript
// Use E2E attributes for element selection
const submitButton = fixture.nativeElement.querySelector('[data-what="submit-button"][data-which="primary"]');
expect(submitButton).toBeTruthy();
```
### 7. Document Attributes
Add comment block at top of template:
```html
<!--
E2E Test Attributes:
- data-what="submit-button" data-which="primary" - Main form submission
- data-what="cancel-button" data-which="primary" - Cancel action
- data-what="search-input" data-which="main" - Product search field
-->
```
## Output
Provide summary:
- Template analyzed: [path]
- Interactive elements found: [count]
- Attributes added: [count]
- Coverage: [percentage]% (elements with E2E attrs / total interactive elements)
- List of added attributes with descriptions
- Validation status: ✅/❌
## Common Patterns by Component Type
**Form Components:**
- `data-what="[field]-input" data-which="[form-name]"`
- `data-what="submit-button" data-which="[form-name]"`
- `data-what="cancel-button" data-which="[form-name]"`
**List/Table Components:**
- `data-what="list-item" [attr.data-which]="item.id"`
- `data-what="edit-button" [attr.data-which]="item.id"`
- `data-what="delete-button" [attr.data-which]="item.id"`
**Navigation Components:**
- `data-what="nav-link" data-which="[destination]"`
- `data-what="breadcrumb" data-which="[level]"`
**Dialog Components:**
- `data-what="confirm-button" data-which="dialog"`
- `data-what="close-button" data-which="dialog"`
## References
- CLAUDE.md Code Quality section (E2E Testing Requirements)
- docs/guidelines/testing.md
- QA team E2E test documentation (if available)

View File

@@ -1,3 +1,9 @@
---
allowed-tools: Read, Write, Edit, Bash, Grep, Glob, Task
argument-hint: [library-name]
description: Generate or update README.md for a specific library with comprehensive documentation
---
# /docs:library - Generate/Update Library README
Generate or update README.md for a specific library with comprehensive documentation.

View File

@@ -1,3 +1,9 @@
---
allowed-tools: Read, Write, Edit, Bash, Grep, Glob
argument-hint: --dry-run | --force
description: Regenerate library reference documentation (docs/library-reference.md) by scanning all monorepo libraries
---
# /docs:refresh-reference - Regenerate Library Reference
Regenerate the library reference documentation (`docs/library-reference.md`) by scanning all libraries in the monorepo.

View File

@@ -0,0 +1,434 @@
---
allowed-tools: Read, Write, Bash, Grep
argument-hint: [date] | --yesterday | --save-only
description: Generate End of Day report summarizing commits and work across all branches
---
# End of Day Report
Generate daily work summary: $ARGUMENTS
## Current State
- Current Date: !`date +%Y-%m-%d`
- Current Time: !`date +%H:%M`
- Current Branch: !`git branch --show-current`
- Git User: !`git config user.name`
- Git Email: !`git config user.email`
## Tasks
### 1. Determine Report Date and Scope
**Objective**: Identify the date range for the report
- [ ] Ask user for their work start time
- Use AskUserQuestion to ask: "What time did you start working today?"
- Provide options: "First commit time", "08:00", "09:00", "10:00", "Custom time"
- If "Custom time" selected, ask for specific time (HH:MM format)
- Default to first commit time if not specified
- Use this for accurate "Work Duration" calculation
- [ ] Check if date argument provided
- If `[date]` provided: Use specific date (format: YYYY-MM-DD)
- If `--yesterday` provided: Use yesterday's date
- Otherwise: Use today's date
```bash
# Get today's date
TODAY=$(date +%Y-%m-%d)
# Get yesterday's date
YESTERDAY=$(date -d "yesterday" +%Y-%m-%d)
# Get start of day
START_TIME="${TODAY} 00:00:00"
# Get end of day
END_TIME="${TODAY} 23:59:59"
```
- [ ] Set report scope
- Search across **all branches** (local and remote)
- Filter by git user name and email
- Include commits from start to end of specified day
### 2. Collect Commit Information
**Objective**: Gather all commits made by the user on the specified date (excluding merge commits)
- [ ] Fetch commits across all branches (non-merge commits only)
```bash
# Get all non-merge commits by current user today across all branches
git log --all \
--author="$(git config user.name)" \
--since="$START_TIME" \
--until="$END_TIME" \
--pretty=format:"%h|%ai|%s|%D" \
--no-merges
```
**Important**: Use `--no-merges` flag to exclude PR merge commits. These will be tracked separately in section 3.
- [ ] Extract commit details:
- Commit hash (short)
- Commit time
- Commit message
- Branch references (if any)
- [ ] Group commits by branch
- Parse branch references from commit output
- Identify which branch each commit belongs to
- Track branch switches during the day
- Exclude "Merged PR" commits from this section (they appear in Merge Activity instead)
**Example Output**:
```
c208327db|2025-10-28 14:23:45|feat(crm-data-access,checkout): improve primary bonus card selection logic|feature/5202-Praemie
9020cb305|2025-10-28 10:15:32|✨ feat(navigation): implement title management and enhance tab system|feature/5351-navigation
```
### 3. Identify PR and Merge Activity
**Objective**: Find pull requests created or merged today, distinguishing between PRs I merged vs PRs merged by colleagues
- [ ] Find ALL merge commits with "Merged PR" (check both author and committer)
```bash
# Get all PR merge activity with author and committer info
git log --all \
--since="$START_TIME" \
--until="$END_TIME" \
--grep="Merged PR" \
--pretty=format:"%h|%ai|%s|Author: %an <%ae>|Committer: %cn <%ce>"
```
- [ ] Categorize PR merges:
- **PRs I merged**: Where I am the COMMITTER (git config user.name matches committer name)
- **My PRs merged by colleagues**: Where I am the AUTHOR but someone else is the COMMITTER
- **Colleague PRs I merged**: Where someone else is the AUTHOR and I am the COMMITTER
- [ ] Parse PR numbers from commit messages
- Look for patterns: "Merged PR 1234:", "PR #1234", etc.
- Extract PR title/description
- Note which branch was merged
- Note who performed the merge (committer name)
- [ ] Identify branch merges
- Look for merge commits to develop/main
- Note feature branches merged
### 4. Analyze Branch Activity
**Objective**: Summarize branches worked on today
- [ ] List all branches with commits today
```bash
# Get unique branches with activity today
git log --all \
--author="$(git config user.name)" \
--since="$START_TIME" \
--until="$END_TIME" \
--pretty=format:"%D" | \
grep -v '^$' | \
tr ',' '\n' | \
sed 's/^ *//' | \
grep -E '^(origin/)?[a-zA-Z]' | \
sort -u
```
- [ ] Identify:
- Primary branch worked on (most commits)
- Other branches touched
- New branches created today
- Branches merged today
- [ ] Check current branch status
- Uncommitted changes
- Untracked files
- Ahead/behind develop
### 5. Generate Report Summary
**Objective**: Create formatted markdown report
- [ ] Build report structure:
```markdown
# End of Day Report - YYYY-MM-DD
**Developer**: [Name] <email>
**Date**: Day, Month DD, YYYY
**Time**: HH:MM
---
## 📊 Summary
- **Commits**: X commits across Y branches
- **PRs I Merged**: Z pull requests (as committer)
- **My PRs Merged by Colleagues**: W pull requests
- **Primary Branch**: branch-name
- **Work Duration**: Started at HH:MM, worked for Xh Ym
## 🔨 Commits Today
### Branch: feature/5351-navigation (5 commits)
- `9020cb3` (10:15) ✨ feat(navigation): implement title management and enhance tab system
- `abc1234` (11:30) fix(navigation): resolve routing edge case
- `def5678` (14:45) test(navigation): add comprehensive test coverage
- `ghi9012` (15:20) refactor(navigation): improve code organization
- `jkl3456` (16:00) docs(navigation): update README with usage examples
### Branch: feature/5202-Praemie (2 commits)
- `c208327` (14:23) feat(crm-data-access,checkout): improve primary bonus card selection logic
- `mno7890` (16:45) fix(checkout): handle edge case for bonus points
## 🔀 Merge Activity
### PRs I Merged (as committer)
- **PR #1990**: feat(ui): add new button variants → develop
- **PR #1991**: fix(api): resolve timeout issues → develop
### My PRs Merged by Colleagues
- **PR #1987**: Carousel Library → develop (merged by Nino Righi)
- **PR #1989**: fix(checkout): resolve currency constraint violations → develop (merged by Nino Righi)
### Branch Merges
- `feature/5202-Praemie-stock-info-request-batching``feature/5202-Praemie`
## 🌿 Branch Activity
**Primary Branch**: feature/5351-navigation (5 commits)
**Other Branches**:
- feature/5202-Praemie (2 commits)
- develop (merged 2 PRs)
**Current Branch**: feature/5351-navigation
**Status**: 3 files changed, 2 files staged, 1 file untracked
## 📝 Notes
[Optional section for manual notes - left empty by default]
---
_Report generated on YYYY-MM-DD at HH:MM_
```
**Formatting Rules**:
- Use emoji for section headers (📊 📝 🔨 🔀 🌿)
- Group commits by branch
- Show time for each commit in (HH:MM) format
- Include commit prefixes (feat:, fix:, docs:, etc.)
- Sort branches by number of commits (most active first)
- Highlight primary branch (most commits)
### 6. Save and Display Report
**Objective**: Output report to terminal and save to file
**Display to Terminal**:
- [ ] Print formatted report to stdout
- [ ] Use clear visual separators
- [ ] Ensure easy copy/paste to Slack/Teams/Email
**Save to File**:
- [ ] Create reports directory if it doesn't exist
```bash
mkdir -p reports/eod
```
- [ ] Determine filename
- Format: `reports/eod/YYYY-MM-DD.md`
- Example: `reports/eod/2025-10-28.md`
- [ ] Write report to file
```bash
# Save report
cat > "reports/eod/${TODAY}.md" << 'EOF'
[report content]
EOF
```
- [ ] Provide file location feedback
- Show absolute path to saved file
- Confirm successful save
**If `--save-only` flag**:
- [ ] Skip terminal display
- [ ] Only save to file
- [ ] Show success message with file path
### 7. Provide Summary Statistics
**Objective**: Show quick statistics and next steps
- [ ] Calculate and display:
- Total commits today (excluding PR merge commits)
- Number of branches worked on
- PRs I merged (as committer)
- My PRs merged by colleagues (authored by me, committed by others)
- Work duration (user-specified start time → last commit time)
- Lines of code changed (optional, if available)
- [ ] Suggest next steps:
- Commit uncommitted changes
- Push branches to remote
- Create PR for completed work
- Update task tracking system
## Output Format
### Standard Display
```
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
📋 End of Day Report - 2025-10-28
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
**Developer**: Lorenz Hilpert <lorenz@example.com>
**Date**: Monday, October 28, 2025
**Time**: 17:30
---
## 📊 Summary
- **Commits**: 5 commits across 1 branch
- **PRs I Merged**: 2 pull requests (as committer)
- **My PRs Merged by Colleagues**: 0
- **Primary Branch**: feature/5351-navigation
- **Work Duration**: Started at 09:00, worked for 7h 45m (last commit at 16:45)
## 🔨 Commits Today
### Branch: feature/5351-navigation (5 commits)
- `9020cb3` (10:15) ✨ feat(navigation): implement title management and enhance tab system
- `abc1234` (11:30) 🐛 fix(navigation): resolve routing edge case
- `def5678` (14:45) ✅ test(navigation): add comprehensive test coverage
- `ghi9012` (15:20) ♻️ refactor(navigation): improve code organization
- `jkl3456` (16:00) 📝 docs(navigation): update README with usage examples
### Branch: feature/5202-Praemie (2 commits)
- `c208327` (14:23) ✨ feat(crm-data-access,checkout): improve primary bonus card selection logic
- `mno7890` (16:45) 🐛 fix(checkout): handle edge case for bonus points
## 🔀 Merge Activity
### PRs I Merged (as committer)
- **PR #1987**: Carousel Library → develop
- **PR #1989**: fix(checkout): resolve currency constraint violations → develop
### My PRs Merged by Colleagues
_None today_
## 🌿 Branch Activity
**Primary Branch**: feature/5351-navigation (5 commits)
**Other Branches**:
- feature/5202-Praemie (2 commits)
- develop (2 PR merges)
**Current Status**:
- Branch: feature/5351-navigation
- Changes: 3 files changed, 2 files staged, 1 file untracked
- Remote: 5 commits ahead of origin/feature/5351-navigation
## 📝 Notes
_No additional notes_
---
✅ Report saved to: /home/lorenz/Projects/ISA-Frontend/reports/eod/2025-10-28.md
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
📊 Daily Statistics
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Total Commits: 5 (excluding PR merges)
Branches: 1 active branch
PRs I Merged: 2
My PRs Merged by Colleagues: 0
Work Duration: 7h 45m (started at 09:00, last commit at 16:45)
📋 Next Steps
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
1. ✅ Push feature/5351-navigation to remote
2. ⚠️ Consider creating PR for completed work
3. 💾 1 untracked file - review and commit if needed
```
### No Activity Case
```
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
📋 End of Day Report - 2025-10-28
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
**Developer**: Lorenz Hilpert <lorenz@example.com>
**Date**: Monday, October 28, 2025
**Time**: 17:30
---
## 📊 Summary
No commits found for today (2025-10-28).
**Possible Reasons**:
- No development work performed
- Working on uncommitted changes
- Using different git user configuration
**Current Branch**: feature/5351-navigation
**Uncommitted Changes**: 5 files modified, 2 files staged
---
💡 Tip: If you have uncommitted work, commit it before generating the report.
```
### Yesterday's Report
```
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
📋 End of Day Report - 2025-10-27 (Yesterday)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
[Report content for yesterday]
✅ Report saved to: /home/lorenz/Projects/ISA-Frontend/reports/eod/2025-10-27.md
```
## Usage Examples
```bash
# Generate today's EOD report
/eod-report
# Generate yesterday's report (if you forgot)
/eod-report --yesterday
# Generate report for specific date
/eod-report 2025-10-25
# Save to file only (no terminal output)
/eod-report --save-only
# Generate yesterday's report and save only
/eod-report --yesterday --save-only
```
## References
- Git Log Documentation: https://git-scm.com/docs/git-log
- Conventional Commits: https://www.conventionalcommits.org/
- Project Conventions: See CLAUDE.md for commit message standards
- Git Configuration: `git config user.name` and `git config user.email`

View File

@@ -0,0 +1,309 @@
---
allowed-tools: Read, Write, Edit, Bash, Grep
argument-hint: [version] | --since [tag] | --dry-run
description: Generate changelog entries from git tags using Keep a Changelog format
---
# Generate Changelog
Generate changelog entries from git commits between version tags: $ARGUMENTS
## Current State
- Latest Tag: !`git tag --sort=-creatordate | head -n 1`
- CHANGELOG.md: !`test -f CHANGELOG.md && echo "exists" || echo "does not exist"`
- Commits Since Last Tag: !`git log $(git tag --sort=-creatordate | head -n 1)..HEAD --oneline | wc -l`
- Current Branch: !`git branch --show-current`
## Tasks
### 1. Determine Version Range
**Objective**: Identify the commit range for changelog generation
- [ ] Check if version argument provided
- If `[version]` provided: Use as the new version number
- If `--since [tag]` provided: Use custom tag as starting point
- Otherwise: Use latest tag as starting point
```bash
# Find latest tag
LATEST_TAG=$(git tag --sort=-creatordate | head -n 1)
# Get commits since tag
git log ${LATEST_TAG}..HEAD --oneline
# If no tags exist, use entire history
if [ -z "$LATEST_TAG" ]; then
git log --oneline
fi
```
**Edge Cases**:
- No tags exist → Use entire commit history and suggest version 0.1.0
- No commits since last tag → Notify user, no changelog needed
- Invalid tag provided → Error with available tags list
### 2. Extract and Categorize Commits
**Objective**: Parse commit messages and group by Keep a Changelog categories
- [ ] Fetch commits with detailed information
```bash
# Get commits with format: hash | date | message
git log ${LATEST_TAG}..HEAD --pretty=format:"%h|%as|%s" --no-merges
```
- [ ] Parse conventional commit patterns and map to categories:
**Mapping Rules**:
- `feat:` or `feature:`**Added**
- `fix:` or `bugfix:`**Fixed**
- `refactor:`**Changed**
- `perf:` or `performance:`**Changed**
- `docs:`**Changed** (or skip if only documentation)
- `style:`**Changed**
- `test:` → (skip from changelog)
- `chore:` → (skip from changelog)
- `build:` or `ci:` → (skip from changelog)
- `revert:`**Changed** or **Fixed**
- `security:`**Security**
- `deprecate:` or `deprecated:`**Deprecated**
- `remove:` or `breaking:`**Removed**
- Non-conventional commits → **Changed** (default)
- [ ] Extract scope and description from commit messages
**Commit Pattern**: `type(scope): description`
Example:
```
feat(checkout): add reward delivery order support
fix(remission): resolve currency constraint violations
refactor(navigation): implement title management system
```
### 3. Generate Changelog Entry
**Objective**: Create properly formatted changelog section
- [ ] Determine version number
- Use provided `[version]` argument
- Or prompt for new version if not provided
- Format: `[X.Y.Z]` following semantic versioning
- [ ] Get current date in ISO format: `YYYY-MM-DD`
```bash
TODAY=$(date +%Y-%m-%d)
```
- [ ] Build changelog entry following Keep a Changelog format:
```markdown
## [VERSION] - YYYY-MM-DD
### Added
- New feature description from feat: commits
- Another feature
### Changed
- Refactored component description
- Performance improvements
### Deprecated
- Feature marked for removal
### Removed
- Deleted feature or breaking change
### Fixed
- Bug fix description
- Another fix
### Security
- Security improvement description
```
**Rules**:
- Only include sections that have entries
- Sort entries alphabetically within each section
- Use sentence case for descriptions
- Remove commit type prefix from descriptions
- Include scope in parentheses if present: `(scope) description`
- Add reference links to commits/PRs if available
### 4. Update or Preview CHANGELOG.md
**Objective**: Append new entry to changelog file or show preview
**If `--dry-run` flag provided**:
- [ ] Display generated changelog entry to stdout
- [ ] Show preview of where it would be inserted
- [ ] Do NOT modify CHANGELOG.md
- [ ] Exit with success
**Otherwise (append mode)**:
- [ ] Check if CHANGELOG.md exists
- If not, create with standard header:
```markdown
# Changelog
All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased]
```
- [ ] Read existing CHANGELOG.md content
- [ ] Find insertion point (after "## [Unreleased]" section, or after main header)
- [ ] Insert new changelog entry
- [ ] Maintain reverse chronological order (newest first)
- [ ] Write updated content back to CHANGELOG.md
```bash
# Backup existing file
cp CHANGELOG.md CHANGELOG.md.bak
# Insert new entry
# (Implementation handled by Edit tool)
```
### 5. Validate and Report
**Objective**: Verify changelog quality and provide summary
- [ ] Validate generated entry:
- Version format is valid (X.Y.Z)
- Date is correct (YYYY-MM-DD)
- At least one category has entries
- No duplicate entries
- Proper markdown formatting
- [ ] Report statistics:
- Number of commits processed
- Entries per category
- Version number used
- File status (preview/updated)
- [ ] Show next steps:
- Review changelog entry
- Update version in package.json if needed
- Create git tag if appropriate
- Commit changelog changes
## Output Format
### Dry Run Preview
```
🔍 Changelog Preview (--dry-run mode)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
## [1.5.0] - 2025-10-28
### Added
- (checkout) Add reward delivery order support
- (navigation) Implement title management and tab system
### Changed
- (carousel) Update carousel library implementation
- (remission) Enhance returns processing workflow
### Fixed
- (checkout) Resolve currency constraint violations in price handling
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
📊 Statistics
─────────────
Commits processed: 12
Added: 2 entries
Changed: 2 entries
Fixed: 1 entry
Version: 1.5.0
Date: 2025-10-28
⚠️ This is a preview. Run without --dry-run to update CHANGELOG.md
```
### Append Mode Success
```
✅ Changelog Updated Successfully
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
## [1.5.0] - 2025-10-28
### Added
- (checkout) Add reward delivery order support
- (navigation) Implement title management and tab system
### Changed
- (carousel) Update carousel library implementation
- (remission) Enhance returns processing workflow
### Fixed
- (checkout) Resolve currency constraint violations in price handling
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
📊 Statistics
─────────────
Commits processed: 12
Added: 2 entries
Changed: 2 entries
Fixed: 1 entry
Version: 1.5.0
File: CHANGELOG.md (updated)
Backup: CHANGELOG.md.bak
📋 Next Steps
─────────────
1. Review the changelog entry in CHANGELOG.md
2. Update version in package.json: npm version 1.5.0
3. Commit the changelog: git add CHANGELOG.md && git commit -m "docs: update changelog for v1.5.0"
4. Create git tag: git tag -a v1.5.0 -m "Release v1.5.0"
5. Push changes: git push && git push --tags
```
### Error Cases
```
❌ No Changes Found
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
No commits found since last tag (v1.4.5).
Nothing to add to changelog.
```
```
❌ No Tags Found
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
No git tags found in this repository.
Suggestions:
- Create your first tag: git tag v0.1.0
- Or specify a commit range: /generate-changelog --since HEAD~10
- Or generate from all commits: /generate-changelog 0.1.0
```
```
⚠️ Invalid Version Format
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Version "1.5" is invalid.
Expected format: X.Y.Z (e.g., 1.5.0)
Please provide a valid semantic version.
```
## References
- Keep a Changelog: https://keepachangelog.com/
- Semantic Versioning: https://semver.org/
- Conventional Commits: https://www.conventionalcommits.org/
- Project Conventions: See CLAUDE.md for commit message standards

View File

@@ -1,129 +0,0 @@
# /quality:bundle-analyze - Analyze Bundle Sizes
Analyze production bundle sizes and provide optimization recommendations. Project thresholds: 2MB warning, 5MB error.
## Tasks
### 1. Run Production Build
```bash
# Clean previous build
rm -rf dist/
# Build for production
npm run build-prod
```
### 2. Analyze Bundle Output
```bash
# List bundle files with sizes
ls -lh dist/apps/isa-app/browser/*.js | awk '{print $9, $5}'
# Get total bundle size
du -sh dist/apps/isa-app/browser/
```
### 3. Identify Large Files
Parse build output and identify:
- Main bundle size
- Lazy-loaded chunk sizes
- Vendor chunks
- Files exceeding thresholds:
- **Warning**: > 2MB
- **Error**: > 5MB
### 4. Analyze Dependencies
```bash
# Check for duplicate dependencies
npm ls --depth=0 | grep -E "UNMET|deduped"
# Show largest node_modules packages
du -sh node_modules/* | sort -rh | head -20
```
### 5. Source Map Analysis
Use source maps to identify large contributors:
```bash
# Install source-map-explorer if needed
npm install -g source-map-explorer
# Analyze main bundle
source-map-explorer dist/apps/isa-app/browser/main.*.js
```
### 6. Generate Recommendations
Based on analysis, provide actionable recommendations:
**If bundle > 2MB:**
- Identify heavy dependencies to replace or remove
- Suggest lazy loading opportunities
- Check for unused imports
**Code Splitting Opportunities:**
- Large feature modules that could be lazy-loaded
- Heavy libraries that could be dynamically imported
- Vendor code that could be split into separate chunks
**Dependency Optimization:**
- Replace large libraries with smaller alternatives
- Remove unused dependencies
- Use tree-shakeable imports
**Build Configuration:**
- Enable/optimize compression
- Check for source maps in production (should be disabled)
- Verify optimization flags
### 7. Comparative Analysis
If previous build data exists:
```bash
# Compare with previous build
# (Requires manual tracking or CI/CD integration)
echo "Current build: $(du -sh dist/apps/isa-app/browser/ | awk '{print $1}')"
```
### 8. Generate Report
Create formatted report with:
- Total bundle size with threshold status (✅ < 2MB, ⚠️ 2-5MB, ❌ > 5MB)
- Main bundle and largest chunks
- Top 10 largest dependencies
- Optimization recommendations prioritized by impact
- Lazy loading opportunities
## Output Format
```
Bundle Analysis Report
======================
Total Size: X.XX MB [STATUS]
Main Bundle: X.XX MB
Largest Chunks:
- chunk-name.js: X.XX MB
- ...
Largest Dependencies:
1. dependency-name: X.XX MB
...
Recommendations:
🔴 Critical (> 5MB):
- [Action items]
⚠️ Warning (2-5MB):
- [Action items]
✅ Optimization Opportunities:
- [Action items]
Lazy Loading Candidates:
- [Feature modules]
```
## Error Handling
- Build failures: Show error and suggest fixes
- Missing tools: Offer to install (source-map-explorer)
- No dist folder: Run build first
## References
- CLAUDE.md Build Configuration section
- Angular build optimization: https://angular.dev/tools/cli/build
- package.json (build-prod script)

View File

@@ -1,201 +0,0 @@
# /quality:coverage - Generate Test Coverage Report
Generate comprehensive test coverage report with recommendations for improving coverage.
## Parameters
- `library-name` (optional): Specific library to analyze. If omitted, analyzes all libraries.
## Tasks
### 1. Run Coverage Analysis
```bash
# Single library
npx nx test [library-name] --skip-nx-cache --coverage
# All libraries (if no library specified)
npm run ci # Runs all tests with coverage
```
### 2. Parse Coverage Report
Coverage output typically in:
- `coverage/libs/[domain]/[layer]/[name]/`
- Look for `coverage-summary.json` or text output
Extract metrics:
- **Line coverage**: % of executable lines tested
- **Branch coverage**: % of conditional branches tested
- **Function coverage**: % of functions called in tests
- **Statement coverage**: % of statements executed
### 3. Identify Uncovered Code
Parse coverage report to find:
- **Uncovered files**: Files with 0% coverage
- **Partially covered files**: < 80% coverage
- **Uncovered lines**: Specific line numbers not tested
- **Uncovered branches**: Conditional paths not tested
```bash
# List files with coverage below 80%
# (Parse from coverage JSON output)
```
### 4. Categorize Coverage Gaps
**Critical (High Risk):**
- Service methods handling business logic
- Data transformation functions
- Error handling code paths
- Security-related functions
- State management store actions
**Important (Medium Risk):**
- Component public methods
- Utility functions
- Validators
- Pipes and filters
- Guard functions
**Low Priority:**
- Getters/setters
- Simple property assignments
- Console logging
- Type definitions
### 5. Generate Recommendations
For each coverage gap, provide:
- **File and line numbers**
- **Risk level** (Critical/Important/Low)
- **Suggested test type** (unit/integration)
- **Test approach** (example test scenario)
Example:
```
📍 libs/oms/data-access/src/lib/services/order.service.ts:45-52
🔴 Critical - Business Logic
❌ 0% coverage - Error handling path
Recommended test:
it('should handle API error when fetching order', async () => {
// Mock API to return error
// Call method
// Verify error handling
});
```
### 6. Calculate Coverage Trends
If historical data available:
- Compare with previous coverage percentage
- Show improvement/regression
- Identify files with declining coverage
### 7. Generate HTML Report
```bash
# Open coverage report in browser (if available)
open coverage/libs/[domain]/[layer]/[name]/index.html
```
### 8. Create Coverage Summary Report
**Overall Metrics:**
```
Coverage Summary for [library-name]
====================================
Line Coverage: XX.X% (XXX/XXX lines)
Branch Coverage: XX.X% (XXX/XXX branches)
Function Coverage: XX.X% (XXX/XXX functions)
Statement Coverage: XX.X% (XXX/XXX statements)
Target: 80% (Recommended minimum)
Status: ✅ Met / ⚠️ Below Target / 🔴 Critical
```
**Files Needing Attention:**
```
🔴 Critical (< 50% coverage):
1. service-name.service.ts - 35% (business logic)
2. data-processor.ts - 42% (transformations)
⚠️ Below Target (50-79% coverage):
3. component-name.component.ts - 68%
4. validator.ts - 72%
✅ Well Covered (≥ 80% coverage):
- Other files maintaining good coverage
```
**Top Priority Tests to Add:**
1. [File:Line] - [Description] - [Risk Level]
2. ...
### 9. Framework-Specific Notes
**Vitest:**
- Coverage provider: v8 or istanbul
- Config in `vitest.config.ts`
- Coverage thresholds configurable
**Jest:**
- Coverage collected via `--coverage` flag
- Config in `jest.config.ts`
- Coverage directory: `coverage/`
### 10. Set Coverage Thresholds (Optional)
Suggest adding to test config:
```typescript
// vitest.config.ts
coverage: {
thresholds: {
lines: 80,
functions: 80,
branches: 80,
statements: 80
}
}
```
## Output Format
```
Test Coverage Report
====================
Library: [name]
Test Framework: [Vitest/Jest]
Generated: [timestamp]
📊 Coverage Metrics
-------------------
Lines: XX.X% ████████░░ (XXX/XXX)
Branches: XX.X% ███████░░░ (XXX/XXX)
Functions: XX.X% █████████░ (XXX/XXX)
Statements: XX.X% ████████░░ (XXX/XXX)
🎯 Target: 80% | Status: [✅/⚠️/🔴]
🔍 Coverage Gaps
----------------
[Categorized list with priorities]
💡 Recommendations
------------------
[Prioritized list of tests to add]
📈 Next Steps
-------------
1. Focus on critical coverage gaps first
2. Add tests for business logic in [files]
3. Consider setting coverage thresholds
4. Re-run: npx nx test [library-name] --skip-nx-cache --coverage
```
## Error Handling
- No coverage data: Ensure `--coverage` flag used
- Missing library: Verify library name is correct
- Coverage tool not configured: Check test config for coverage setup
## References
- docs/guidelines/testing.md
- CLAUDE.md Testing Framework section
- Vitest coverage: https://vitest.dev/guide/coverage
- Jest coverage: https://jestjs.io/docs/configuration#collectcoverage-boolean

188
.claude/commands/quality.md Normal file
View File

@@ -0,0 +1,188 @@
---
allowed-tools: Read, Write, Edit, Bash, Grep, Glob
argument-hint: bundle | coverage [library-name] | --all
description: Analyze code quality: bundle sizes, test coverage, with optimization recommendations
---
# /quality - Code Quality Analysis
Comprehensive quality analysis including bundle sizes and test coverage.
## Subcommands
- `bundle` - Analyze production bundle sizes
- `coverage [library-name]` - Test coverage analysis
- No argument - Run both analyses
- `[library-name]` - Coverage for specific library
## Bundle Analysis
### 1. Run Production Build
```bash
# Clean previous build
rm -rf dist/
# Build for production
npm run build-prod
```
### 2. Analyze Bundle Output
```bash
# List bundle files with sizes
ls -lh dist/apps/isa-app/browser/*.js | awk '{print $9, $5}'
# Get total bundle size
du -sh dist/apps/isa-app/browser/
```
### 3. Identify Large Files
Parse build output and identify:
- Main bundle size
- Lazy-loaded chunk sizes
- Vendor chunks
- Files exceeding thresholds:
- **Warning**: > 2MB
- **Error**: > 5MB
### 4. Analyze Dependencies
```bash
# Check for duplicate dependencies
npm ls --depth=0 | grep -E "UNMET|deduped"
# Show largest node_modules packages
du -sh node_modules/* | sort -rh | head -20
```
### 5. Source Map Analysis (Optional)
```bash
# Install source-map-explorer if needed
npm install -g source-map-explorer
# Analyze main bundle
source-map-explorer dist/apps/isa-app/browser/main.*.js
```
### 6. Bundle Recommendations
**If bundle > 2MB:**
- Identify heavy dependencies to replace or remove
- Suggest lazy loading opportunities
- Check for unused imports
**Code Splitting Opportunities:**
- Large feature modules that could be lazy-loaded
- Heavy libraries that could be dynamically imported
**Dependency Optimization:**
- Replace large libraries with smaller alternatives
- Remove unused dependencies
- Use tree-shakeable imports
---
## Coverage Analysis
### 1. Run Coverage Analysis
```bash
# Single library
npx nx test [library-name] --skip-nx-cache --coverage
# All libraries (if no library specified)
npm run ci # Runs all tests with coverage
```
### 2. Parse Coverage Report
Coverage output in: `coverage/libs/[domain]/[layer]/[name]/`
Extract metrics:
- **Line coverage**: % of executable lines tested
- **Branch coverage**: % of conditional branches tested
- **Function coverage**: % of functions called in tests
- **Statement coverage**: % of statements executed
### 3. Identify Uncovered Code
Parse coverage report to find:
- **Uncovered files**: Files with 0% coverage
- **Partially covered files**: < 80% coverage
- **Uncovered lines**: Specific line numbers not tested
- **Uncovered branches**: Conditional paths not tested
### 4. Categorize Coverage Gaps
**Critical (High Risk):**
- Service methods handling business logic
- Data transformation functions
- Error handling code paths
- Security-related functions
- State management store actions
**Important (Medium Risk):**
- Component public methods
- Utility functions
- Validators and guards
**Low Priority:**
- Getters/setters
- Simple property assignments
### 5. Generate Recommendations
For each coverage gap provide:
- **File and line numbers**
- **Risk level** (Critical/Important/Low)
- **Suggested test type** (unit/integration)
- **Test approach** (example test scenario)
---
## Output Formats
### Bundle Report
```
Bundle Analysis Report
======================
Total Size: X.XX MB [STATUS]
Main Bundle: X.XX MB
Largest Chunks:
- chunk-name.js: X.XX MB
Largest Dependencies:
1. dependency-name: X.XX MB
Recommendations:
- [Prioritized action items]
```
### Coverage Report
```
Coverage Summary for [library-name]
====================================
Line Coverage: XX.X% (XXX/XXX lines)
Branch Coverage: XX.X% (XXX/XXX branches)
Function Coverage: XX.X% (XXX/XXX functions)
Target: 80% (Recommended minimum)
Status: [Met/Below Target/Critical]
Files Needing Attention:
[Categorized list with priorities]
Top Priority Tests to Add:
[Prioritized recommendations]
```
## Error Handling
- **Build failures**: Show error and suggest fixes
- **Missing tools**: Offer to install (source-map-explorer)
- **No coverage data**: Ensure `--coverage` flag used
- **Missing library**: Verify library name is correct
## References
- CLAUDE.md Build Configuration section
- docs/guidelines/testing.md
- Angular build optimization: https://angular.dev/tools/cli/build
- Vitest coverage: https://vitest.dev/guide/coverage

View File

@@ -0,0 +1,417 @@
---
name: angular-effects-alternatives
description: This skill should be used when writing Angular code with signals and effects. Use when deciding whether to use effect(), computed(), or reactive patterns for state management. Applies to all Angular components and services using signals, especially when considering effect() for state propagation, data synchronization, or reactive flows. Essential for code review of effect usage and refactoring imperative patterns to declarative alternatives.
---
# Angular Effects Alternatives
## Overview
This skill guides proper usage of Angular's `effect()` and provides declarative alternatives for common patterns. Effects are frequently misused for state propagation, leading to circular updates, maintenance issues, and violations of reactive principles. This skill prevents anti-patterns and promotes maintainable, declarative code.
## When to Use Effects (Valid Use Cases)
Effects are **primarily for rendering content that cannot be rendered through data binding**. Valid use cases are limited to:
### 1. Logging
Recording application events or debugging:
```typescript
effect(() => {
const error = this.error();
if (error) {
console.error('Error occurred:', error);
}
});
```
### 2. Canvas Painting
Custom graphics rendering (e.g., Angular Three library, Chart.js integration):
```typescript
effect(() => {
const data = this.chartData();
this.renderCanvas(data);
});
```
### 3. Custom DOM Behavior
Imperative APIs that require direct DOM manipulation:
```typescript
effect(() => {
const message = this.notificationMessage();
if (message) {
this.snackBar.open(message, 'Close');
}
});
```
**Key principle:** Data binding is the preferred way to display data. Effects should only be used when data binding is insufficient.
## Understanding Auto-Tracking
Angular automatically tracks signals accessed during effect execution, **even within called methods**:
```typescript
effect(() => {
this.logError(); // Signal tracking happens inside this method
});
logError(): void {
const error = this.error(); // This signal is automatically tracked
if (error) {
console.error(error);
}
}
```
**Implication:** Auto-tracking makes effect dependencies non-obvious and hard to maintain. This is a primary reason to avoid effects for state management.
## When NOT to Use Effects (Anti-Patterns)
### ❌ Anti-Pattern 1: State Propagation
**NEVER use effects to propagate state changes to other state:**
```typescript
// ❌ WRONG - Anti-pattern
effect(() => {
const value = this.source();
this.derived.set(value * 2);
});
```
**Problems:**
- Risk of circular updates and infinite loops
- Hard to maintain due to implicit tracking
- Violates declarative reactive principles
- Inappropriate glitch-free semantics
### ❌ Anti-Pattern 2: Synchronizing Signals
```typescript
// ❌ WRONG - Anti-pattern
effect(() => {
const filter = this.filter();
this.loadData(filter);
});
```
### ❌ Anti-Pattern 3: Event Emulation
```typescript
// ❌ WRONG - Anti-pattern
effect(() => {
const count = this.itemCount();
this.countChanged.emit(count);
});
```
**Why signals ≠ events:** Signals are designed to be glitch-free, collapsing multiple updates. This makes them inappropriate for representing discrete events.
## Decision Tree: Effect vs Alternative
```
Need to react to signal changes?
├─ Synchronous derivation?
│ └─ ✅ Use computed()
├─ Asynchronous derivation?
│ └─ ✅ Use Resource API
├─ Complex reactive flow with race conditions?
│ └─ ✅ Use RxJS (toObservable + operators + toSignal)
├─ Event-based trigger (not state change)?
│ └─ ✅ React to event directly, not signal
├─ Need RxJS operators with signals?
│ └─ ✅ Use reactive helpers (rxMethod, deriveAsync)
└─ Rendering non-data-bound content (logging, canvas, imperative API)?
└─ ✅ Use effect()
```
## Recommended Alternatives
### Alternative 1: Use `computed()` for Synchronous Derivations
**When to use:** Deriving new state synchronously from existing signals.
```typescript
// ✅ CORRECT - Declarative
const derived = computed(() => {
return this.baseSignal() * 2;
});
const fullName = computed(() => {
return `${this.firstName()} ${this.lastName()}`;
});
```
**Benefits:**
- Declarative and maintainable
- Automatic dependency tracking
- Memoized and efficient
- No risk of circular updates
### Alternative 2: Use Resource API for Asynchronous Derivations
**When to use:** Loading data based on reactive parameters.
```typescript
// ✅ CORRECT - Declarative async state
readonly itemsResource = resource({
params: this.filter,
loader: ({ params, abortSignal }) => {
return this.dataService.load(params, abortSignal);
}
});
readonly items = computed(() => this.itemsResource.value() ?? []);
```
**Benefits:**
- Automatic race condition handling
- Built-in loading/error states
- Declarative parameter tracking
- Cancellation support
**See also:** `ngrx-resource-api` skill for detailed Resource API patterns.
### Alternative 3: React to Events, Not State Changes
**When to use:** User interactions or DOM events should trigger actions.
```typescript
// ❌ WRONG - Reacting to signal change
effect(() => {
const searchTerm = this.searchTerm();
this.search(searchTerm);
});
// ✅ CORRECT - React to event
<input (input)="search($event.target.value)" />
// Component
search(term: string): void {
this.searchTerm.set(term);
this.performSearch(term);
}
```
**Benefits:**
- Clear causality (event → action)
- No auto-tracking complexity
- Explicit control flow
### Alternative 4: RxJS Integration
**When to use:** Complex reactive flows requiring operators like `debounceTime`, `switchMap`, `combineLatest`.
```typescript
// ✅ CORRECT - RxJS for complex flows
readonly searchTerm = signal('');
readonly searchTerm$ = toObservable(this.searchTerm);
readonly results$ = this.searchTerm$.pipe(
debounceTime(300),
distinctUntilChanged(),
switchMap(term => this.searchService.search(term))
);
readonly results = toSignal(this.results$, { initialValue: [] });
```
**Benefits:**
- Full RxJS operator ecosystem
- Race condition prevention (`switchMap`)
- Powerful composition
- Type-safe streams
**Pattern:** Signal → Observable (toObservable) → RxJS operators → Signal (toSignal)
### Alternative 5: Reactive Helpers
**When to use:** Need RxJS operators but prefer signal-centric API.
#### Using `rxMethod` (NgRx Signal Store)
```typescript
readonly loadItem = rxMethod<number>(
pipe(
tap(() => patchState(this, { loading: true })),
switchMap(id => this.service.findById(id)),
tap(item => patchState(this, { item, loading: false }))
)
);
// Call with signal or value
constructor() {
this.loadItem(this.selectedId);
}
```
#### Using `deriveAsync` (ngxtension)
```typescript
readonly data = deriveAsync(() => {
const filter = this.filter();
return this.service.load(filter);
});
```
**Benefits:**
- Signal-friendly API
- RxJS operator support
- Cleaner than manual Observable conversion
- Automatic subscription management
## The `explicitEffect` Consideration
Some libraries provide `explicitEffect` to restrict auto-tracking:
```typescript
// Uses untracked() internally to limit tracking
explicitEffect(this.id, (id) => {
this.store.load(id);
});
```
**Evaluation:**
- ✅ Mitigates auto-tracking drawbacks
- ✅ Makes dependencies explicit
- ❌ Still imperative (not declarative)
- ❌ Doesn't solve circular update risks
- ❌ Less idiomatic than reactive alternatives
**Recommendation:** Prefer declarative patterns (computed, Resource API, RxJS) over `explicitEffect`.
## Common Refactoring Patterns
### Pattern 1: Effect for State Sync → computed()
```typescript
// ❌ Before
effect(() => {
const x = this.x();
const y = this.y();
this.sum.set(x + y);
});
// ✅ After
readonly sum = computed(() => this.x() + this.y());
```
### Pattern 2: Effect for Async Load → Resource API
```typescript
// ❌ Before
effect(() => {
const id = this.selectedId();
this.loadItem(id);
});
// ✅ After
readonly itemResource = resource({
params: this.selectedId,
loader: ({ params }) => this.service.loadItem(params)
});
```
### Pattern 3: Effect for Debounced Search → RxJS
```typescript
// ❌ Before
effect(() => {
const term = this.searchTerm();
// No way to debounce within effect
this.search(term);
});
// ✅ After
readonly searchTerm$ = toObservable(this.searchTerm);
readonly results = toSignal(
this.searchTerm$.pipe(
debounceTime(300),
switchMap(term => this.searchService.search(term))
),
{ initialValue: [] }
);
```
### Pattern 4: Effect for Event Notification → Direct Event Handling
```typescript
// ❌ Before
effect(() => {
const value = this.value();
this.valueChange.emit(value);
});
// ✅ After
updateValue(newValue: string): void {
this.value.set(newValue);
this.valueChange.emit(newValue);
}
```
## Code Review Checklist
When reviewing code with `effect()`, ask:
- [ ] Is this for rendering non-data-bound content? (logging, canvas, imperative APIs)
- **YES:** Effect is appropriate
- **NO:** Continue checklist
- [ ] Is this synchronous state derivation?
- **YES:** Use `computed()` instead
- [ ] Is this asynchronous data loading?
- **YES:** Use Resource API instead
- [ ] Does this need RxJS operators (debounce, switchMap, etc.)?
- **YES:** Use RxJS integration or reactive helpers instead
- [ ] Is this reacting to a user event?
- **YES:** Handle event directly instead
- [ ] Could this cause circular updates?
- **YES:** Refactor immediately - this will cause bugs
## Anti-Pattern Detection Rules
Flag any effect that:
1. **Calls `set()` or `update()` on signals** - Likely state propagation anti-pattern
2. **Calls service methods that update state** - Hidden state propagation
3. **Emits events based on signal changes** - Signal/event semantic mismatch
4. **Has try/catch for async operations** - Should use Resource API
5. **Would benefit from debouncing/throttling** - Should use RxJS
## Migration Strategy
When converting effects to alternatives:
1. **Identify effect purpose** - State derivation? Async load? Event handling?
2. **Choose appropriate alternative** - Use decision tree above
3. **Implement replacement** - Follow patterns in this skill
4. **Test thoroughly** - Ensure reactive flow works correctly
5. **Remove effect** - Clean up unused code
## Key Principles
1. **Effects are for side effects, not state management**
2. **Prefer declarative over imperative**
3. **Use computed() for sync, Resource API for async**
4. **React to events, not state changes**
5. **RxJS for complex reactive flows**
6. **Auto-tracking is powerful but opaque - avoid when possible**
## When in Doubt
Ask: "Can the user see this without an effect using data binding?"
- **YES:** Don't use effect, use data binding
- **NO:** Effect might be appropriate (but verify against decision tree)

View File

@@ -15,6 +15,11 @@ Guide for modern Angular 20+ template patterns: control flow, lazy loading, proj
- Designing reusable components with `ng-content`
- Template performance optimization
**Related Skills:** These skills work together when writing Angular templates:
- **[html-template](../html-template/SKILL.md)** - E2E testing attributes (`data-what`, `data-which`) and ARIA accessibility
- **[tailwind](../tailwind/SKILL.md)** - ISA design system styling (colors, typography, spacing, layout)
- **[logging](../logging/SKILL.md)** - MANDATORY logging in all Angular files using `@isa/core/logging`
## Control Flow (Angular 17+)
### @if / @else if / @else
@@ -211,7 +216,7 @@ Groups elements without DOM footprint:
1. **Use signals:** `isExpanded = signal(false)`
2. **Prefer control flow over directives:** Use `@if` not `*ngIf`
3. **Keep expressions simple:** Use `computed()` for complex logic
4. **E2E attributes:** Always add `[attr.data-what]` and `[attr.data-which]`
4. **Testing & Accessibility:** Always add E2E and ARIA attributes (see **[html-template](../html-template/SKILL.md)** skill)
5. **Track expressions:** Required in `@for`, use unique IDs
## Migration

View File

@@ -1,6 +1,6 @@
---
name: api-change-analyzer
description: This skill should be used when analyzing Swagger/OpenAPI specification changes BEFORE regenerating API clients. It compares old vs new specs, categorizes changes as breaking/compatible/warnings, finds affected code, and generates migration strategies. Use this skill when the user wants to check API changes safely before sync, mentions "check breaking changes", or needs impact assessment.
description: This skill should be used when checking for breaking changes before API regeneration, assessing backend API update impact, or user mentions "check breaking changes", "API diff", "impact assessment". Analyzes Swagger/OpenAPI spec changes, categorizes as breaking/compatible/warnings, and provides migration strategies.
---
# API Change Analyzer

View File

@@ -0,0 +1,171 @@
---
name: architecture-documentation
description: Generate architecture documentation (C4, Arc42, ADRs, PlantUML). Auto-invoke when user mentions "architecture docs", "C4 model", "ADR", "document architecture", "system design", or "create architecture diagram".
---
# Architecture Documentation Skill
Generate comprehensive architecture documentation using modern frameworks and best practices.
## When to Use
- Creating or updating architecture documentation
- Generating C4 model diagrams (Context, Container, Component, Code)
- Writing Architecture Decision Records (ADRs)
- Documenting system design and component relationships
- Creating PlantUML or Mermaid diagrams
## Available Frameworks
### C4 Model
Best for: Visualizing software architecture at different abstraction levels
Levels:
1. **Context** - System landscape and external actors
2. **Container** - High-level technology choices (apps, databases, etc.)
3. **Component** - Internal structure of containers
4. **Code** - Class/module level detail (optional)
See: `@references/c4-model.md` for patterns and examples
### Arc42 Template
Best for: Comprehensive architecture documentation
Sections:
1. Introduction and Goals
2. Constraints
3. Context and Scope
4. Solution Strategy
5. Building Block View
6. Runtime View
7. Deployment View
8. Cross-cutting Concepts
9. Architecture Decisions
10. Quality Requirements
11. Risks and Technical Debt
12. Glossary
See: `@references/arc42.md` for template structure
### Architecture Decision Records (ADRs)
Best for: Documenting individual architectural decisions
See: `@references/adr-template.md` for format and examples
## Workflow
### 1. Discovery Phase
```bash
# Find existing architecture files
find . -name "*architecture*" -o -name "*.puml" -o -name "*.mmd"
# Identify service boundaries
cat nx.json docker-compose.yml
# Check for existing ADRs
ls -la docs/adr/ docs/decisions/
```
### 2. Analysis Phase
- Analyze codebase structure (`libs/`, `apps/`)
- Identify dependencies from `tsconfig.base.json` paths
- Review service boundaries from `project.json` tags
- Map data flow from API definitions
### 3. Documentation Phase
Based on the request, create appropriate documentation:
**For C4 diagrams:**
```
docs/architecture/
├── c4-context.puml
├── c4-container.puml
└── c4-component-[name].puml
```
**For ADRs:**
```
docs/adr/
├── 0001-record-architecture-decisions.md
├── 0002-[decision-title].md
└── template.md
```
**For Arc42:**
```
docs/architecture/
└── arc42/
├── 01-introduction.md
├── 02-constraints.md
└── ...
```
## ISA-Frontend Specific Context
### Monorepo Structure
- **apps/**: Angular applications
- **libs/**: Shared libraries organized by domain
- `libs/[domain]/feature/` - Feature modules
- `libs/[domain]/data-access/` - State management
- `libs/[domain]/ui/` - Presentational components
- `libs/[domain]/util/` - Utilities
### Key Architectural Patterns
- **Nx Monorepo** with strict module boundaries
- **NgRx Signal Store** for state management
- **Standalone Components** (Angular 20+)
- **Domain-Driven Design** library organization
### Documentation Locations
- ADRs: `docs/adr/`
- Architecture diagrams: `docs/architecture/`
- API documentation: Generated from Swagger/OpenAPI
## Output Standards
### PlantUML Format
```plantuml
@startuml C4_Context
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Context.puml
Person(user, "User", "System user")
System(system, "ISA System", "Main application")
System_Ext(external, "External API", "Third-party service")
Rel(user, system, "Uses")
Rel(system, external, "Calls")
@enduml
```
### Mermaid Format
```mermaid
graph TD
A[User] --> B[ISA App]
B --> C[API Gateway]
C --> D[Backend Services]
```
### ADR Format
```markdown
# ADR-XXXX: [Title]
## Status
[Proposed | Accepted | Deprecated | Superseded]
## Context
[What is the issue?]
## Decision
[What was decided?]
## Consequences
[What are the results?]
```
## Best Practices
1. **Start with Context** - Always begin with C4 Level 1 (System Context)
2. **Use Consistent Notation** - Stick to one diagramming tool/format
3. **Keep ADRs Atomic** - One decision per ADR
4. **Version Control** - Commit documentation with code changes
5. **Review Regularly** - Architecture docs decay; schedule reviews

View File

@@ -0,0 +1,213 @@
# Architecture Decision Record (ADR) Template
## Overview
Architecture Decision Records document significant architectural decisions along with their context and consequences.
## ADR Format
### Standard Template
```markdown
# ADR-XXXX: [Short Title]
## Status
[Proposed | Accepted | Deprecated | Superseded by ADR-YYYY]
## Date
YYYY-MM-DD
## Context
What is the issue that we're seeing that is motivating this decision or change?
## Decision
What is the change that we're proposing and/or doing?
## Consequences
### Positive
- Benefit 1
- Benefit 2
### Negative
- Drawback 1
- Drawback 2
### Neutral
- Side effect 1
## Alternatives Considered
### Option 1: [Name]
- Pros: ...
- Cons: ...
- Why rejected: ...
### Option 2: [Name]
- Pros: ...
- Cons: ...
- Why rejected: ...
## References
- [Link to related documentation]
- [Link to discussion thread]
```
## Example ADRs
### ADR-0001: Use Nx Monorepo
```markdown
# ADR-0001: Use Nx Monorepo for Project Organization
## Status
Accepted
## Date
2024-01-15
## Context
The ISA Frontend consists of multiple applications and shared libraries. We need a way to:
- Share code between applications
- Maintain consistent tooling and dependencies
- Enable efficient CI/CD with affected-based testing
- Enforce architectural boundaries
## Decision
We will use Nx as our monorepo tool with the following structure:
- `apps/` - Deployable applications
- `libs/` - Shared libraries organized by domain and type
## Consequences
### Positive
- Single version of dependencies across all projects
- Affected-based testing reduces CI time
- Consistent tooling (ESLint, Prettier, TypeScript)
- Built-in dependency graph visualization
### Negative
- Learning curve for team members new to Nx
- More complex initial setup
- All code in single repository increases clone time
### Neutral
- Requires discipline in library boundaries
- Need to maintain `project.json` and tags
## Alternatives Considered
### Polyrepo
- Pros: Simpler individual repos, independent deployments
- Cons: Dependency management nightmare, code duplication
- Why rejected: Too much overhead for code sharing
```
### ADR-0002: Adopt NgRx Signal Store
```markdown
# ADR-0002: Adopt NgRx Signal Store for State Management
## Status
Accepted
## Date
2024-03-01
## Context
We need a state management solution that:
- Integrates well with Angular signals
- Provides predictable state updates
- Supports devtools for debugging
- Has good TypeScript support
## Decision
We will use NgRx Signal Store for new features and gradually migrate existing stores.
## Consequences
### Positive
- Native signal integration
- Simpler boilerplate than classic NgRx
- Better performance with fine-grained reactivity
- Excellent TypeScript inference
### Negative
- Migration effort for existing NgRx stores
- Different patterns from classic NgRx
### Neutral
- Team needs to learn new API
## Alternatives Considered
### Classic NgRx (Store + Effects)
- Pros: Mature, well-documented
- Cons: Verbose boilerplate, doesn't leverage signals
- Why rejected: Signal Store is the future direction
### Akita
- Pros: Less boilerplate
- Cons: Not Angular-native, less community support
- Why rejected: NgRx has better Angular integration
```
## ADR Naming Convention
```
docs/adr/
├── 0000-adr-template.md # Template file
├── 0001-use-nx-monorepo.md
├── 0002-adopt-ngrx-signal-store.md
├── 0003-standalone-components.md
└── README.md # Index of all ADRs
```
## ADR Index Template
```markdown
# Architecture Decision Records
This directory contains Architecture Decision Records (ADRs) for the ISA Frontend.
## Index
| ADR | Title | Status | Date |
|-----|-------|--------|------|
| [0001](0001-use-nx-monorepo.md) | Use Nx Monorepo | Accepted | 2024-01-15 |
| [0002](0002-adopt-ngrx-signal-store.md) | Adopt NgRx Signal Store | Accepted | 2024-03-01 |
| [0003](0003-standalone-components.md) | Migrate to Standalone Components | Accepted | 2024-04-01 |
## Process
1. Copy `0000-adr-template.md` to `XXXX-short-title.md`
2. Fill in the template
3. Submit PR for review
4. Update status once decided
5. Update this index
```
## Best Practices
1. **One decision per ADR** - Keep ADRs focused
2. **Number sequentially** - Never reuse numbers
3. **Record context** - Why was this needed?
4. **Document alternatives** - Show what was considered
5. **Keep concise** - 1-2 pages max
6. **Update status** - Mark deprecated decisions
7. **Link related ADRs** - Reference superseding decisions
8. **Review regularly** - Quarterly ADR review meetings
## When to Write an ADR
Write an ADR when:
- Choosing a framework or library
- Defining code organization patterns
- Setting up infrastructure
- Establishing conventions
- Making trade-offs that affect multiple teams
Don't write an ADR for:
- Small implementation details
- Obvious choices with no alternatives
- Temporary solutions

View File

@@ -0,0 +1,268 @@
# Arc42 Architecture Documentation Template
## Overview
Arc42 is a template for architecture documentation with 12 sections covering all aspects of software architecture.
## Template Structure
### 1. Introduction and Goals
```markdown
# 1. Introduction and Goals
## 1.1 Requirements Overview
- Core business requirements driving the architecture
- Key functional requirements
- Quality goals and priorities
## 1.2 Quality Goals
| Priority | Quality Goal | Description |
|----------|-------------|-------------|
| 1 | Performance | < 200ms response time |
| 2 | Usability | Intuitive for store employees |
| 3 | Reliability | 99.9% uptime during store hours |
## 1.3 Stakeholders
| Role | Expectations |
|------|-------------|
| Store Employee | Fast, reliable daily operations |
| IT Operations | Easy deployment and monitoring |
| Development Team | Maintainable, testable code |
```
### 2. Architecture Constraints
```markdown
# 2. Architecture Constraints
## 2.1 Technical Constraints
| Constraint | Background |
|------------|------------|
| Angular 20+ | Company standard frontend framework |
| TypeScript strict | Type safety requirement |
| Browser support | Chrome 90+, Edge 90+ |
## 2.2 Organizational Constraints
| Constraint | Background |
|------------|------------|
| Monorepo | Nx-based shared codebase |
| CI/CD | Azure DevOps pipelines |
| Code review | All changes require PR approval |
## 2.3 Conventions
- Conventional commits
- ESLint/Prettier formatting
- Component-driven development
```
### 3. System Scope and Context
```markdown
# 3. System Scope and Context
## 3.1 Business Context
[C4 Level 1 - System Context Diagram]
| Neighbor | Description |
|----------|-------------|
| Store Employee | Primary user performing daily operations |
| Backend APIs | Provides business logic and data |
| Printer Service | Label and receipt printing |
## 3.2 Technical Context
[Deployment/Network Diagram]
| Interface | Protocol | Description |
|-----------|----------|-------------|
| REST API | HTTPS/JSON | Backend communication |
| WebSocket | WSS | Real-time updates |
| OAuth2 | HTTPS | Authentication |
```
### 4. Solution Strategy
```markdown
# 4. Solution Strategy
## Key Architectural Decisions
| Decision | Rationale |
|----------|-----------|
| Angular SPA | Rich interactive UI, offline capability |
| NgRx Signal Store | Predictable state management |
| Nx Monorepo | Code sharing, consistent tooling |
| Standalone Components | Better tree-shaking, simpler imports |
## Quality Achievement Strategies
| Quality Goal | Approach |
|--------------|----------|
| Performance | Lazy loading, caching, code splitting |
| Maintainability | Domain-driven library structure |
| Testability | Component isolation, dependency injection |
```
### 5. Building Block View
```markdown
# 5. Building Block View
## Level 1: Application Overview
[C4 Container Diagram]
## Level 2: Domain Decomposition
| Domain | Purpose | Libraries |
|--------|---------|-----------|
| CRM | Customer management | crm-feature-*, crm-data-access-* |
| OMS | Order management | oms-feature-*, oms-data-access-* |
| Checkout | Transactions | checkout-feature-*, checkout-data-access-* |
## Level 3: Feature Details
[C4 Component Diagrams per domain]
```
### 6. Runtime View
```markdown
# 6. Runtime View
## Scenario 1: User Login
```mermaid
sequenceDiagram
User->>App: Open application
App->>Auth: Redirect to login
Auth->>App: Return token
App->>API: Fetch user profile
API->>App: User data
App->>User: Display dashboard
```
## Scenario 2: Order Processing
[Sequence diagram for order flow]
```
### 7. Deployment View
```markdown
# 7. Deployment View
## Infrastructure
```mermaid
graph TD
CDN[CDN] --> Browser[User Browser]
Browser --> LB[Load Balancer]
LB --> API[API Gateway]
API --> Services[Backend Services]
```
## Environments
| Environment | URL | Purpose |
|-------------|-----|---------|
| Development | dev.isa.local | Local development |
| Staging | staging.isa.com | Integration testing |
| Production | isa.com | Live system |
```
### 8. Cross-cutting Concepts
```markdown
# 8. Cross-cutting Concepts
## 8.1 Domain Model
[Domain entity relationships]
## 8.2 Security
- Authentication: OAuth2/OIDC
- Authorization: Role-based access control
- Data protection: HTTPS, encrypted storage
## 8.3 Error Handling
- Global error interceptor
- User-friendly error messages
- Error logging to backend
## 8.4 Logging
- @isa/core/logging library
- Structured log format
- Log levels: trace, debug, info, warn, error
```
### 9. Architecture Decisions
```markdown
# 9. Architecture Decisions
See [ADR folder](../adr/) for detailed decision records.
## Key Decisions
- ADR-0001: Use Nx Monorepo
- ADR-0002: Adopt NgRx Signal Store
- ADR-0003: Migrate to Standalone Components
```
### 10. Quality Requirements
```markdown
# 10. Quality Requirements
## Quality Tree
```
Quality
├── Performance
│ ├── Response Time < 200ms
│ └── Time to Interactive < 3s
├── Reliability
│ ├── Uptime 99.9%
│ └── Graceful degradation
└── Maintainability
├── Test coverage > 80%
└── Clear module boundaries
```
## Quality Scenarios
| Scenario | Measure | Target |
|----------|---------|--------|
| Page load | Time to interactive | < 3s |
| API call | Response time | < 200ms |
| Build | CI pipeline duration | < 10min |
```
### 11. Risks and Technical Debt
```markdown
# 11. Risks and Technical Debt
## Identified Risks
| Risk | Probability | Impact | Mitigation |
|------|-------------|--------|------------|
| Backend unavailable | Medium | High | Offline mode |
| Performance degradation | Low | Medium | Monitoring |
## Technical Debt
| Item | Priority | Effort |
|------|----------|--------|
| Legacy Jest tests | Medium | High |
| Any types in codebase | High | Medium |
```
### 12. Glossary
```markdown
# 12. Glossary
| Term | Definition |
|------|------------|
| ADR | Architecture Decision Record |
| C4 | Context, Container, Component, Code model |
| ISA | In-Store Application |
| SPA | Single Page Application |
```
## Best Practices
1. **Start with sections 1-4** - Goals, constraints, context, strategy
2. **Add diagrams to section 5** - Building block views
3. **Document decisions in section 9** - Link to ADRs
4. **Keep updated** - Review quarterly
5. **Use templates** - Consistent formatting

View File

@@ -0,0 +1,163 @@
# C4 Model Reference
## Overview
The C4 model provides a way to visualize software architecture at four levels of abstraction:
1. **Context** - System landscape
2. **Container** - Applications and data stores
3. **Component** - Internal structure
4. **Code** - Class/module detail (optional)
## Level 1: System Context Diagram
Shows the system under design and its relationships with users and external systems.
### PlantUML Template
```plantuml
@startuml C4_Context
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Context.puml
LAYOUT_WITH_LEGEND()
title System Context Diagram - ISA Frontend
Person(user, "Store Employee", "Uses the ISA application")
Person(admin, "Administrator", "Manages system configuration")
System(isa, "ISA Frontend", "Angular application for in-store operations")
System_Ext(backend, "ISA Backend", "REST API services")
System_Ext(auth, "Auth Provider", "Authentication service")
System_Ext(printer, "Printer Service", "Receipt/label printing")
Rel(user, isa, "Uses", "Browser")
Rel(admin, isa, "Configures", "Browser")
Rel(isa, backend, "API calls", "HTTPS/JSON")
Rel(isa, auth, "Authenticates", "OAuth2")
Rel(isa, printer, "Prints", "WebSocket")
@enduml
```
### Key Elements
- **Person**: Human users of the system
- **System**: The system being documented (highlighted)
- **System_Ext**: External systems the system depends on
- **Rel**: Relationships between elements
## Level 2: Container Diagram
Shows the high-level technology choices and how containers communicate.
### PlantUML Template
```plantuml
@startuml C4_Container
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Container.puml
LAYOUT_WITH_LEGEND()
title Container Diagram - ISA Frontend
Person(user, "Store Employee")
System_Boundary(isa, "ISA Frontend") {
Container(spa, "SPA", "Angular 20", "Single-page application")
Container(pwa, "Service Worker", "Workbox", "Offline capability")
ContainerDb(storage, "Local Storage", "IndexedDB", "Offline data cache")
}
System_Ext(api, "ISA API Gateway")
System_Ext(cdn, "CDN", "Static assets")
Rel(user, spa, "Uses", "Browser")
Rel(spa, pwa, "Registers")
Rel(pwa, storage, "Caches data")
Rel(spa, api, "API calls", "REST/JSON")
Rel(spa, cdn, "Loads assets", "HTTPS")
@enduml
```
### Container Types
- **Container**: Application or service
- **ContainerDb**: Database or data store
- **ContainerQueue**: Message queue
## Level 3: Component Diagram
Shows the internal structure of a container.
### PlantUML Template
```plantuml
@startuml C4_Component
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Component.puml
LAYOUT_WITH_LEGEND()
title Component Diagram - OMS Feature Module
Container_Boundary(oms, "OMS Feature") {
Component(list, "Order List", "Angular Component", "Displays orders")
Component(detail, "Order Detail", "Angular Component", "Order management")
Component(store, "Order Store", "NgRx Signal Store", "State management")
Component(api, "Order API Service", "Angular Service", "API communication")
}
ContainerDb_Ext(backend, "OMS Backend API")
Rel(list, store, "Reads state")
Rel(detail, store, "Reads/writes state")
Rel(store, api, "Fetches data")
Rel(api, backend, "HTTP requests")
@enduml
```
## ISA-Frontend Domain Components
### Suggested Component Structure
```
libs/[domain]/
├── feature/ → Component diagrams
│ └── [feature]/
├── data-access/ → Store/API components
│ └── [store]/
├── ui/ → Presentational components
│ └── [component]/
└── util/ → Utility components
└── [util]/
```
### Domain Boundaries
- **CRM**: Customer management, loyalty
- **OMS**: Order management, returns
- **Checkout**: Payment, transactions
- **Remission**: Product returns processing
- **Catalogue**: Product information
## Mermaid Alternative
```mermaid
C4Context
title System Context - ISA Frontend
Person(user, "Store Employee", "Daily operations")
System(isa, "ISA Frontend", "Angular SPA")
System_Ext(backend, "Backend Services")
System_Ext(auth, "Auth Service")
Rel(user, isa, "Uses")
Rel(isa, backend, "API calls")
Rel(isa, auth, "Authenticates")
```
## Best Practices
1. **One diagram per level** - Don't mix abstraction levels
2. **Consistent naming** - Use same names across diagrams
3. **Show key relationships** - Not every possible connection
4. **Include legends** - Explain notation
5. **Keep it simple** - 5-20 elements per diagram max

View File

@@ -1,6 +1,6 @@
---
name: architecture-enforcer
description: This skill should be used when validating import boundaries and architectural rules in the ISA-Frontend monorepo. It checks for circular dependencies, layer violations (Feature→Feature), domain violations (OMS→Remission), and relative imports. Use this skill when the user wants to check architecture, mentions "validate boundaries", "check imports", or needs dependency analysis.
description: This skill should be used when checking architecture compliance, validating layer boundaries (Feature→Feature violations), detecting circular dependencies, or user mentions "check architecture", "validate boundaries", "check imports". Validates import boundaries and architectural rules in ISA-Frontend monorepo.
---
# Architecture Enforcer

View File

@@ -1,6 +1,6 @@
---
name: circular-dependency-resolver
description: This skill should be used when detecting and resolving circular dependencies in the ISA-Frontend monorepo. It uses graph algorithms to find A→B→C→A cycles, categorizes by severity, provides multiple fix strategies (DI, interface extraction, shared code), and validates fixes. Use this skill when the user mentions "circular dependencies", "dependency cycles", or has build/runtime issues from circular imports.
description: This skill should be used when build fails with circular import warnings, user mentions "circular dependencies" or "dependency cycles", or fixing A→B→C→A import cycles. Detects and resolves circular dependencies using graph algorithms with DI, interface extraction, and shared code fix strategies.
---
# Circular Dependency Resolver

View File

@@ -0,0 +1,392 @@
---
name: css-keyframes-animations
description: This skill should be used when writing or reviewing CSS animations in Angular components. Use when creating entrance/exit animations, implementing @keyframes instead of @angular/animations, applying timing functions and fill modes, creating staggered animations, or ensuring GPU-accelerated performance. Essential for modern Angular 20+ components using animate.enter/animate.leave directives and converting legacy Angular animations to native CSS.
---
# CSS @keyframes Animations
## Overview
Implement native CSS @keyframes animations for Angular applications, replacing @angular/animations with GPU-accelerated, zero-bundle-size alternatives. This skill provides comprehensive guidance on creating performant entrance/exit animations, staggered effects, and proper timing configurations.
## When to Use This Skill
Apply this skill when:
- **Writing Angular components** with entrance/exit animations
- **Converting @angular/animations** to native CSS @keyframes
- **Implementing animate.enter/animate.leave** in Angular 20+ templates
- **Creating staggered animations** for lists or collections
- **Debugging animation issues** (snap-back, wrong starting positions, choppy playback)
- **Optimizing animation performance** for GPU acceleration
- **Reviewing animation code** for accessibility and best practices
## Quick Start
### Basic Animation Setup
1. **Define @keyframes** in component CSS:
```css
@keyframes fadeIn {
from { opacity: 0; }
to { opacity: 1; }
}
```
2. **Apply animation** to element:
```css
.element {
animation: fadeIn 0.3s ease-out;
}
```
3. **Use with Angular 20+ directives**:
```html
@if (visible()) {
<div animate.enter="fade-in" animate.leave="fade-out">
Content
</div>
}
```
### Common Pitfall: Element Snaps Back
**Problem:** Element returns to original state after animation completes.
**Solution:** Add `forwards` fill mode:
```css
.element {
animation: fadeOut 1s forwards;
}
```
### Common Pitfall: Animation Conflicts with State Transitions
**Problem:** Entrance animation overrides initial state transforms (e.g., stacked cards appear unstacked then jump).
**Solution:** Animate only properties that don't conflict with state. Use opacity-only animations when transforms are state-driven:
```css
/* BAD: Overrides stacked transform */
@keyframes cardEntrance {
from { transform: translateY(20px); opacity: 0; }
to { transform: translateY(0); opacity: 1; }
}
/* GOOD: Only animates opacity, allows state transforms to apply */
@keyframes cardEntrance {
from { opacity: 0; }
to { opacity: 1; }
}
```
## Core Principles
### 1. GPU-Accelerated Properties Only
**Always use** for animations:
- `transform` (translate, rotate, scale)
- `opacity`
**Avoid animating** (triggers layout recalculation):
- `width`, `height`
- `top`, `left`, `right`, `bottom`
- `margin`, `padding`
- `font-size`
### 2. Fill Modes
| Fill Mode | Behavior | Use Case |
|-----------|----------|----------|
| `forwards` | Keep end state | Exit animations (stay invisible) |
| `backwards` | Apply start state during delay | Entrance with delay (prevent flash) |
| `both` | Both of above | Complex sequences |
### 3. Timing Functions
Choose appropriate easing for animation type:
```css
/* Entrance animations - ease-out (fast start, slow end) */
animation-timing-function: cubic-bezier(0, 0, 0.58, 1);
/* Exit animations - ease-in (slow start, fast end) */
animation-timing-function: cubic-bezier(0.42, 0, 1, 1);
/* Bouncy overshoot effect */
animation-timing-function: cubic-bezier(0.34, 1.56, 0.64, 1);
```
Tool: [cubic-bezier.com](https://cubic-bezier.com) for custom curves.
### 4. Staggered Animations
Create cascading effects using CSS custom properties:
**Template:**
```html
@for (item of items(); track item.id; let idx = $index) {
<div [style.--i]="idx" class="stagger-item">
{{ item.name }}
</div>
}
```
**CSS:**
```css
.stagger-item {
animation: fadeSlideIn 0.5s ease-out backwards;
animation-delay: calc(var(--i, 0) * 100ms);
}
```
### 5. Accessibility
Always respect reduced motion preferences:
```css
@media (prefers-reduced-motion: reduce) {
.animated {
animation: none;
/* Or use simpler, faster animation */
animation-duration: 0.1s;
}
}
```
## Common Animation Patterns
### Fade Entrance/Exit
```css
@keyframes fadeIn {
from { opacity: 0; }
to { opacity: 1; }
}
@keyframes fadeOut {
from { opacity: 1; }
to { opacity: 0; }
}
.fade-in { animation: fadeIn 0.3s ease-out; }
.fade-out { animation: fadeOut 0.3s ease-in forwards; }
```
### Slide Entrance
```css
@keyframes slideInUp {
from {
opacity: 0;
transform: translateY(20px);
}
to {
opacity: 1;
transform: translateY(0);
}
}
.slide-in-up { animation: slideInUp 0.3s ease-out; }
```
### Scale Entrance
```css
@keyframes scaleIn {
from {
opacity: 0;
transform: scale(0.9);
}
to {
opacity: 1;
transform: scale(1);
}
}
.scale-in { animation: scaleIn 0.2s ease-out; }
```
### Loading Spinner
```css
@keyframes spin {
to { transform: rotate(360deg); }
}
.spinner {
width: 40px;
height: 40px;
border: 3px solid #f3f3f3;
border-top: 3px solid #3498db;
border-radius: 50%;
animation: spin 1s linear infinite;
}
```
### Shake (Error Feedback)
```css
@keyframes shake {
0%, 100% { transform: translateX(0); }
10%, 30%, 50%, 70%, 90% { transform: translateX(-5px); }
20%, 40%, 60%, 80% { transform: translateX(5px); }
}
.error-input {
animation: shake 0.5s ease-in-out;
}
```
## Angular 20+ Integration
### Basic Usage with animate.enter/animate.leave
```typescript
@Component({
template: `
@if (show()) {
<div animate.enter="fade-in" animate.leave="fade-out">
Content
</div>
}
`,
styles: [`
.fade-in { animation: fadeIn 0.3s ease-out; }
.fade-out { animation: fadeOut 0.3s ease-in forwards; }
@keyframes fadeIn {
from { opacity: 0; }
to { opacity: 1; }
}
@keyframes fadeOut {
from { opacity: 1; }
to { opacity: 0; }
}
`]
})
```
### Dynamic Animation Classes
```typescript
@Component({
template: `
@if (show()) {
<div [animate.enter]="enterAnim()" [animate.leave]="leaveAnim()">
Content
</div>
}
`
})
export class DynamicAnimComponent {
show = signal(false);
enterAnim = signal('slide-in-up');
leaveAnim = signal('slide-out-down');
}
```
## Debugging Animations
### Common Issues
| Problem | Cause | Solution |
|---------|-------|----------|
| Animation doesn't run | Missing duration | Add `animation-duration: 0.3s` |
| Element snaps back | No fill mode | Add `animation-fill-mode: forwards` |
| Wrong starting position during delay | No backwards fill | Add `animation-fill-mode: backwards` |
| Choppy animation | Animating layout properties | Use `transform` instead |
| State conflict (jump/snap) | Animation overrides state transforms | Animate only opacity, not transform |
### Browser DevTools
- **Chrome DevTools** → More Tools → Animations panel
- **Firefox DevTools** → Inspector → Animations tab
### Animation Events
```typescript
element.addEventListener('animationend', (e) => {
console.log('Animation completed:', e.animationName);
// Clean up, remove element, etc.
});
```
## Resources
### references/keyframes-guide.md
Comprehensive deep-dive covering:
- Complete @keyframes syntax reference
- Detailed timing functions and cubic-bezier curves
- Advanced techniques (direction, play-state, @starting-style)
- Performance optimization strategies
- Extensive common patterns library
- Debugging techniques and troubleshooting
**When to reference:** Complex animation requirements, custom easing curves, advanced techniques, performance optimization, or learning comprehensive details.
### assets/animations.css
Ready-to-use CSS file with common animation patterns:
- Fade animations (in/out)
- Slide animations (up/down/left/right)
- Scale animations (in/out)
- Utility animations (spin, shimmer, shake, breathe, attention-pulse)
- Toast/notification animations
- Accessibility (@media prefers-reduced-motion)
**Usage:** Copy this file to project and import in component styles or global styles:
```css
@import 'path/to/animations.css';
```
Then use classes directly:
```html
<div animate.enter="fade-in" animate.leave="slide-out-down">
```
## Migration from @angular/animations
### Before (Angular Animations)
```typescript
import { trigger, state, style, transition, animate } from '@angular/animations';
@Component({
animations: [
trigger('fadeIn', [
transition(':enter', [
style({ opacity: 0 }),
animate('300ms ease-out', style({ opacity: 1 }))
])
])
]
})
```
### After (CSS @keyframes)
```typescript
@Component({
template: `
@if (show()) {
<div animate.enter="fade-in">Content</div>
}
`,
styles: [`
.fade-in { animation: fadeIn 0.3s ease-out; }
@keyframes fadeIn {
from { opacity: 0; }
to { opacity: 1; }
}
`]
})
```
**Benefits:**
- Zero JavaScript bundle size (~60KB savings)
- GPU hardware acceleration
- Standard CSS (transferable skills)
- Better performance

View File

@@ -0,0 +1,278 @@
/**
* Reusable CSS @keyframes Animations
*
* Common animation patterns for Angular applications.
* Import this file in your component styles or global styles.
*/
/* ============================================
FADE ANIMATIONS
============================================ */
@keyframes fadeIn {
from { opacity: 0; }
to { opacity: 1; }
}
@keyframes fadeOut {
from { opacity: 1; }
to { opacity: 0; }
}
.fade-in {
animation: fadeIn 0.3s ease-out;
}
.fade-out {
animation: fadeOut 0.3s ease-in;
}
/* ============================================
SLIDE ANIMATIONS
============================================ */
@keyframes slideInUp {
from {
opacity: 0;
transform: translateY(20px);
}
to {
opacity: 1;
transform: translateY(0);
}
}
@keyframes slideOutDown {
from {
opacity: 1;
transform: translateY(0);
}
to {
opacity: 0;
transform: translateY(20px);
}
}
@keyframes slideInDown {
from {
opacity: 0;
transform: translateY(-20px);
}
to {
opacity: 1;
transform: translateY(0);
}
}
@keyframes slideOutUp {
from {
opacity: 1;
transform: translateY(0);
}
to {
opacity: 0;
transform: translateY(-20px);
}
}
@keyframes slideInLeft {
from {
opacity: 0;
transform: translateX(-20px);
}
to {
opacity: 1;
transform: translateX(0);
}
}
@keyframes slideOutLeft {
from {
opacity: 1;
transform: translateX(0);
}
to {
opacity: 0;
transform: translateX(-20px);
}
}
@keyframes slideInRight {
from {
opacity: 0;
transform: translateX(20px);
}
to {
opacity: 1;
transform: translateX(0);
}
}
@keyframes slideOutRight {
from {
opacity: 1;
transform: translateX(0);
}
to {
opacity: 0;
transform: translateX(20px);
}
}
.slide-in-up { animation: slideInUp 0.3s ease-out; }
.slide-out-down { animation: slideOutDown 0.3s ease-in; }
.slide-in-down { animation: slideInDown 0.3s ease-out; }
.slide-out-up { animation: slideOutUp 0.3s ease-in; }
.slide-in-left { animation: slideInLeft 0.3s ease-out; }
.slide-out-left { animation: slideOutLeft 0.3s ease-in; }
.slide-in-right { animation: slideInRight 0.3s ease-out; }
.slide-out-right { animation: slideOutRight 0.3s ease-in; }
/* ============================================
SCALE ANIMATIONS
============================================ */
@keyframes scaleIn {
from {
opacity: 0;
transform: scale(0.9);
}
to {
opacity: 1;
transform: scale(1);
}
}
@keyframes scaleOut {
from {
opacity: 1;
transform: scale(1);
}
to {
opacity: 0;
transform: scale(0.9);
}
}
.scale-in { animation: scaleIn 0.2s ease-out; }
.scale-out { animation: scaleOut 0.2s ease-in; }
/* ============================================
UTILITY ANIMATIONS
============================================ */
/* Loading Spinner */
@keyframes spin {
to { transform: rotate(360deg); }
}
.spin {
animation: spin 1s linear infinite;
}
/* Skeleton Loading */
@keyframes shimmer {
0% { background-position: -200% 0; }
100% { background-position: 200% 0; }
}
.shimmer {
background: linear-gradient(
90deg,
#f0f0f0 25%,
#e0e0e0 50%,
#f0f0f0 75%
);
background-size: 200% 100%;
animation: shimmer 1.5s infinite;
}
/* Attention Pulse */
@keyframes attention-pulse {
0%, 100% {
box-shadow: 0 0 0 0 rgba(59, 130, 246, 0.5);
}
50% {
box-shadow: 0 0 0 10px rgba(59, 130, 246, 0);
}
}
.attention-pulse {
animation: attention-pulse 2s ease-in-out infinite;
}
/* Shake (Error Feedback) */
@keyframes shake {
0%, 100% { transform: translateX(0); }
10%, 30%, 50%, 70%, 90% { transform: translateX(-5px); }
20%, 40%, 60%, 80% { transform: translateX(5px); }
}
.shake {
animation: shake 0.5s ease-in-out;
}
/* Breathing/Pulsing */
@keyframes breathe {
0%, 100% {
opacity: 1;
transform: scale(1);
}
50% {
opacity: 0.7;
transform: scale(1.05);
}
}
.breathe {
animation: breathe 2s ease-in-out infinite;
}
/* ============================================
TOAST/NOTIFICATION ANIMATIONS
============================================ */
@keyframes toastIn {
from {
opacity: 0;
transform: translateY(100%) scale(0.9);
}
to {
opacity: 1;
transform: translateY(0) scale(1);
}
}
@keyframes toastOut {
from {
opacity: 1;
transform: translateY(0) scale(1);
}
to {
opacity: 0;
transform: translateY(100%) scale(0.9);
}
}
.toast-in {
animation: toastIn 0.3s cubic-bezier(0.34, 1.56, 0.64, 1);
}
.toast-out {
animation: toastOut 0.2s ease-in forwards;
}
/* ============================================
ACCESSIBILITY
============================================ */
/* Respect user's motion preferences */
@media (prefers-reduced-motion: reduce) {
*,
*::before,
*::after {
animation-duration: 0.01ms !important;
animation-iteration-count: 1 !important;
transition-duration: 0.01ms !important;
}
}

View File

@@ -0,0 +1,833 @@
# CSS @keyframes Deep Dive
A comprehensive guide for Angular developers transitioning from `@angular/animations` to native CSS animations.
---
## Table of Contents
1. [Understanding @keyframes](#understanding-keyframes)
2. [Basic Syntax](#basic-syntax)
3. [Animation Properties](#animation-properties)
4. [Timing Functions (Easing)](#timing-functions-easing)
5. [Fill Modes](#fill-modes)
6. [Advanced Techniques](#advanced-techniques)
7. [Angular 20+ Integration](#angular-20-integration)
8. [Common Patterns & Recipes](#common-patterns--recipes)
9. [Performance Tips](#performance-tips)
10. [Debugging Animations](#debugging-animations)
---
## Understanding @keyframes
The `@keyframes` at-rule controls the intermediate steps in a CSS animation sequence by defining styles for keyframes (waypoints) along the animation. Unlike transitions (which only animate between two states), keyframes let you define multiple intermediate steps.
### How It Differs from @angular/animations
| @angular/animations | Native CSS @keyframes |
|---------------------|----------------------|
| ~60KB JavaScript bundle | Zero JS overhead |
| CPU-based rendering | GPU hardware acceleration |
| Angular-specific syntax | Standard CSS (transferable skills) |
| `trigger()`, `state()`, `animate()` | `@keyframes` + CSS classes |
---
## Basic Syntax
### The @keyframes Rule
```css
@keyframes animation-name {
from {
/* Starting styles (same as 0%) */
}
to {
/* Ending styles (same as 100%) */
}
}
```
### Percentage-Based Keyframes
For more control, use percentages to define multiple waypoints:
```css
@keyframes bounce {
0% {
transform: translateY(0);
}
25% {
transform: translateY(-30px);
}
50% {
transform: translateY(0);
}
75% {
transform: translateY(-15px);
}
100% {
transform: translateY(0);
}
}
```
### Combining Multiple Percentages
You can apply the same styles to multiple keyframes:
```css
@keyframes pulse {
0%, 100% {
opacity: 1;
transform: scale(1);
}
50% {
opacity: 0.7;
transform: scale(1.05);
}
}
```
### Applying the Animation
```css
.element {
animation: bounce 1s ease-in-out infinite;
}
```
---
## Animation Properties
### Individual Properties
| Property | Description | Example |
|----------|-------------|---------|
| `animation-name` | Name of the @keyframes | `animation-name: bounce;` |
| `animation-duration` | How long one cycle takes | `animation-duration: 2s;` |
| `animation-timing-function` | Speed curve (easing) | `animation-timing-function: ease-in;` |
| `animation-delay` | Wait before starting | `animation-delay: 500ms;` |
| `animation-iteration-count` | How many times to run | `animation-iteration-count: 3;` or `infinite` |
| `animation-direction` | Forward, reverse, or alternate | `animation-direction: alternate;` |
| `animation-fill-mode` | Styles before/after animation | `animation-fill-mode: forwards;` |
| `animation-play-state` | Pause or play | `animation-play-state: paused;` |
### Shorthand Syntax
```css
/* animation: name duration timing-function delay iteration-count direction fill-mode play-state */
.element {
animation: slideIn 0.5s ease-out 0.2s 1 normal forwards running;
}
```
**Minimum required:** name and duration
```css
.element {
animation: fadeIn 1s;
}
```
### Multiple Animations
Apply multiple animations to a single element:
```css
.element {
animation:
fadeIn 0.5s ease-out,
slideUp 0.5s ease-out,
pulse 2s ease-in-out 0.5s infinite;
}
```
---
## Timing Functions (Easing)
The timing function controls how the animation progresses over time—where it speeds up and slows down.
### Keyword Values
| Keyword | Cubic-Bezier Equivalent | Description |
|---------|------------------------|-------------|
| `linear` | `cubic-bezier(0, 0, 1, 1)` | Constant speed |
| `ease` | `cubic-bezier(0.25, 0.1, 0.25, 1)` | Default: slow start, fast middle, slow end |
| `ease-in` | `cubic-bezier(0.42, 0, 1, 1)` | Slow start, fast end |
| `ease-out` | `cubic-bezier(0, 0, 0.58, 1)` | Fast start, slow end |
| `ease-in-out` | `cubic-bezier(0.42, 0, 0.58, 1)` | Slow start and end |
### Custom Cubic-Bezier
Create custom easing curves with `cubic-bezier(x1, y1, x2, y2)`:
```css
/* Bouncy overshoot effect */
.element {
animation-timing-function: cubic-bezier(0.68, -0.6, 0.32, 1.6);
}
/* Smooth deceleration */
.element {
animation-timing-function: cubic-bezier(0.25, 1, 0.5, 1);
}
```
**Tool:** Use [cubic-bezier.com](https://cubic-bezier.com) to visualize and create custom curves.
### Popular Easing Functions
```css
/* Ease Out Quart - Great for enter animations */
cubic-bezier(0.25, 1, 0.5, 1)
/* Ease In Out Cubic - Smooth state changes */
cubic-bezier(0.65, 0, 0.35, 1)
/* Ease Out Back - Slight overshoot */
cubic-bezier(0.34, 1.56, 0.64, 1)
/* Ease In Out Back - Overshoot both ends */
cubic-bezier(0.68, -0.6, 0.32, 1.6)
```
### Steps Function
For frame-by-frame animations (like sprite sheets):
```css
/* 6 discrete steps */
.sprite {
animation: walk 1s steps(6) infinite;
}
/* Step positions */
steps(4, jump-start) /* Jump at start of each interval */
steps(4, jump-end) /* Jump at end of each interval (default) */
steps(4, jump-both) /* Jump at both ends */
steps(4, jump-none) /* No jump at ends */
```
### Timing Function Per Keyframe
Apply different easing to different segments:
```css
@keyframes complexMove {
0% {
transform: translateX(0);
animation-timing-function: ease-out;
}
50% {
transform: translateX(100px);
animation-timing-function: ease-in;
}
100% {
transform: translateX(200px);
}
}
```
**Important:** The timing function applies to each step individually, not the entire animation.
---
## Fill Modes
Fill modes control what styles apply before and after the animation runs.
### Values
| Value | Before Animation | After Animation |
|-------|-----------------|-----------------|
| `none` | Original styles | Original styles |
| `forwards` | Original styles | **Last keyframe styles** |
| `backwards` | **First keyframe styles** | Original styles |
| `both` | **First keyframe styles** | **Last keyframe styles** |
### Common Problem: Element Snaps Back
```css
/* BAD: Element disappears then reappears after animation */
@keyframes fadeOut {
from { opacity: 1; }
to { opacity: 0; }
}
.element {
animation: fadeOut 1s; /* Element snaps back to opacity: 1 */
}
/* GOOD: Element stays invisible */
.element {
animation: fadeOut 1s forwards;
}
```
### Backwards Fill Mode (for delays)
```css
@keyframes slideIn {
from {
transform: translateX(-100%);
opacity: 0;
}
to {
transform: translateX(0);
opacity: 1;
}
}
/* Without backwards: element visible at original position during delay */
/* With backwards: element starts at first keyframe position during delay */
.element {
animation: slideIn 0.5s ease-out 1s backwards;
}
```
---
## Advanced Techniques
### Animation Direction
Control playback direction:
```css
animation-direction: normal; /* 0% → 100% */
animation-direction: reverse; /* 100% → 0% */
animation-direction: alternate; /* 0% → 100% → 0% */
animation-direction: alternate-reverse; /* 100% → 0% → 100% */
```
**Use Case:** Breathing/pulsing effects
```css
@keyframes breathe {
from { transform: scale(1); }
to { transform: scale(1.1); }
}
.element {
animation: breathe 2s ease-in-out infinite alternate;
}
```
### Staggered Animations
Create cascading effects with animation-delay:
```css
.item { animation: fadeSlideIn 0.5s ease-out backwards; }
.item:nth-child(1) { animation-delay: 0ms; }
.item:nth-child(2) { animation-delay: 100ms; }
.item:nth-child(3) { animation-delay: 200ms; }
.item:nth-child(4) { animation-delay: 300ms; }
/* Or use CSS custom properties */
.item {
animation: fadeSlideIn 0.5s ease-out backwards;
animation-delay: calc(var(--i, 0) * 100ms);
}
```
In your template:
```html
<div class="item" style="--i: 0">First</div>
<div class="item" style="--i: 1">Second</div>
<div class="item" style="--i: 2">Third</div>
```
### @starting-style (Modern CSS)
Define styles for when an element first enters the DOM:
```css
.modal {
opacity: 1;
transform: scale(1);
transition: opacity 0.3s, transform 0.3s;
@starting-style {
opacity: 0;
transform: scale(0.9);
}
}
```
### Animating Auto Height
Use CSS Grid for height: auto animations:
```css
.accordion-content {
display: grid;
grid-template-rows: 0fr;
transition: grid-template-rows 0.3s ease-out;
}
.accordion-content.open {
grid-template-rows: 1fr;
}
.accordion-content > div {
overflow: hidden;
}
```
### Pause/Play with CSS
```css
.element {
animation: spin 2s linear infinite;
animation-play-state: running;
}
.element:hover {
animation-play-state: paused;
}
/* Or with a class */
.element.paused {
animation-play-state: paused;
}
```
---
## Angular 20+ Integration
### Using animate.enter and animate.leave
Angular 20.2+ provides `animate.enter` and `animate.leave` to apply CSS classes when elements enter/leave the DOM.
```typescript
@Component({
selector: 'app-example',
template: `
@if (isVisible()) {
<div animate.enter="fade-in" animate.leave="fade-out">
Content here
</div>
}
<button (click)="toggle()">Toggle</button>
`,
styles: [`
.fade-in {
animation: fadeIn 0.3s ease-out;
}
.fade-out {
animation: fadeOut 0.3s ease-in;
}
@keyframes fadeIn {
from { opacity: 0; }
to { opacity: 1; }
}
@keyframes fadeOut {
from { opacity: 1; }
to { opacity: 0; }
}
`]
})
export class ExampleComponent {
isVisible = signal(false);
toggle() { this.isVisible.update(v => !v); }
}
```
### Dynamic Animation Classes
```typescript
@Component({
template: `
@if (show()) {
<div [animate.enter]="enterAnimation()" [animate.leave]="leaveAnimation()">
Dynamic animations!
</div>
}
`
})
export class DynamicAnimComponent {
show = signal(false);
enterAnimation = signal('slide-in-right');
leaveAnimation = signal('slide-out-left');
}
```
### Reusable Animation CSS File
Create a shared `animations.css`:
```css
/* animations.css */
/* Fade animations */
.fade-in { animation: fadeIn 0.3s ease-out; }
.fade-out { animation: fadeOut 0.3s ease-in; }
@keyframes fadeIn {
from { opacity: 0; }
to { opacity: 1; }
}
@keyframes fadeOut {
from { opacity: 1; }
to { opacity: 0; }
}
/* Slide animations */
.slide-in-up { animation: slideInUp 0.3s ease-out; }
.slide-out-down { animation: slideOutDown 0.3s ease-in; }
@keyframes slideInUp {
from {
opacity: 0;
transform: translateY(20px);
}
to {
opacity: 1;
transform: translateY(0);
}
}
@keyframes slideOutDown {
from {
opacity: 1;
transform: translateY(0);
}
to {
opacity: 0;
transform: translateY(20px);
}
}
/* Scale animations */
.scale-in { animation: scaleIn 0.2s ease-out; }
.scale-out { animation: scaleOut 0.2s ease-in; }
@keyframes scaleIn {
from {
opacity: 0;
transform: scale(0.9);
}
to {
opacity: 1;
transform: scale(1);
}
}
@keyframes scaleOut {
from {
opacity: 1;
transform: scale(1);
}
to {
opacity: 0;
transform: scale(0.9);
}
}
```
Import in `styles.css` or `angular.json`:
```css
@import 'animations.css';
```
---
## Common Patterns & Recipes
### Loading Spinner
```css
@keyframes spin {
to { transform: rotate(360deg); }
}
.spinner {
width: 40px;
height: 40px;
border: 3px solid #f3f3f3;
border-top: 3px solid #3498db;
border-radius: 50%;
animation: spin 1s linear infinite;
}
```
### Skeleton Loading
```css
@keyframes shimmer {
0% { background-position: -200% 0; }
100% { background-position: 200% 0; }
}
.skeleton {
background: linear-gradient(
90deg,
#f0f0f0 25%,
#e0e0e0 50%,
#f0f0f0 75%
);
background-size: 200% 100%;
animation: shimmer 1.5s infinite;
}
```
### Attention Pulse
```css
@keyframes attention-pulse {
0%, 100% {
box-shadow: 0 0 0 0 rgba(59, 130, 246, 0.5);
}
50% {
box-shadow: 0 0 0 10px rgba(59, 130, 246, 0);
}
}
.notification-badge {
animation: attention-pulse 2s ease-in-out infinite;
}
```
### Shake (Error Feedback)
```css
@keyframes shake {
0%, 100% { transform: translateX(0); }
10%, 30%, 50%, 70%, 90% { transform: translateX(-5px); }
20%, 40%, 60%, 80% { transform: translateX(5px); }
}
.error-input {
animation: shake 0.5s ease-in-out;
}
```
### Slide Down Menu
```css
@keyframes slideDown {
from {
opacity: 0;
transform: translateY(-10px);
}
to {
opacity: 1;
transform: translateY(0);
}
}
.dropdown-menu {
animation: slideDown 0.2s ease-out forwards;
}
```
### Toast Notification
```css
@keyframes toastIn {
from {
opacity: 0;
transform: translateY(100%) scale(0.9);
}
to {
opacity: 1;
transform: translateY(0) scale(1);
}
}
@keyframes toastOut {
from {
opacity: 1;
transform: translateY(0) scale(1);
}
to {
opacity: 0;
transform: translateY(100%) scale(0.9);
}
}
.toast {
animation: toastIn 0.3s cubic-bezier(0.34, 1.56, 0.64, 1);
}
.toast.leaving {
animation: toastOut 0.2s ease-in forwards;
}
```
---
## Performance Tips
### Use Transform and Opacity
These properties are GPU-accelerated and don't trigger layout:
```css
/* GOOD - GPU accelerated */
@keyframes good {
from { transform: translateX(0); opacity: 0; }
to { transform: translateX(100px); opacity: 1; }
}
/* AVOID - Triggers layout recalculation */
@keyframes avoid {
from { left: 0; width: 100px; }
to { left: 100px; width: 200px; }
}
```
### Use will-change Sparingly
```css
.element {
will-change: transform, opacity;
}
/* Remove after animation */
.element.animation-complete {
will-change: auto;
}
```
### Respect Reduced Motion
```css
@keyframes fadeSlide {
from {
opacity: 0;
transform: translateY(20px);
}
to {
opacity: 1;
transform: translateY(0);
}
}
.element {
animation: fadeSlide 0.3s ease-out;
}
@media (prefers-reduced-motion: reduce) {
.element {
animation: none;
/* Or use a simpler fade */
animation: fadeIn 0.1s ease-out;
}
}
```
### Avoid Animating Layout Properties
Properties that trigger layout (reflow):
- `width`, `height`
- `top`, `left`, `right`, `bottom`
- `margin`, `padding`
- `font-size`
- `border-width`
Use `transform: scale()` instead of `width/height` when possible.
---
## Debugging Animations
### Browser DevTools
1. **Chrome DevTools** → More Tools → Animations
- Pause, slow down, or step through animations
- Inspect timing curves
2. **Firefox** → Inspector → Animations tab
- Visual timeline of all animations
### Force Slow Motion
```css
/* Temporarily add to debug */
* {
animation-duration: 3s !important;
}
```
### Animation Events in JavaScript
```typescript
element.addEventListener('animationstart', (e) => {
console.log('Started:', e.animationName);
});
element.addEventListener('animationend', (e) => {
console.log('Ended:', e.animationName);
// Clean up class, remove element, etc.
});
element.addEventListener('animationiteration', (e) => {
console.log('Iteration:', e.animationName);
});
```
### Common Issues
| Problem | Solution |
|---------|----------|
| Animation not running | Check `animation-duration` is > 0 |
| Element snaps back | Add `animation-fill-mode: forwards` |
| Animation starts wrong | Use `animation-fill-mode: backwards` with delay |
| Choppy animation | Use `transform` instead of layout properties |
| Animation restarts on state change | Ensure Angular doesn't recreate the element |
---
## Quick Reference Card
```css
/* Basic setup */
@keyframes name {
from { /* start */ }
to { /* end */ }
}
.element {
animation: name 0.3s ease-out forwards;
}
/* Angular 20+ */
<div animate.enter="fade-in" animate.leave="fade-out">
/* Shorthand order */
animation: name duration timing delay count direction fill-mode state;
/* Common timing functions */
ease-out: cubic-bezier(0, 0, 0.58, 1) /* Enter animations */
ease-in: cubic-bezier(0.42, 0, 1, 1) /* Exit animations */
ease-in-out: cubic-bezier(0.42, 0, 0.58, 1) /* State changes */
/* Fill modes */
forwards Keep end state
backwards Apply start state during delay
both Both of the above
```
---
## Resources
- [MDN CSS Animations Guide](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_animations/Using_CSS_animations)
- [Angular Animation Migration Guide](https://angular.dev/guide/animations/migration)
- [Cubic Bezier Tool](https://cubic-bezier.com)
- [Easing Functions Cheat Sheet](https://easings.net)
- [Josh W. Comeau's Keyframe Guide](https://www.joshwcomeau.com/animation/keyframe-animations/)

View File

@@ -1,203 +0,0 @@
---
name: Git Commit Helper
description: Generate descriptive commit messages by analyzing git diffs. Use when the user asks for help writing commit messages or reviewing staged changes.
---
# Git Commit Helper
## Quick start
Analyze staged changes and generate commit message:
```bash
# View staged changes
git diff --staged
# Generate commit message based on changes
# (Claude will analyze the diff and suggest a message)
```
## Commit message format
Follow conventional commits format:
```
<type>(<scope>): <description>
[optional body]
[optional footer]
```
### Types
- **feat**: New feature
- **fix**: Bug fix
- **docs**: Documentation changes
- **style**: Code style changes (formatting, missing semicolons)
- **refactor**: Code refactoring
- **test**: Adding or updating tests
- **chore**: Maintenance tasks
### Examples
**Feature commit:**
```
feat(auth): add JWT authentication
Implement JWT-based authentication system with:
- Login endpoint with token generation
- Token validation middleware
- Refresh token support
```
**Bug fix:**
```
fix(api): handle null values in user profile
Prevent crashes when user profile fields are null.
Add null checks before accessing nested properties.
```
**Refactor:**
```
refactor(database): simplify query builder
Extract common query patterns into reusable functions.
Reduce code duplication in database layer.
```
## Analyzing changes
Review what's being committed:
```bash
# Show files changed
git status
# Show detailed changes
git diff --staged
# Show statistics
git diff --staged --stat
# Show changes for specific file
git diff --staged path/to/file
```
## Commit message guidelines
**DO:**
- Use imperative mood ("add feature" not "added feature")
- Keep first line under 50 characters
- Capitalize first letter
- No period at end of summary
- Explain WHY not just WHAT in body
**DON'T:**
- Use vague messages like "update" or "fix stuff"
- Include technical implementation details in summary
- Write paragraphs in summary line
- Use past tense
## Multi-file commits
When committing multiple related changes:
```
refactor(core): restructure authentication module
- Move auth logic from controllers to service layer
- Extract validation into separate validators
- Update tests to use new structure
- Add integration tests for auth flow
Breaking change: Auth service now requires config object
```
## Scope examples
**Frontend:**
- `feat(ui): add loading spinner to dashboard`
- `fix(form): validate email format`
**Backend:**
- `feat(api): add user profile endpoint`
- `fix(db): resolve connection pool leak`
**Infrastructure:**
- `chore(ci): update Node version to 20`
- `feat(docker): add multi-stage build`
## Breaking changes
Indicate breaking changes clearly:
```
feat(api)!: restructure API response format
BREAKING CHANGE: All API responses now follow JSON:API spec
Previous format:
{ "data": {...}, "status": "ok" }
New format:
{ "data": {...}, "meta": {...} }
Migration guide: Update client code to handle new response structure
```
## Template workflow
1. **Review changes**: `git diff --staged`
2. **Identify type**: Is it feat, fix, refactor, etc.?
3. **Determine scope**: What part of the codebase?
4. **Write summary**: Brief, imperative description
5. **Add body**: Explain why and what impact
6. **Note breaking changes**: If applicable
## Interactive commit helper
Use `git add -p` for selective staging:
```bash
# Stage changes interactively
git add -p
# Review what's staged
git diff --staged
# Commit with message
git commit -m "type(scope): description"
```
## Amending commits
Fix the last commit message:
```bash
# Amend commit message only
git commit --amend
# Amend and add more changes
git add forgotten-file.js
git commit --amend --no-edit
```
## Best practices
1. **Atomic commits** - One logical change per commit
2. **Test before commit** - Ensure code works
3. **Reference issues** - Include issue numbers if applicable
4. **Keep it focused** - Don't mix unrelated changes
5. **Write for humans** - Future you will read this
## Commit message checklist
- [ ] Type is appropriate (feat/fix/docs/etc.)
- [ ] Scope is specific and clear
- [ ] Summary is under 50 characters
- [ ] Summary uses imperative mood
- [ ] Body explains WHY not just WHAT
- [ ] Breaking changes are clearly marked
- [ ] Related issue numbers are included

View File

@@ -0,0 +1,352 @@
---
name: git-workflow
description: This skill should be used when creating branches, writing commits, or creating pull requests. Enforces ISA-Frontend Git conventions including feature/task-id-name branch format, conventional commits without co-author tags, and PRs targeting develop branch.
---
# Git Workflow Skill
Enforces Git workflow conventions specific to the ISA-Frontend project.
## When to Use
- Creating new branches for features or bugfixes
- Writing commit messages
- Creating pull requests
- Any Git operations requiring adherence to project conventions
## Core Principles
### 1. Default Branch is `develop` (NOT `main`)
- **All PRs target**: `develop` branch
- **Feature branches from**: `develop`
- **Never push directly to**: `develop` or `main`
### 2. Branch Naming Convention
**Format**: `<type>/{task-id}-{short-description}`
**Types**:
- `feature/` - New features or enhancements
- `bugfix/` - Bug fixes
- `hotfix/` - Emergency production fixes
**Rules**:
- Use English kebab-case for descriptions
- Start with task/issue ID (e.g., `5391`)
- Keep description concise - shorten if too long
- Use hyphens to separate words
**Examples**:
```bash
# Good
feature/5391-praemie-checkout-action-card-delivery-order
bugfix/6123-fix-login-redirect-loop
hotfix/7890-critical-payment-error
# Bad
feature/praemie-checkout # Missing task ID
feature/5391_praemie # Using underscores
feature-5391-very-long-description-that-goes-on-forever # Too long
```
### 3. Conventional Commits (WITHOUT Co-Author Tags)
**Format**: `<type>(<scope>): <description>`
**Types**:
- `feat`: New feature
- `fix`: Bug fix
- `docs`: Documentation only
- `style`: Code style (formatting, missing semicolons)
- `refactor`: Code restructuring without feature changes
- `perf`: Performance improvements
- `test`: Adding or updating tests
- `build`: Build system or dependencies
- `ci`: CI configuration
- `chore`: Maintenance tasks
**Rules**:
-**NO** "Generated with Claude Code" tags
-**NO** "Co-Authored-By: Claude" tags
- ✅ Keep first line under 72 characters
- ✅ Use imperative mood ("add" not "added")
- ✅ Body optional but recommended for complex changes
**Examples**:
```bash
# Good
feat(checkout): add bonus card selection for delivery orders
fix(crm): resolve customer search filter reset issue
refactor(oms): extract return validation logic into service
# Bad
feat(checkout): add bonus card selection
Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
# Also bad
Added new feature # Wrong tense
Fix bug # Missing scope
```
### 4. Pull Request Creation
**Target Branch**: Always `develop`
**PR Title Format**: Same as conventional commit
```
feat(domain): concise description of changes
```
**PR Body Structure**:
```markdown
## Summary
- Brief bullet points of changes
## Related Tasks
- Closes #{task-id}
- Refs #{related-task}
## Test Plan
- [ ] Unit tests added/updated
- [ ] E2E attributes added
- [ ] Manual testing completed
## Breaking Changes
None / List breaking changes
## Screenshots (if UI changes)
[Add screenshots]
```
## Common Workflows
### Creating a Feature Branch
```bash
# 1. Update develop
git checkout develop
git pull origin develop
# 2. Create feature branch
git checkout -b feature/5391-praemie-checkout-action-card
# 3. Work and commit
git add .
git commit -m "feat(checkout): add primary bonus card selection logic"
# 4. Push to remote
git push -u origin feature/5391-praemie-checkout-action-card
# 5. Create PR targeting develop (use gh CLI or web UI)
```
### Creating a Bugfix Branch
```bash
# From develop
git checkout develop
git pull origin develop
git checkout -b bugfix/6123-login-redirect-loop
# Commit
git commit -m "fix(auth): resolve infinite redirect on logout"
```
### Creating a Hotfix Branch
```bash
# From main (production)
git checkout main
git pull origin main
git checkout -b hotfix/7890-payment-processing-error
# Commit
git commit -m "fix(checkout): critical payment API timeout handling"
# Merge to both main and develop
```
## Commit Message Guidelines
### Good Commit Messages
```bash
feat(crm): add customer loyalty tier calculation
Implements three-tier loyalty system based on annual spend.
Includes migration for existing customer data.
Refs #5234
---
fix(oms): prevent duplicate return submissions
Adds debouncing to return form submission and validates
against existing returns in the last 60 seconds.
Closes #5891
---
refactor(catalogue): extract product search into dedicated service
Moves search logic from component to ProductSearchService
for better testability and reusability.
---
perf(remission): optimize remission list query with pagination
Reduces initial load time from 3s to 800ms by implementing
cursor-based pagination.
Closes #6234
```
### Bad Commit Messages
```bash
# Too vague
fix: bug fixes
# Missing scope
feat: new feature
# Wrong tense
fixed the login issue
# Including banned tags
feat(checkout): add feature
Generated with Claude Code
Co-Authored-By: Claude <noreply@anthropic.com>
```
## Git Configuration Checks
### Verify Git Setup
```bash
# Check current branch
git branch --show-current
# Verify remote
git remote -v # Should show origin pointing to ISA-Frontend
# Check for uncommitted changes
git status
```
## Common Mistakes to Avoid
```bash
# ❌ Creating PR against main
gh pr create --base main # WRONG
# ✅ Always target develop
gh pr create --base develop # CORRECT
# ❌ Using underscores in branch names
git checkout -b feature/5391_my_feature # WRONG
# ✅ Use hyphens
git checkout -b feature/5391-my-feature # CORRECT
# ❌ Adding co-author tags
git commit -m "feat: something
Co-Authored-By: Claude <noreply@anthropic.com>" # WRONG
# ✅ Clean commit message
git commit -m "feat(scope): something" # CORRECT
# ❌ Forgetting task ID in branch name
git checkout -b feature/new-checkout-flow # WRONG
# ✅ Include task ID
git checkout -b feature/5391-new-checkout-flow # CORRECT
```
## Integration with Claude Code
When Claude Code creates commits or PRs:
### Commit Creation
```bash
# Claude uses conventional commits WITHOUT attribution
git commit -m "feat(checkout): implement bonus card selection
Adds logic for selecting primary bonus card during checkout
for delivery orders. Includes validation and error handling.
Refs #5391"
```
### PR Creation
```bash
# Target develop by default
gh pr create --base develop \
--title "feat(checkout): implement bonus card selection" \
--body "## Summary
- Add primary bonus card selection logic
- Implement validation for delivery orders
- Add error handling for API failures
## Related Tasks
- Closes #5391
## Test Plan
- [x] Unit tests added
- [x] E2E attributes added
- [x] Manual testing completed"
```
## Branch Cleanup
### After PR Merge
```bash
# Update develop
git checkout develop
git pull origin develop
# Delete local feature branch
git branch -d feature/5391-praemie-checkout
# Delete remote branch (usually done by PR merge)
git push origin --delete feature/5391-praemie-checkout
```
## Quick Reference
```bash
# Branch naming
feature/{task-id}-{description}
bugfix/{task-id}-{description}
hotfix/{task-id}-{description}
# Commit format
<type>(<scope>): <description>
# Common types
feat, fix, docs, style, refactor, perf, test, build, ci, chore
# PR target
Always: develop (NOT main)
# Banned in commits
- "Generated with Claude Code"
- "Co-Authored-By: Claude"
- Any AI attribution
```
## Resources
- [Conventional Commits](https://www.conventionalcommits.org/)
- Project PR template: `.github/pull_request_template.md`
- Code review standards: `.github/review-instructions.md`

View File

@@ -0,0 +1,299 @@
---
name: html-template
description: This skill should be used when writing or reviewing HTML templates to ensure proper E2E testing attributes (data-what, data-which) and ARIA accessibility attributes are included. Use when creating interactive elements like buttons, inputs, links, forms, dialogs, or any HTML markup requiring testing and accessibility compliance. Works seamlessly with the angular-template skill.
---
# HTML Template - Testing & Accessibility Attributes
This skill should be used when writing or reviewing HTML templates to ensure proper testing and accessibility attributes are included.
## When to Use This Skill
Use this skill when:
- Writing or modifying Angular component templates
- Creating any HTML templates or markup
- Reviewing code for testing and accessibility compliance
- Adding interactive elements (buttons, inputs, links, etc.)
- Implementing forms, lists, navigation, or dialogs
**Works seamlessly with:**
- **[angular-template](../angular-template/SKILL.md)** - Angular template syntax, control flow, and modern patterns
- **[tailwind](../tailwind/SKILL.md)** - ISA design system styling for visual design
- **[logging](../logging/SKILL.md)** - MANDATORY logging in all Angular components using `@isa/core/logging`
## Overview
This skill provides comprehensive guidance for two critical HTML attribute categories:
### 1. E2E Testing Attributes
Enable automated end-to-end testing by providing stable selectors for QA automation:
- **`data-what`**: Semantic description of element's purpose
- **`data-which`**: Unique identifier for specific instances
- **`data-*`**: Additional contextual information
### 2. ARIA Accessibility Attributes
Ensure web applications are accessible to all users, including those using assistive technologies:
- **Roles**: Define element purpose (button, navigation, dialog, etc.)
- **Properties**: Provide additional context (aria-label, aria-describedby)
- **States**: Indicate dynamic states (aria-expanded, aria-disabled)
- **Live Regions**: Announce dynamic content changes
## Why Both Are Essential
- **E2E Attributes**: Enable reliable automated testing without brittle CSS or XPath selectors
- **ARIA Attributes**: Ensure compliance with WCAG standards and improve user experience for people with disabilities
- **Together**: Create robust, testable, and accessible web applications
## Quick Reference
### Button Example
```html
<button
type="button"
(click)="onSubmit()"
data-what="submit-button"
data-which="registration-form"
aria-label="Submit registration form">
Submit
</button>
```
### Input Example
```html
<input
type="text"
[(ngModel)]="email"
data-what="email-input"
data-which="registration-form"
aria-label="Email address"
aria-describedby="email-hint"
aria-required="true" />
<span id="email-hint">We'll never share your email</span>
```
### Dynamic List Example
```html
@for (item of items; track item.id) {
<li
(click)="selectItem(item)"
data-what="list-item"
[attr.data-which]="item.id"
[attr.data-status]="item.status"
[attr.aria-label]="'Select ' + item.name"
role="button"
tabindex="0">
{{ item.name }}
</li>
}
```
### Link Example
```html
<a
[routerLink]="['/orders', orderId]"
data-what="order-link"
[attr.data-which]="orderId"
[attr.aria-label]="'View order ' + orderNumber">
View Order #{{ orderNumber }}
</a>
```
### Dialog Example
```html
<div
class="dialog"
data-what="confirmation-dialog"
data-which="delete-item"
role="dialog"
aria-modal="true"
aria-labelledby="dialog-title"
aria-describedby="dialog-description">
<h2 id="dialog-title">Confirm Deletion</h2>
<p id="dialog-description">Are you sure you want to delete this item?</p>
<button
(click)="confirm()"
data-what="confirm-button"
data-which="delete-dialog"
aria-label="Confirm deletion">
Delete
</button>
<button
(click)="cancel()"
data-what="cancel-button"
data-which="delete-dialog"
aria-label="Cancel deletion">
Cancel
</button>
</div>
```
## Common Patterns by Element Type
### Interactive Elements That Need Attributes
**Required attributes for:**
- Buttons (`<button>`, `<ui-button>`, custom button components)
- Form inputs (`<input>`, `<textarea>`, `<select>`)
- Links (`<a>`, `[routerLink]`)
- Clickable elements (elements with `(click)` handlers)
- Custom interactive components
- List items in dynamic lists
- Navigation items
- Dialog/modal controls
### Naming Conventions
**E2E `data-what` patterns:**
- `*-button` (submit-button, cancel-button, delete-button)
- `*-input` (email-input, search-input, quantity-input)
- `*-link` (product-link, order-link, customer-link)
- `*-item` (list-item, menu-item, card-item)
- `*-dialog` (confirm-dialog, error-dialog, info-dialog)
- `*-dropdown` (status-dropdown, category-dropdown)
**E2E `data-which` guidelines:**
- Use unique identifiers: `data-which="primary"`, `data-which="customer-list"`
- Bind dynamically for lists: `[attr.data-which]="item.id"`
- Combine with context: `data-which="customer-{{ customerId }}-edit"`
**ARIA role patterns:**
- Interactive elements: `button`, `link`, `menuitem`
- Structural: `navigation`, `main`, `complementary`, `contentinfo`
- Widget: `dialog`, `alertdialog`, `tooltip`, `tablist`, `tab`
- Landmark: `banner`, `search`, `form`, `region`
## Best Practices
### E2E Attributes
1. ✅ Add to ALL interactive elements
2. ✅ Use kebab-case for `data-what` values
3. ✅ Ensure `data-which` is unique within the view
4. ✅ Use Angular binding for dynamic values: `[attr.data-*]`
5. ✅ Avoid including sensitive data in attributes
6. ✅ Document complex attribute patterns in template comments
### ARIA Attributes
1. ✅ Use semantic HTML first (use `<button>` instead of `<div role="button">`)
2. ✅ Provide text alternatives for all interactive elements
3. ✅ Ensure proper keyboard navigation (tabindex, focus management)
4. ✅ Use `aria-label` when visual label is missing
5. ✅ Use `aria-labelledby` to reference existing visible labels
6. ✅ Keep ARIA attributes in sync with visual states
7. ✅ Test with screen readers (NVDA, JAWS, VoiceOver)
### Combined Best Practices
1. ✅ Add both E2E and ARIA attributes to every interactive element
2. ✅ Keep attributes close together in the HTML for readability
3. ✅ Update tests to use `data-what` and `data-which` selectors
4. ✅ Validate coverage: all interactive elements should have both types
5. ✅ Review with QA and accessibility teams
## Detailed References
For comprehensive guides, examples, and patterns, see:
- **[E2E Testing Attributes](references/e2e-attributes.md)** - Complete E2E attribute patterns and conventions
- **[ARIA Accessibility Attributes](references/aria-attributes.md)** - Comprehensive ARIA guidance and WCAG compliance
- **[Combined Patterns](references/combined-patterns.md)** - Real-world examples with both attribute types
## Project-Specific Links
- **Testing Guidelines**: `docs/guidelines/testing.md` - Project testing standards including E2E attributes
- **CLAUDE.md**: Project conventions and requirements
- **Angular Template Skill**: `.claude/skills/angular-template` - For Angular-specific syntax
## Validation Checklist
Before considering template complete:
- [ ] All buttons have `data-what`, `data-which`, and `aria-label`
- [ ] All inputs have `data-what`, `data-which`, and appropriate ARIA attributes
- [ ] All links have `data-what`, `data-which`, and descriptive ARIA labels
- [ ] Dynamic lists use `[attr.data-*]` bindings with unique identifiers
- [ ] Dialogs have proper ARIA roles and relationships
- [ ] Forms have proper field associations and error announcements
- [ ] Interactive elements are keyboard accessible (tabindex where needed)
- [ ] No duplicate `data-which` values within the same view
- [ ] Screen reader testing completed (if applicable)
## Example: Complete Form
```html
<form
data-what="registration-form"
data-which="user-signup"
role="form"
aria-labelledby="form-title">
<h2 id="form-title">User Registration</h2>
<div class="form-field">
<label for="username-input">Username</label>
<input
id="username-input"
type="text"
[(ngModel)]="username"
data-what="username-input"
data-which="registration-form"
aria-required="true"
aria-describedby="username-hint" />
<span id="username-hint">Must be at least 3 characters</span>
</div>
<div class="form-field">
<label for="email-input">Email</label>
<input
id="email-input"
type="email"
[(ngModel)]="email"
data-what="email-input"
data-which="registration-form"
aria-required="true"
[attr.aria-invalid]="emailError ? 'true' : null"
aria-describedby="email-error" />
@if (emailError) {
<span
id="email-error"
role="alert"
aria-live="polite">
{{ emailError }}
</span>
}
</div>
<div class="form-actions">
<button
type="submit"
(click)="onSubmit()"
data-what="submit-button"
data-which="registration-form"
[attr.aria-disabled]="!isValid"
aria-label="Submit registration form">
Register
</button>
<button
type="button"
(click)="onCancel()"
data-what="cancel-button"
data-which="registration-form"
aria-label="Cancel registration">
Cancel
</button>
</div>
</form>
```
## Remember
- **Always use both E2E and ARIA attributes together**
- **E2E attributes enable automated testing** - your QA team relies on them
- **ARIA attributes enable accessibility** - legal requirement and right thing to do
- **Test with real users and assistive technologies** - automated checks aren't enough
- **Keep attributes up-to-date** - maintain as code changes
---
**This skill works automatically with Angular templates. Both E2E and ARIA attributes should be added to every interactive element.**

View File

File diff suppressed because it is too large Load Diff

View File

File diff suppressed because it is too large Load Diff

View File

@@ -0,0 +1,842 @@
# E2E Testing Attributes - Complete Reference
This reference provides comprehensive guidance for adding E2E (End-to-End) testing attributes to HTML templates for reliable automated testing.
## Table of Contents
- [Overview](#overview)
- [Core Attribute Types](#core-attribute-types)
- [Why E2E Attributes?](#why-e2e-attributes)
- [Naming Conventions](#naming-conventions)
- [Patterns by Element Type](#patterns-by-element-type)
- [Patterns by Component Type](#patterns-by-component-type)
- [Dynamic Attributes](#dynamic-attributes)
- [Best Practices](#best-practices)
- [Validation](#validation)
- [Testing Integration](#testing-integration)
## Overview
E2E testing attributes provide stable, semantic selectors for automated testing. They enable QA automation without relying on brittle CSS classes, IDs, or XPath selectors that frequently break when styling changes.
## Core Attribute Types
### 1. `data-what` (Required)
**Purpose**: Semantic description of the element's purpose or type
**Format**: kebab-case string
**Examples**:
- `data-what="submit-button"`
- `data-what="search-input"`
- `data-what="product-link"`
- `data-what="list-item"`
**Guidelines**:
- Describes WHAT the element is or does
- Should be consistent across similar elements
- Use descriptive, semantic names
- Keep it concise but clear
### 2. `data-which` (Required)
**Purpose**: Unique identifier for the specific instance of this element type
**Format**: kebab-case string or dynamic binding
**Examples**:
- `data-which="primary"` (static)
- `data-which="customer-form"` (static)
- `[attr.data-which]="item.id"` (dynamic)
- `[attr.data-which]="'customer-' + customerId"` (dynamic with context)
**Guidelines**:
- Identifies WHICH specific instance of this element type
- Must be unique within the same view/component
- Use dynamic binding for list items: `[attr.data-which]="item.id"`
- Can combine multiple identifiers: `data-which="customer-123-edit"`
### 3. `data-*` (Contextual)
**Purpose**: Additional contextual information about state, status, or data
**Format**: Custom attributes with kebab-case names
**Examples**:
- `data-status="active"`
- `data-index="0"`
- `data-role="admin"`
- `[attr.data-count]="items.length"`
**Guidelines**:
- Use for additional context that helps testing
- Avoid sensitive data (passwords, tokens, PII)
- Use Angular binding for dynamic values: `[attr.data-*]`
- Keep attribute names semantic and clear
## Why E2E Attributes?
### Problems with Traditional Selectors
**CSS Classes (Bad)**:
```html
<!-- Brittle - breaks when styling changes -->
<button class="btn btn-primary submit">Submit</button>
```
```javascript
// Test breaks when class names change
await page.click('.btn-primary.submit');
```
**XPath (Bad)**:
```javascript
// Brittle - breaks when structure changes
await page.click('//div[@class="form"]/button[2]');
```
**IDs (Better, but limited)**:
```html
<!-- IDs must be unique across entire page -->
<button id="submit-btn">Submit</button>
```
### Benefits of E2E Attributes
**Stable, Semantic Selectors (Good)**:
```html
<button
class="btn btn-primary"
data-what="submit-button"
data-which="registration-form">
Submit
</button>
```
```javascript
// Stable - survives styling and structure changes
await page.click('[data-what="submit-button"][data-which="registration-form"]');
```
**Advantages**:
- ✅ Decoupled from styling (CSS classes can change freely)
- ✅ Semantic and self-documenting
- ✅ Consistent across the application
- ✅ Easy to read and maintain
- ✅ Survives refactoring and restructuring
- ✅ QA and developers speak the same language
## Naming Conventions
### Common `data-what` Patterns
| Pattern | Use Case | Examples |
|---------|----------|----------|
| `*-button` | All button elements | `submit-button`, `cancel-button`, `delete-button`, `save-button` |
| `*-input` | Text inputs and textareas | `email-input`, `search-input`, `quantity-input`, `password-input` |
| `*-select` | Dropdown/select elements | `status-select`, `category-select`, `country-select` |
| `*-checkbox` | Checkbox inputs | `terms-checkbox`, `subscribe-checkbox`, `remember-checkbox` |
| `*-radio` | Radio button inputs | `payment-radio`, `shipping-radio` |
| `*-link` | Navigation links | `product-link`, `order-link`, `customer-link`, `home-link` |
| `*-item` | List/grid items | `list-item`, `menu-item`, `card-item`, `row-item` |
| `*-dialog` | Modals and dialogs | `confirm-dialog`, `error-dialog`, `info-dialog` |
| `*-dropdown` | Dropdown menus | `actions-dropdown`, `filter-dropdown` |
| `*-toggle` | Toggle switches | `theme-toggle`, `notifications-toggle` |
| `*-tab` | Tab navigation | `profile-tab`, `settings-tab` |
| `*-badge` | Status badges | `status-badge`, `count-badge` |
| `*-icon` | Interactive icons | `close-icon`, `menu-icon`, `search-icon` |
### `data-which` Naming Guidelines
**Static unique identifiers** (single instance):
- `data-which="primary"` - Primary action button
- `data-which="secondary"` - Secondary action button
- `data-which="main-search"` - Main search input
- `data-which="customer-form"` - Customer form context
**Dynamic identifiers** (multiple instances):
- `[attr.data-which]="item.id"` - List item by ID
- `[attr.data-which]="'product-' + product.id"` - Product item
- `[attr.data-which]="index"` - By array index (use sparingly)
**Contextual identifiers** (combine context):
- `data-which="customer-{{ customerId }}-edit"` - Edit button for specific customer
- `data-which="order-{{ orderId }}-cancel"` - Cancel button for specific order
## Patterns by Element Type
### Buttons
```html
<!-- Submit Button -->
<button
type="submit"
(click)="onSubmit()"
data-what="submit-button"
data-which="registration-form">
Submit
</button>
<!-- Cancel Button -->
<button
type="button"
(click)="onCancel()"
data-what="cancel-button"
data-which="registration-form">
Cancel
</button>
<!-- Delete Button with Confirmation -->
<button
(click)="onDelete(item)"
data-what="delete-button"
[attr.data-which]="item.id"
[attr.data-status]="item.canDelete ? 'enabled' : 'disabled'">
Delete
</button>
<!-- Icon Button -->
<button
(click)="toggleMenu()"
data-what="menu-button"
data-which="main-nav"
aria-label="Toggle menu">
<i class="icon-menu"></i>
</button>
<!-- Custom Button Component -->
<ui-button
(click)="save()"
data-what="save-button"
data-which="order-form">
Save Order
</ui-button>
```
### Inputs
```html
<!-- Text Input -->
<input
type="text"
[(ngModel)]="email"
placeholder="Email address"
data-what="email-input"
data-which="registration-form" />
<!-- Textarea -->
<textarea
[(ngModel)]="comments"
data-what="comments-textarea"
data-which="feedback-form"
rows="4"></textarea>
<!-- Number Input with State -->
<input
type="number"
[(ngModel)]="quantity"
data-what="quantity-input"
data-which="order-form"
[attr.data-min]="minQuantity"
[attr.data-max]="maxQuantity" />
<!-- Search Input -->
<input
type="search"
[(ngModel)]="searchTerm"
(input)="onSearch()"
placeholder="Search products..."
data-what="search-input"
data-which="product-catalog" />
<!-- Password Input -->
<input
type="password"
[(ngModel)]="password"
data-what="password-input"
data-which="login-form" />
```
### Select/Dropdown
```html
<!-- Basic Select -->
<select
[(ngModel)]="selectedStatus"
data-what="status-select"
data-which="order-filter">
<option value="">All Statuses</option>
<option value="pending">Pending</option>
<option value="completed">Completed</option>
</select>
<!-- Custom Dropdown Component -->
<ui-dropdown
[(value)]="selectedCategory"
data-what="category-dropdown"
data-which="product-filter">
</ui-dropdown>
```
### Checkboxes and Radios
```html
<!-- Checkbox -->
<label>
<input
type="checkbox"
[(ngModel)]="agreedToTerms"
data-what="terms-checkbox"
data-which="registration-form" />
I agree to the terms
</label>
<!-- Radio Group -->
<div data-what="payment-radio-group" data-which="checkout-form">
<label>
<input
type="radio"
name="payment"
value="credit"
[(ngModel)]="paymentMethod"
data-what="payment-radio"
data-which="credit-card" />
Credit Card
</label>
<label>
<input
type="radio"
name="payment"
value="paypal"
[(ngModel)]="paymentMethod"
data-what="payment-radio"
data-which="paypal" />
PayPal
</label>
</div>
```
### Links
```html
<!-- Static Link -->
<a
routerLink="/about"
data-what="nav-link"
data-which="about">
About Us
</a>
<!-- Dynamic Link with ID -->
<a
[routerLink]="['/products', product.id]"
data-what="product-link"
[attr.data-which]="product.id">
{{ product.name }}
</a>
<!-- External Link -->
<a
href="https://example.com"
target="_blank"
data-what="external-link"
data-which="documentation">
Documentation
</a>
<!-- Action Link (not navigation) -->
<a
(click)="downloadReport()"
data-what="download-link"
data-which="sales-report">
Download Report
</a>
```
### Lists and Tables
```html
<!-- Dynamic List with @for -->
<ul data-what="product-list" data-which="catalog">
@for (product of products; track product.id) {
<li
(click)="selectProduct(product)"
data-what="list-item"
[attr.data-which]="product.id"
[attr.data-status]="product.stock > 0 ? 'in-stock' : 'out-of-stock'">
{{ product.name }}
</li>
}
</ul>
<!-- Table Row -->
<table data-what="orders-table" data-which="customer-orders">
<tbody>
@for (order of orders; track order.id) {
<tr
data-what="table-row"
[attr.data-which]="order.id">
<td>{{ order.id }}</td>
<td>{{ order.date }}</td>
<td>
<button
data-what="view-button"
[attr.data-which]="order.id">
View
</button>
</td>
</tr>
}
</tbody>
</table>
```
### Dialogs and Modals
```html
<!-- Confirmation Dialog -->
<div
*ngIf="showDialog"
data-what="confirmation-dialog"
data-which="delete-item">
<h2>Confirm Deletion</h2>
<p>Are you sure you want to delete this item?</p>
<button
(click)="confirmDelete()"
data-what="confirm-button"
data-which="delete-dialog">
Delete
</button>
<button
(click)="cancelDelete()"
data-what="cancel-button"
data-which="delete-dialog">
Cancel
</button>
</div>
<!-- Info Dialog with Close -->
<div
data-what="info-dialog"
data-which="welcome-message">
<button
(click)="closeDialog()"
data-what="close-button"
data-which="dialog">
×
</button>
<div data-what="dialog-content" data-which="welcome">
<h2>Welcome!</h2>
<p>Thank you for joining us.</p>
</div>
</div>
```
## Patterns by Component Type
### Form Components
```html
<form data-what="user-form" data-which="registration">
<!-- Field inputs -->
<input
data-what="username-input"
data-which="registration-form"
type="text" />
<input
data-what="email-input"
data-which="registration-form"
type="email" />
<!-- Action buttons -->
<button
data-what="submit-button"
data-which="registration-form"
type="submit">
Submit
</button>
<button
data-what="cancel-button"
data-which="registration-form"
type="button">
Cancel
</button>
</form>
```
### List/Table Components
```html
<!-- Each item needs unique data-which -->
@for (item of items; track item.id) {
<div
data-what="list-item"
[attr.data-which]="item.id">
<span data-what="item-name" [attr.data-which]="item.id">
{{ item.name }}
</span>
<button
data-what="edit-button"
[attr.data-which]="item.id">
Edit
</button>
<button
data-what="delete-button"
[attr.data-which]="item.id">
Delete
</button>
</div>
}
```
### Navigation Components
```html
<nav data-what="main-navigation" data-which="header">
<a
routerLink="/dashboard"
data-what="nav-link"
data-which="dashboard">
Dashboard
</a>
<a
routerLink="/orders"
data-what="nav-link"
data-which="orders">
Orders
</a>
<a
routerLink="/customers"
data-what="nav-link"
data-which="customers">
Customers
</a>
</nav>
<!-- Breadcrumbs -->
<nav data-what="breadcrumb" data-which="page-navigation">
@for (crumb of breadcrumbs; track $index) {
<a
[routerLink]="crumb.url"
data-what="breadcrumb-link"
[attr.data-which]="crumb.id">
{{ crumb.label }}
</a>
}
</nav>
```
### Dialog/Modal Components
```html
<!-- All dialog buttons need clear identifiers -->
<div data-what="modal" data-which="user-settings">
<button
data-what="close-button"
data-which="modal">
Close
</button>
<button
data-what="save-button"
data-which="modal">
Save Changes
</button>
<button
data-what="reset-button"
data-which="modal">
Reset to Defaults
</button>
</div>
```
## Dynamic Attributes
### Using Angular Binding
When values need to be dynamic, use Angular's attribute binding:
```html
<!-- Static (simple values) -->
<button data-what="submit-button" data-which="form">
<!-- Dynamic (from component properties) -->
<button
data-what="submit-button"
[attr.data-which]="formId">
<!-- Dynamic (from loop variables) -->
@for (item of items; track item.id) {
<div
data-what="list-item"
[attr.data-which]="item.id"
[attr.data-status]="item.status"
[attr.data-index]="$index">
</div>
}
<!-- Dynamic (computed values) -->
<button
data-what="action-button"
[attr.data-which]="'customer-' + customerId + '-' + action">
</button>
```
### Loop Variables
Angular's `@for` provides special variables:
```html
@for (item of items; track item.id; let idx = $index; let isFirst = $first) {
<div
data-what="list-item"
[attr.data-which]="item.id"
[attr.data-index]="idx"
[attr.data-first]="isFirst">
{{ item.name }}
</div>
}
```
## Best Practices
### Do's ✅
1. **Add to ALL interactive elements**
- Buttons, inputs, links, clickable elements
- Custom components that handle user interaction
- Form controls and navigation items
2. **Use consistent naming**
- Follow the naming patterns (e.g., `*-button`, `*-input`)
- Use kebab-case consistently
- Be descriptive but concise
3. **Ensure uniqueness**
- `data-which` must be unique within the view
- Use item IDs for list items: `[attr.data-which]="item.id"`
- Combine context when needed: `data-which="form-primary-submit"`
4. **Use Angular binding for dynamic values**
- `[attr.data-which]="item.id"`
- `data-which="{{ item.id }}"` ❌ (avoid interpolation)
5. **Document complex patterns**
- Add comments for non-obvious attribute choices
- Document the expected test selectors
6. **Keep attributes updated**
- Update when element purpose changes
- Remove when elements are removed
- Maintain consistency across refactoring
### Don'ts ❌
1. **Don't include sensitive data**
-`data-which="password-{{ userPassword }}"`
-`data-token="{{ authToken }}"`
-`data-ssn="{{ socialSecurity }}"`
2. **Don't use generic values**
-`data-what="button"` (too generic)
-`data-what="submit-button"` (specific)
3. **Don't duplicate `data-which` in the same view**
- ❌ Two buttons with `data-which="primary"`
-`data-which="form-primary"` and `data-which="dialog-primary"`
4. **Don't rely only on index for lists**
-`[attr.data-which]="$index"` (changes when list reorders)
-`[attr.data-which]="item.id"` (stable identifier)
5. **Don't forget about custom components**
- Custom components need attributes too
- Attributes should be on the component tag, not just internal elements
## Validation
### Coverage Check
Ensure all interactive elements have E2E attributes:
```bash
# Count interactive elements
grep -E '\(click\)|routerLink|button|input|select|textarea' component.html | wc -l
# Count elements with data-what
grep -c 'data-what=' component.html
# Find elements missing E2E attributes
grep -E '\(click\)|button' component.html | grep -v 'data-what='
```
### Uniqueness Check
Verify no duplicate `data-which` values in the same template:
```typescript
// In component tests
it('should have unique data-which attributes', () => {
const elements = fixture.nativeElement.querySelectorAll('[data-which]');
const dataWhichValues = Array.from(elements).map(
(el: any) => el.getAttribute('data-which')
);
const uniqueValues = new Set(dataWhichValues);
expect(dataWhichValues.length).toBe(uniqueValues.size);
});
```
### Validation Checklist
- [ ] All buttons have `data-what` and `data-which`
- [ ] All inputs have `data-what` and `data-which`
- [ ] All links have `data-what` and `data-which`
- [ ] All clickable elements have attributes
- [ ] Dynamic lists use `[attr.data-which]="item.id"`
- [ ] No duplicate `data-which` values in the same view
- [ ] No sensitive data in attributes
- [ ] Custom components have attributes
- [ ] Attributes use kebab-case
- [ ] Coverage: 100% of interactive elements
## Testing Integration
### Using E2E Attributes in Tests
**Unit Tests (Angular Testing Utilities)**:
```typescript
import { ComponentFixture, TestBed } from '@angular/core/testing';
describe('MyComponent', () => {
let fixture: ComponentFixture<MyComponent>;
beforeEach(async () => {
await TestBed.configureTestingModule({
imports: [MyComponent],
}).compileComponents();
fixture = TestBed.createComponent(MyComponent);
fixture.detectChanges();
});
it('should have submit button with E2E attributes', () => {
const button = fixture.nativeElement.querySelector(
'[data-what="submit-button"][data-which="registration-form"]'
);
expect(button).toBeTruthy();
expect(button.textContent).toContain('Submit');
});
it('should have unique data-which for list items', () => {
const items = fixture.nativeElement.querySelectorAll('[data-what="list-item"]');
const dataWhichValues = Array.from(items).map(
(item: any) => item.getAttribute('data-which')
);
// All should have unique IDs
const uniqueValues = new Set(dataWhichValues);
expect(dataWhichValues.length).toBe(uniqueValues.size);
});
});
```
**E2E Tests (Playwright)**:
```typescript
import { test, expect } from '@playwright/test';
test('user registration flow', async ({ page }) => {
await page.goto('/register');
// Fill form using E2E attributes
await page.fill(
'[data-what="username-input"][data-which="registration-form"]',
'johndoe'
);
await page.fill(
'[data-what="email-input"][data-which="registration-form"]',
'john@example.com'
);
// Click submit using E2E attributes
await page.click(
'[data-what="submit-button"][data-which="registration-form"]'
);
// Verify success
await expect(page.locator('[data-what="success-message"]')).toBeVisible();
});
```
**E2E Tests (Cypress)**:
```typescript
describe('Order Management', () => {
it('should edit an order', () => {
cy.visit('/orders');
// Find specific order by ID using data-which
cy.get('[data-what="list-item"][data-which="order-123"]')
.should('be.visible');
// Click edit button for that specific order
cy.get('[data-what="edit-button"][data-which="order-123"]')
.click();
// Update quantity
cy.get('[data-what="quantity-input"][data-which="order-form"]')
.clear()
.type('5');
// Save changes
cy.get('[data-what="save-button"][data-which="order-form"]')
.click();
});
});
```
## Documentation in Templates
Add comment blocks to document E2E attributes:
```html
<!--
E2E Test Attributes:
- data-what="submit-button" data-which="registration-form" - Main form submission
- data-what="cancel-button" data-which="registration-form" - Cancel registration
- data-what="username-input" data-which="registration-form" - Username field
- data-what="email-input" data-which="registration-form" - Email field
- data-what="password-input" data-which="registration-form" - Password field
-->
<form data-what="registration-form" data-which="user-signup">
<!-- Form content -->
</form>
```
## Related Documentation
- **[ARIA Accessibility Attributes](aria-attributes.md)** - Accessibility guidance
- **[Combined Patterns](combined-patterns.md)** - Examples with E2E + ARIA together
- **Testing Guidelines**: `docs/guidelines/testing.md` - Project testing standards
- **CLAUDE.md**: Project code quality requirements
## Summary
E2E testing attributes are essential for:
- ✅ Stable, maintainable automated tests
- ✅ Clear communication between developers and QA
- ✅ Tests that survive styling and structural changes
- ✅ Self-documenting code that expresses intent
- ✅ Reliable CI/CD pipelines
**Always add `data-what` and `data-which` to every interactive element.**

View File

@@ -1,6 +1,6 @@
---
name: library-scaffolder
description: This skill should be used when creating new Angular libraries in the ISA-Frontend monorepo. It handles Nx library generation with proper naming conventions, Vitest configuration with JUnit/Cobertura reporters, path alias setup, and validation. Use this skill when the user wants to create a new library, scaffold a feature/data-access/ui/util library, or requests "new library" creation.
description: This skill should be used when creating feature/data-access/ui/util libraries or user says "create library", "new library", "scaffold library". Creates new Angular libraries in ISA-Frontend monorepo with proper Nx configuration, Vitest setup, architectural tags, and path aliases.
---
# Library Scaffolder
@@ -51,6 +51,7 @@ npx nx generate @nx/angular:library \
--name=[domain]-[layer]-[name] \
--directory=libs/[domain]/[layer]/[name] \
--importPath=@isa/[domain]/[layer]/[name] \
--prefix=[domain] \
--style=css \
--unitTestRunner=vitest \
--standalone=true \
@@ -69,13 +70,53 @@ npx nx generate @nx/angular:library \
--name=[domain]-[layer]-[name] \
--directory=libs/[domain]/[layer]/[name] \
--importPath=@isa/[domain]/[layer]/[name] \
--prefix=[domain] \
--style=css \
--unitTestRunner=vitest \
--standalone=true \
--skipTests=false
```
### Step 4: Configure Vitest with JUnit and Cobertura
### Step 4: Add Architectural Tags
**CRITICAL**: Immediately after library generation, add proper tags to `project.json` for `@nx/enforce-module-boundaries`.
Run the tagging script:
```bash
node scripts/add-library-tags.js
```
Or manually add tags to `libs/[domain]/[layer]/[name]/project.json`:
```json
{
"name": "[domain]-[layer]-[name]",
"tags": [
"scope:[domain]",
"type:[layer]"
]
}
```
**Tag Rules:**
- **Scope tag**: `scope:[domain]` (e.g., `scope:oms`, `scope:crm`, `scope:ui`, `scope:shared`)
- **Type tag**: `type:[layer]` (e.g., `type:feature`, `type:data-access`, `type:ui`, `type:util`)
**Examples:**
- `libs/oms/feature/return-search``["scope:oms", "type:feature"]`
- `libs/ui/buttons``["scope:ui", "type:ui"]`
- `libs/shared/scanner``["scope:shared", "type:shared"]`
- `libs/core/auth``["scope:core", "type:core"]`
**Verification:**
```bash
# Check tags were added
cat libs/[domain]/[layer]/[name]/project.json | jq '.tags'
# Should output: ["scope:[domain]", "type:[layer]"]
```
### Step 5: Configure Vitest with JUnit and Cobertura
Update `libs/[path]/vite.config.mts`:
@@ -113,7 +154,7 @@ defineConfig(() => ({
**Critical**: Adjust path depth based on library location.
### Step 5: Verify Configuration
### Step 6: Verify Configuration
1. **Check Path Alias**
- Verify `tsconfig.base.json` was updated
@@ -128,7 +169,7 @@ defineConfig(() => ({
- JUnit XML: `testresults/junit-[library-name].xml`
- Cobertura XML: `coverage/libs/[path]/cobertura-coverage.xml`
### Step 6: Create Library README
### Step 7: Create Library README
Use `docs-researcher` to find similar library READMEs, then create comprehensive documentation including:
- Overview and purpose
@@ -137,7 +178,7 @@ Use `docs-researcher` to find similar library READMEs, then create comprehensive
- Usage examples
- Testing information (Vitest + Angular Testing Utilities)
### Step 7: Update Library Reference
### Step 8: Update Library Reference
Add entry to `docs/library-reference.md` under appropriate domain:
@@ -150,10 +191,10 @@ Add entry to `docs/library-reference.md` under appropriate domain:
[Brief description]
```
### Step 8: Run Full Validation
### Step 9: Run Full Validation
```bash
# Lint
# Lint (includes boundary checks)
npx nx lint [library-name]
# Test with coverage
@@ -166,7 +207,7 @@ npx nx build [library-name]
npx nx graph --focus=[library-name]
```
### Step 9: Generate Creation Report
### Step 10: Generate Creation Report
```
Library Created Successfully
@@ -181,6 +222,7 @@ Import Alias: @isa/[domain]/[layer]/[name]
Test Framework: Vitest with Angular Testing Utilities
Style: CSS
Standalone: Yes
Tags: scope:[domain], type:[layer]
JUnit Reporter: ✅ testresults/junit-[library-name].xml
Cobertura Coverage: ✅ coverage/libs/[path]/cobertura-coverage.xml
@@ -193,12 +235,18 @@ import { Component } from '@isa/[domain]/[layer]/[name]';
npx nx test [library-name] --skip-nx-cache
npx nx test [library-name] --coverage.enabled=true --skip-nx-cache
🏗️ Architecture Compliance
--------------------------
Tags enforce module boundaries via @nx/enforce-module-boundaries
Run lint to check for violations: npx nx lint [library-name]
📝 Next Steps
-------------
1. Develop library features
2. Write tests using Vitest + Angular Testing Utilities
3. Add E2E attributes (data-what, data-which) to templates
4. Update README with usage examples
5. Follow architecture rules (see eslint.config.js for constraints)
```
## Error Handling
@@ -220,4 +268,8 @@ npx nx test [library-name] --coverage.enabled=true --skip-nx-cache
- docs/guidelines/testing.md (Vitest, JUnit, Cobertura sections)
- docs/library-reference.md (domain patterns)
- CLAUDE.md (Library Organization, Testing Framework sections)
- eslint.config.js (@nx/enforce-module-boundaries configuration)
- scripts/add-library-tags.js (automatic tagging script)
- .claude/skills/architecture-enforcer (boundary validation)
- Nx Angular Library Generator: https://nx.dev/nx-api/angular/generators/library
- Nx Enforce Module Boundaries: https://nx.dev/nx-api/eslint-plugin/documents/enforce-module-boundaries

View File

@@ -1,6 +1,6 @@
---
name: logging-helper
description: Ensures consistent usage of the @isa/core/logging library across the codebase with best practices for performance and maintainability
name: logging
description: This skill should be used when working with Angular components, directives, services, pipes, guards, or TypeScript classes. Logging is MANDATORY in all Angular files. Implements @isa/core/logging with logger() factory pattern, appropriate log levels, lazy evaluation for performance, error handling, and avoids console.log and common mistakes.
---
# Logging Helper Skill

View File

@@ -0,0 +1,287 @@
---
name: ngrx-resource-api
description: This skill should be used when implementing Angular's Resource API with NgRx Signal Store for reactive data management. Use when creating signal stores that load data reactively, need automatic race condition prevention, or require declarative resource management without RxJS. Applies to data-access libraries, feature stores with API integration, and components needing reactive filtering or pagination.
---
# NgRx Resource API
## Overview
This skill enables integration of Angular's Resource API with NgRx Signal Store to create reactive data flows without RxJS while automatically preventing race conditions. The Resource API handles concurrent request management declaratively, eliminating manual `switchMap` or `takeUntilDestroyed` patterns.
## Core Architectural Concepts
### Reactive Flow Graph
Establish three clear interaction points in the store:
1. **Filter signals trigger resource loading** - Parameter changes automatically reload resources
2. **Methods explicitly invoke operations** - Use `signalMethod` for user-triggered actions
3. **Computed signals derive view models** - Transform loaded data for component consumption
### The withProps Pattern for Dependency Injection
Inject services via `withProps` with underscore-prefixed properties to mark them as internal implementation details:
```typescript
withProps(() => ({
_dataService: inject(DataService),
_notificationService: inject(ToastService),
}))
```
**Benefits:**
- Centralizes dependency injection in one location
- Clear distinction between internal (prefixed) and public properties
- Services available to all subsequent feature sections
## Implementation Steps
### Step 1: Inject Services with withProps
Create the initial `withProps` section to inject required services:
```typescript
export const MyStore = signalStore(
withProps(() => ({
_dataService: inject(DataService),
_toastService: inject(ToastService),
})),
// ... additional features
);
```
**Naming convention:** Prefix all injected services with underscore (`_`) to indicate internal use.
### Step 2: Define Filter State
Add state properties that will serve as resource parameters:
```typescript
withState({
filter: {
searchTerm: '',
category: '',
} as MyFilter,
})
```
### Step 3: Configure Resources
In a subsequent `withProps` section, create resources that reference the injected services and state:
```typescript
withProps((store) => ({
_itemsResource: resource({
params: store.filter,
loader: (loaderParams) => {
const filter = loaderParams.params;
const abortSignal = loaderParams.abortSignal;
return store._dataService.loadItems(filter, abortSignal);
}
})
}))
```
**Key points:**
- Resources automatically reload when `params` signal changes
- `abortSignal` enables automatic cancellation of in-flight requests
- Loader must return a Promise (use `.findPromise()` if service returns Observable)
### Step 4: Expose Read-Only Resources (Optional)
If the resource should be accessible to consumers, expose it as read-only:
```typescript
withProps((store) => ({
itemsResource: store._itemsResource.asReadonly(),
}))
```
**Pattern:** Internal resources use underscore prefix, public versions are read-only without prefix.
### Step 5: Create Signal Methods for Updates
Use `signalMethod` for actions that update state and trigger resource reloads:
```typescript
withMethods((store) => ({
updateFilter: signalMethod<MyFilter>((filter) => {
patchState(store, { filter });
}),
refresh: () => {
store._itemsResource.reload();
}
}))
```
**Important:** `signalMethod` implementations are **untracked by convention** - they don't re-execute when signals change. This provides explicit control flow.
### Step 6: Add Error Handling
Use `withHooks` to react to resource errors:
```typescript
withHooks({
onInit: (store) => {
effect(() => {
const error = store._itemsResource.error();
if (error) {
store._toastService.show('Error: ' + getMessage(error));
}
});
}
})
```
**Pattern:** Error effects should be read-only - they observe errors and trigger side effects, but don't modify state.
## Common Patterns
### Template Integration with linkedSignal
For two-way form binding that synchronizes with the store:
```typescript
export class MyComponent {
#store = inject(MyStore);
// Create linked signal for form field
searchTerm = linkedSignal(() => this.#store.filter().searchTerm);
// Combine form fields into filter object
#linkedFilter = computed(() => ({
searchTerm: this.searchTerm(),
// ... other fields
}));
constructor() {
// Sync form changes back to store
this.#store.updateFilter(this.#linkedFilter);
}
}
```
**Benefits:**
- Two-way binding for forms
- Automatic store synchronization
- Type-safe filter construction
### Working with Resource Data
Access resource data through resource signals:
```typescript
withComputed((store) => ({
items: computed(() => store._itemsResource.value() ?? []),
isLoading: computed(() => store._itemsResource.isLoading()),
hasError: computed(() => store._itemsResource.hasError()),
}))
```
**Available signals:**
- `value()` - The loaded data (undefined while loading)
- `isLoading()` - Loading state boolean
- `hasError()` - Error state boolean
- `error()` - Error object if present
- `status()` - Overall status: 'idle' | 'loading' | 'resolved' | 'error'
### Updating Resource Data Locally
For temporary working copies before server writes:
```typescript
withMethods((store) => ({
updateLocalItem: (id: string, changes: Partial<Item>) => {
store._itemsResource.update((currentItems) => {
return currentItems.map(item =>
item.id === id ? { ...item, ...changes } : item
);
});
}
}))
```
**Note:** This pattern feels unconventional but aligns with maintaining temporary working copies before server persistence.
### Multiple Resources in One Store
Combine multiple resources for complex data requirements:
```typescript
withProps((store) => ({
_itemsResource: resource({
params: store.filter,
loader: (params) => store._dataService.loadItems(params.params, params.abortSignal)
}),
_detailsResource: resource({
params: store.selectedId,
loader: (params) => {
if (!params.params) return Promise.resolve(null);
return store._dataService.loadDetails(params.params, params.abortSignal);
}
})
}))
```
**Pattern:** Each resource has independent params and loading state, but can share service instances.
## Important Considerations
### Race Condition Prevention
The Resource API automatically handles race conditions:
- New requests automatically cancel pending requests
- No need for `switchMap`, `takeUntilDestroyed`, or manual abort handling
- Declarative parameter changes trigger clean cancellation
### Untracked Signal Methods
`signalMethod` implementations deliberately skip reactive tracking:
- Provides explicit, predictable control flow
- Prevents unexpected re-executions from signal changes
- Makes side effects obvious at call sites
### Loader Function Requirements
Loaders must:
- Return a `Promise` (not Observable)
- Accept and pass through the `abortSignal` to enable cancellation
- Handle the signal in the underlying HTTP call
**Converting Observables:**
```typescript
loader: (params) => {
return firstValueFrom(
this._service.load$(params.params)
.pipe(takeUntilDestroyed(this._destroyRef))
);
}
```
### Resource Lifecycle
Resources maintain their own state machine:
1. **Idle** - Initial state before first load
2. **Loading** - Request in progress
3. **Resolved** - Data loaded successfully
4. **Error** - Request failed
State transitions automatically trigger reactive updates to dependent computeds and effects.
## When to Use This Pattern
**Use Resource API with Signal Store when:**
- Loading data based on reactive filter/search parameters
- Need automatic race condition handling for concurrent requests
- Want declarative data loading without RxJS subscriptions
- Building stores with frequently changing query parameters
- Implementing pagination, filtering, or search features
**Consider alternatives when:**
- Simple one-time data loads (use `rxMethod` or direct service calls)
- Complex Observable chains with multiple operators needed
- Need fine-grained control over request timing/caching
- Working with WebSocket or SSE streams (use `rxMethod` instead)

View File

@@ -1,5 +1,5 @@
---
name: tailwind-isa
name: tailwind
description: This skill should be used when working with Tailwind CSS styling in the ISA-Frontend project. Use it when writing component styles, choosing color values, applying typography, creating buttons, or determining appropriate spacing and layout utilities. Essential for maintaining design system consistency.
---
@@ -23,6 +23,15 @@ Invoke this skill when:
**Important**: This skill provides Tailwind utilities. Always prefer using components from `@isa/ui/*` libraries before applying custom Tailwind styles.
**Works together with:**
- **[angular-template](../angular-template/SKILL.md)** - Angular template syntax, control flow (@if, @for, @defer), and binding patterns
- **[html-template](../html-template/SKILL.md)** - E2E testing attributes (`data-what`, `data-which`) and ARIA accessibility
When building Angular components, these three skills work together:
1. Use **angular-template** for Angular syntax and control flow
2. Use **html-template** for `data-*` and ARIA attributes
3. Use **tailwind** (this skill) for styling with the ISA design system
## Core Design System Principles
### 0. Component Libraries First (Most Important)

View File

@@ -0,0 +1,346 @@
# Jest to Vitest Migration Patterns
## Overview
This reference provides syntax mappings and patterns for migrating tests from Jest (with Spectator) to Vitest (with Angular Testing Library).
## Configuration Migration
### Jest Config → Vitest Config
**Before (jest.config.ts):**
```typescript
export default {
displayName: 'my-lib',
preset: '../../jest.preset.js',
setupFilesAfterEnv: ['<rootDir>/src/test-setup.ts'],
coverageDirectory: '../../coverage/libs/my-lib',
transform: {
'^.+\\.(ts|mjs|js|html)$': 'jest-preset-angular',
},
transformIgnorePatterns: ['node_modules/(?!.*\\.mjs$)'],
snapshotSerializers: [
'jest-preset-angular/build/serializers/no-ng-attributes',
'jest-preset-angular/build/serializers/ng-snapshot',
],
};
```
**After (vitest.config.ts):**
```typescript
import { defineConfig } from 'vitest/config';
import angular from '@analogjs/vite-plugin-angular';
export default defineConfig({
plugins: [angular()],
test: {
globals: true,
environment: 'jsdom',
setupFiles: ['src/test-setup.ts'],
include: ['**/*.spec.ts'],
reporters: ['default'],
coverage: {
provider: 'v8',
reporter: ['text', 'json', 'html'],
},
},
});
```
### Test Setup Migration
**Before (test-setup.ts - Jest):**
```typescript
import 'jest-preset-angular/setup-jest';
```
**After (test-setup.ts - Vitest):**
```typescript
import '@analogjs/vitest-angular/setup-zone';
```
## Import Changes
### Test Function Imports
**Before (Jest):**
```typescript
import { describe, it, expect, beforeEach, afterEach } from '@jest/globals';
```
**After (Vitest):**
```typescript
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
```
### Mock Imports
**Before (Jest):**
```typescript
jest.fn()
jest.spyOn()
jest.mock()
jest.useFakeTimers()
```
**After (Vitest):**
```typescript
vi.fn()
vi.spyOn()
vi.mock()
vi.useFakeTimers()
```
## Mock Migration Patterns
### Function Mocks
**Before (Jest):**
```typescript
const mockFn = jest.fn();
const mockFnWithReturn = jest.fn().mockReturnValue('value');
const mockFnWithAsync = jest.fn().mockResolvedValue('async value');
```
**After (Vitest):**
```typescript
const mockFn = vi.fn();
const mockFnWithReturn = vi.fn().mockReturnValue('value');
const mockFnWithAsync = vi.fn().mockResolvedValue('async value');
```
### Spy Migration
**Before (Jest):**
```typescript
const spy = jest.spyOn(service, 'method');
spy.mockImplementation(() => 'mocked');
```
**After (Vitest):**
```typescript
const spy = vi.spyOn(service, 'method');
spy.mockImplementation(() => 'mocked');
```
### Module Mocks
**Before (Jest):**
```typescript
jest.mock('@isa/core/logging', () => ({
logger: jest.fn(() => ({
info: jest.fn(),
error: jest.fn(),
})),
}));
```
**After (Vitest):**
```typescript
vi.mock('@isa/core/logging', () => ({
logger: vi.fn(() => ({
info: vi.fn(),
error: vi.fn(),
})),
}));
```
## Spectator → Angular Testing Library
### Component Testing
**Before (Spectator):**
```typescript
import { createComponentFactory, Spectator } from '@ngneat/spectator/jest';
describe('MyComponent', () => {
let spectator: Spectator<MyComponent>;
const createComponent = createComponentFactory({
component: MyComponent,
imports: [CommonModule],
providers: [
{ provide: MyService, useValue: mockService },
],
});
beforeEach(() => {
spectator = createComponent();
});
it('should render title', () => {
expect(spectator.query('.title')).toHaveText('Hello');
});
it('should handle click', () => {
spectator.click('.button');
expect(mockService.doSomething).toHaveBeenCalled();
});
});
```
**After (Angular Testing Library):**
```typescript
import { render, screen, fireEvent } from '@testing-library/angular';
describe('MyComponent', () => {
it('should render title', async () => {
await render(MyComponent, {
imports: [CommonModule],
providers: [
{ provide: MyService, useValue: mockService },
],
});
expect(screen.getByText('Hello')).toBeInTheDocument();
});
it('should handle click', async () => {
await render(MyComponent, {
providers: [{ provide: MyService, useValue: mockService }],
});
fireEvent.click(screen.getByRole('button'));
expect(mockService.doSomething).toHaveBeenCalled();
});
});
```
### Query Selectors
| Spectator | Angular Testing Library |
|-----------|------------------------|
| `spectator.query('.class')` | `screen.getByTestId()` or `screen.getByRole()` |
| `spectator.queryAll('.class')` | `screen.getAllByRole()` |
| `spectator.query('button')` | `screen.getByRole('button')` |
| `spectator.query('[data-testid]')` | `screen.getByTestId()` |
### Events
| Spectator | Angular Testing Library |
|-----------|------------------------|
| `spectator.click(element)` | `fireEvent.click(element)` or `await userEvent.click(element)` |
| `spectator.typeInElement(value, element)` | `await userEvent.type(element, value)` |
| `spectator.blur(element)` | `fireEvent.blur(element)` |
| `spectator.focus(element)` | `fireEvent.focus(element)` |
### Service Testing
**Before (Spectator):**
```typescript
import { createServiceFactory, SpectatorService } from '@ngneat/spectator/jest';
describe('MyService', () => {
let spectator: SpectatorService<MyService>;
const createService = createServiceFactory({
service: MyService,
providers: [
{ provide: HttpClient, useValue: mockHttp },
],
});
beforeEach(() => {
spectator = createService();
});
it('should fetch data', () => {
spectator.service.getData().subscribe(data => {
expect(data).toEqual(expectedData);
});
});
});
```
**After (TestBed):**
```typescript
import { TestBed } from '@angular/core/testing';
describe('MyService', () => {
let service: MyService;
beforeEach(() => {
TestBed.configureTestingModule({
providers: [
MyService,
{ provide: HttpClient, useValue: mockHttp },
],
});
service = TestBed.inject(MyService);
});
it('should fetch data', () => {
service.getData().subscribe(data => {
expect(data).toEqual(expectedData);
});
});
});
```
## Async Testing
### Observable Testing
**Before (Jest):**
```typescript
it('should emit values', (done) => {
service.data$.subscribe({
next: (value) => {
expect(value).toBe(expected);
done();
},
});
});
```
**After (Vitest):**
```typescript
import { firstValueFrom } from 'rxjs';
it('should emit values', async () => {
const value = await firstValueFrom(service.data$);
expect(value).toBe(expected);
});
```
### Timer Mocks
**Before (Jest):**
```typescript
jest.useFakeTimers();
service.startTimer();
jest.advanceTimersByTime(1000);
expect(callback).toHaveBeenCalled();
jest.useRealTimers();
```
**After (Vitest):**
```typescript
vi.useFakeTimers();
service.startTimer();
vi.advanceTimersByTime(1000);
expect(callback).toHaveBeenCalled();
vi.useRealTimers();
```
## Common Matchers
| Jest | Vitest |
|------|--------|
| `expect(x).toBe(y)` | Same |
| `expect(x).toEqual(y)` | Same |
| `expect(x).toHaveBeenCalled()` | Same |
| `expect(x).toHaveBeenCalledWith(y)` | Same |
| `expect(x).toMatchSnapshot()` | `expect(x).toMatchSnapshot()` |
| `expect(x).toHaveText('text')` | `expect(x).toHaveTextContent('text')` (with jest-dom) |
## Migration Checklist
1. [ ] Update `vitest.config.ts`
2. [ ] Update `test-setup.ts`
3. [ ] Replace `jest.fn()` with `vi.fn()`
4. [ ] Replace `jest.spyOn()` with `vi.spyOn()`
5. [ ] Replace `jest.mock()` with `vi.mock()`
6. [ ] Replace Spectator with Angular Testing Library
7. [ ] Update queries to use accessible selectors
8. [ ] Update async patterns
9. [ ] Run tests and fix any remaining issues
10. [ ] Remove Jest dependencies from `package.json`

View File

@@ -0,0 +1,293 @@
# Zod Patterns Reference
## Overview
Zod is a TypeScript-first schema validation library. Use it for runtime validation at system boundaries (API responses, form inputs, external data).
## Basic Schema Patterns
### Primitive Types
```typescript
import { z } from 'zod';
// Basic types
const stringSchema = z.string();
const numberSchema = z.number();
const booleanSchema = z.boolean();
const dateSchema = z.date();
// With constraints
const emailSchema = z.string().email();
const positiveNumber = z.number().positive();
const nonEmptyString = z.string().min(1);
const optionalString = z.string().optional();
const nullableString = z.string().nullable();
```
### Object Schemas
```typescript
// Basic object
const userSchema = z.object({
id: z.string().uuid(),
email: z.string().email(),
name: z.string().min(1),
age: z.number().int().positive().optional(),
role: z.enum(['admin', 'user', 'guest']),
createdAt: z.string().datetime(),
});
// Infer TypeScript type from schema
type User = z.infer<typeof userSchema>;
// Partial and Pick utilities
const partialUser = userSchema.partial(); // All fields optional
const requiredUser = userSchema.required(); // All fields required
const pickedUser = userSchema.pick({ email: true, name: true });
const omittedUser = userSchema.omit({ createdAt: true });
```
### Array Schemas
```typescript
// Basic array
const stringArray = z.array(z.string());
// With constraints
const nonEmptyArray = z.array(z.string()).nonempty();
const limitedArray = z.array(z.number()).min(1).max(10);
// Tuple (fixed length, different types)
const coordinate = z.tuple([z.number(), z.number()]);
```
## API Response Validation
### Pattern: Validate API Responses
```typescript
// Define response schema
const apiResponseSchema = z.object({
data: z.object({
items: z.array(userSchema),
total: z.number(),
page: z.number(),
pageSize: z.number(),
}),
meta: z.object({
timestamp: z.string().datetime(),
requestId: z.string().uuid(),
}),
});
// In Angular service
@Injectable({ providedIn: 'root' })
export class UserService {
#http = inject(HttpClient);
#logger = logger({ component: 'UserService' });
getUsers(): Observable<User[]> {
return this.#http.get('/api/users').pipe(
map((response) => {
const result = apiResponseSchema.safeParse(response);
if (!result.success) {
this.#logger.error('Invalid API response', {
errors: result.error.errors
});
throw new Error('Invalid API response');
}
return result.data.data.items;
})
);
}
}
```
### Pattern: Coerce Types
```typescript
// API returns string IDs, coerce to number
const productSchema = z.object({
id: z.coerce.number(), // "123" -> 123
price: z.coerce.number(), // "99.99" -> 99.99
inStock: z.coerce.boolean(), // "true" -> true
createdAt: z.coerce.date(), // "2024-01-01" -> Date
});
```
## Form Validation
### Pattern: Form Schema
```typescript
// Define form schema with custom error messages
const loginFormSchema = z.object({
email: z.string()
.email({ message: 'Invalid email address' }),
password: z.string()
.min(8, { message: 'Password must be at least 8 characters' })
.regex(/[A-Z]/, { message: 'Must contain uppercase letter' })
.regex(/[0-9]/, { message: 'Must contain number' }),
rememberMe: z.boolean().default(false),
});
// Use with Angular forms
type LoginForm = z.infer<typeof loginFormSchema>;
```
### Pattern: Cross-field Validation
```typescript
const passwordFormSchema = z.object({
password: z.string().min(8),
confirmPassword: z.string(),
}).refine(
(data) => data.password === data.confirmPassword,
{
message: "Passwords don't match",
path: ['confirmPassword'], // Error path
}
);
```
## Type Guards
### Pattern: Create Type Guard from Schema
```typescript
// Schema
const customerSchema = z.object({
type: z.literal('customer'),
customerId: z.string(),
loyaltyPoints: z.number(),
});
// Type guard function
function isCustomer(value: unknown): value is z.infer<typeof customerSchema> {
return customerSchema.safeParse(value).success;
}
// Usage
if (isCustomer(data)) {
console.log(data.loyaltyPoints); // Type-safe access
}
```
### Pattern: Discriminated Unions
```typescript
const customerSchema = z.object({
type: z.literal('customer'),
customerId: z.string(),
});
const guestSchema = z.object({
type: z.literal('guest'),
sessionId: z.string(),
});
const userSchema = z.discriminatedUnion('type', [
customerSchema,
guestSchema,
]);
type User = z.infer<typeof userSchema>;
// User = { type: 'customer'; customerId: string } | { type: 'guest'; sessionId: string }
```
## Replacing `any` Types
### Before (unsafe)
```typescript
function processOrder(order: any) {
// No type safety
console.log(order.items.length);
console.log(order.customer.name);
}
```
### After (with Zod)
```typescript
const orderSchema = z.object({
id: z.string().uuid(),
items: z.array(z.object({
productId: z.string(),
quantity: z.number().positive(),
price: z.number().nonnegative(),
})),
customer: z.object({
name: z.string(),
email: z.string().email(),
}),
status: z.enum(['pending', 'confirmed', 'shipped', 'delivered']),
});
type Order = z.infer<typeof orderSchema>;
function processOrder(input: unknown): Order {
const order = orderSchema.parse(input); // Throws if invalid
console.log(order.items.length); // Type-safe
console.log(order.customer.name); // Type-safe
return order;
}
```
## Error Handling
### Pattern: Structured Error Handling
```typescript
const result = schema.safeParse(data);
if (!result.success) {
// Access formatted errors
const formatted = result.error.format();
// Access flat error list
const flat = result.error.flatten();
// Custom error mapping
const errors = result.error.errors.map(err => ({
field: err.path.join('.'),
message: err.message,
code: err.code,
}));
}
```
## Transform Patterns
### Pattern: Transform on Parse
```typescript
const userInputSchema = z.object({
email: z.string().email().transform(s => s.toLowerCase()),
name: z.string().transform(s => s.trim()),
tags: z.string().transform(s => s.split(',')),
});
// Input: { email: "USER@EXAMPLE.COM", name: " John ", tags: "a,b,c" }
// Output: { email: "user@example.com", name: "John", tags: ["a", "b", "c"] }
```
### Pattern: Default Values
```typescript
const configSchema = z.object({
theme: z.enum(['light', 'dark']).default('light'),
pageSize: z.number().default(20),
features: z.array(z.string()).default([]),
});
```
## Best Practices
1. **Define schemas at module boundaries** - API services, form handlers
2. **Use `safeParse` for error handling** - Don't let validation throw unexpectedly
3. **Infer types from schemas** - Single source of truth
4. **Add meaningful error messages** - Help debugging and user feedback
5. **Use transforms for normalization** - Clean data on parse
6. **Keep schemas close to usage** - Colocate with services/components

5
.gitignore vendored
View File

@@ -78,3 +78,8 @@ vitest.config.*.timestamp*
nx.instructions.md
CLAUDE.md
*.pyc
.vite
reports/
# Local iPad dev setup (proxy)
/local-dev/

View File

@@ -1,13 +1,13 @@
{
"mcpServers": {
"context7": {
"type": "sse",
"url": "https://mcp.context7.com/sse"
"type": "http",
"url": "https://mcp.context7.com/mcp"
},
"nx-mcp": {
"type": "stdio",
"command": "npx",
"args": ["nx-mcp@latest"]
"args": ["nx", "mcp"]
},
"angular-mcp": {
"type": "stdio",

13
AGENTS.md Normal file
View File

@@ -0,0 +1,13 @@
<!-- nx configuration start-->
<!-- Leave the start & end comments to automatically receive updates. -->
# General Guidelines for working with Nx
- When running tasks (for example build, lint, test, e2e, etc.), always prefer running the task through `nx` (i.e. `nx run`, `nx run-many`, `nx affected`) instead of using the underlying tooling directly
- You have access to the Nx MCP server and its tools, use them to help the user
- When answering questions about the repository, use the `nx_workspace` tool first to gain an understanding of the workspace architecture where applicable.
- When working in individual projects, use the `nx_project_details` mcp tool to analyze and understand the specific project structure and dependencies
- For questions around nx configuration, best practices or if you're unsure, use the `nx_docs` tool to get relevant, up-to-date docs. Always use this instead of assuming things about nx configuration
- If the user needs help with an Nx configuration or project graph error, use the `nx_workspace` tool to get any errors
<!-- nx configuration end-->

139
CHANGELOG.md Normal file
View File

@@ -0,0 +1,139 @@
# Changelog
All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased]
### Added
- (checkout-reward) Disable and hide delivery options for reward feature purchases
- (purchase-options) Add disabledPurchaseOptions with flexible visibility control
- (reward-catalog) Pre-select in-store option for reward purchases
- (checkout) Complete reward order confirmation with reusable product info component
- (checkout) Implement reward order confirmation UI and confirmation list item action card component
- (checkout) Add reward order confirmation feature with schema migrations
- (stock-info) Implement request batching with BatchingResource
- (crm) Introduce PrimaryCustomerCardResource and format-name utility
- Angular template skill for modern template patterns
- Tailwind ISA design system skill
### Changed
- (checkout-reward) Implement hierarchical grouping on rewards order confirmation
- (checkout) Move reward selection helpers to data-access for reusability
- (common) Add validation for notification channel flag combinations
- (customer) Merge continueReward and continue methods into unified flow
- Comprehensive CLAUDE.md overhaul with library reference system
- Add Claude Code agents, commands, and skills infrastructure
### Fixed
- (checkout) Resolve currency constraint violations in price handling
- (checkout) Add complete price structure for reward delivery orders
- (checkout) Correct reward output desktop/mobile layout and add insufficient stock warnings
- (customer-card) Implement navigation flow from customer card to reward search
- (purchase-options) Correct customer features mapping
- (reward-order-confirmation) Group items by item-level delivery type
- (reward-order-confirmation) Correct typo and add loading state to collect button
- (reward-confirmation) Improve action card visibility and status messages
- (reward-selection-pop-up) Fix width issue
## [4.2] - 2025-10-23
### Added
- (checkout-reward) Add reward checkout feature (#5258)
- (crm) Add crm-data-access library with initial component and tests
- (shared-filter) Add canApply input to filter input menu components
- Architecture Decision Records (ADRs) documentation
- Error handling and validation infrastructure enhancements
### Changed
- (tabs) Implement backwards compatibility for Process → Tabs migration
- (notifications) Update remission path logic to use Date.now()
- (customer-card) Deactivate Create Customer with Card feature
- Update package.json and recreate package-lock.json for npm@11.6
- Disable markdown format on save in VSCode settings
### Fixed
- (process) Simulate "old tab logic" for compatibility
- (tabs) Correct singleton tabs interaction with new tab areas
- (remission-list) Prioritize reload trigger over exact search
- (remission-list-item, remission-list-empty-state) Improve empty state handling
## [4.1] - 2025-10-06
### Added
- (isa-app) Migrate remission navigation to tab-based routing system
- (utils) Add scroll-top button component
- (remission-list, empty-state) Add comprehensive empty state handling with user guidance
- (remission) Ensure package assignment before completing return receipts
- (libs-ui-dialog-feedback-dialog) Add auto-close functionality with configurable delay
- (old-ui-tooltip) Add pointer-events-auto to tooltip panel
### Changed
- (remission-list) Improve item update handling and UI feedback
- (remission-list, search-item-to-remit-dialog) Simplify dialog flow by removing intermediate steps
### Fixed
- (remission-list) Ensure list reload after search dialog closes
- (remission-list) Auto-select single search result when remission started
- (remission-list, remission-return-receipt-details, libs-dialog) Improve error handling with dedicated error dialog
- (remission-error) Simplify error handling in remission components
- (remission) Filter search results by stock availability and display stock info
- (remission-list, remission-data-access) Add impediment comment and remaining quantity tracking
- (remission-quantity-and-reason-item) Correct quantity input binding and dropdown behavior
- (remission-quantity-reason) Correct dropdown placeholder and remove hardcoded values
- (remission-filter-label) Improve filter button label display and default text
- (remission-data-access) Remove automatic date defaulting in fetchRemissions
- (remission-shared-search-item-to-remit-dialog) Display context-aware feedback on errors
- (isa-app-shell) Improve navigation link targeting for remission sub-routes
- (oms-data-access) Adjust tolino return eligibility logic for display damage
- (ui-input-controls-dropdown) Prevent multiple dropdowns from being open simultaneously
## [4.0] - 2025-07-23
### Added
- (oms-data-access) Initial implementation of OMS data access layer
- (oms-return-review) Implement return review feature
- (print-button) Implement reusable print button component with service integration
- (scanner) Add full-screen scanner styles and components
- (product-router-link) Add shared product router link directive and builder
- (tooltip) Add tooltip component and directive with customizable triggers
- (shared-scanner) Move scanner to shared/scanner location
- (common-data-access) Add takeUntil operators for keydown events
### Changed
- (oms-return-review, oms-return-summary) Fix return receipt mapping and ensure process completion
- (ui-tooltip) Remove native title attribute from tooltip icon host
- (oms-return-details) Improve layout and styling of order group item controls
- (searchbox) Improve formatting and add showScannerButton getter
- (libs-ui-item-rows) Improve data value wrapping and label sizing
- (shared-filter, search-bar, search-main) Add E2E data attributes for filtering and search
### Fixed
- (return-details) Update email validation and improve error handling
- (return-details) Correct storage key retrieval in ReturnDetailsStore
- (return-details) Small layout fix (#5171)
- (isa-app-moment-locale) Correct locale initialization for date formatting
- (oms-return-search) Fix display and logic issues in return search results
- (oms-return-search) Resolve issues in return search result item rendering
- (oms-task-list-item) Address styling and layout issues in return task list
- (ui-dropdown) Improve dropdown usability and conditional rendering
- (return-search) Correct typo in tooltip content
- (libs-shared-filter) Improve date range equality for default filter inputs
## [3.4] - 2025-02-10
_Earlier versions available in git history. Detailed changelog entries start from version 4.0._
### Historical Versions
Previous versions (3.3, 3.2, 3.1, 3.0, 2.x, 1.x) are available in the git repository.
For detailed information about changes in these versions, please refer to:
- Git tags: `git tag --sort=-creatordate`
- Commit history: `git log <tag-from>..<tag-to>`
- Pull requests in the repository
---
_This changelog was initially generated from git commit history. Future entries will be maintained manually following the Keep a Changelog format._

451
CLAUDE.md
View File

@@ -1,287 +1,177 @@
# CLAUDE.md
> **Last Updated:** 2025-10-22
> **Angular Version:** 20.1.2
> **Nx Version:** 21.3.2
> **Node.js:** ≥22.0.0
> **npm:** ≥10.0.0
This file contains meta-instructions for how Claude should work with the ISA-Frontend codebase.
## 🔴 CRITICAL: Mandatory Agent Usage
## 🔴 CRITICAL: You Are an LLM with Outdated Knowledge
**You MUST use these subagents for ALL research tasks:**
- **`docs-researcher`**: For ALL documentation (packages, libraries, READMEs)
- **`docs-researcher-advanced`**: Auto-escalate when docs-researcher fails
- **`Explore`**: For ALL code pattern searches and multi-file analysis
- **Direct tools (Read/Bash)**: ONLY for single specific files or commands
**Your training data is outdated. NEVER assume you know current APIs.**
**Violations of this rule degrade performance and context quality. NO EXCEPTIONS.**
- Libraries, frameworks, and APIs change constantly
- Your memory of APIs is unreliable
- Current documentation is the ONLY source of truth
## Project Overview
**ALWAYS use research agents PROACTIVELY - without user asking.**
This is a sophisticated Angular 20.1.2 monorepo managed by Nx 21.3.2. The main application is `isa-app`, a comprehensive inventory and returns management system for retail/e-commerce operations. The system handles complex workflows including order management (OMS), returns processing (remission), customer relationship management (CRM), product cataloging, and checkout/reward systems.
## 🔴 CRITICAL: Proactive Agent & Skill Usage
## Architecture
**You MUST use agents and skills AUTOMATICALLY for ALL tasks - do NOT wait for user to tell you.**
### Monorepo Structure
- **apps/isa-app**: Main Angular application
- **libs/**: Reusable libraries organized by domain and type
- **core/**: Core utilities (config, logging, storage, tabs, navigation)
- **common/**: Shared utilities (data-access, decorators, print)
- **ui/**: UI component libraries (buttons, dialogs, inputs, etc.)
- **shared/**: Shared domain components (filter, scanner, product components)
- **oms/**: Order Management System features and utilities
- **remission/**: Remission/returns management features
- **catalogue/**: Product catalogue functionality
- **utils/**: General utilities (validation, scroll position, parsing)
- **icons/**: Icon library
- **generated/swagger/**: Auto-generated API client code from OpenAPI specs
### Research Agents (Use BEFORE Implementation)
### Key Architectural Patterns
- **Domain-Driven Design**: Clear domain boundaries with dedicated modules (OMS, remission, CRM, catalogue, checkout)
- **Layered Architecture**: Strict dependency hierarchy (Feature → Shared/UI → Data Access → Infrastructure)
- **Standalone Components**: All new components use Angular standalone architecture with explicit imports
- **Feature Libraries**: Domain features organized as separate libraries (e.g., `oms-feature-return-search`, `remission-feature-remission-list`)
- **Data Access Layer**: Separate data-access libraries for each domain with NgRx Signals stores
- **Shared UI Components**: 17 dedicated UI component libraries with design system integration
- **Generated API Clients**: 10 auto-generated Swagger/OpenAPI clients with post-processing pipeline
- **Path Aliases**: Comprehensive TypeScript path mapping (`@isa/domain/layer/feature`)
- **Component Prefixes**: Domain-specific prefixes (OMS: `oms-feature-*`, Remission: `remi-*`, UI: `ui-*`)
- **Modern State Management**: NgRx Signals with entities, session persistence, and reactive patterns
| Agent | Auto-Invoke When | User Interaction |
|-------|------------------|------------------|
| `docs-researcher` | ANY external library/API usage | NONE - just do it |
| `docs-researcher-advanced` | Implementation fails OR docs-researcher insufficient | NONE - just do it |
| `Explore` | Need codebase patterns or multi-file analysis | NONE - just do it |
## Common Development Commands
### Essential Commands (Project-Specific)
```bash
# Start development server with SSL (required for authentication flows)
npm start
# Run tests for all libraries (excludes main app)
npm test
# Build for development
npm run build
# Build for production
npm run build-prod
# Regenerate all API clients from Swagger/OpenAPI specs
npm run generate:swagger
# Regenerate library reference documentation
npm run docs:generate
# Format code with Prettier
npm run prettier
# Format only staged files (pre-commit hook)
npm run pretty-quick
# Run CI tests with coverage
npm run ci
**Research-First Flow (Mandatory):**
```
Task involves external API? → AUTO-INVOKE docs-researcher
Implement based on docs
Failed? → AUTO-INVOKE docs-researcher-advanced
Still failed? → ASK USER for guidance
```
### Standard Nx Commands
For complete command reference, see [Nx Documentation](https://nx.dev/reference/commands).
### Skills (Use DURING Implementation)
**Common patterns:**
```bash
# Test specific library (always use --skip-nx-cache)
npx nx test <project-name> --skip-nx-cache
| Trigger | Auto-Invoke Skill |
|---------|-------------------|
| Writing Angular templates | `angular-template` |
| Writing HTML with interactivity | `html-template` |
| Applying Tailwind classes | `tailwind` |
| Writing any Angular code | `logging` |
| Creating CSS animations | `css-keyframes-animations` |
| Creating new library | `library-scaffolder` |
| Regenerating API clients | `swagger-sync-manager` |
| Git operations | `git-workflow` |
# Lint a project
npx nx lint <project-name>
# Show project dependencies
npx nx graph
# Run tests for affected projects (CI/CD)
npx nx affected:test --skip-nx-cache
**Skill chaining for Angular work:**
```
angular-template → html-template → logging → tailwind
```
**Important:** Always use `--skip-nx-cache` flag when running tests to ensure fresh results.
### Implementation Agents (Use for Complex Tasks)
## Testing Framework
| Agent | Auto-Invoke When |
|-------|------------------|
| `angular-developer` | Creating components, services, stores (2-5 files) |
| `test-writer` | Writing tests, adding coverage |
| `refactor-engineer` | Refactoring 5+ files, migrations |
> **Last Reviewed:** 2025-10-22
> **Status:** Migration in Progress (Jest → Vitest)
### Anti-Patterns (FORBIDDEN)
### Current Setup (Migration in Progress)
- **Jest**: 40 libraries (65.6% - legacy/existing code)
- **Vitest**: 21 libraries (34.4% - new standard)
- All formal libraries now have test executors configured
### Testing Strategy
- **New libraries**: Use Vitest + Angular Testing Utilities (TestBed, ComponentFixture)
- **Legacy libraries**: Continue with Jest + Spectator until migrated
- **Advanced mocking**: Use ng-mocks for complex scenarios
### Key Requirements
- Test files must end with `.spec.ts`
- Use AAA pattern (Arrange-Act-Assert)
- **Always include E2E attributes**: `data-what`, `data-which`, and dynamic `data-*` in HTML templates
- Mock external dependencies appropriately for your framework
**For detailed testing guidelines, framework comparison, and migration instructions, see [`docs/guidelines/testing.md`](docs/guidelines/testing.md).**
**References:**
- [Jest Documentation](https://jestjs.io/)
- [Vitest Documentation](https://vitest.dev/)
- [Angular Testing Guide](https://angular.io/guide/testing)
- [Spectator](https://ngneat.github.io/spectator/)
## State Management
- **NgRx Signals**: Primary state management with modern functional approach using `signalStore()`
- **Entity Management**: Uses `withEntities()` for normalized data storage
- **Session Persistence**: State persistence with `withStorage()` using SessionStorageProvider
- **Reactive Methods**: `rxMethod()` with `takeUntilKeydownEscape()` for user-cancellable operations
- **Custom RxJS Operators**: Specialized operators like `takeUntilAborted()`, `takeUntilKeydown()`
- **Error Handling**: `tapResponse()` for handling success/error states in stores
- **Lifecycle Hooks**: `withHooks()` for cleanup and initialization (e.g., orphaned entity cleanup)
- **Navigation State**: Use `@isa/core/navigation` for temporary navigation context (return URLs, wizard state) instead of query parameters
## Styling and Design System
- **Framework**: [Tailwind CSS](https://tailwindcss.com/docs) with extensive ISA-specific customization
- **Custom Breakpoints**: `isa-desktop` (1024px), `isa-desktop-l` (1440px), `isa-desktop-xl` (1920px)
- **Brand Color System**: `isa-*` color palette with semantic naming
- **Custom Tailwind Plugins** (7): button, typography, menu, label, input, section, select-bullet
- **Typography System**: 14 custom utilities (`.isa-text-heading-1-bold`, `.isa-text-body-2-regular`, etc.)
- **UI Component Libraries**: 17 specialized libraries with consistent APIs (see Library Reference)
- **Storybook**: Component documentation and development at `npm run storybook`
### Responsive Design with Breakpoint Service
Use `@isa/ui/layout` for reactive breakpoint detection instead of CSS-only solutions:
```typescript
import { breakpoint, Breakpoint } from '@isa/ui/layout';
// Detect screen size reactively
isDesktop = breakpoint([Breakpoint.Desktop, Breakpoint.DekstopL, Breakpoint.DekstopXL]);
```
❌ Implementing without researching first
❌ Asking "should I research this?" - just do it
❌ Asking "should I use a skill?" - just do it
❌ Trial and error: implement → fail → try again → fail
❌ Writing Angular code without loading skills first
```
**Available Breakpoints:**
- `Tablet`: max-width: 1279px (mobile/tablet)
- `Desktop`: 1280px - 1439px (standard desktop)
- `DekstopL`: 1440px - 1919px (large desktop)
- `DekstopXL`: 1920px+ (extra large)
### Correct Pattern
**Template Usage:**
```html
@if (isDesktop) {
<!-- Desktop-specific content -->
}
```
✅ "Researching [library] API..." → [auto-invokes docs-researcher]
✅ "Loading angular-template skill..." → [auto-invokes skill]
✅ "Implementing based on current docs..."
✅ If fails: "Escalating research..." → [auto-invokes docs-researcher-advanced]
```
**Why:** Prefer breakpoint service over CSS-only (hidden/flex) for SSR and maintainability.
## Communication Guidelines
## API Integration and Data Access
- Keep answers concise and focused
- Use bullet points and structured formatting
- Skip verbose explanations unless requested
- Focus on what the user needs, not everything you know
**Generated Swagger Clients:** 10 auto-generated TypeScript clients in `generated/swagger/`
- Available APIs: availability-api, cat-search-api, checkout-api, crm-api, eis-api, inventory-api, isa-api, oms-api, print-api, wws-api
- Tool: [ng-swagger-gen](https://www.npmjs.com/package/ng-swagger-gen) with custom per-API configuration
- Post-processing: Automatic Unicode cleanup via `tools/fix-files.js`
- Regenerate: `npm run generate:swagger`
## Context Management
**Architecture Pattern:**
- Business logic services wrap generated API clients
- Type safety: TypeScript + [Zod](https://zod.dev/) schema validation
- Error handling: Global HTTP interceptor with automatic re-authentication
- Modern injection: Uses `inject()` function with private field pattern
- Request cancellation: Built-in via AbortSignal and custom RxJS operators (`takeUntilAborted()`, `takeUntilKeydown()`)
**Context bloat kills reliability. Minimize aggressively.**
**Data Access Libraries:** See Library Reference section for domain-specific implementations (`@isa/[domain]/data-access`).
### Tool Result Minimization
## Build Configuration
- **Framework**: Angular with TypeScript (see `package.json` for current versions)
- **Requirements**:
- Node.js >= 22.0.0 (specified in package.json engines)
- npm >= 10.0.0 (specified in package.json engines)
- **Build System**: Nx monorepo with Vite for testing (Vitest)
- **Development Server**: Serves with SSL by default (required for authentication flows)
| Tool | Keep | Discard |
|------|------|---------|
| Bash (success) | `✓ Command succeeded` | Full output |
| Bash (failure) | Exit code + error (max 10 lines) | Verbose output |
| Edit | `✓ Modified file.ts` | Full diffs |
| Read | Extracted relevant section | Full file content |
| Agent results | 1-2 sentence summary | Raw JSON/full output |
## Important Conventions and Patterns
### Agent Result Handling
### Library Organization
- **Naming Pattern**: `[domain]-[layer]-[feature]` (e.g., `oms-feature-return-search`, `ui-buttons`)
- **Path Aliases**: `@isa/[domain]/[layer]/[feature]` (e.g., `@isa/oms/data-access`, `@isa/ui/buttons`)
- **Project Names**: Found in each library's `project.json` file, following consistent naming
```
❌ WRONG: "Docs researcher returned: [huge JSON...]"
✅ RIGHT: "docs-researcher found: Use signalStore() with withState()"
```
### Component Architecture
- **Standalone Components**: All new components must be standalone with explicit imports
- **Component Prefixes**: Domain-specific prefixes for clear identification
- OMS features: `oms-feature-*` (e.g., `oms-feature-return-search-main`)
- Remission features: `remi-*`
- UI components: `ui-*`
- Core utilities: `core-*`
- **Signal-based Inputs**: Use Angular signals (`input()`, `computed()`) for reactive properties
- **Host Binding**: Dynamic CSS classes via Angular host properties
### Session Cleanup
### Dependency Rules
- **Unidirectional Dependencies**: Feature → Shared/UI → Data Access → Infrastructure
- **Import Boundaries**: Use path aliases, avoid relative imports across domain boundaries
- **Generated API Imports**: Import from `@generated/swagger/[api-name]` for API clients
Use `/clear` between unrelated tasks to prevent context degradation.
### Code Quality
- **Modern Angular Patterns**: Prefer `inject()` over constructor injection
- **Type Safety**: Use Zod schemas for runtime validation alongside TypeScript
- **Error Handling**: Custom error classes with specific error codes
- **E2E Testing**: Always include `data-what` and `data-which` attributes in templates
### Long-Running Task Pattern
## Development Workflow and Best Practices
For complex tasks approaching context limits:
1. Dump progress to a `.md` file (e.g., `progress.md`)
2. Use `/clear` to reset context
3. Resume by reading the progress file
4. Continue from where you left off
### Project Conventions
- **Default Branch**: `develop` (not main) - Always create PRs against develop
- **Branch Naming**: When starting work on a new feature or bug, create a branch following this pattern:
- Format: `feature/{task-id}-{short-description}` or `bugfix/{task-id}-{short-description}`
- Use English kebab-case for the description
- Start with the task/issue ID (e.g., `5391`)
- Keep description concise - shorten if the full title is too long
- Example: For task "#5391 Prämie Checkout // Action Card - Versandbestellung"
- Branch: `feature/5391-praemie-checkout-action-card-delivery-order`
- **Commit Style**: [Conventional commits](https://www.conventionalcommits.org/) without co-author tags
- **Nx Cache**: Always use `--skip-nx-cache` for tests to ensure fresh results
- **Testing**: New libraries use Vitest + Angular Testing Utilities; legacy use Jest + Spectator
- **E2E Attributes**: Always include `data-what`, `data-which`, and dynamic `data-*` in templates
- **Design System**: Use ISA-specific Tailwind utilities (`isa-accent-*`, `isa-text-*`)
### Context Monitoring
### Code Quality Tools
- **Linting**: [ESLint](https://eslint.org/) with Nx dependency checks
- **Formatting**: [Prettier](https://prettier.io/) with Husky + lint-staged pre-commit hooks
- **Type Safety**: [TypeScript](https://www.typescriptlang.org/) strict mode + [Zod](https://zod.dev/) validation
- **Bundle Size**: Monitor carefully (2MB warning, 5MB error for main bundle)
- Use `/context` to check current token usage
- Fresh session baseline: ~20k tokens
- Consider `/compact` when approaching 150k tokens
- Prefer `/clear` over `/compact` when starting new topics
### Nx Workflow Tips
- Use `npx nx graph` to visualize dependencies
- Use `npx nx affected:test` for CI/CD optimization
- Reference: [Nx Documentation](https://nx.dev/getting-started/intro)
## Extended Thinking
## Development Notes and Guidelines
Use progressive thinking depth for complex analysis:
### Getting Started
- **Application Startup**: Only `isa-app` can be started - it's the main application entry point
- **SSL Development**: The development server runs with SSL by default (`npm start`), which is crucial for production-like authentication flows
- **Node Requirements**: Ensure Node.js ≥22.0.0 and npm ≥10.0.0 before starting development
- **First-Time Setup**: After cloning, run `npm install` then `npm start` to verify everything works
| Trigger | Thinking Budget | Use Case |
|---------|----------------|----------|
| `"think"` | ~4k tokens | Basic analysis, simple decisions |
| `"think hard"` | ~10k tokens | Moderate complexity, multi-factor decisions |
| `"think harder"` | ~16k tokens | Deep analysis, architectural decisions |
| `"ultrathink"` | ~32k tokens | Maximum depth, critical planning |
### Essential Documentation References
- **Testing Guidelines**: Review `docs/guidelines/testing.md` before writing any tests - it covers the Jest→Vitest migration, Spectator→Angular Testing Utilities transition, and E2E attribute requirements
- **Code Review Standards**: Follow the structured review process in `.github/review-instructions.md` with categorized feedback (🚨 Critical, ❗ Minor, ⚠️ Warnings, ✅ Good Practices)
- **E2E Testing Requirements**: Always include `data-what`, `data-which`, and dynamic `data-*` attributes in HTML templates - these are essential for automated testing by QA colleagues
**Examples:**
- "Think about how to structure this component"
- "Think hard about the best approach for state management"
- "Ultrathink about the architecture for this feature"
### Researching and Investigating the Codebase
## Code Investigation (MANDATORY)
**🔴 MANDATORY: You MUST use subagents for research. Direct file reading/searching is FORBIDDEN except for single specific files.**
**Never speculate about code you haven't read.**
#### Required Agent Usage
If user references a specific file:
1. **READ the file first** using the Read tool
2. **THEN provide analysis** based on actual contents
3. If file doesn't exist, **say so explicitly**
**Anti-Hallucination Rules:**
- Never describe code you haven't opened
- Never assume file contents based on names
- Never guess API signatures without documentation
- Always verify imports and dependencies exist
## Implementation Decisions
| Task Type | Required Agent | Escalation Path |
|-----------|---------------|-----------------|
| --------------------------------- | ------------------ | ----------------------------------------- |
| **Package/Library Documentation** | `docs-researcher` | → `docs-researcher-advanced` if not found |
| **Internal Library READMEs** | `docs-researcher` | Keep context clean |
| **Monorepo Library Overview** | `docs-researcher` | Uses `docs/library-reference.md` |
| **Code Pattern Search** | `Explore` | Set thoroughness level |
| **Implementation Analysis** | `Explore` | Multiple file analysis |
| **Single Specific File** | Read tool directly | No agent needed |
#### Documentation Research System (Two-Tier)
**Note:** The `docs-researcher` agent uses `docs/library-reference.md` as a primary index for discovering monorepo libraries. This file contains descriptions and locations for all libraries, enabling quick library discovery without reading individual READMEs.
### Documentation Research System (Two-Tier)
1. **ALWAYS start with `docs-researcher`** (Haiku, 30-120s) for any documentation need
2. **Auto-escalate to `docs-researcher-advanced`** (Sonnet, 2-7min) when:
@@ -290,75 +180,60 @@ isDesktop = breakpoint([Breakpoint.Desktop, Breakpoint.DekstopL, Breakpoint.Deks
- Need code inference
- Complex architectural questions
#### Enforcement Examples
### When to Use Agents vs Direct Tools
```
❌ WRONG: Read libs/ui/buttons/README.md
✅ RIGHT: Task → docs-researcher"Find documentation for @isa/ui/buttons"
❌ WRONG: Grep for "signalStore" patterns
✅ RIGHT: Task → Explore → "Find all signalStore implementations"
❌ WRONG: WebSearch for Zod documentation
✅ RIGHT: Task → docs-researcher → "Find Zod validation documentation"
Single known file? → Read tool directly
Code pattern search?Explore agent
Documentation lookup? → docs-researcher agent
Creating 2-5 Angular files? → angular-developer agent
Refactoring 5+ files? → refactor-engineer agent
Simple 1-file edit? → Direct implementation
```
**Remember: Using subagents is NOT optional - it's mandatory for maintaining context efficiency and search quality.**
### Proactive Agent Triggers
#### Common Research Patterns
**Auto-invoke `angular-developer` when user says:**
- "Create component/service/store/pipe/directive/guard"
- Task touches 2-5 Angular files
| Information Need | Required Approach |
|-----------------|-------------------|
| **Library documentation** | `docs-researcher` → Check library-reference.md → Escalate if needed |
| **Code patterns/examples** | `Explore` with "medium" or "very thorough" |
| **Architecture understanding** | `npx nx graph` + `Explore` for implementation |
| **Debugging/errors** | Direct tool use (Read specific error file, check console) |
**Auto-invoke `test-writer` when user says:**
- "Write tests", "Add coverage"
#### Debugging Tips
- **TypeScript errors**: Follow error path to exact file:line
- **Test failures**: Use `--skip-nx-cache` for fresh output
- **Module resolution**: Check `tsconfig.base.json` path aliases
- **State issues**: Use Angular DevTools browser extension
**Auto-invoke `refactor-engineer` when user says:**
- "Refactor all", "Migrate X files", "Update pattern across"
### Library Development Patterns
- **Library Documentation**: Use `docs-researcher` for ALL library READMEs (mandatory for context management)
- **New Library Creation**: Use Nx generators with domain-specific naming (`[domain]-[layer]-[feature]`)
- **Standalone Components**: All new components must be standalone with explicit imports - no NgModules
- **Testing Framework**: New = Vitest + Angular Testing Utilities, Legacy = Jest + Spectator
- **Path Aliases**: Always use `@isa/[domain]/[layer]/[feature]` - avoid relative imports
**Auto-invoke `context-manager` when user says:**
- "Remember to", "TODO:", "Don't forget"
#### Library Reference Guide
## Agent Communication
The monorepo contains **62 libraries** organized across 12 domains. For quick lookup, see **[`docs/library-reference.md`](docs/library-reference.md)**.
### Briefing Agents
**Quick Overview by Domain:**
- Availability (1) | Catalogue (1) | Checkout (6) | Common (3) | Core (5) | CRM (1) | Icons (1)
- OMS (9) | Remission (8) | Shared Components (7) | UI Components (17) | Utilities (3)
Keep briefings focused:
```
Implement: [type] at [path]
Purpose: [1 sentence]
Requirements: [list]
```
### API Integration Workflow
- **Swagger Generation**: Run `npm run generate:swagger` to regenerate all 10 API clients when backend changes
- **Data Services**: Wrap generated API clients in domain-specific data-access services with proper error handling and Zod validation
- **State Management**: Use NgRx Signals with `signalStore()`, entity management, and session persistence for complex state
### Agent Results
### Performance and Quality Considerations
- **Bundle Monitoring**: Watch bundle sizes (2MB warning, 5MB error for main bundle)
- **Testing Cache**: Always use `--skip-nx-cache` flag when running tests to ensure reliable results
- **Code Quality**: Pre-commit hooks enforce Prettier formatting and ESLint rules automatically
- **Memory Management**: Clean up subscriptions and use OnPush change detection for optimal performance
Extract only what's needed, discard the rest:
```
✓ Created 3 files
✓ Tests: 12/12 passing
✓ Skills applied: angular-template, logging
```
### Common Troubleshooting
- **Build Issues**: Check Node version and run `npm install` if encountering module resolution errors
- **Test Failures**: Use `--skip-nx-cache` flag and ensure test isolation (no shared state between tests)
- **Nx Cache Issues**: If you see `existing outputs match the cache, left as is` during build or testing:
- **Option 1**: Run `npx nx reset` to clear the Nx cache completely
- **Option 2**: Use `--skip-nx-cache` flag to bypass Nx cache for a specific command (e.g., `npx nx test <project> --skip-nx-cache`)
- **When to use**: Always use `--skip-nx-cache` when you need guaranteed fresh builds or test results
- **SSL Certificates**: Development server uses SSL - accept certificate warnings in browser for localhost
- **Import Errors**: Verify path aliases in `tsconfig.base.json` and use absolute imports for cross-library dependencies
<!-- nx configuration start-->
<!-- Leave the start & end comments to automatically receive updates. -->
### Domain-Specific Conventions
- **Component Prefixes**: Use `oms-feature-*` for OMS, `remi-*` for remission, `ui-*` for shared components
- **Git Workflow**: Default branch is `develop` (not main), use conventional commits without co-author tags
- **Design System**: Use ISA-specific Tailwind utilities (`isa-accent-*`, `isa-text-*`) and custom breakpoints (`isa-desktop-*`)
- **Logging**: Use centralized logging service (`@isa/core/logging`) with contextual information for debugging
- **Navigation State**: Use `@isa/core/navigation` for passing temporary state between routes (return URLs, form context) instead of query parameters - keeps URLs clean and state reliable
# General Guidelines for working with Nx
- Run tasks through `nx` (i.e. `nx run`, `nx run-many`, `nx affected`) instead of underlying tooling
- Use `nx_workspace` tool to understand workspace architecture
- Use `nx_project_details` for specific project structure
- Use `nx_docs` for nx configuration questions
<!-- nx configuration end-->

View File

@@ -1,4 +1,8 @@
import type { Preview } from '@storybook/angular';
import { registerLocaleData } from '@angular/common';
import localeDe from '@angular/common/locales/de';
registerLocaleData(localeDe);
const preview: Preview = {
tags: ['autodocs'],

View File

@@ -4,7 +4,7 @@
"projectType": "application",
"prefix": "app",
"sourceRoot": "apps/isa-app/src",
"tags": [],
"tags": ["skip:ci"],
"targets": {
"build": {
"executor": "@angular-devkit/build-angular:application",

View File

@@ -1,4 +1,4 @@
import { isDevMode, NgModule } from '@angular/core';
import { NgModule } from '@angular/core';
import { RouterModule, Routes } from '@angular/router';
import {
CanActivateCartGuard,
@@ -7,29 +7,27 @@ import {
CanActivateCustomerOrdersGuard,
CanActivateCustomerOrdersWithProcessIdGuard,
CanActivateCustomerWithProcessIdGuard,
CanActivateGoodsInGuard,
CanActivateProductGuard,
CanActivateProductWithProcessIdGuard,
CanActivateTaskCalendarGuard,
IsAuthenticatedGuard,
} from './guards';
import { CanActivateAssortmentGuard } from './guards/can-activate-assortment.guard';
import { CanActivatePackageInspectionGuard } from './guards/can-activate-package-inspection.guard';
import { MainComponent } from './main.component';
import { PreviewComponent } from './preview';
import {
BranchSectionResolver,
CustomerSectionResolver,
ProcessIdResolver,
} from './resolvers';
import { TokenLoginComponent, TokenLoginModule } from './token-login';
import { ProcessIdGuard } from './guards/process-id.guard';
import {
ActivateProcessIdGuard,
ActivateProcessIdWithConfigKeyGuard,
} from './guards/activate-process-id.guard';
import { MatomoRouteData } from 'ngx-matomo-client';
import { tabResolverFn, processResolverFn } from '@isa/core/tabs';
import {
tabResolverFn,
processResolverFn,
hasTabIdGuard,
} from '@isa/core/tabs';
import { provideScrollPositionRestoration } from '@isa/utils/scroll-position';
const routes: Routes = [
@@ -70,8 +68,12 @@ const routes: Routes = [
loadChildren: () =>
import('@page/catalog').then((m) => m.PageCatalogModule),
canActivate: [CanActivateProductWithProcessIdGuard],
resolve: { processId: ProcessIdResolver },
resolve: {
processId: ProcessIdResolver,
},
},
// TODO: Check if order and :processId/order is still being used
// If not, remove these routes and the related guards and resolvers
{
path: 'order',
loadChildren: () =>
@@ -83,7 +85,9 @@ const routes: Routes = [
loadChildren: () =>
import('@page/customer-order').then((m) => m.CustomerOrderModule),
canActivate: [CanActivateCustomerOrdersWithProcessIdGuard],
resolve: { processId: ProcessIdResolver },
resolve: {
processId: ProcessIdResolver,
},
},
{
path: 'customer',
@@ -96,7 +100,9 @@ const routes: Routes = [
loadChildren: () =>
import('@page/customer').then((m) => m.CustomerModule),
canActivate: [CanActivateCustomerWithProcessIdGuard],
resolve: { processId: ProcessIdResolver },
resolve: {
processId: ProcessIdResolver,
},
},
{
path: 'cart',
@@ -109,10 +115,13 @@ const routes: Routes = [
loadChildren: () =>
import('@page/checkout').then((m) => m.PageCheckoutModule),
canActivate: [CanActivateCartWithProcessIdGuard],
resolve: {
processId: ProcessIdResolver,
},
},
{
path: 'pickup-shelf',
canActivate: [ProcessIdGuard],
canActivate: [ActivateProcessIdGuard],
// NOTE: This is a workaround for the canActivate guard not being called
loadChildren: () =>
import('@page/pickup-shelf').then((m) => m.PickupShelfOutModule),
@@ -122,6 +131,9 @@ const routes: Routes = [
canActivate: [ActivateProcessIdGuard],
loadChildren: () =>
import('@page/pickup-shelf').then((m) => m.PickupShelfOutModule),
resolve: {
processId: ProcessIdResolver,
},
},
{ path: '**', redirectTo: 'dashboard', pathMatch: 'full' },
],
@@ -137,7 +149,7 @@ const routes: Routes = [
import('@page/task-calendar').then(
(m) => m.PageTaskCalendarModule,
),
canActivate: [CanActivateTaskCalendarGuard],
canActivate: [ActivateProcessIdWithConfigKeyGuard('taskCalendar')],
},
{
path: 'pickup-shelf',
@@ -150,27 +162,23 @@ const routes: Routes = [
path: 'goods/in',
loadChildren: () =>
import('@page/goods-in').then((m) => m.GoodsInModule),
canActivate: [CanActivateGoodsInGuard],
canActivate: [ActivateProcessIdWithConfigKeyGuard('goodsIn')],
},
// {
// path: 'remission',
// loadChildren: () =>
// import('@page/remission').then((m) => m.PageRemissionModule),
// canActivate: [CanActivateRemissionGuard],
// },
{
path: 'package-inspection',
loadChildren: () =>
import('@page/package-inspection').then(
(m) => m.PackageInspectionModule,
),
canActivate: [CanActivatePackageInspectionGuard],
canActivate: [
ActivateProcessIdWithConfigKeyGuard('packageInspection'),
],
},
{
path: 'assortment',
loadChildren: () =>
import('@page/assortment').then((m) => m.AssortmentModule),
canActivate: [CanActivateAssortmentGuard],
canActivate: [ActivateProcessIdWithConfigKeyGuard('assortment')],
},
{ path: '**', redirectTo: 'task-calendar', pathMatch: 'full' },
],
@@ -182,7 +190,7 @@ const routes: Routes = [
path: ':tabId',
component: MainComponent,
resolve: { process: processResolverFn, tab: tabResolverFn },
canActivate: [IsAuthenticatedGuard],
canActivate: [IsAuthenticatedGuard, hasTabIdGuard],
children: [
{
path: 'reward',
@@ -239,13 +247,6 @@ const routes: Routes = [
},
];
if (isDevMode()) {
routes.unshift({
path: 'preview',
component: PreviewComponent,
});
}
@NgModule({
imports: [
RouterModule.forRoot(routes, {

View File

@@ -1,4 +1,5 @@
import { version } from '../../../../package.json';
import { IsaTitleStrategy } from '@isa/common/title-management';
import {
HTTP_INTERCEPTORS,
provideHttpClient,
@@ -56,7 +57,6 @@ import {
ScanditScanAdapterModule,
} from '@adapter/scan';
import * as Commands from './commands';
import { PreviewComponent } from './preview';
import { NativeContainerService } from '@external/native-container';
import { ShellModule } from '@shared/shell';
import { MainComponent } from './main.component';
@@ -68,7 +68,7 @@ import {
matWifiOff,
} from '@ng-icons/material-icons/baseline';
import { NetworkStatusService } from './services/network-status.service';
import { debounceTime, firstValueFrom } from 'rxjs';
import { debounceTime, filter, firstValueFrom, switchMap } from 'rxjs';
import { provideMatomo } from 'ngx-matomo-client';
import { withRouter, withRouteData } from 'ngx-matomo-client';
import {
@@ -77,7 +77,7 @@ import {
LogLevel,
withSink,
ConsoleLogSink,
logger,
logger as loggerFactory,
} from '@isa/core/logging';
import {
IDBStorageProvider,
@@ -85,57 +85,78 @@ import {
UserStorageProvider,
} from '@isa/core/storage';
import { Store } from '@ngrx/store';
import { TabNavigationService } from '@isa/core/tabs';
import { OAuthService } from 'angular-oauth2-oidc';
import z from 'zod';
import { TitleStrategy } from '@angular/router';
import { TabNavigationService } from '@isa/core/tabs';
registerLocaleData(localeDe, localeDeExtra);
registerLocaleData(localeDe, 'de', localeDeExtra);
export function _appInitializerFactory(config: Config, injector: Injector) {
return async () => {
// Get logging service for initialization logging
const logger = loggerFactory(() => ({ service: 'AppInitializer' }));
const statusElement = document.querySelector('#init-status');
const laoderElement = document.querySelector('#init-loader');
try {
logger.info('Starting application initialization');
let online = false;
const networkStatus = injector.get(NetworkStatusService);
while (!online) {
online = await firstValueFrom(networkStatus.online$);
if (!online) {
logger.warn('Waiting for network connection');
statusElement.innerHTML =
'<b>Warte auf Netzwerkverbindung (WLAN)</b><br><br>Bitte prüfen Sie die Netzwerkverbindung (WLAN).<br>Sobald eine Netzwerkverbindung besteht, wird die App automatisch neu geladen.';
await new Promise((resolve) => setTimeout(resolve, 250));
}
}
logger.info('Network connection established');
statusElement.innerHTML = 'Konfigurationen werden geladen...';
logger.info('Loading configurations');
statusElement.innerHTML = 'Scanner wird initialisiert...';
logger.info('Initializing scanner');
const scanAdapter = injector.get(ScanAdapterService);
await scanAdapter.init();
logger.info('Scanner initialized');
statusElement.innerHTML = 'Authentifizierung wird geprüft...';
logger.info('Initializing authentication');
const auth = injector.get(AuthService);
try {
await auth.init();
const authenticated = await auth.init();
if (!authenticated) {
throw new Error('User is not authenticated');
}
} catch {
statusElement.innerHTML = 'Authentifizierung wird durchgeführt...';
logger.info('Performing login');
const strategy = injector.get(LoginStrategy);
await strategy.login();
return;
}
statusElement.innerHTML = 'Native Container wird initialisiert...';
logger.info('Initializing native container');
const nativeContainer = injector.get(NativeContainerService);
await nativeContainer.init();
logger.info('Native container initialized');
statusElement.innerHTML = 'Datenbank wird initialisiert...';
logger.info('Initializing database');
await injector.get(IDBStorageProvider).init();
logger.info('Database initialized');
statusElement.innerHTML = 'Benutzerzustand wird geladen...';
logger.info('Loading user storage');
const userStorage = injector.get(UserStorageProvider);
await userStorage.init();
@@ -144,16 +165,29 @@ export function _appInitializerFactory(config: Config, injector: Injector) {
const state = userStorage.get('store');
if (state && state['version'] === version) {
store.dispatch({ type: 'HYDRATE', payload: userStorage.get('store') });
logger.info('Store hydrated from user storage');
} else {
logger.debug('Store hydration skipped', () => ({
reason: state ? 'version mismatch' : 'no stored state',
}));
}
// Subscribe on Store changes and save to user storage
store.pipe(debounceTime(1000)).subscribe((state) => {
userStorage.set('store', { ...state, version });
auth.initialized$
.pipe(
filter((initialized) => initialized),
switchMap(() => store.pipe(debounceTime(1000))),
)
.subscribe((state) => {
userStorage.set('store', state);
});
logger.info('Application initialization completed');
// Inject tab navigation service to initialize it
injector.get(TabNavigationService).init();
} catch (error) {
console.error('Error during app initialization', error);
logger.error('Application initialization failed', error as Error, () => ({
message: (error as Error).message,
}));
laoderElement.remove();
statusElement.classList.add('text-xl');
statusElement.innerHTML +=
@@ -199,7 +233,7 @@ export function _notificationsHubOptionsFactory(
}
const USER_SUB_FACTORY = () => {
const _logger = logger(() => ({
const _logger = loggerFactory(() => ({
context: 'USER_SUB',
}));
const auth = inject(OAuthService);
@@ -237,7 +271,6 @@ const USER_SUB_FACTORY = () => {
CoreCommandModule.forRoot(Object.values(Commands)),
CoreLoggerModule.forRoot(),
AppStoreModule,
PreviewComponent,
AuthModule.forRoot(),
CoreApplicationModule.forRoot(),
UiModalModule.forRoot(),
@@ -297,6 +330,7 @@ const USER_SUB_FACTORY = () => {
useValue: 'EUR',
},
provideUserSubFactory(USER_SUB_FACTORY),
{ provide: TitleStrategy, useClass: IsaTitleStrategy },
],
})
export class AppModule {}

View File

@@ -1,8 +1,13 @@
import { inject } from '@angular/core';
import { ActivatedRouteSnapshot, CanActivateFn, RouterStateSnapshot } from '@angular/router';
import {
ActivatedRouteSnapshot,
CanActivateFn,
RouterStateSnapshot,
} from '@angular/router';
import { ApplicationService } from '@core/application';
import { Config } from '@core/config';
import { take } from 'rxjs/operators';
import z from 'zod';
export const ActivateProcessIdGuard: CanActivateFn = async (
route: ActivatedRouteSnapshot,
@@ -19,10 +24,18 @@ export const ActivateProcessIdGuard: CanActivateFn = async (
const processId = Number(processIdStr);
// Check if Process already exists
const process = await application.getProcessById$(processId).pipe(take(1)).toPromise();
const process = await application
.getProcessById$(processId)
.pipe(take(1))
.toPromise();
if (!process) {
application.createCustomerProcess(processId);
application.createProcess({
id: processId,
type: 'cart',
section: 'customer',
name: `Vorgang ${processId}`,
});
}
application.activateProcess(processId);
@@ -30,17 +43,39 @@ export const ActivateProcessIdGuard: CanActivateFn = async (
return true;
};
export const ActivateProcessIdWithConfigKeyGuard: (key: string) => CanActivateFn =
(key) => async (route: ActivatedRouteSnapshot, state: RouterStateSnapshot) => {
export const ActivateProcessIdWithConfigKeyGuard: (
key: string,
) => CanActivateFn =
(key) =>
async (route: ActivatedRouteSnapshot, state: RouterStateSnapshot) => {
const application = inject(ApplicationService);
const config = inject(Config);
const processId = config.get(`process.ids.${key}`);
const processId = config.get(`process.ids.${key}`, z.coerce.number());
if (isNaN(processId)) {
if (typeof processId !== 'number' || isNaN(processId)) {
return false;
}
const processTitle = config.get(
`process.titles.${key}`,
z.string().default(key),
);
const process = await application
.getProcessById$(processId)
.pipe(take(1))
.toPromise();
if (!process) {
await application.createProcess({
id: processId,
type: key,
section: 'customer', // Not important anymore
name: processTitle,
});
}
application.activateProcess(processId);
return true;

View File

@@ -23,7 +23,7 @@ export class CanActivateGoodsInGuard {
id: this._config.get('process.ids.goodsIn'),
type: 'goods-in',
section: 'branch',
name: '',
name: 'Abholfach',
});
}
this._applicationService.activateProcess(

View File

@@ -8,24 +8,25 @@ import {
} from '@angular/common/http';
import { from, NEVER, Observable, throwError } from 'rxjs';
import { catchError, filter, mergeMap, takeUntil } from 'rxjs/operators';
import { LoginStrategy } from '@core/auth';
import { IsaLogProvider } from '../providers';
import { LogLevel } from '@core/logger';
import { AuthService, LoginStrategy } from '@core/auth';
import { injectOnline$ } from '../services/network-status.service';
import { logger } from '@isa/core/logging';
@Injectable()
export class HttpErrorInterceptor implements HttpInterceptor {
readonly offline$ = injectOnline$().pipe(filter((online) => !online));
readonly injector = inject(Injector);
constructor(private _isaLogProvider: IsaLogProvider) {}
#logger = logger(() => ({
'http-interceptor': 'HttpErrorInterceptor',
}));
#offline$ = injectOnline$().pipe(filter((online) => !online));
#injector = inject(Injector);
#auth = inject(AuthService);
intercept(
req: HttpRequest<any>,
next: HttpHandler,
): Observable<HttpEvent<any>> {
return next.handle(req).pipe(
takeUntil(this.offline$),
takeUntil(this.#offline$),
catchError((error: HttpErrorResponse, caught: any) =>
this.handleError(error),
),
@@ -33,8 +34,10 @@ export class HttpErrorInterceptor implements HttpInterceptor {
}
handleError(error: HttpErrorResponse): Observable<any> {
if (error.status === 401) {
const strategy = this.injector.get(LoginStrategy);
return this.#auth.initialized$.pipe(
mergeMap((initialized) => {
if (initialized && error.status === 401) {
const strategy = this.#injector.get(LoginStrategy);
return from(strategy.login('Sie sind nicht mehr angemeldet')).pipe(
mergeMap(() => NEVER),
@@ -42,9 +45,11 @@ export class HttpErrorInterceptor implements HttpInterceptor {
}
if (!error.url.endsWith('/isa/logging')) {
this._isaLogProvider.log(LogLevel.ERROR, 'Http Error', error);
this.#logger.error('Http Error', error);
}
return throwError(error);
return throwError(() => error);
}),
);
}
}

View File

@@ -1,3 +0,0 @@
// start:ng42.barrel
export * from './preview.component';
// end:ng42.barrel

View File

@@ -1,3 +0,0 @@
:host {
@apply grid min-h-screen content-center justify-center;
}

View File

@@ -1,10 +0,0 @@
<h1>Platform: {{ platform | json }}</h1>
<br />
<h1>{{ appVersion }}</h1>
<br />
<h1>{{ userAgent }}</h1>
<br />
<h1>Navigator: {{ navigator | json }}</h1>
<br />
<br />
<h1>Device: {{ device }}</h1>

View File

@@ -1,56 +0,0 @@
import { Platform, PlatformModule } from '@angular/cdk/platform';
import { CommonModule } from '@angular/common';
import { Component } from '@angular/core';
import { BranchDTO } from '@generated/swagger/checkout-api';
import { BehaviorSubject } from 'rxjs';
@Component({
selector: 'app-preview',
templateUrl: 'preview.component.html',
styleUrls: ['preview.component.css'],
imports: [CommonModule, PlatformModule],
})
export class PreviewComponent {
selectedBranch$ = new BehaviorSubject<BranchDTO>({});
get appVersion() {
return 'App Version: ' + (window.navigator as any).appVersion;
}
get userAgent() {
return 'User Agent: ' + (window.navigator as any).userAgent;
}
get navigator() {
const nav = {};
for (const i in window.navigator) nav[i] = navigator[i];
return nav;
}
get platform() {
return this._platform;
}
get device() {
const isIpadNative = this._platform.IOS && !this._platform.SAFARI;
const isIpadMini6Native = window?.navigator?.userAgent?.includes('Macintosh') && !this._platform.SAFARI;
const isNative = isIpadNative || isIpadMini6Native;
const isPWA = this._platform.IOS && this._platform.SAFARI;
const isDesktop = !isNative && !isPWA;
if (isNative) {
if (isIpadMini6Native) {
return 'IPAD mini 6 Native App';
} else if (isIpadNative) {
return 'IPAD mini 2 Native App or IPAD mini 5 Native App';
}
} else if (isPWA) {
return 'IPAD Safari PWA';
} else if (isDesktop) return 'Desktop or Macintosh';
}
constructor(private readonly _platform: Platform) {}
setNewBranch(branch: BranchDTO) {
this.selectedBranch$.next(branch);
}
}

View File

@@ -1,4 +1,2 @@
// start:ng42.barrel
export * from './process-id.resolver';
export * from './section.resolver';
// end:ng42.barrel

View File

@@ -20,7 +20,7 @@
"olaExpiration": "5m"
},
"@swagger/isa": {
"rootUrl": "https://isa-feature.paragon-data.net/isa/v1"
"rootUrl": "https://isa-test.paragon-data.net/isa/v1"
},
"@swagger/cat": {
"rootUrl": "https://isa-test.paragon-data.net/catsearch/v6"

View File

@@ -67,10 +67,9 @@
"goodsOut": 1000,
"goodsIn": 2000,
"taskCalendar": 3000,
"remission": 4000,
"packageInspection": 5000,
"assortment": 6000,
"pickupShelf": 7000
"pickupShelf": 2000
}
},
"checkForUpdates": 3600000,

View File

@@ -36,12 +36,18 @@ export class ApplicationService {
getProcesses$(section?: 'customer' | 'branch') {
const processes$ = this.store.select(selectProcesses);
return processes$.pipe(
map((processes) => processes.filter((process) => (section ? process.section === section : true))),
map((processes) =>
processes.filter((process) =>
section ? process.section === section : true,
),
),
);
}
getProcessById$(processId: number): Observable<ApplicationProcess> {
return this.getProcesses$().pipe(map((processes) => processes.find((process) => process.id === processId)));
return this.getProcesses$().pipe(
map((processes) => processes.find((process) => process.id === processId)),
);
}
getSection$() {
@@ -58,7 +64,9 @@ export class ApplicationService {
/** @deprecated */
getActivatedProcessId$() {
return this.store.select(selectActivatedProcess).pipe(map((process) => process?.id));
return this.store
.select(selectActivatedProcess)
.pipe(map((process) => process?.id));
}
activateProcess(activatedProcessId: number) {
@@ -81,19 +89,29 @@ export class ApplicationService {
getSelectedBranch$(processId?: number): Observable<BranchDTO> {
if (!processId) {
return this.activatedProcessId$.pipe(
switchMap((processId) => this.getProcessById$(processId).pipe(map((process) => process?.data?.selectedBranch))),
switchMap((processId) =>
this.getProcessById$(processId).pipe(
map((process) => process?.data?.selectedBranch),
),
),
);
}
return this.getProcessById$(processId).pipe(map((process) => process?.data?.selectedBranch));
return this.getProcessById$(processId).pipe(
map((process) => process?.data?.selectedBranch),
);
}
readonly REGEX_PROCESS_NAME = /^Vorgang \d+$/;
async createCustomerProcess(processId?: number): Promise<ApplicationProcess> {
const processes = await this.getProcesses$('customer').pipe(first()).toPromise();
const processes = await this.getProcesses$('customer')
.pipe(first())
.toPromise();
const processIds = processes.filter((x) => this.REGEX_PROCESS_NAME.test(x.name)).map((x) => +x.name.split(' ')[1]);
const processIds = processes
.filter((x) => this.REGEX_PROCESS_NAME.test(x.name))
.map((x) => +x.name.split(' ')[1]);
const maxId = processIds.length > 0 ? Math.max(...processIds) : 0;
@@ -111,7 +129,9 @@ export class ApplicationService {
}
async createProcess(process: ApplicationProcess) {
const existingProcess = await this.getProcessById$(process?.id).pipe(first()).toPromise();
const existingProcess = await this.getProcessById$(process?.id)
.pipe(first())
.toPromise();
if (existingProcess?.id === process?.id) {
throw new Error('Process Id existiert bereits');
}
@@ -155,7 +175,9 @@ export class ApplicationService {
);
}
getLastActivatedProcessWithSection$(section: 'customer' | 'branch'): Observable<ApplicationProcess> {
getLastActivatedProcessWithSection$(
section: 'customer' | 'branch',
): Observable<ApplicationProcess> {
return this.getProcesses$(section).pipe(
map((processes) =>
processes?.reduce((latest, current) => {

View File

@@ -5,6 +5,8 @@ import { isNullOrUndefined } from '@utils/common';
import { AuthConfig, OAuthService } from 'angular-oauth2-oidc';
import { JwksValidationHandler } from 'angular-oauth2-oidc-jwks';
import { BehaviorSubject } from 'rxjs';
import { logger } from '@isa/core/logging';
import { Router } from '@angular/router';
/**
* Storage key for the URL to redirect to after login
@@ -15,9 +17,17 @@ const REDIRECT_URL_KEY = 'auth_redirect_url';
providedIn: 'root',
})
export class AuthService {
private readonly _initialized = new BehaviorSubject<boolean>(false);
#logger = logger(() => ({ service: 'AuthService' }));
#router = inject(Router);
#initialized = new BehaviorSubject<boolean>(false);
get initialized$() {
return this._initialized.asObservable();
return this.#initialized.asObservable();
}
#authenticated = new BehaviorSubject<boolean>(false);
get authenticated$() {
return this.#authenticated.asObservable();
}
private _authConfig: AuthConfig;
@@ -27,16 +37,21 @@ export class AuthService {
) {
this._oAuthService.events?.subscribe((event) => {
if (event.type === 'token_received') {
console.log(
'SSO Token Expiration:',
new Date(this._oAuthService.getAccessTokenExpiration()),
);
this.#logger.info('SSO token received', () => ({
tokenExpiration: new Date(
this._oAuthService.getAccessTokenExpiration(),
).toISOString(),
}));
// Handle redirect after successful authentication
setTimeout(() => {
const redirectUrl = this._getAndClearRedirectUrl();
if (redirectUrl) {
window.location.href = redirectUrl;
this.#logger.debug('Redirecting after authentication', () => ({
redirectUrl,
}));
this.#router.navigateByUrl(redirectUrl);
}
}, 100);
}
@@ -44,50 +59,72 @@ export class AuthService {
}
async init() {
if (this._initialized.getValue()) {
if (this.#initialized.getValue()) {
this.#logger.error(
'AuthService initialization attempted twice',
new Error('Already initialized'),
);
throw new Error('AuthService is already initialized');
}
this.#logger.info('Initializing AuthService');
this._authConfig = this._config.get('@core/auth');
this.#logger.debug('Auth config loaded', () => ({
issuer: this._authConfig.issuer,
clientId: this._authConfig.clientId,
scope: this._authConfig.scope,
}));
this._authConfig.redirectUri = window.location.origin;
this._authConfig.silentRefreshRedirectUri =
window.location.origin + '/silent-refresh.html';
this._authConfig.useSilentRefresh = true;
this.#logger.debug('Auth URIs configured', () => ({
redirectUri: this._authConfig.redirectUri,
silentRefreshRedirectUri: this._authConfig.silentRefreshRedirectUri,
}));
this._oAuthService.configure(this._authConfig);
this._oAuthService.tokenValidationHandler = new JwksValidationHandler();
this.#logger.debug('Setting up automatic silent refresh');
this._oAuthService.setupAutomaticSilentRefresh();
this.#logger.debug('Loading discovery document and attempting login');
const authenticated =
await this._oAuthService.loadDiscoveryDocumentAndTryLogin();
if (!this._oAuthService.getAccessToken()) {
throw new Error('No access token. User is not authenticated.');
}
this.#authenticated.next(authenticated);
this.#logger.info('AuthService initialized', () => ({ authenticated }));
this._initialized.next(true);
this.#initialized.next(true);
return authenticated;
}
isAuthenticated() {
return this.isIdTokenValid();
return this.#authenticated.getValue();
}
isIdTokenValid() {
console.log(
'ID Token Expiration:',
new Date(this._oAuthService.getIdTokenExpiration()),
);
return this._oAuthService.hasValidIdToken();
const expiration = new Date(this._oAuthService.getIdTokenExpiration());
const isValid = this._oAuthService.hasValidIdToken();
this.#logger.debug('ID token validation check', () => ({
expiration: expiration.toISOString(),
isValid,
}));
return isValid;
}
isAccessTokenValid() {
console.log(
'ACCESS Token Expiration:',
new Date(this._oAuthService.getAccessTokenExpiration()),
);
return this._oAuthService.hasValidAccessToken();
const expiration = new Date(this._oAuthService.getAccessTokenExpiration());
const isValid = this._oAuthService.hasValidAccessToken();
this.#logger.debug('Access token validation check', () => ({
expiration: expiration.toISOString(),
isValid,
}));
return isValid;
}
getToken() {
@@ -111,6 +148,7 @@ export class AuthService {
if (isNullOrUndefined(token)) {
return null;
}
const base64Url = token.split('.')[1];
const base64 = base64Url.replace(/-/g, '+').replace(/_/g, '/');
@@ -135,18 +173,22 @@ export class AuthService {
}
login() {
this.#logger.info('Initiating login flow');
this._saveRedirectUrl();
this._oAuthService.initLoginFlow();
}
setKeyCardToken(token: string) {
this.#logger.debug('Setting keycard token');
this._oAuthService.customQueryParams = {
temp_token: token,
};
}
async logout() {
this.#logger.info('Initiating logout');
await this._oAuthService.revokeTokenAndLogout();
this.#logger.info('Logout completed');
}
hasRole(role: string | string[]) {
@@ -163,16 +205,20 @@ export class AuthService {
async refresh() {
try {
this.#logger.debug('Refreshing authentication token');
if (
this._authConfig.responseType.includes('code') &&
this._authConfig.scope.includes('offline_access')
) {
await this._oAuthService.refreshToken();
this.#logger.info('Token refreshed using refresh token');
} else {
await this._oAuthService.silentRefresh();
this.#logger.info('Token refreshed using silent refresh');
}
} catch (error) {
console.error(error);
this.#logger.error('Token refresh failed', error as Error);
}
}
}

View File

@@ -3,31 +3,49 @@ import { ActionHandler } from './action-handler.interface';
import { CommandService } from './command.service';
import { FEATURE_ACTION_HANDLERS, ROOT_ACTION_HANDLERS } from './tokens';
export function provideActionHandlers(actionHandlers: Type<ActionHandler>[]): Provider[] {
export function provideActionHandlers(
actionHandlers: Type<ActionHandler>[],
): Provider[] {
return [
CommandService,
actionHandlers.map((handler) => ({ provide: FEATURE_ACTION_HANDLERS, useClass: handler, multi: true })),
actionHandlers.map((handler) => ({
provide: FEATURE_ACTION_HANDLERS,
useClass: handler,
multi: true,
})),
];
}
@NgModule({})
export class CoreCommandModule {
static forRoot(actionHandlers: Type<ActionHandler>[]): ModuleWithProviders<CoreCommandModule> {
static forRoot(
actionHandlers: Type<ActionHandler>[],
): ModuleWithProviders<CoreCommandModule> {
return {
ngModule: CoreCommandModule,
providers: [
CommandService,
actionHandlers.map((handler) => ({ provide: ROOT_ACTION_HANDLERS, useClass: handler, multi: true })),
actionHandlers.map((handler) => ({
provide: ROOT_ACTION_HANDLERS,
useClass: handler,
multi: true,
})),
],
};
}
static forChild(actionHandlers: Type<ActionHandler>[]): ModuleWithProviders<CoreCommandModule> {
static forChild(
actionHandlers: Type<ActionHandler>[],
): ModuleWithProviders<CoreCommandModule> {
return {
ngModule: CoreCommandModule,
providers: [
CommandService,
actionHandlers.map((handler) => ({ provide: FEATURE_ACTION_HANDLERS, useClass: handler, multi: true })),
actionHandlers.map((handler) => ({
provide: FEATURE_ACTION_HANDLERS,
useClass: handler,
multi: true,
})),
],
};
}

View File

@@ -9,16 +9,19 @@ export class CommandService {
@Optional() @SkipSelf() private _parent: CommandService,
) {}
async handleCommand<T>(command: string, data?: T): Promise<T> {
async handleCommand<T>(command: string, data: T): Promise<T> {
const actions = this.getActions(command);
for (const action of actions) {
const handler = this.getActionHandler(action);
if (!handler) {
console.error('CommandService.handleCommand', 'Action Handler does not exist', { action });
console.error(
'CommandService.handleCommand',
'Action Handler does not exist',
{ action },
);
throw new Error('Action Handler does not exist');
}
data = await handler.handler(data, this);
}
return data;
@@ -29,10 +32,18 @@ export class CommandService {
}
getActionHandler(action: string): ActionHandler | undefined {
const featureActionHandlers: ActionHandler[] = this.injector.get(FEATURE_ACTION_HANDLERS, []);
const rootActionHandlers: ActionHandler[] = this.injector.get(ROOT_ACTION_HANDLERS, []);
const featureActionHandlers: ActionHandler[] = this.injector.get(
FEATURE_ACTION_HANDLERS,
[],
);
const rootActionHandlers: ActionHandler[] = this.injector.get(
ROOT_ACTION_HANDLERS,
[],
);
let handler = [...featureActionHandlers, ...rootActionHandlers].find((handler) => handler.action === action);
let handler = [...featureActionHandlers, ...rootActionHandlers].find(
(handler) => handler.action === action,
);
if (this._parent && !handler) {
handler = this._parent.getActionHandler(action);

View File

@@ -72,12 +72,82 @@ import { ApplicationService } from '@core/application';
import { CustomerDTO } from '@generated/swagger/crm-api';
import { Config } from '@core/config';
import parseDuration from 'parse-duration';
import { CheckoutMetadataService } from '@isa/checkout/data-access';
import {
CheckoutMetadataService,
ShoppingCart,
} from '@isa/checkout/data-access';
import {
ShoppingCartEvent,
ShoppingCartEvents,
} from '@isa/checkout/data-access';
/**
* Domain service for managing the complete checkout flow including shopping cart operations,
* checkout creation, buyer/payer management, payment processing, and order completion.
*
* This service orchestrates interactions between:
* - NgRx Store for state management
* - Multiple Swagger API clients (checkout, OMS, shopping cart, payment, buyer, payer, branch, kulturpass)
* - Shopping cart event system for cross-component synchronization
* - Availability service for real-time product availability checks
*
* @remarks
* **Process ID Pattern**: All methods require a `processId` (typically `Date.now()`) to isolate
* checkout sessions. Multiple concurrent checkout processes can run independently.
*
* **Observable-First Design**: Most methods return Observables for reactive composition. Consumers
* should use RxJS operators for transformation and error handling.
*
* **Auto-Creation**: Shopping carts auto-create if missing. The service uses `filter()` operators
* to trigger lazy initialization and prevent race conditions.
*
* **Event Sourcing**: Publishes shopping cart events (Created, ItemAdded, ItemUpdated, ItemRemoved)
* for synchronization across components. Subscribes to events from `ShoppingCartService` to maintain
* consistency.
*
* **OLA Management**: Tracks Order Level Agreement (OLA) expiration timestamps per item and order type.
* Validates availability freshness before checkout completion.
*
* @example
* ```typescript
* // Basic shopping cart flow
* const processId = Date.now();
*
* // Add items to cart
* this.checkoutService.addItemToShoppingCart({
* processId,
* items: [{ productId: 123, quantity: 2 }]
* }).subscribe();
*
* // Get cart (auto-creates if missing)
* this.checkoutService.getShoppingCart({ processId })
* .subscribe(cart => console.log(cart));
*
* // Complete checkout (orchestrates all steps)
* this.checkoutService.completeCheckout({ processId })
* .subscribe(orders => console.log('Orders created:', orders));
* ```
*
* @see DomainCheckoutSelectors For state selection patterns
* @see DomainCheckoutActions For available actions
* @see ShoppingCartEvents For event system integration
*/
@Injectable()
export class DomainCheckoutService {
/** Metadata service for shopping cart persistence */
#checkoutMetadataService = inject(CheckoutMetadataService);
/** Event bus for shopping cart synchronization across components */
#shoppingCartEvents = inject(ShoppingCartEvents);
/**
* Gets the OLA (Order Level Agreement) expiration duration in milliseconds.
*
* OLA expiration defines how long availability data remains valid before requiring refresh.
* Default is 5 minutes if not configured.
*
* @returns Duration in milliseconds
*/
get olaExpiration() {
const exp = this._config.get('@domain/checkout.olaExpiration') ?? '5m';
return parseDuration(exp);
@@ -96,9 +166,56 @@ export class DomainCheckoutService {
private _payerService: StoreCheckoutPayerService,
private _branchService: StoreCheckoutBranchService,
private _kulturpassService: KulturPassService,
) {}
) {
// Subscribe to shopping cart events from ShoppingCartService
this.#shoppingCartEvents.events$
.pipe(
// Only process events from ShoppingCartService to avoid circular updates
filter((payload) => payload.source === 'ShoppingCartService'),
)
.subscribe((payload) => {
// Update the store with the shopping cart from the event
this.store.dispatch(
DomainCheckoutActions.setShoppingCartByShoppingCartId({
shoppingCartId: payload.shoppingCart.id!,
shoppingCart: payload.shoppingCart as any,
}),
);
});
}
//#region shoppingcart
/**
* Retrieves the shopping cart for a given process ID. Auto-creates the cart if it doesn't exist.
*
* @remarks
* **Auto-Creation**: If no cart exists for the process ID, triggers `createShoppingCart()` automatically.
* The Observable filters out null/undefined and waits for cart creation to complete.
*
* **Latest Data**: Setting `latest: true` forces a refresh from the API instead of using cached state.
* This is useful before critical operations like checkout completion.
*
* **Memoization**: Uses `@memorize()` decorator to cache results by parameters, reducing duplicate calls.
*
* @param params - Parameters object
* @param params.processId - Unique process identifier (typically `Date.now()`)
* @param params.latest - If true, fetches fresh data from API; if false/undefined, uses store state
*
* @returns Observable of the shopping cart DTO. Never emits null/undefined.
*
* @example
* ```typescript
* // Get cart from store (creates if missing)
* this.checkoutService.getShoppingCart({ processId: 123 })
* .pipe(first())
* .subscribe(cart => console.log('Items:', cart.items));
*
* // Force refresh from API
* this.checkoutService.getShoppingCart({ processId: 123, latest: true })
* .pipe(first())
* .subscribe(cart => console.log('Fresh cart:', cart));
* ```
*/
@memorize()
getShoppingCart({
processId,
@@ -127,7 +244,6 @@ export class DomainCheckoutService {
.pipe(
map((response) => response.result),
tap((shoppingCart) => {
this.updateProcessCount(processId, shoppingCart);
this.store.dispatch(
DomainCheckoutActions.setShoppingCart({
processId,
@@ -144,6 +260,24 @@ export class DomainCheckoutService {
);
}
/**
* Reloads the shopping cart from the API and updates the store with fresh data.
*
* This is an async method that fetches the latest cart state from the backend
* and dispatches an action to update the NgRx store. Unlike `getShoppingCart({ latest: true })`,
* this method doesn't return the cart Observable - it's fire-and-forget.
*
* @param params - Parameters object
* @param params.processId - Process identifier
*
* @returns Promise that resolves when reload completes (or immediately if no cart exists)
*
* @example
* ```typescript
* await this.checkoutService.reloadShoppingCart({ processId: 123 });
* console.log('Cart reloaded');
* ```
*/
async reloadShoppingCart({ processId }: { processId: number }) {
const shoppingCart = await firstValueFrom(
this.store.select(DomainCheckoutSelectors.selectShoppingCartByProcessId, {
@@ -159,7 +293,6 @@ export class DomainCheckoutService {
}),
);
this.updateProcessCount(processId, cart.result);
this.store.dispatch(
DomainCheckoutActions.setShoppingCart({
processId,
@@ -168,6 +301,29 @@ export class DomainCheckoutService {
);
}
/**
* Creates a new shopping cart and associates it with the given process ID.
*
* @remarks
* **State Updates**:
* - Saves shopping cart ID to metadata service for persistence
* - Publishes `ShoppingCartEvent.Created` event for component synchronization
* - Dispatches `setShoppingCart` action to update NgRx store
*
* **Auto-Invocation**: Usually called automatically by `getShoppingCart()` when no cart exists.
* Rarely needs to be called directly.
*
* @param params - Parameters object
* @param params.processId - Process identifier to associate with the new cart
*
* @returns Observable of the newly created shopping cart DTO
*
* @example
* ```typescript
* this.checkoutService.createShoppingCart({ processId: Date.now() })
* .subscribe(cart => console.log('Cart created:', cart.id));
* ```
*/
createShoppingCart({
processId,
}: {
@@ -182,6 +338,11 @@ export class DomainCheckoutService {
processId,
shoppingCart.id,
);
this.#shoppingCartEvents.pub(
ShoppingCartEvent.Created,
shoppingCart as ShoppingCart,
'DomainCheckoutService',
);
this.store.dispatch(
DomainCheckoutActions.setShoppingCart({
processId,
@@ -192,6 +353,41 @@ export class DomainCheckoutService {
);
}
/**
* Adds one or more items to the shopping cart.
*
* @remarks
* **Process Flow**:
* 1. Retrieves existing shopping cart (creates if missing)
* 2. Calls API to add items
* 3. Publishes `ShoppingCartEvent.ItemAdded` event
* 4. Updates NgRx store with modified cart
*
* **Validation**: Ensure items are validated via `canAddItem()` or `canAddItems()` before calling
* this method to avoid API errors.
*
* @param params - Parameters object
* @param params.processId - Process identifier
* @param params.items - Array of items to add (product, quantity, availability, destination, etc.)
*
* @returns Observable of the updated shopping cart with new items
*
* @example
* ```typescript
* this.checkoutService.addItemToShoppingCart({
* processId: 123,
* items: [{
* product: { ean: '1234567890', catalogProductNumber: 456 },
* quantity: 2,
* availability: availabilityDto,
* destination: destinationDto
* }]
* }).subscribe(cart => console.log('Items:', cart.items.length));
* ```
*
* @see canAddItem For single item validation
* @see canAddItems For bulk item validation
*/
addItemToShoppingCart({
processId,
items,
@@ -210,7 +406,11 @@ export class DomainCheckoutService {
.pipe(
map((response) => response.result),
tap((shoppingCart) => {
this.updateProcessCount(processId, shoppingCart);
this.#shoppingCartEvents.pub(
ShoppingCartEvent.ItemAdded,
shoppingCart as ShoppingCart,
'DomainCheckoutService',
);
this.store.dispatch(
DomainCheckoutActions.setShoppingCart({
processId,
@@ -270,6 +470,37 @@ export class DomainCheckoutService {
);
}
/**
* Validates if a single item can be added to the shopping cart.
*
* Checks business rules, customer features, and cart compatibility before adding items.
* Use this before calling `addItemToShoppingCart()` to prevent API errors.
*
* @param params - Parameters object
* @param params.processId - Process identifier
* @param params.availability - OLA availability data for the item
* @param params.orderType - Order type (e.g., 'Abholung', 'Versand', 'Download', 'Rücklage')
*
* @returns Observable of `true` if item can be added, or error message string if not allowed
*
* @example
* ```typescript
* this.checkoutService.canAddItem({
* processId: 123,
* availability: olaAvailability,
* orderType: 'Versand'
* }).subscribe(result => {
* if (result === true) {
* // Proceed with adding item
* this.checkoutService.addItemToShoppingCart(...);
* } else {
* console.error('Cannot add item:', result);
* }
* });
* ```
*
* @see canAddItems For bulk validation
*/
canAddItem({
processId,
availability,
@@ -315,6 +546,38 @@ export class DomainCheckoutService {
.pipe(map((response) => response?.result));
}
/**
* Validates if multiple items can be added to the shopping cart in bulk.
*
* More efficient than calling `canAddItem()` multiple times. Returns validation
* results for each item in the payload.
*
* @param params - Parameters object
* @param params.processId - Process identifier
* @param params.payload - Array of item payloads to validate
* @param params.orderType - Order type for all items
*
* @returns Observable array of validation results (one per item). Each result contains
* `ok` flag and optional error messages.
*
* @example
* ```typescript
* this.checkoutService.canAddItems({
* processId: 123,
* payload: [
* { availabilities: [avail1], productId: 111, quantity: 2 },
* { availabilities: [avail2], productId: 222, quantity: 1 }
* ],
* orderType: 'Versand'
* }).subscribe(results => {
* results.forEach((result, index) => {
* console.log(`Item ${index}:`, result.ok ? 'Valid' : result.message);
* });
* });
* ```
*
* @see canAddItem For single item validation
*/
canAddItems({
processId,
payload,
@@ -386,6 +649,50 @@ export class DomainCheckoutService {
);
}
/**
* Updates an existing item in the shopping cart (quantity, availability, special comment, etc.).
*
* @remarks
* **Special Behavior**:
* - Setting `quantity: 0` removes the item and publishes `ItemRemoved` event instead of `ItemUpdated`
* - Always fetches latest cart state (`latest: true`) to avoid stale data conflicts
* - If availability is updated, adds timestamp to history for OLA validation
*
* **Event Publishing**:
* - Publishes `ShoppingCartEvent.ItemRemoved` if quantity is 0
* - Publishes `ShoppingCartEvent.ItemUpdated` for all other changes
*
* @param params - Parameters object
* @param params.processId - Process identifier
* @param params.shoppingCartItemId - ID of the cart item to update
* @param params.update - Fields to update (quantity, availability, specialComment, etc.)
*
* @returns Observable of the updated shopping cart
*
* @example
* ```typescript
* // Update quantity
* this.checkoutService.updateItemInShoppingCart({
* processId: 123,
* shoppingCartItemId: 456,
* update: { quantity: 5 }
* }).subscribe();
*
* // Remove item (quantity = 0)
* this.checkoutService.updateItemInShoppingCart({
* processId: 123,
* shoppingCartItemId: 456,
* update: { quantity: 0 }
* }).subscribe();
*
* // Update availability
* this.checkoutService.updateItemInShoppingCart({
* processId: 123,
* shoppingCartItemId: 456,
* update: { availability: newAvailabilityDto }
* }).subscribe();
* ```
*/
updateItemInShoppingCart({
processId,
shoppingCartItemId,
@@ -407,6 +714,17 @@ export class DomainCheckoutService {
.pipe(
map((response) => response.result),
tap((shoppingCart) => {
// Check if item was removed (quantity === 0)
const eventType =
update.quantity === 0
? ShoppingCartEvent.ItemRemoved
: ShoppingCartEvent.ItemUpdated;
this.#shoppingCartEvents.pub(
eventType,
shoppingCart as ShoppingCart,
'DomainCheckoutService',
);
this.store.dispatch(
DomainCheckoutActions.setShoppingCart({
processId,
@@ -425,8 +743,6 @@ export class DomainCheckoutService {
),
);
}
this.updateProcessCount(processId, shoppingCart);
}),
),
),
@@ -437,6 +753,34 @@ export class DomainCheckoutService {
//#region Checkout
/**
* Retrieves the checkout entity for a given process. Auto-creates if missing.
*
* @remarks
* **Auto-Creation**: Similar to `getShoppingCart()`, automatically triggers `createCheckout()`
* if no checkout exists for the process ID.
*
* **Refresh**: Setting `refresh: true` forces recreation of the checkout entity from the API.
*
* **Purpose**: The checkout entity aggregates buyer, payer, payment, destinations, and
* notification channels. It's required before order completion.
*
* @param params - Parameters object
* @param params.processId - Process identifier
* @param params.refresh - If true, recreates checkout from API; if false/undefined, uses store state
*
* @returns Observable of the checkout DTO. Never emits null/undefined.
*
* @example
* ```typescript
* this.checkoutService.getCheckout({ processId: 123 })
* .pipe(first())
* .subscribe(checkout => {
* console.log('Buyer:', checkout.buyer);
* console.log('Payment:', checkout.payment);
* });
* ```
*/
getCheckout({
processId,
refresh,
@@ -777,6 +1121,40 @@ export class DomainCheckoutService {
);
}
/**
* Refreshes the availability data for a single shopping cart item.
*
* Fetches fresh availability from the appropriate service based on order type
* (Abholung, Rücklage, Download, Versand, DIG-Versand, B2B-Versand) and updates
* the cart item.
*
* @remarks
* **Order Type Handling**:
* - **Abholung** (Pickup): Requires branch for availability check
* - **Rücklage** (TakeAway): Requires branch for availability check
* - **Download**: No additional parameters needed
* - **Versand** (Delivery): Standard delivery availability
* - **DIG-Versand** (Digital Delivery): Digital goods delivery
* - **B2B-Versand** (B2B Delivery): Business customer delivery
*
* **Updates**: Automatically calls `updateItemInShoppingCart()` with the new availability
* after fetching.
*
* @param params - Parameters object
* @param params.processId - Process identifier
* @param params.shoppingCartItemId - ID of the cart item to refresh
*
* @returns Promise of the refreshed availability DTO, or undefined if item not found
*
* @example
* ```typescript
* const availability = await this.checkoutService.refreshAvailability({
* processId: 123,
* shoppingCartItemId: 456
* });
* console.log('Updated availability:', availability);
* ```
*/
async refreshAvailability({
processId,
shoppingCartItemId,
@@ -873,7 +1251,12 @@ export class DomainCheckoutService {
await this.updateItemInShoppingCart({
processId,
update: { availability },
update: {
availability: {
...availability,
price: item?.availability?.price ?? availability?.price,
}, // #5488 After Refreshing Availabilities in Cart make sure to keep the original selected price from purchasing options modal
},
shoppingCartItemId: item.id,
}).toPromise();
@@ -881,9 +1264,41 @@ export class DomainCheckoutService {
}
/**
* Check if the availability of all items is valid
* @param param0 Process Id
* @returns true if the availability of all items is valid
* Validates if all shopping cart items have fresh availability data (OLA not expired).
*
* OLA (Order Level Agreement) defines how long availability data remains valid.
* This method polls the store at regular intervals and checks if the oldest
* availability timestamp is still within the expiration window.
*
* @remarks
* **Polling**: Uses `rxjsInterval()` to continuously check OLA status. The Observable emits
* `true` while all items are valid, `false` when any item expires.
*
* **Timestamp Tracking**: Tracks timestamps per `${itemId}_${orderType}` combination.
* Shipping types (Versand, DIG-Versand, B2B-Versand) fall back to generic 'Versand' timestamp.
*
* **Default Interval**: Polls every `olaExpiration / 10` milliseconds (default: 30 seconds for 5-minute expiration).
*
* @param params - Parameters object
* @param params.processId - Process identifier
* @param params.interval - Custom polling interval in milliseconds (optional)
*
* @returns Observable that emits `true` when OLA is valid, `false` when expired.
* Emits only on changes (`distinctUntilChanged()`).
*
* @example
* ```typescript
* this.checkoutService.validateOlaStatus({ processId: 123 })
* .subscribe(isValid => {
* if (!isValid) {
* console.warn('Availability data expired! Refresh required.');
* // Trigger availability refresh
* }
* });
* ```
*
* @see olaExpiration For expiration duration configuration
* @see checkoutIsValid For combined OLA + availability validation
*/
validateOlaStatus({
processId,
@@ -970,6 +1385,39 @@ export class DomainCheckoutService {
);
}
/**
* Validates if the checkout is ready for order completion.
*
* Combines OLA status validation with availability validation. Both must be true
* for checkout to proceed.
*
* @remarks
* **Validation Checks**:
* - OLA Status: All item availabilities are within expiration window
* - Availabilities: All items are marked as available (not out of stock)
*
* **Polling**: Uses fast polling (250ms) for OLA status to catch expiration quickly.
*
* @param params - Parameters object
* @param params.processId - Process identifier
*
* @returns Observable that emits `true` when checkout is valid, `false` otherwise.
* Emits on every change in either validation.
*
* @example
* ```typescript
* this.checkoutService.checkoutIsValid({ processId: 123 })
* .subscribe(isValid => {
* this.checkoutButton.disabled = !isValid;
* if (!isValid) {
* this.showWarning('Checkout unavailable: Availability expired');
* }
* });
* ```
*
* @see validateOlaStatus For OLA-only validation
* @see validateAvailabilities For availability-only validation
*/
checkoutIsValid({ processId }: { processId: number }): Observable<boolean> {
const olaStatus$ = this.validateOlaStatus({ processId, interval: 250 });
@@ -980,6 +1428,73 @@ export class DomainCheckoutService {
);
}
/**
* Orchestrates the complete checkout process from cart validation to order creation.
*
* This is the most complex method in the service, executing a 12-step sequence that
* validates data, updates entities, and creates orders. Each step must complete before
* the next begins.
*
* @remarks
* **Execution Sequence** (sequential, not parallel):
* 1. **Update Destination**: Sets shipping addresses on delivery destinations
* 2. **Refresh Shopping Cart**: Gets latest cart state from API
* 3. **Set Special Comments**: Applies agent comments to all cart items
* 4. **Refresh Checkout**: Recreates checkout entity from current state
* 5. **Check Availabilities**: Validates download items are available
* 6. **Update Availabilities**: Refreshes DIG-Versand and B2B-Versand prices
* 7. **Set Buyer**: Submits buyer information to checkout
* 8. **Set Notification Channels**: Configures email/SMS preferences
* 9. **Set Payer**: Submits payer information (if needed for order type)
* 10. **Set Payment Type**: Configures payment method (Rechnung/Bar)
* 11. **Set Destination**: Updates destinations with shipping addresses
* 12. **Complete Order**: Submits to OMS for order creation
*
* **Payment Type Logic**:
* - Download/Versand/DIG-Versand/B2B-Versand → Payment type 128 (Rechnung/Invoice)
* - Pickup/TakeAway only → Payment type 4 (Bar/Cash)
*
* **Payer Requirement**:
* - Required for B2B customers or Download/Delivery order types
* - Skipped for in-store pickup/takeaway only
*
* **Error Handling**:
* - HTTP 409 (Conflict): Order already exists - dispatches existing orders to store
* - Other errors propagate to consumer for handling
* - Failed availability checks throw error preventing order creation
*
* **Side Effects**:
* - Logs each step to console (for debugging)
* - Updates NgRx store at multiple points
* - Dispatches final orders to store on success
*
* @param params - Parameters object
* @param params.processId - Process identifier
*
* @returns Observable array of created orders (DisplayOrderDTO[])
*
* @throws Observable error if availability validation fails or API returns non-409 error
*
* @example
* ```typescript
* this.checkoutService.completeCheckout({ processId: 123 })
* .subscribe({
* next: (orders) => {
* console.log('Orders created:', orders);
* this.router.navigate(['/order-confirmation']);
* },
* error: (error) => {
* if (error.status === 409) {
* console.log('Order already exists');
* } else {
* console.error('Checkout failed:', error);
* }
* }
* });
* ```
*
* @see completeKulturpassOrder For Kulturpass-specific checkout flow
*/
completeCheckout({
processId,
}: {
@@ -1333,11 +1848,45 @@ export class DomainCheckoutService {
//#region Common
// Fix für Ticket #4619 Versand Artikel im Warenkob -> keine Änderung bei Kundendaten erfassen
// Auskommentiert, da dieser Aufruf oftmals mit gleichen Parametern aufgerufen wird (ohne ausgewählten Kunden nur ein leeres Objekt bei customerFeatures)
// memorize macht keinen deepCompare von Objekten und denkt hier, dass immer der gleiche Return Wert zurückkommt, allerdings ist das hier oft nicht der Fall
// und der Decorator memorized dann fälschlicherweise
// @memorize()
/**
* Validates if a customer can be set on the shopping cart based on cart contents and customer features.
*
* @remarks
* **Memoization Disabled**: The `@memorize()` decorator was intentionally disabled for this method
* due to shallow comparison issues. The decorator couldn't detect when `customerFeatures` object
* changed, causing stale cached results. See Ticket #4619.
*
* **Response Fields**:
* - `ok`: True if customer can be set without issues
* - `filter`: Customer search filters (e.g., `{ customertype: 'webshop;guest' }`)
* - `message`: Error message if validation fails
* - `create`: Options for creating new customer types (store, guest, webshop, b2b)
*
* **Use Cases**:
* - Determine which customer types are compatible with cart contents
* - Pre-filter customer search results
* - Enable/disable customer type creation buttons
*
* @param params - Parameters object
* @param params.processId - Process identifier
* @param params.customerFeatures - Customer feature flags (optional: webshop, guest, b2b, staff, etc.)
*
* @returns Observable with validation result containing ok, filter, message, and create options
*
* @example
* ```typescript
* this.checkoutService.canSetCustomer({
* processId: 123,
* customerFeatures: { webshop: 'true', guest: 'false' }
* }).subscribe(result => {
* if (result.ok) {
* console.log('Customer types allowed:', result.create.options.values);
* } else {
* console.error('Cannot set customer:', result.message);
* }
* });
* ```
*/
canSetCustomer({
processId,
customerFeatures,
@@ -1432,7 +1981,7 @@ export class DomainCheckoutService {
): Observable<{ [key: string]: boolean }> {
return this.canSetCustomer({ processId, customerFeatures: undefined }).pipe(
map((res) => {
let setableTypes: { [key: string]: boolean } = {
const setableTypes: { [key: string]: boolean } = {
store: false,
guest: false,
webshop: false,
@@ -1472,6 +2021,32 @@ export class DomainCheckoutService {
);
}
/**
* Retrieves all active, online branches that support shipping.
*
* @remarks
* **Filtering**: Returns only branches matching ALL criteria:
* - `status === 1` (Active)
* - `branchType === 1` (Standard branch type)
* - `isOnline === true` (Available online)
* - `isShippingEnabled === true` (Supports shipping)
*
* **Memoization**: Uses `@memorize()` decorator to cache results. Subsequent calls
* return cached data without API round-trip.
*
* **Pagination**: Fetches up to 999 branches (effectively all branches).
*
* @returns Observable array of filtered branch DTOs
*
* @example
* ```typescript
* this.checkoutService.getBranches()
* .subscribe(branches => {
* console.log('Available branches:', branches.length);
* this.branchDropdown.options = branches;
* });
* ```
*/
@memorize()
getBranches(): Observable<BranchDTO[]> {
return this._branchService
@@ -1552,6 +2127,21 @@ export class DomainCheckoutService {
);
}
/**
* Removes all checkout data for a process ID from the store.
*
* Cleans up shopping cart, checkout entity, buyer, payer, and all associated data.
* Call this when a checkout session is complete or cancelled.
*
* @param params - Parameters object
* @param params.processId - Process identifier to remove
*
* @example
* ```typescript
* // After successful order or when user cancels
* this.checkoutService.removeProcess({ processId: 123 });
* ```
*/
removeProcess({ processId }: { processId: number }) {
this.store.dispatch(
DomainCheckoutActions.removeCheckoutWithProcessId({ processId }),
@@ -1627,13 +2217,4 @@ export class DomainCheckoutService {
});
}
//#endregion
//#region Common
async updateProcessCount(processId: number, shoppingCart: ShoppingCartDTO) {
this.applicationService.patchProcessData(processId, {
count: shoppingCart.items?.length ?? 0,
});
}
//#endregion
}

View File

@@ -19,6 +19,11 @@ export const setShoppingCart = createAction(
props<{ processId: number; shoppingCart: ShoppingCartDTO }>(),
);
export const setShoppingCartByShoppingCartId = createAction(
`${prefix} Set Shopping Cart By Shopping Cart Id`,
props<{ shoppingCartId: number; shoppingCart: ShoppingCartDTO }>(),
);
export const setCheckout = createAction(
`${prefix} Set Checkout`,
props<{ processId: number; checkout: CheckoutDTO }>(),

View File

@@ -1,5 +1,8 @@
import { createReducer, on } from '@ngrx/store';
import { initialCheckoutState, storeCheckoutAdapter } from './domain-checkout.state';
import {
initialCheckoutState,
storeCheckoutAdapter,
} from './domain-checkout.state';
import * as DomainCheckoutActions from './domain-checkout.actions';
import { Dictionary } from '@ngrx/entity';
@@ -8,35 +11,74 @@ import { isNullOrUndefined } from '@utils/common';
const _domainCheckoutReducer = createReducer(
initialCheckoutState,
on(DomainCheckoutActions.setShoppingCart, (s, { processId, shoppingCart }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
on(
DomainCheckoutActions.setShoppingCart,
(s, { processId, shoppingCart }) => {
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
const addedShoppingCartItems =
shoppingCart?.items
?.filter((item) => !entity.shoppingCart?.items?.find((i) => i.id === item.id))
?.filter(
(item) =>
!entity.shoppingCart?.items?.find((i) => i.id === item.id),
)
?.map((item) => item.data) ?? [];
entity.shoppingCart = shoppingCart;
entity.itemAvailabilityTimestamp = entity.itemAvailabilityTimestamp ? { ...entity.itemAvailabilityTimestamp } : {};
entity.itemAvailabilityTimestamp = entity.itemAvailabilityTimestamp
? { ...entity.itemAvailabilityTimestamp }
: {};
const now = Date.now();
for (let shoppingCartItem of addedShoppingCartItems) {
for (const shoppingCartItem of addedShoppingCartItems) {
if (shoppingCartItem.features?.orderType) {
entity.itemAvailabilityTimestamp[`${shoppingCartItem.id}_${shoppingCartItem.features.orderType}`] = now;
entity.itemAvailabilityTimestamp[
`${shoppingCartItem.id}_${shoppingCartItem.features.orderType}`
] = now;
}
}
return storeCheckoutAdapter.setOne(entity, s);
}),
},
),
on(
DomainCheckoutActions.setShoppingCartByShoppingCartId,
(s, { shoppingCartId, shoppingCart }) => {
let entity = getCheckoutEntityByShoppingCartId({
shoppingCartId,
entities: s.entities,
});
if (!entity) {
// No entity found for this shoppingCartId, cannot update
return s;
}
entity = { ...entity, shoppingCart };
return storeCheckoutAdapter.setOne(entity, s);
},
),
on(DomainCheckoutActions.setCheckout, (s, { processId, checkout }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
entity.checkout = checkout;
return storeCheckoutAdapter.setOne(entity, s);
}),
on(DomainCheckoutActions.setBuyerCommunicationDetails, (s, { processId, email, mobile }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
on(
DomainCheckoutActions.setBuyerCommunicationDetails,
(s, { processId, email, mobile }) => {
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
const communicationDetails = { ...entity.buyer.communicationDetails };
communicationDetails.email = email || communicationDetails.email;
communicationDetails.mobile = mobile || communicationDetails.mobile;
@@ -45,13 +87,28 @@ const _domainCheckoutReducer = createReducer(
communicationDetails,
};
return storeCheckoutAdapter.setOne(entity, s);
}),
on(DomainCheckoutActions.setNotificationChannels, (s, { processId, notificationChannels }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
return storeCheckoutAdapter.setOne({ ...entity, notificationChannels }, s);
}),
on(DomainCheckoutActions.setCheckoutDestination, (s, { processId, destination }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
},
),
on(
DomainCheckoutActions.setNotificationChannels,
(s, { processId, notificationChannels }) => {
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
return storeCheckoutAdapter.setOne(
{ ...entity, notificationChannels },
s,
);
},
),
on(
DomainCheckoutActions.setCheckoutDestination,
(s, { processId, destination }) => {
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
entity.checkout = {
...entity.checkout,
destinations: entity.checkout.destinations.map((dest) => {
@@ -62,41 +119,68 @@ const _domainCheckoutReducer = createReducer(
}),
};
return storeCheckoutAdapter.setOne(entity, s);
}),
on(DomainCheckoutActions.setShippingAddress, (s, { processId, shippingAddress }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
},
),
on(
DomainCheckoutActions.setShippingAddress,
(s, { processId, shippingAddress }) => {
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
entity.shippingAddress = shippingAddress;
return storeCheckoutAdapter.setOne(entity, s);
}),
},
),
on(DomainCheckoutActions.setBuyer, (s, { processId, buyer }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
entity.buyer = buyer;
return storeCheckoutAdapter.setOne(entity, s);
}),
on(DomainCheckoutActions.setPayer, (s, { processId, payer }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
entity.payer = payer;
return storeCheckoutAdapter.setOne(entity, s);
}),
on(DomainCheckoutActions.setSpecialComment, (s, { processId, agentComment }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
on(
DomainCheckoutActions.setSpecialComment,
(s, { processId, agentComment }) => {
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
entity.specialComment = agentComment;
return storeCheckoutAdapter.setOne(entity, s);
}),
},
),
on(DomainCheckoutActions.removeCheckoutWithProcessId, (s, { processId }) => {
return storeCheckoutAdapter.removeOne(processId, s);
}),
on(DomainCheckoutActions.setOrders, (s, { orders }) => ({ ...s, orders: [...s.orders, ...orders] })),
on(DomainCheckoutActions.setOrders, (s, { orders }) => ({
...s,
orders: [...s.orders, ...orders],
})),
on(DomainCheckoutActions.updateOrderItem, (s, { item }) => {
const orders = [...s.orders];
const orderToUpdate = orders?.find((order) => order.items?.find((i) => i.id === item?.id));
const orderToUpdate = orders?.find((order) =>
order.items?.find((i) => i.id === item?.id),
);
const orderToUpdateIndex = orders?.indexOf(orderToUpdate);
const orderItemToUpdate = orderToUpdate?.items?.find((i) => i.id === item?.id);
const orderItemToUpdateIndex = orderToUpdate?.items?.indexOf(orderItemToUpdate);
const orderItemToUpdate = orderToUpdate?.items?.find(
(i) => i.id === item?.id,
);
const orderItemToUpdateIndex =
orderToUpdate?.items?.indexOf(orderItemToUpdate);
const items = [...orderToUpdate?.items];
const items = [...(orderToUpdate?.items ?? [])];
items[orderItemToUpdateIndex] = item;
orders[orderToUpdateIndex] = {
@@ -111,29 +195,41 @@ const _domainCheckoutReducer = createReducer(
orders: [],
})),
on(DomainCheckoutActions.setOlaError, (s, { processId, olaErrorIds }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
entity.olaErrorIds = olaErrorIds;
return storeCheckoutAdapter.setOne(entity, s);
}),
on(DomainCheckoutActions.setCustomer, (s, { processId, customer }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
entity.customer = customer;
return storeCheckoutAdapter.setOne(entity, s);
}),
on(
DomainCheckoutActions.addShoppingCartItemAvailabilityToHistory,
(s, { processId, shoppingCartItemId, availability }) => {
const entity = getOrCreateCheckoutEntity({ processId, entities: s.entities });
const entity = getOrCreateCheckoutEntity({
processId,
entities: s.entities,
});
const itemAvailabilityTimestamp = entity?.itemAvailabilityTimestamp
? { ...entity?.itemAvailabilityTimestamp }
: {};
const item = entity?.shoppingCart?.items?.find((i) => i.id === shoppingCartItemId)?.data;
const item = entity?.shoppingCart?.items?.find(
(i) => i.id === shoppingCartItemId,
)?.data;
if (!item?.features?.orderType) return s;
itemAvailabilityTimestamp[`${item.id}_${item?.features?.orderType}`] = Date.now();
itemAvailabilityTimestamp[`${item.id}_${item?.features?.orderType}`] =
Date.now();
entity.itemAvailabilityTimestamp = itemAvailabilityTimestamp;
@@ -143,17 +239,23 @@ const _domainCheckoutReducer = createReducer(
on(
DomainCheckoutActions.addShoppingCartItemAvailabilityToHistoryByShoppingCartId,
(s, { shoppingCartId, shoppingCartItemId, availability }) => {
const entity = getCheckoutEntityByShoppingCartId({ shoppingCartId, entities: s.entities });
const entity = getCheckoutEntityByShoppingCartId({
shoppingCartId,
entities: s.entities,
});
const itemAvailabilityTimestamp = entity?.itemAvailabilityTimestamp
? { ...entity?.itemAvailabilityTimestamp }
: {};
const item = entity?.shoppingCart?.items?.find((i) => i.id === shoppingCartItemId)?.data;
const item = entity?.shoppingCart?.items?.find(
(i) => i.id === shoppingCartItemId,
)?.data;
if (!item?.features?.orderType) return s;
itemAvailabilityTimestamp[`${item.id}_${item?.features?.orderType}`] = Date.now();
itemAvailabilityTimestamp[`${item.id}_${item?.features?.orderType}`] =
Date.now();
entity.itemAvailabilityTimestamp = itemAvailabilityTimestamp;
@@ -173,7 +275,7 @@ function getOrCreateCheckoutEntity({
entities: Dictionary<CheckoutEntity>;
processId: number;
}): CheckoutEntity {
let entity = entities[processId];
const entity = entities[processId];
if (isNullOrUndefined(entity)) {
return {
@@ -203,5 +305,7 @@ function getCheckoutEntityByShoppingCartId({
entities: Dictionary<CheckoutEntity>;
shoppingCartId: number;
}): CheckoutEntity {
return Object.values(entities).find((entity) => entity.shoppingCart?.id === shoppingCartId);
return Object.values(entities).find(
(entity) => entity.shoppingCart?.id === shoppingCartId,
);
}

View File

@@ -47,7 +47,10 @@ export class CrmCustomerService {
);
}
complete(queryString: string, filter?: { [key: string]: string }): Observable<Result<AutocompleteDTO[]>> {
complete(
queryString: string,
filter?: { [key: string]: string },
): Observable<Result<AutocompleteDTO[]>> {
return this.customerService.CustomerCustomerAutocomplete({
input: queryString,
filter: filter || {},
@@ -65,7 +68,11 @@ export class CrmCustomerService {
getCustomers(
queryString: string,
options: { take?: number; skip?: number; filter?: { [key: string]: string } } = { take: 20, skip: 0 },
options: {
take?: number;
skip?: number;
filter?: { [key: string]: string };
} = { take: 20, skip: 0 },
): Observable<ListResponseArgsOfCustomerInfoDTO> {
return this.customerService.CustomerListCustomers({
input: queryString ? { qs: queryString } : undefined,
@@ -84,15 +91,27 @@ export class CrmCustomerService {
return this.customerService.CustomerListCustomers(queryToken);
}
getCustomersByCustomerCardNumber(queryString: string): Observable<PagedResult<CustomerInfoDTO>> {
return this.customerService.CustomerGetCustomerByBonuscard(queryString ? queryString : undefined);
getCustomersByCustomerCardNumber(
queryString: string,
): Observable<PagedResult<CustomerInfoDTO>> {
return this.customerService.CustomerGetCustomerByBonuscard(
queryString ? queryString : undefined,
);
}
getCustomer(customerId: number, eagerLoading?: number): Observable<Result<CustomerDTO>> {
return this.customerService.CustomerGetCustomer({ customerId, eagerLoading });
getCustomer(
customerId: number,
eagerLoading?: number,
): Observable<Result<CustomerDTO>> {
return this.customerService.CustomerGetCustomer({
customerId,
eagerLoading,
});
}
getAssignedPayers(params: CustomerService.CustomerGetAssignedPayersByCustomerIdParams) {
getAssignedPayers(
params: CustomerService.CustomerGetAssignedPayersByCustomerIdParams,
) {
return this.customerService.CustomerGetAssignedPayersByCustomerId(params);
}
@@ -102,7 +121,7 @@ export class CrmCustomerService {
}: {
communicationDetails: CommunicationDetailsDTO;
}): NotificationChannel {
let notificationChannels: number = 0;
let notificationChannels = 0;
if (communicationDetails?.email) {
notificationChannels += 1;
@@ -114,20 +133,32 @@ export class CrmCustomerService {
return notificationChannels as NotificationChannel;
}
patchCustomer(customerId: number, customer: CustomerDTO): Observable<Result<CustomerDTO>> {
const notificationChannels = this.getNotificationChannelForCommunicationDetails({
patchCustomer(
customerId: number,
customer: CustomerDTO,
): Observable<Result<CustomerDTO>> {
const notificationChannels =
this.getNotificationChannelForCommunicationDetails({
communicationDetails: customer?.communicationDetails,
});
return this.customerService.CustomerPatchCustomer({ customerId, customer: { ...customer, notificationChannels } });
return this.customerService.CustomerPatchCustomer({
customerId,
customer: { ...customer, notificationChannels },
});
}
createB2BCustomer(customer: CustomerDTO): Promise<Result<CustomerDTO>> {
const notificationChannels = this.getNotificationChannelForCommunicationDetails({
const notificationChannels =
this.getNotificationChannelForCommunicationDetails({
communicationDetails: customer?.communicationDetails,
});
const payload: CustomerDTO = { ...customer, customerType: 16, notificationChannels };
const payload: CustomerDTO = {
...customer,
customerType: 16,
notificationChannels,
};
payload.shippingAddresses = payload.shippingAddresses ?? [];
@@ -142,13 +173,23 @@ export class CrmCustomerService {
}
createOnlineCustomer(customer: CustomerDTO): Observable<Result<CustomerDTO>> {
const payload: CustomerDTO = { ...customer, customerType: 8, hasOnlineAccount: true };
const payload: CustomerDTO = {
...customer,
customerType: 8,
hasOnlineAccount: true,
};
const notificationChannels = this.getNotificationChannelForCommunicationDetails({
const notificationChannels =
this.getNotificationChannelForCommunicationDetails({
communicationDetails: customer?.communicationDetails,
});
if (!(isArray(payload.shippingAddresses) && payload.shippingAddresses.length > 0)) {
if (
!(
isArray(payload.shippingAddresses) &&
payload.shippingAddresses.length > 0
)
) {
payload.shippingAddresses = [
{
data: {
@@ -187,7 +228,9 @@ export class CrmCustomerService {
const p4mUser = customer.features.find((f) => f.key === 'p4mUser')?.value;
const modifiers: KeyValueDTOOfStringAndString[] = [{ key: 'webshop', group: 'customertype' }];
const modifiers: KeyValueDTOOfStringAndString[] = [
{ key: 'webshop', group: 'customertype' },
];
if (p4mUser) {
modifiers.push({ key: 'add-loyalty-card', value: p4mUser });
@@ -225,7 +268,9 @@ export class CrmCustomerService {
};
}
async updateToOnlineCustomer(customer: CustomerDTO): Promise<Result<CustomerDTO>> {
async updateToOnlineCustomer(
customer: CustomerDTO,
): Promise<Result<CustomerDTO>> {
const payload: CustomerDTO = {
shippingAddresses: [],
payers: [],
@@ -234,19 +279,29 @@ export class CrmCustomerService {
hasOnlineAccount: true,
};
const notificationChannels = this.getNotificationChannelForCommunicationDetails({
const notificationChannels =
this.getNotificationChannelForCommunicationDetails({
communicationDetails: payload?.communicationDetails,
});
const shippingAddressesToAdd = payload.shippingAddresses?.filter((sa) => !sa.id)?.map((m) => m.data) ?? [];
payload.shippingAddresses = payload.shippingAddresses?.filter((sa) => !!sa.id) ?? [];
const shippingAddressesToAdd =
payload.shippingAddresses?.filter((sa) => !sa.id)?.map((m) => m.data) ??
[];
payload.shippingAddresses =
payload.shippingAddresses?.filter((sa) => !!sa.id) ?? [];
if (payload.shippingAddresses.length === 0) {
shippingAddressesToAdd.unshift(this.mapCustomerToShippingAddress(payload));
shippingAddressesToAdd.unshift(
this.mapCustomerToShippingAddress(payload),
);
}
const payersToAdd = payload.payers?.filter((p) => !p.assignedToCustomer)?.map((p) => p.payer?.data) ?? [];
payload.payers = payload.payers?.filter((p) => !!p.assignedToCustomer) ?? [];
const payersToAdd =
payload.payers
?.filter((p) => !p.assignedToCustomer)
?.map((p) => p.payer?.data) ?? [];
payload.payers =
payload.payers?.filter((p) => !!p.assignedToCustomer) ?? [];
if (payload.payers.length === 0) {
payersToAdd.unshift({
@@ -255,7 +310,9 @@ export class CrmCustomerService {
});
}
const modifiers: KeyValueDTOOfStringAndString[] = [{ key: 'webshop', group: 'customertype' }];
const modifiers: KeyValueDTOOfStringAndString[] = [
{ key: 'webshop', group: 'customertype' },
];
const res = await this.customerService
.CustomerUpdateCustomer({
@@ -267,27 +324,38 @@ export class CrmCustomerService {
})
.toPromise();
for (let shippingAddress of shippingAddressesToAdd) {
for (const shippingAddress of shippingAddressesToAdd) {
await this.createShippingAddress(res.result.id, shippingAddress, true);
}
for (let payer of payersToAdd) {
for (const payer of payersToAdd) {
await this.createPayer(res.result.id, payer, true);
}
return res;
}
async updateToP4MOnlineCustomer(customer: CustomerDTO): Promise<Result<CustomerDTO>> {
const shippingAddressesToAdd = customer.shippingAddresses?.filter((sa) => !sa.id)?.map((m) => m.data) ?? [];
customer.shippingAddresses = customer.shippingAddresses?.filter((sa) => !!sa.id) ?? [];
async updateToP4MOnlineCustomer(
customer: CustomerDTO,
): Promise<Result<CustomerDTO>> {
const shippingAddressesToAdd =
customer.shippingAddresses?.filter((sa) => !sa.id)?.map((m) => m.data) ??
[];
customer.shippingAddresses =
customer.shippingAddresses?.filter((sa) => !!sa.id) ?? [];
if (customer.shippingAddresses.length === 0) {
shippingAddressesToAdd.unshift(this.mapCustomerToShippingAddress(customer));
shippingAddressesToAdd.unshift(
this.mapCustomerToShippingAddress(customer),
);
}
const payersToAdd = customer.payers?.filter((p) => !p.assignedToCustomer)?.map((p) => p.payer?.data) ?? [];
customer.payers = customer.payers?.filter((p) => !!p.assignedToCustomer) ?? [];
const payersToAdd =
customer.payers
?.filter((p) => !p.assignedToCustomer)
?.map((p) => p.payer?.data) ?? [];
customer.payers =
customer.payers?.filter((p) => !!p.assignedToCustomer) ?? [];
if (customer.payers.length === 0) {
payersToAdd.unshift({
@@ -298,7 +366,9 @@ export class CrmCustomerService {
const p4mUser = customer.features.find((f) => f.key === 'p4mUser')?.value;
const modifiers: KeyValueDTOOfStringAndString[] = [{ key: 'webshop', group: 'customertype' }];
const modifiers: KeyValueDTOOfStringAndString[] = [
{ key: 'webshop', group: 'customertype' },
];
if (p4mUser) {
modifiers.push({ key: 'add-loyalty-card', value: p4mUser });
@@ -314,27 +384,38 @@ export class CrmCustomerService {
})
.toPromise();
for (let shippingAddress of shippingAddressesToAdd) {
for (const shippingAddress of shippingAddressesToAdd) {
await this.createShippingAddress(res.result.id, shippingAddress, true);
}
for (let payer of payersToAdd) {
for (const payer of payersToAdd) {
await this.createPayer(res.result.id, payer, true);
}
return res;
}
async updateStoreP4MToWebshopP4M(customer: CustomerDTO): Promise<Result<CustomerDTO>> {
const shippingAddressesToAdd = customer.shippingAddresses?.filter((sa) => !sa.id)?.map((m) => m.data) ?? [];
customer.shippingAddresses = customer.shippingAddresses?.filter((sa) => !!sa.id) ?? [];
async updateStoreP4MToWebshopP4M(
customer: CustomerDTO,
): Promise<Result<CustomerDTO>> {
const shippingAddressesToAdd =
customer.shippingAddresses?.filter((sa) => !sa.id)?.map((m) => m.data) ??
[];
customer.shippingAddresses =
customer.shippingAddresses?.filter((sa) => !!sa.id) ?? [];
if (customer.shippingAddresses.length === 0) {
shippingAddressesToAdd.unshift(this.mapCustomerToShippingAddress(customer));
shippingAddressesToAdd.unshift(
this.mapCustomerToShippingAddress(customer),
);
}
const payersToAdd = customer.payers?.filter((p) => !p.assignedToCustomer)?.map((p) => p.payer?.data) ?? [];
customer.payers = customer.payers?.filter((p) => !!p.assignedToCustomer) ?? [];
const payersToAdd =
customer.payers
?.filter((p) => !p.assignedToCustomer)
?.map((p) => p.payer?.data) ?? [];
customer.payers =
customer.payers?.filter((p) => !!p.assignedToCustomer) ?? [];
if (customer.payers.length === 0) {
payersToAdd.unshift({
@@ -343,7 +424,9 @@ export class CrmCustomerService {
});
}
const modifiers: KeyValueDTOOfStringAndString[] = [{ key: 'webshop', group: 'customertype' }];
const modifiers: KeyValueDTOOfStringAndString[] = [
{ key: 'webshop', group: 'customertype' },
];
const res = await this.customerService
.CustomerUpdateCustomer({
@@ -355,22 +438,30 @@ export class CrmCustomerService {
})
.toPromise();
for (let shippingAddress of shippingAddressesToAdd) {
for (const shippingAddress of shippingAddressesToAdd) {
await this.createShippingAddress(res.result.id, shippingAddress, true);
}
for (let payer of payersToAdd) {
for (const payer of payersToAdd) {
await this.createPayer(res.result.id, payer, true);
}
return res;
}
async createGuestCustomer(customer: CustomerDTO): Promise<Result<CustomerDTO>> {
const notificationChannels = this.getNotificationChannelForCommunicationDetails({
async createGuestCustomer(
customer: CustomerDTO,
): Promise<Result<CustomerDTO>> {
const notificationChannels =
this.getNotificationChannelForCommunicationDetails({
communicationDetails: customer?.communicationDetails,
});
const payload: CustomerDTO = { ...customer, customerType: 8, isGuestAccount: true, notificationChannels };
const payload: CustomerDTO = {
...customer,
customerType: 8,
isGuestAccount: true,
notificationChannels,
};
payload.shippingAddresses = customer.shippingAddresses ?? [];
@@ -400,13 +491,16 @@ export class CrmCustomerService {
}
createStoreCustomer(customer: CustomerDTO): Observable<Result<CustomerDTO>> {
const notificationChannels = this.getNotificationChannelForCommunicationDetails({
const notificationChannels =
this.getNotificationChannelForCommunicationDetails({
communicationDetails: customer?.communicationDetails,
});
const p4mUser = customer.features.find((f) => f.key === 'p4mUser')?.value;
const modifiers: KeyValueDTOOfStringAndString[] = [{ key: 'store', group: 'customertype' }];
const modifiers: KeyValueDTOOfStringAndString[] = [
{ key: 'store', group: 'customertype' },
];
if (p4mUser) {
modifiers.push({ key: 'add-loyalty-card', value: p4mUser });
@@ -468,9 +562,9 @@ export class CrmCustomerService {
return this.customerService.CustomerEmailExists(email);
}
checkLoyaltyCard({ loyaltyCardNumber, customerId }: { loyaltyCardNumber: string; customerId?: number }) {
return this.loyaltyCardService.LoyaltyCardCheckLoyaltyCard({ loyaltyCardNumber, customerId });
}
// checkLoyaltyCard({ loyaltyCardNumber, customerId }: { loyaltyCardNumber: string; customerId?: number }) {
// return this.loyaltyCardService.LoyaltyCardCheckLoyaltyCard({ loyaltyCardNumber, customerId });
// }
createPayer(
customerId: number,
@@ -480,7 +574,12 @@ export class CrmCustomerService {
return this.getCustomer(customerId)
.pipe(
mergeMap((customerResponse) =>
this.payerService.PayerCreatePayer({ ...payer, payerType: customerResponse.result.customerType }).pipe(
this.payerService
.PayerCreatePayer({
...payer,
payerType: customerResponse.result.customerType,
})
.pipe(
mergeMap((payerResponse) =>
this.customerService
.CustomerAddPayerReference({
@@ -491,7 +590,10 @@ export class CrmCustomerService {
.pipe(
map(
(assigendPayerResponse) =>
[payerResponse, assigendPayerResponse] as [Result<PayerDTO>, Result<AssignedPayerDTO>],
[payerResponse, assigendPayerResponse] as [
Result<PayerDTO>,
Result<AssignedPayerDTO>,
],
),
),
),
@@ -501,14 +603,33 @@ export class CrmCustomerService {
.toPromise();
}
updatePayer(customerId: number, payerId: number, payer: PayerDTO, isDefault?: boolean): Observable<Result<PayerDTO>> {
updatePayer(
customerId: number,
payerId: number,
payer: PayerDTO,
isDefault?: boolean,
): Observable<Result<PayerDTO>> {
return this.payerService
.PayerUpdatePayer({ payerId, payer })
.pipe(mergeMap((response) => this.setDefaultPayer(payerId, customerId, isDefault).pipe(map(() => response))));
.pipe(
mergeMap((response) =>
this.setDefaultPayer(payerId, customerId, isDefault).pipe(
map(() => response),
),
),
);
}
setDefaultPayer(payerId: number, customerId: number, isDefault = true): Observable<Result<AssignedPayerDTO>> {
return this.customerService.CustomerModifyPayerReference({ payerId, customerId, isDefault });
setDefaultPayer(
payerId: number,
customerId: number,
isDefault = true,
): Observable<Result<AssignedPayerDTO>> {
return this.customerService.CustomerModifyPayerReference({
payerId,
customerId,
isDefault,
});
}
createShippingAddress(
@@ -524,7 +645,10 @@ export class CrmCustomerService {
}
return this.shippingAddressService
.ShippingAddressCreateShippingAddress({ customerId, shippingAddress: data })
.ShippingAddressCreateShippingAddress({
customerId,
shippingAddress: data,
})
.toPromise();
}
@@ -543,29 +667,43 @@ export class CrmCustomerService {
}
return this.shippingAddressService
.ShippingAddressUpdateShippingAddress({ shippingAddressId, shippingAddress: data, customerId })
.ShippingAddressUpdateShippingAddress({
shippingAddressId,
shippingAddress: data,
customerId,
})
.toPromise();
}
getShippingAddress(shippingAddressId: number): Observable<Result<ShippingAddressDTO>> {
return this.shippingAddressService.ShippingAddressGetShippingaddress(shippingAddressId);
getShippingAddress(
shippingAddressId: number,
): Observable<Result<ShippingAddressDTO>> {
return this.shippingAddressService.ShippingAddressGetShippingaddress(
shippingAddressId,
);
}
getShippingAddresses(
params: ShippingAddressService.ShippingAddressGetShippingAddressesParams,
): Observable<Result<ShippingAddressDTO[]>> {
return this.shippingAddressService.ShippingAddressGetShippingAddresses(params);
return this.shippingAddressService.ShippingAddressGetShippingAddresses(
params,
);
}
getPayer(payerId: number): Observable<Result<PayerDTO>> {
return this.payerService.PayerGetPayer(payerId);
}
getCustomerCard(customerId: number): Observable<ResponseArgsOfIEnumerableOfBonusCardInfoDTO> {
getCustomerCard(
customerId: number,
): Observable<ResponseArgsOfIEnumerableOfBonusCardInfoDTO> {
return this.customerService.CustomerGetBonuscards(customerId);
}
getCustomerHistory(customerId: number): Observable<HistoryDTO[]> {
return this.customerService.CustomerGetCustomerHistory({ customerId }).pipe(map((response) => response?.result));
return this.customerService
.CustomerGetCustomerHistory({ customerId })
.pipe(map((response) => response?.result));
}
}

View File

@@ -20,9 +20,15 @@ export class PrintShippingNoteActionHandler extends ActionHandler<OrderItemsCont
async printShippingNoteHelper(printer: string, receipts: ReceiptDTO[]) {
try {
for (const group of groupBy(receipts, (receipt) => receipt?.buyer?.buyerNumber)) {
for (const group of groupBy(
receipts,
(receipt) => receipt?.buyer?.buyerNumber,
)) {
await this.domainPrinterService
.printShippingNote({ printer, receipts: group?.items?.map((r) => r?.id) })
.printShippingNote({
printer,
receipts: group?.items?.map((r) => r?.id),
})
.toPromise();
}
return {
@@ -38,7 +44,9 @@ export class PrintShippingNoteActionHandler extends ActionHandler<OrderItemsCont
}
async handler(data: OrderItemsContext): Promise<OrderItemsContext> {
const printerList = await this.domainPrinterService.getAvailableLabelPrinters().toPromise();
const printerList = await this.domainPrinterService
.getAvailableLabelPrinters()
.toPromise();
const receipts = data?.receipts?.filter((r) => r?.receiptType & 1);
let printer: Printer;
@@ -53,7 +61,8 @@ export class PrintShippingNoteActionHandler extends ActionHandler<OrderItemsCont
data: {
printImmediately: !this._environmentSerivce.matchTablet(),
printerType: 'Label',
print: async (printer) => await this.printShippingNoteHelper(printer, receipts),
print: async (printer) =>
await this.printShippingNoteHelper(printer, receipts),
} as PrintModalData,
})
.afterClosed$.toPromise();

View File

@@ -5,7 +5,7 @@ import {
VATValueDTO,
} from '@generated/swagger/checkout-api';
import { PurchaseOption } from './store';
import { OrderType } from '@isa/checkout/data-access';
import { OrderTypeFeature } from '@isa/checkout/data-access';
export const PURCHASE_OPTIONS: PurchaseOption[] = [
'in-store',
@@ -23,7 +23,7 @@ export const DELIVERY_PURCHASE_OPTIONS: PurchaseOption[] = [
];
export const PURCHASE_OPTION_TO_ORDER_TYPE: {
[purchaseOption: string]: OrderType;
[purchaseOption: string]: OrderTypeFeature;
} = {
'in-store': 'Rücklage',
'pickup': 'Abholung',

View File

@@ -242,6 +242,14 @@
}
}
@if (showNoDownloadAvailability$ | async) {
<span
class="inline-block font-bold text-[#BE8100] mt-[14px] max-w-[19rem]"
>
Derzeit nicht verfügbar
</span>
}
@if (showMaxAvailableQuantity$ | async) {
<span class="font-bold text-[#BE8100] mt-[14px]">
{{ (availability$ | async)?.inStock }} Exemplare sofort lieferbar

View File

@@ -36,6 +36,7 @@ import { GIFT_CARD_MAX_PRICE, PRICE_PATTERN } from '../constants';
import {
Item,
PurchaseOptionsStore,
isDownload,
isItemDTO,
isShoppingCartItemDTO,
} from '../store';
@@ -222,13 +223,23 @@ export class PurchaseOptionsListItemComponent
}),
);
fetchingAvailabilities$ = this.item$
.pipe(
switchMap((item) =>
this._store.getFetchingAvailabilitiesForItem$(item.id),
fetchingAvailabilitiesArray$ = this.item$.pipe(
switchMap((item) => this._store.getFetchingAvailabilitiesForItem$(item.id)),
);
fetchingAvailabilities$ = this.fetchingAvailabilitiesArray$.pipe(
map((fetchingAvailabilities) => fetchingAvailabilities.length > 0),
);
fetchingInStoreAvailability$ = this.fetchingAvailabilitiesArray$.pipe(
map((fetchingAvailabilities) =>
fetchingAvailabilities.some((fa) => fa.purchaseOption === 'in-store'),
),
)
.pipe(map((fetchingAvailabilities) => fetchingAvailabilities.length > 0));
);
isFetchingInStore = toSignal(this.fetchingInStoreAvailability$, {
initialValue: false,
});
showNotAvailable$ = combineLatest([
this.availabilities$,
@@ -247,6 +258,35 @@ export class PurchaseOptionsListItemComponent
}),
);
isDownload$ = this.item$.pipe(map((item) => isDownload(item)));
isDownloadItem = toSignal(this.isDownload$, { initialValue: false });
showNoDownloadAvailability$ = combineLatest([
this.isDownload$,
this.availabilities$,
this.fetchingAvailabilities$,
]).pipe(
map(([isDownloadItem, availabilities, fetchingAvailabilities]) => {
// Only check for download items
if (!isDownloadItem) {
return false;
}
// Don't show error while loading
if (fetchingAvailabilities) {
return false;
}
// Check if download availability exists
const hasDownloadAvailability = availabilities.some(
(a) => a.purchaseOption === 'download',
);
return !hasDownloadAvailability;
}),
);
// Ticket #4813 Artikeldetailseite // EVT-Datum bei der Kaufoption Rücklage anzeigen
get isEVT() {
// Einstieg über Kaufoptionen - Hier wird die Katalogavailability verwendet die am ItemDTO hängt
@@ -279,10 +319,16 @@ export class PurchaseOptionsListItemComponent
});
showLowStockMessage = computed(() => {
const availability = this.availability();
const inStock = availability?.inStock ?? 0;
return (
this.useRedemptionPoints() &&
this.isReservePurchaseOption() &&
(!this.availability() || this.availability().inStock < 2)
!this.isDownloadItem() &&
!this.isFetchingInStore() &&
inStock > 0 &&
inStock < 2
);
});

View File

@@ -20,6 +20,7 @@ import {
PickupPurchaseOptionTileComponent,
} from './purchase-options-tile';
import {
isDownload,
isGiftCard,
Item,
PurchaseOption,
@@ -102,19 +103,16 @@ export class PurchaseOptionsModalComponent implements OnInit, OnDestroy {
purchasingOptions$ = this.store.getPurchaseOptionsInAvailabilities$;
isDownloadOnly$ = this.purchasingOptions$.pipe(
map(
(purchasingOptions) =>
purchasingOptions.length === 1 && purchasingOptions[0] === 'download',
),
isDownloadOnly$ = this.store.items$.pipe(
map((items) => items.length > 0 && items.every((item) => isDownload(item))),
);
isGiftCardOnly$ = this.store.items$.pipe(
map((items) => items.every((item) => isGiftCard(item, this.store.type))),
);
hasDownload$ = this.purchasingOptions$.pipe(
map((purchasingOptions) => purchasingOptions.includes('download')),
hasDownload$ = this.store.items$.pipe(
map((items) => items.some((item) => isDownload(item))),
);
canContinue$ = this.store.canContinue$;

View File

@@ -1,4 +1,4 @@
import { Injectable, inject } from '@angular/core';
import { Injectable, inject, untracked } from '@angular/core';
import { UiModalRef, UiModalService } from '@ui/modal';
import { PurchaseOptionsModalComponent } from './purchase-options-modal.component';
import {
@@ -10,6 +10,9 @@ import {
Customer,
CrmTabMetadataService,
} from '@isa/crm/data-access';
import { TabService } from '@isa/core/tabs';
import { BranchDTO } from '@generated/swagger/checkout-api';
import { CheckoutMetadataService } from '@isa/checkout/data-access';
/**
* Service for opening and managing the Purchase Options Modal.
@@ -35,7 +38,9 @@ import {
@Injectable({ providedIn: 'root' })
export class PurchaseOptionsModalService {
#uiModal = inject(UiModalService);
#tabService = inject(TabService);
#crmTabMetadataService = inject(CrmTabMetadataService);
#checkoutMetadataService = inject(CheckoutMetadataService);
#customerFacade = inject(CustomerFacade);
/**
@@ -71,6 +76,10 @@ export class PurchaseOptionsModalService {
};
context.selectedCustomer = await this.#getSelectedCustomer(data);
context.selectedBranch = this.#getSelectedBranch(
data.tabId,
data.useRedemptionPoints,
);
return this.#uiModal.open<string, PurchaseOptionsModalContext>({
content: PurchaseOptionsModalComponent,
data: context,
@@ -90,4 +99,32 @@ export class PurchaseOptionsModalService {
return this.#customerFacade.fetchCustomer({ customerId });
}
#getSelectedBranch(
tabId: number,
useRedemptionPoints: boolean,
): BranchDTO | undefined {
const tab = untracked(() =>
this.#tabService.entities().find((t) => t.id === tabId),
);
if (!tab) {
return undefined;
}
if (useRedemptionPoints) {
return this.#checkoutMetadataService.getSelectedBranch(tabId);
}
const legacyProcessData = tab?.metadata?.process_data;
if (
typeof legacyProcessData === 'object' &&
'selectedBranch' in legacyProcessData
) {
return legacyProcessData.selectedBranch as BranchDTO;
}
return undefined;
}
}

View File

@@ -13,7 +13,7 @@ import {
ItemPayloadWithSourceId,
PurchaseOption,
} from './purchase-options.types';
import { OrderType } from '@isa/checkout/data-access';
import { OrderTypeFeature } from '@isa/checkout/data-access';
export function isItemDTO(item: any, type: ActionType): item is ItemDTO {
return type === 'add';
@@ -145,7 +145,7 @@ export function mapToOlaAvailability({
export function getOrderTypeForPurchaseOption(
purchaseOption: PurchaseOption,
): OrderType | undefined {
): OrderTypeFeature | undefined {
switch (purchaseOption) {
case 'delivery':
case 'dig-delivery':
@@ -163,7 +163,7 @@ export function getOrderTypeForPurchaseOption(
}
export function getPurchaseOptionForOrderType(
orderType: OrderType,
orderType: OrderTypeFeature,
): PurchaseOption | undefined {
switch (orderType) {
case 'Versand':

View File

@@ -17,7 +17,10 @@ import { memorize } from '@utils/common';
import { AuthService } from '@core/auth';
import { ApplicationService } from '@core/application';
import { DomainOmsService } from '@domain/oms';
import { OrderType, PurchaseOptionsFacade } from '@isa/checkout/data-access';
import {
OrderTypeFeature,
PurchaseOptionsFacade,
} from '@isa/checkout/data-access';
@Injectable({ providedIn: 'root' })
export class PurchaseOptionsService {
@@ -28,19 +31,12 @@ export class PurchaseOptionsService {
private _checkoutService: DomainCheckoutService,
private _omsService: DomainOmsService,
private _auth: AuthService,
private _app: ApplicationService,
) {}
getVats$() {
return this._omsService.getVATs();
}
getSelectedBranchForProcess(processId: number): Observable<Branch> {
return this._app
.getSelectedBranch$(processId)
.pipe(take(1), shareReplay(1));
}
getCustomerFeatures(processId: number): Observable<Record<string, string>> {
return this._checkoutService
.getCustomerFeatures({ processId })
@@ -122,7 +118,7 @@ export class PurchaseOptionsService {
fetchCanAdd(
shoppingCartId: number,
orderType: OrderType,
orderType: OrderTypeFeature,
payload: ItemPayload[],
customerFeatures: Record<string, string>,
): Promise<ItemsResult[]> {
@@ -185,10 +181,11 @@ export class PurchaseOptionsService {
items,
});
console.log('added item to cart', { shoppingCart });
this._checkoutService.updateProcessCount(
this._app.activatedProcessId,
shoppingCart,
);
// FIX BUILD ERRORS
// this._checkoutService.updateProcessCount(
// this._app.activatedProcessId,
// shoppingCart,
// );
return shoppingCart;
}
@@ -203,10 +200,11 @@ export class PurchaseOptionsService {
values: payload,
});
console.log('updated item in cart', { shoppingCart });
this._checkoutService.updateProcessCount(
this._app.activatedProcessId,
shoppingCart,
);
// FIX BUILD ERRORS
// this._checkoutService.updateProcessCount(
// this._app.activatedProcessId,
// shoppingCart,
// );
}
@memorize({ comparer: (_) => true })

View File

@@ -40,7 +40,12 @@ import { uniqueId } from 'lodash';
import { VATDTO } from '@generated/swagger/oms-api';
import { DomainCatalogService } from '@domain/catalog';
import { ItemDTO } from '@generated/swagger/cat-search-api';
import { Loyalty, OrderType, Promotion } from '@isa/checkout/data-access';
import {
Loyalty,
OrderTypeFeature,
Promotion,
} from '@isa/checkout/data-access';
import { ensureCurrencyDefaults } from '@isa/common/data-access';
@Injectable()
export class PurchaseOptionsStore extends ComponentStore<PurchaseOptionsState> {
@@ -314,11 +319,17 @@ export class PurchaseOptionsStore extends ComponentStore<PurchaseOptionsState> {
const itemData = mapToItemData(item, this.type);
if ((purchaseOption === 'in-store' || purchaseOption === undefined) && !this.isOptionDisabled('in-store')) {
if (
(purchaseOption === 'in-store' || purchaseOption === undefined) &&
!this.isOptionDisabled('in-store')
) {
promises.push(this._loadInStoreAvailability(itemData));
}
if ((purchaseOption === 'pickup' || purchaseOption === undefined) && !this.isOptionDisabled('pickup')) {
if (
(purchaseOption === 'pickup' || purchaseOption === undefined) &&
!this.isOptionDisabled('pickup')
) {
promises.push(this._loadPickupAvailability(itemData));
}
@@ -717,7 +728,7 @@ export class PurchaseOptionsStore extends ComponentStore<PurchaseOptionsState> {
try {
const res = await this._service.fetchCanAdd(
this.shoppingCartId,
key as OrderType,
key as OrderTypeFeature,
itemPayloads,
this.customerFeatures,
);
@@ -726,7 +737,9 @@ export class PurchaseOptionsStore extends ComponentStore<PurchaseOptionsState> {
this._addCanAddResult({
canAdd: canAdd.status === 0,
itemId: item.sourceId,
purchaseOption: getPurchaseOptionForOrderType(key as OrderType),
purchaseOption: getPurchaseOptionForOrderType(
key as OrderTypeFeature,
),
message: canAdd.message,
});
});
@@ -1056,7 +1069,7 @@ export class PurchaseOptionsStore extends ComponentStore<PurchaseOptionsState> {
throw new Error('Invalid item');
}
const price = this.getPriceForPurchaseOption(itemId, this.purchaseOption);
let price = this.getPriceForPurchaseOption(itemId, this.purchaseOption);
const availability = this.getAvailabilityWithPurchaseOption(
itemId,
purchaseOption,
@@ -1074,7 +1087,15 @@ export class PurchaseOptionsStore extends ComponentStore<PurchaseOptionsState> {
// Set loyalty points from item
loyalty = { value: redemptionPoints };
// Set price to 0
price.value.value = 0;
price = ensureCurrencyDefaults({
...price,
value: {
...price.value,
value: 0,
currency: 'EUR',
currencySymbol: '€',
},
});
}
let destination: EntityDTOContainerOfDestinationDTO;
@@ -1112,7 +1133,7 @@ export class PurchaseOptionsStore extends ComponentStore<PurchaseOptionsState> {
if (!isShoppingCartItemDTO(item, this.type)) {
throw new Error('Invalid item');
}
const price = this.getPriceForPurchaseOption(itemId, this.purchaseOption);
let price = this.getPriceForPurchaseOption(itemId, this.purchaseOption);
const availability = this.getAvailabilityWithPurchaseOption(
itemId,
purchaseOption,
@@ -1121,7 +1142,15 @@ export class PurchaseOptionsStore extends ComponentStore<PurchaseOptionsState> {
// If loyalty points is set we know it is a redemption item
// we need to make sure we don't update the price
if (this.useRedemptionPoints) {
price.value.value = 0;
price = ensureCurrencyDefaults({
...price,
value: {
...price.value,
value: 0,
currency: 'EUR',
currencySymbol: '€',
},
});
}
let destination: EntityDTOContainerOfDestinationDTO;

View File

@@ -6,8 +6,13 @@ export const routes: Routes = [
{
path: '',
component: AssortmentComponent,
title: 'Sortiment',
children: [
{ path: 'price-update', component: PriceUpdateComponent },
{
path: 'price-update',
component: PriceUpdateComponent,
title: 'Sortiment - Preisänderung',
},
{ path: '**', redirectTo: 'price-update' },
],
},

Some files were not shown because too many files have changed in this diff Show More