From d46bf462cbbb889bbb691f427bb27847b4ab97a4 Mon Sep 17 00:00:00 2001
From: Lorenz Hilpert <l.hilpert@paragon-data.de>
Date: Tue, 4 Nov 2025 16:46:19 +0000
Subject: [PATCH] =?UTF-8?q?Merged=20PR=202004:=20=F0=9F=90=9B=20fix(checko?=
 =?UTF-8?q?ut):=20remove=20manual=20cart=20counter=20updates=20(#5412)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

🐛 fix(checkout): remove manual cart counter updates (#5412)

Remove updateProcessCount method and all manual calls to it.
The cart counter is now updated through reactive mechanisms,
ensuring it stays in sync when items are added or removed.

Fixes bug where reward cart icon counter was not updating
when items were removed from the cart.

Related work items: #5412
---
 .../src/domain/checkout/checkout.service.ts      | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/apps/isa-app/src/domain/checkout/checkout.service.ts b/apps/isa-app/src/domain/checkout/checkout.service.ts
index b87bbeed5..2d34baa52 100644
--- a/apps/isa-app/src/domain/checkout/checkout.service.ts
+++ b/apps/isa-app/src/domain/checkout/checkout.service.ts
@@ -127,7 +127,6 @@ export class DomainCheckoutService {
               .pipe(
                 map((response) => response.result),
                 tap((shoppingCart) => {
-                  this.updateProcessCount(processId, shoppingCart);
                   this.store.dispatch(
                     DomainCheckoutActions.setShoppingCart({
                       processId,
@@ -159,7 +158,6 @@ export class DomainCheckoutService {
       }),
     );
 
-    this.updateProcessCount(processId, cart.result);
     this.store.dispatch(
       DomainCheckoutActions.setShoppingCart({
         processId,
@@ -210,7 +208,6 @@ export class DomainCheckoutService {
           .pipe(
             map((response) => response.result),
             tap((shoppingCart) => {
-              this.updateProcessCount(processId, shoppingCart);
               this.store.dispatch(
                 DomainCheckoutActions.setShoppingCart({
                   processId,
@@ -425,8 +422,6 @@ export class DomainCheckoutService {
                   ),
                 );
               }
-
-              this.updateProcessCount(processId, shoppingCart);
             }),
           ),
       ),
@@ -1432,7 +1427,7 @@ export class DomainCheckoutService {
   ): Observable<{ [key: string]: boolean }> {
     return this.canSetCustomer({ processId, customerFeatures: undefined }).pipe(
       map((res) => {
-        let setableTypes: { [key: string]: boolean } = {
+        const setableTypes: { [key: string]: boolean } = {
           store: false,
           guest: false,
           webshop: false,
@@ -1627,13 +1622,4 @@ export class DomainCheckoutService {
     });
   }
   //#endregion
-
-  //#region Common
-
-  async updateProcessCount(processId: number, shoppingCart: ShoppingCartDTO) {
-    this.applicationService.patchProcessData(processId, {
-      count: shoppingCart.items?.length ?? 0,
-    });
-  }
-  //#endregion
 }