From b0afc80a262bf53d50f614f8106736fa9d2c3b8c Mon Sep 17 00:00:00 2001
From: Lorenz Hilpert <l.hilpert@paragon-data.de>
Date: Fri, 7 Nov 2025 16:21:08 +0000
Subject: [PATCH 1/2] =?UTF-8?q?Merged=20PR=202013:=20=F0=9F=90=9B=20fix(or?=
 =?UTF-8?q?der-destination):=20display=20'Hugendubel=20Digital'=20for=20do?=
 =?UTF-8?q?wnload=20destinat...?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

🐛 fix(order-destination): display 'Hugendubel Digital' for download destinations

Fixes #5453

- Add handling for Download order type in name() computed signal to return 'Hugendubel Digital'
- Add handling for Download order type in address() computed signal to return undefined
- Update template to conditionally show pipe separator and address only when address exists
- Add isaDeliveryDownload icon for download order type
- Remove unused OrderType import

Related work items: #5453
---
 .../order-destination.component.html            | 11 +++++++----
 .../order-destination.component.ts              | 17 ++++++++++++++++-
 2 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/libs/shared/delivery/src/lib/order-destination/order-destination.component.html b/libs/shared/delivery/src/lib/order-destination/order-destination.component.html
index 8e1a62599..cdfcebfd3 100644
--- a/libs/shared/delivery/src/lib/order-destination/order-destination.component.html
+++ b/libs/shared/delivery/src/lib/order-destination/order-destination.component.html
@@ -18,10 +18,13 @@
   role="region"
   aria-label="Destination information">
   @if (name() || address()) {
-    <span data-what="recipient-name">{{ name() }}</span> |
-    <shared-inline-address
-      [address]="address()"
-      data-what="destination-address"></shared-inline-address>
+    <span data-what="recipient-name">{{ name() }}</span>
+    @if (address()) {
+      |
+      <shared-inline-address
+        [address]="address()"
+        data-what="destination-address"></shared-inline-address>
+    }
   } @else if (estimatedDelivery()) {
     <span data-what="estimated-delivery">
       @if (estimatedDelivery()!.stop) {
diff --git a/libs/shared/delivery/src/lib/order-destination/order-destination.component.ts b/libs/shared/delivery/src/lib/order-destination/order-destination.component.ts
index 90664543c..127aef5ad 100644
--- a/libs/shared/delivery/src/lib/order-destination/order-destination.component.ts
+++ b/libs/shared/delivery/src/lib/order-destination/order-destination.component.ts
@@ -6,10 +6,11 @@ import {
   isaDeliveryVersand,
   isaDeliveryRuecklage2,
   isaDeliveryRuecklage1,
+  isaDeliveryDownload,
 } from '@isa/icons';
 import { InlineAddressComponent } from '@isa/shared/address';
 import { logger } from '@isa/core/logging';
-import { OrderType, OrderTypeFeature } from '@isa/common/data-access';
+import { OrderTypeFeature } from '@isa/common/data-access';
 
 export type Address = {
   apartment?: string;
@@ -52,6 +53,7 @@ export type EstimatedDelivery = {
       isaDeliveryVersand,
       isaDeliveryRuecklage2,
       isaDeliveryRuecklage1,
+      isaDeliveryDownload,
     }),
   ],
 })
@@ -83,11 +85,20 @@ export class OrderDestinationComponent {
       return 'isaDeliveryRuecklage1';
     }
 
+    if (OrderTypeFeature.Download === orderType) {
+      return 'isaDeliveryDownload';
+    }
+
     return 'isaDeliveryVersand';
   });
 
   name = computed(() => {
     const orderType = this.orderType();
+
+    if (OrderTypeFeature.Download === orderType) {
+      return 'Hugendubel Digital';
+    }
+
     if (
       OrderTypeFeature.Delivery === orderType ||
       OrderTypeFeature.B2BShipping === orderType ||
@@ -104,6 +115,10 @@ export class OrderDestinationComponent {
   address = computed(() => {
     const orderType = this.orderType();
 
+    if (OrderTypeFeature.Download === orderType) {
+      return undefined;
+    }
+
     if (
       OrderTypeFeature.Delivery === orderType ||
       OrderTypeFeature.B2BShipping === orderType ||

From b984a2cac268ae3f5a8c1ca723789ce4a6a03fc6 Mon Sep 17 00:00:00 2001
From: Lorenz Hilpert <l.hilpert@paragon-data.de>
Date: Mon, 10 Nov 2025 13:11:49 +0000
Subject: [PATCH 2/2] Merged PR 2014: fix(open-reward-tasks): filter out
 pickup-only reward orders

fix(open-reward-tasks): filter out pickup-only reward orders

Exclude reward orders with only pickup items (supplier_id: '16') from open tasks
as these cannot be completed in the reward shop.

Fixes BUG-5444
---
 .../data-access/src/lib/services/open-reward-tasks.service.ts   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libs/oms/data-access/src/lib/services/open-reward-tasks.service.ts b/libs/oms/data-access/src/lib/services/open-reward-tasks.service.ts
index 9fe7bddc1..e08e378c7 100644
--- a/libs/oms/data-access/src/lib/services/open-reward-tasks.service.ts
+++ b/libs/oms/data-access/src/lib/services/open-reward-tasks.service.ts
@@ -7,7 +7,6 @@ import {
 import { ResponseArgsError, takeUntilAborted } from '@isa/common/data-access';
 import { logger } from '@isa/core/logging';
 import { firstValueFrom } from 'rxjs';
-import { Cache, CacheTimeToLive, InFlight } from '@isa/common/decorators';
 
 /**
  * Service for fetching open reward distribution tasks (Prämienausgabe) from the OMS API.
@@ -45,6 +44,7 @@ export class OpenRewardTasksService {
       filter: {
         orderitemprocessingstatus: '16', // InPreparation(16) and ReadyForPickup(128)
         praemie: '1-', // Reward items only
+        supplier_id: '16',
       },
       orderBy: [],
     };