From 3bbec6a68dbed7fd678565bfbc17c7f07754a3ad Mon Sep 17 00:00:00 2001 From: Lorenz Hilpert Date: Mon, 31 Mar 2025 17:57:50 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9A=20Update=20review=20instructions?= =?UTF-8?q?=20for=20positive=20feedback?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Clarified guidelines for highlighting positive aspects of code reviews. - πŸ“š **Docs**: Specify using different funny emojis for good practices - πŸ› οΈ **Refactor**: Removed redundant good practice example --- .github/review-instructions.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/review-instructions.md b/.github/review-instructions.md index 7889693d7..dfca3a79b 100644 --- a/.github/review-instructions.md +++ b/.github/review-instructions.md @@ -132,15 +132,12 @@ Include relevant resources for more information. ## βœ… Good Practices -Highlight positive aspects of the code to reinforce well-implemented patterns and encourage good practices. Use funny emoji at the beginning of each good practice. +Highlight one up to five positive aspects of the code to reinforce well-implemented patterns and encourage good practices. Use different funny emoji at the beginning of each good practice. - Emoji **Good Practice 1**: Describe a specific strength (e.g., clear code structure) with an example reference (e.g., file.js#L20). Explain why it’s commendable. - Emoji **Good Practice 2**: Outline another positive feature (e.g., effective error handling) with a snippet reference. -- Emoji **Good Practice 3**: - Outline another positive feature (e.g., effective error handling) with a snippet reference. -- ... ---