From 2d654aa63ae87e1835dd9d565fa40576a2ef9f45 Mon Sep 17 00:00:00 2001 From: Lorenz Hilpert Date: Mon, 27 Oct 2025 11:14:14 +0000 Subject: [PATCH] Merged PR 1986: fix(checkout): add complete price structure for reward delivery orders MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commits Summary Commit 1: fix(checkout): add complete price structure for reward delivery orders File: libs/checkout/data-access/src/lib/services/shopping-cart.service.ts - Fixed incomplete price object when adding reward items to cart - Added currency (EUR) and currencySymbol (€) to price value - This resolves the API error: "Error converting value 0 to type PriceDTO" Commit 2: feat(checkout): enable delivery options for reward shop items Files: - libs/checkout/feature/reward-catalog/src/lib/reward-action/reward-action.component.ts - libs/checkout/feature/reward-shopping-cart/src/lib/reward-shopping-cart-item/reward-shopping-cart-item.component.ts - libs/checkout/feature/reward-order-confirmation/src/lib/reward-order-confirmation.component.ts Changes: - Re-enabled 'delivery' and 'dig-delivery' purchase options for reward items - Removed unused import - Applied code formatting Related work items: #5405 --- .../data-access/src/lib/services/shopping-cart.service.ts | 7 ++++++- .../da39a3ee5e6b4b0d3255bfef95601890afd80709/results.json | 1 - .../src/lib/reward-action/reward-action.component.ts | 2 +- .../reward-shopping-cart-item.component.ts | 2 +- 4 files changed, 8 insertions(+), 4 deletions(-) delete mode 100644 libs/checkout/feature/node_modules/.vite/checkout-feature-reward-shopping-cart/vitest/da39a3ee5e6b4b0d3255bfef95601890afd80709/results.json diff --git a/libs/checkout/data-access/src/lib/services/shopping-cart.service.ts b/libs/checkout/data-access/src/lib/services/shopping-cart.service.ts index dd6d6cb5b..669cdd9ce 100644 --- a/libs/checkout/data-access/src/lib/services/shopping-cart.service.ts +++ b/libs/checkout/data-access/src/lib/services/shopping-cart.service.ts @@ -353,7 +353,12 @@ export class ShoppingCartService { availability: { ...rewardSelectionItem.item.availability, price: { - value: { value: 0 }, + value: { + value: 0, + currency: 'EUR', + currencySymbol: '€', + }, + vat: undefined, }, }, }, diff --git a/libs/checkout/feature/node_modules/.vite/checkout-feature-reward-shopping-cart/vitest/da39a3ee5e6b4b0d3255bfef95601890afd80709/results.json b/libs/checkout/feature/node_modules/.vite/checkout-feature-reward-shopping-cart/vitest/da39a3ee5e6b4b0d3255bfef95601890afd80709/results.json deleted file mode 100644 index 9796f35a8..000000000 --- a/libs/checkout/feature/node_modules/.vite/checkout-feature-reward-shopping-cart/vitest/da39a3ee5e6b4b0d3255bfef95601890afd80709/results.json +++ /dev/null @@ -1 +0,0 @@ -{"version":"3.2.4","results":[[":src/lib/routes.spec.ts",{"duration":0,"failed":false}]]} \ No newline at end of file diff --git a/libs/checkout/feature/reward-catalog/src/lib/reward-action/reward-action.component.ts b/libs/checkout/feature/reward-catalog/src/lib/reward-action/reward-action.component.ts index f7573831e..accee3a6a 100644 --- a/libs/checkout/feature/reward-catalog/src/lib/reward-action/reward-action.component.ts +++ b/libs/checkout/feature/reward-catalog/src/lib/reward-action/reward-action.component.ts @@ -75,7 +75,7 @@ export class RewardActionComponent { items, useRedemptionPoints: true, preSelectOption: { option: 'in-store' }, - disabledPurchaseOptions: ['delivery', 'dig-delivery', 'b2b-delivery'], + disabledPurchaseOptions: ['b2b-delivery'], hideDisabledPurchaseOptions: true, }); diff --git a/libs/checkout/feature/reward-shopping-cart/src/lib/reward-shopping-cart-item/reward-shopping-cart-item.component.ts b/libs/checkout/feature/reward-shopping-cart/src/lib/reward-shopping-cart-item/reward-shopping-cart-item.component.ts index 083564115..80e4ed2e4 100644 --- a/libs/checkout/feature/reward-shopping-cart/src/lib/reward-shopping-cart-item/reward-shopping-cart-item.component.ts +++ b/libs/checkout/feature/reward-shopping-cart/src/lib/reward-shopping-cart-item/reward-shopping-cart-item.component.ts @@ -83,7 +83,7 @@ export class RewardShoppingCartItemComponent { tabId: this.#tabId() as unknown as number, type: 'update', useRedemptionPoints: true, - disabledPurchaseOptions: ['delivery', 'dig-delivery', 'b2b-delivery'], + disabledPurchaseOptions: ['b2b-delivery'], hideDisabledPurchaseOptions: true, });